Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review203311 --- Patch looks great! Reviews applied: [65811, 65812, 65900, 67175,

Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review203309 --- PASS: Mesos patch 67177 was successfully built and tested.

Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and

Review Request 67176: Fixed target path resolution for mounts within container rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67176/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and

Re: Review Request 67173: WIP: Adjusted code for changes in `Result` and `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67173/#review203304 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 67175: Added support for marking slave mounts and creating non-existing paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67175/ --- Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and

Re: Review Request 65900: Defer creation of volume target paths to container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65900/ --- (Updated May 17, 2018, 1:16 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65812/ --- (Updated May 17, 2018, 1:07 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/ --- (Updated May 17, 2018, 1:06 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203302 --- Patch looks great! Reviews applied: [67164, 67154, 67155, 67156,

Re: Review Request 67173: WIP: Adjusted code for changes in `Result` and `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67173/#review203298 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67172: WIP: Adjusted libprocess for changes in `Result` and `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67172/ --- Review request for mesos. Repository: mesos Description --- WIP:

Review Request 67168: WIP: Made use of generic `Error` stringification in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67168/ --- Review request for mesos. Repository: mesos Description --- WIP: Made

Review Request 67171: WIP: Adjusted stout for changes in `Result` and `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67171/ --- Review request for mesos. Repository: mesos Description --- WIP:

Review Request 67165: WIP: Made `Error` explicitly stringifyable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67165/ --- Review request for mesos. Repository: mesos Description --- Whenever we

Review Request 67169: WIP: Made use of generic `Error` stringification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67169/ --- Review request for mesos. Repository: mesos Description --- WIP: Made

Review Request 67170: WIP: Changed `Result` and `Try` to not errors to `string`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67170/ --- Review request for mesos. Repository: mesos Description --- Both

Review Request 67166: WIP: Made use of generic `Error` stringification in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67166/ --- Review request for mesos. Repository: mesos Description --- WIP: Made

Review Request 67173: WIP: Adjusted code for changes in `Result` and `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67173/ --- Review request for mesos. Repository: mesos Description --- WIP:

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203297 --- PASS: Mesos patch 67157 was successfully built and tested.

Re: Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67158/#review203296 --- Patch looks great! Reviews applied: [67154, 67155, 67156, 67157,

Review Request 67164: Supported custom error types for `Try` in `AssertSome`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67164/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 16, 2018, 10:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203290 --- FAIL: Failed to apply the dependent review: 67155. Failed

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- (Updated May 16, 2018, 9:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67158/#review203289 --- PASS: Mesos patch 67158 was successfully built and tested.

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 16, 2018, 7:45 p.m., Zhitao Li wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 125-126 (patched) > > > > > > Do we need to call out what case the `Future` itself can be failed? Currently

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

> On May 16, 2018, 8:36 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Line 86 (original), 84-93 (patched) > > > > > > Is this any different than > > > >

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- (Updated May 16, 2018, 8:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203273 --- Not a proper review, yet.

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203275 --- PASS: Mesos patch 67154 was successfully built and tested.

Re: Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/#review203271 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 122 (patched)

Review Request 67158: Updated the CSI client to use the new libprocess gRPC interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67158/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Review Request 67156: Renamed `grpc::Channel` to `grpc::client::Connection`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67156/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Review Request 67155: Renamed `GRPC_RPC` and adapted the new gRPC async API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67155/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Review Request 67154: Replaced `RpcResult` with `Try<Response, StatusError>`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67154/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao

Re: Review Request 67153: Enforced that `allowed_devices` entries must have a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/#review203270 --- PASS: Mesos patch 67153 was successfully built and tested.

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 11, 2018, 11:34 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 73 (patched) > > > > > > I'd suggest we just skip this whitelist entry, instead of fail the > >

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

> On May 14, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > > Lines 779-796 (patched) > > > > > > This is a good and informative comment; however, [Mesos > >

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review203264 --- src/master/master.hpp Lines 2993 (patched)

Review Request 67153: Enforced that `allowed_devices` entries must have a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67153/ --- Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. Bugs:

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67075/ --- (Updated May 16, 2018, 5:55 p.m.) Review request for mesos and Andrew

Re: Review Request 66825: Added per framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66825/#review203257 --- Ship it! Ship It! - Greg Mann On May 16, 2018, 12:43 a.m.,

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67075/#review203255 --- Fix it, then Ship it!

Re: Review Request 66846: Added per framework metrics support for terminal task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66846/#review203253 --- src/master/master.cpp Lines 12113 (patched)

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/#review203248 --- support/cpplint.py Line 63 (original), 63 (patched)

Re: Review Request 67075: Fix TEST_F(SubprocessTest, Flags)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67075/ --- (Updated May 16, 2018, 5:07 p.m.) Review request for mesos and Andrew

Re: Review Request 67094: Split linux chroot into prepare and enter phases.

> On May 11, 2018, 11:26 p.m., Jason Lai wrote: > > src/linux/fs.cpp > > Lines 968-1034 (original), 973-1041 (patched) > > > > > > We can also consider changing `fs::chroot::enter` with the [`pivotRoot` > >

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203234 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203231 --- src/slave/containerizer/mesos/launch.cpp Lines 1040 (patched)

Re: Review Request 67055: Updated cpplint to be compatible with Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67055/ --- (Updated May 16, 2018, 2:29 p.m.) Review request for mesos, Andrew

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 15, 2018, 11:05 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 361 (original), 360-365 (patched) > > > > > > Moving our previous discussion from

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203227 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203216 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

> On May 15, 2018, 8:28 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 481 (patched) > > > > > > This kind of logic will _never_ work on Windows, because the file > >

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 16, 2018, 1:56 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67146: Updated the container logger interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67146/#review203211 --- Patch looks great! Reviews applied: [67146] Passed command:

Re: Review Request 67150: Fixed links used in WebUI index.html to get assets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67150/#review203204 --- PASS: Mesos patch 67150 was successfully built and tested.

Review Request 67150: Fixed links used in WebUI index.html to get assets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67150/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Repository: