Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/#review205560 --- PASS: Mesos patch 66822 was successfully built and tested. Review

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review205559 --- src/python/cli_new/README.md Line 11 (original), 11 (patched)

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205558 --- Patch looks great! Reviews applied: [67773, 67444, 6] Passed

Re: Review Request 67780: Removed incorrect symlink handling in archiver utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67780/#review205557 --- PASS: Mesos patch 67780 was successfully built and tested. Review

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205556 --- PASS: Mesos patch 67769 was successfully built and tested. Review

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review20 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66822: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66822/#review205553 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822]

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205552 --- PASS: Mesos patch 67590 was successfully built and tested. Review

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205550 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 67737: Updated CNI slave recovery test.

> On June 26, 2018, 3:44 p.m., Qian Zhang wrote: > > Do we still need to kill the task and wait for `TASK_KILLED`? > > Qian Zhang wrote: > And is it possible for CNI DEL command gets called after > `reregisterExecutorMessage` is received? > > Jie Yu wrote: > It's not possible. recover

Re: Review Request 67780: Removed incorrect symlink handling in archiver utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67780/#review205547 --- Ship it! Duh! - Kapil Arya On June 28, 2018, 9 p.m., Joseph

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/ --- (Updated June 29, 2018, 9:41 a.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 67779: WIP: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/#review205546 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

> On June 29, 2018, 12:24 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Line 440 (original), 442 (patched) > > > > > > I would use 'await' here so that the agent will still s

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/ --- (Updated June 29, 2018, 9:20 a.m.) Review request for mesos, Gilbert Song and J

Review Request 67780: Removed incorrect symlink handling in archiver utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67780/ --- Review request for mesos, Andrew Schwartzmeyer and Kapil Arya. Bugs: MESOS-9038

Re: Review Request 67776: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/#review205544 --- src/master/metrics.cpp Lines 566 (patched)

Re: Review Request 67776: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/#review205543 --- Ship it! src/master/metrics.cpp Lines 566 (patched)

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205542 --- PASS: Mesos patch 6 was successfully built and tested. Review

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

> On June 28, 2018, 2:04 p.m., Benjamin Mahler wrote: > > Looks pretty good! The only thing that feels a little off is the size > > parameterization. It currently represents the number of ranges, but I > > imagine other benchmarks might not want to use that as the "size" (vs the > > overall ra

Review Request 67779: WIP: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, James DeF

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/ --- (Updated June 28, 2018, 5:38 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 67444: Persisted role consumed quota info in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/#review205541 --- Patch looks great! Reviews applied: [67773, 67444] Passed comman

Re: Review Request 67778: Fixed flaky test `DefaultExecutorTest.SigkillExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67778/#review205540 --- Ship it! Ship It! - Chun-Hung Hsiao On June 28, 2018, 11:31

Re: Review Request 67444: Persisted role consumed quota info in the allocator.

> On June 28, 2018, 3:25 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67773', '67444']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > > http://dcos-win

Review Request 67778: Fixed flaky test `DefaultExecutorTest.SigkillExecutor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67778/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9037 https://issu

Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8916 https://issu

Re: Review Request 66823: Added per framework metrics for framework events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66823/ --- (Updated June 28, 2018, 10:41 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67776: Added per Framework Calls to metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song. Bu

Re: Review Request 67444: Persisted role consumed quota info in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/#review205537 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67773: Removed redundant 'toUnreserved()' call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67773/#review205536 --- Ship it! Ship It! - Greg Mann On June 28, 2018, 8:54 p.m., M

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205531 --- PASS: Mesos patch 67590 was successfully built and tested. Review

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205530 --- Patch looks great! Reviews applied: [67590] Passed command: expo

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205529 --- Fix it, then Ship it! Looks pretty good! The only thing that fe

Review Request 67444: Persisted role consumed quota info in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8802 https://issu

Review Request 67773: Removed redundant 'toUnreserved()' call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67773/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Repository: mesos De

Re: Review Request 65784: Added validation of QuotaRequest.

> On May 1, 2018, 4:40 p.m., Meng Zhu wrote: > > src/master/quota.cpp > > Lines 199-200 (patched) > > > > > > Add `AllocationInfo` and `SharedInfo` check as well? Now we can use `isScalarQuantity()` for this https:

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/ --- (Updated June 28, 2018, 12:34 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

> On June 27, 2018, 6:29 p.m., Benjamin Mahler wrote: > > Great to see this! > > > > Can you update the testing done to say whether this was measured with an > > optimized build? If not, can you add the optimized build measurements? Updated numbers with optimized build > On June 27, 2018, 6:

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205519 --- Patch looks great! Reviews applied: [67769] Passed command: expo

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205516 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp Line

Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/#review205515 --- PASS: Mesos patch 67769 was successfully built and tested. Review

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review205512 --- Patch looks great! Reviews applied: [67411, 67412, 67413, 67487,

Re: Review Request 67488: Updated CLI to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review205508 --- PASS: Mesos patch 67488 was successfully built and tested. Review

Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67769/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review205505 --- Patch looks great! Reviews applied: [67185] Passed command: expo

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205501 --- Ship it! Ship It! - Jan Schlicht On June 21, 2018, 5:53 p.m.

Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/#review205497 --- PASS: Mesos patch 67767 was successfully built and tested. Review

Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/#review205496 --- Patch looks great! Reviews applied: [67767] Passed command: expo

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/ --- (Updated June 28, 2018, 10:50 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/ --- (Updated June 28, 2018, 10:47 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review205493 --- PASS: Mesos patch 67185 was successfully built and tested. Review

Re: Review Request 67501: Added authorization for storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67501/#review205492 --- include/mesos/authorizer/acls.proto Lines 542 (patched)

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review205491 --- Patch looks great! Reviews applied: [67761, 67762] Passed comman

Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos Des