Re: Review Request 67901: Removed outdated comments regarding `Slave::executorTerminated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67901/#review206036 --- PASS: Mesos patch 67901 was successfully built and tested.

Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.

Thanks for clarifying! On Thu, Jul 12, 2018 at 4:40 PM Andrew Schwartzmeyer < and...@schwartzmeyer.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67900/ > > On July 12th, 2018, 3:39 p.m. PDT, *Benjamin Mahler* wrote: > > Could we clarify

Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67900/ --- (Updated July 12, 2018, 4:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.

> On July 12, 2018, 3:39 p.m., Benjamin Mahler wrote: > > Could we clarify that it's windows specific in the summary and that we're > > re-enabling the benchmark? E.g. > > > > "Re-enabled on windows." This patch in its entirety though is not Windows specific. The change (adding `this->`) is

Review Request 67901: Removed outdated comments regarding `Slave::executorTerminated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67901/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67900/#review206032 --- Fix it, then Ship it! Could we clarify that it's windows

Re: Review Request 67900: Fixed compilation error with `DispatchProcess` code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67900/#review206031 --- PASS: Mesos patch 67900 was successfully built and tested.

Re: Review Request 67890: Updated metrics add / remove to avoid double lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67890/#review206030 --- Looks like this needs a rebase - it must be close enough to

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/#review206029 --- PASS: Mesos patch 67871 was successfully built and tested.

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- (Updated July 12, 2018, 9:39 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67884: Windows: Explicitly cast to `SOCKET` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67884/#review206020 --- PASS: Mesos patch 67884 was successfully built and tested.

Review Request 67900: Fixed compilation error with `DispatchProcess` code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67900/ --- Review request for mesos, Benjamin Mahler, Joseph Wu, and Michael Park. Bugs:

Re: Review Request 67871: Optimized the generation of metrics snapshots.

> On July 10, 2018, 4:21 p.m., James Peach wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp > > Lines 158 (patched) > > > > > > Since we are optimizing, shall we do `++iter`? Yep, thx! - Greg

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/ --- (Updated July 12, 2018, 8:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67871: Optimized the generation of metrics snapshots.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67871/ --- (Updated July 12, 2018, 8:10 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67882: Windows: Made `int_fd` cast operators explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67882/#review206016 --- 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 162-183

Review Request 67884: Windows: Explicitly cast to `SOCKET` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67884/ --- Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika

Review Request 67882: Windows: Made `int_fd` cast operators explicit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67882/ --- Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika

Review Request 67883: Windows: Explicitly cast to `SOCKET`/`HANDLE` where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67883/ --- Review request for mesos, Akash Gupta, John Kordich, Joseph Wu, and Radhika

Re: Review Request 67870: Avoided implicit construction of a hashmap in the metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67870/ --- (Updated July 12, 2018, 6:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67891: Added multi-framework scalability guidelines to the documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67891/#review206014 --- Thanks for adding this! docs/app-framework-development-guide.md

Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67897/#review206013 --- PASS: Mesos patch 67897 was successfully built and tested.

Review Request 67897: Updated two tests to verfiy freezer subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67897/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9070

Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-9070

Re: Review Request 67890: Updated metrics add / remove to avoid double lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67890/#review206008 --- Patch looks great! Reviews applied: [67877, 67889, 67890]

Re: Review Request 67894: Migrated mesos python package to python3.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67894/#review206007 --- PASS: Mesos patch 67894 was successfully built and tested.

Re: Review Request 67893: Updated site's sprockets package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67893/#review206005 --- PASS: Mesos patch 67893 was successfully built and tested.

Review Request 67894: Migrated mesos python package to python3.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67894/ --- Review request for mesos. Repository: mesos Description --- Migrated

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67779/#review206000 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 1994

Re: Review Request 67893: Updated site's sprockets package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67893/#review205999 --- Ship it! Ship It! - Alexander Rukletsov On July 12, 2018,

Re: Review Request 67893: Updated site's sprockets package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67893/ --- (Updated July 12, 2018, 7:19 a.m.) Review request for mesos and Alexander

Review Request 67893: Updated site's sprockets package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67893/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67864/#review205998 --- PASS: Mesos patch 67864 was successfully built and tested.

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67869/#review205997 --- PASS: Mesos patch 67869 was successfully built and tested.