Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review211322 --- Patch looks great! Reviews applied: [69337, 69338] Passed

Re: Review Request 69563: Made master process authorization results properly for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/#review211321 --- PASS: Mesos patch 69563 was successfully built and tested.

Review Request 69563: Made master process authorization results properly for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69563/ --- Review request for mesos, Benjamin Bannier, Greg Mann, James DeFelice, and Jan

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69522/#review211314 --- PASS: Mesos patch 69522 was successfully built and tested.

Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review211312 --- Fix it, then Ship it! src/slave/slave.cpp Lines 7664

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211313 --- src/master/master.cpp Lines 8205 (patched)

Re: Review Request 69521: Fixed test `AgentResourceProviderConfigApiTest.Update` for the `vendor` field.

> On Dec. 13, 2018, 12:15 p.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 634-636 (patched) > > > > > > These need to be `ASSERT_TRUE` since we access the fields

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69037/ --- (Updated Dec. 13, 2018, 10:14 p.m.) Review request for mesos, Benjamin

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69522/ --- (Updated Dec. 13, 2018, 10:22 p.m.) Review request for mesos, Benjamin

Re: Review Request 69521: Fixed `AgentResourceProviderConfigApiTest.Update` for `vendor` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69521/ --- (Updated Dec. 13, 2018, 10:18 p.m.) Review request for mesos, Benjamin

Re: Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69520/ --- (Updated Dec. 13, 2018, 10:16 p.m.) Review request for mesos, Benjamin

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211306 --- git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n'

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

> On Dec. 13, 2018, 12:14 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1467-1468 (patched) > > > > > > I wonder if we should even document this implementation (?) aspect. It > > doesn't

Re: Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.

> On Dec. 13, 2018, 12:15 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 251 (patched) > > > > > > Could we order `vendor` before `id` in the arg list? I put the arguments in

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

> On Dec. 13, 2018, 12:14 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1467-1468 (patched) > > > > > > I wonder if we should even document this implementation (?) aspect. It > > doesn't

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

> On Dec. 13, 2018, 12:14 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 1467-1468 (patched) > > > > > > I wonder if we should even document this implementation (?) aspect. It > > doesn't

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/#review211295 --- PASS: Mesos patch 69551 was successfully built and tested.

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211294 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/#review211292 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 12, 2018, 11:51 p.m., Gilbert Song wrote: > > configure.ac > > Lines 352 (patched) > > > > > > Do we have a plan to deprecate this configuraton flag in the future? > > E.g., always only compile the

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 13, 2018, 8:24 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > When parsing a profile, I can see unavoidably we have to do some > > transforming

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 13, 2018, 8:20 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 200-215 (patched) > > > > > > I saw you remove all `SCMP_` prefix and implemented a hashmap converter > > in

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/ --- (Updated Dec. 13, 2018, 2:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

> On Nov. 23, 2018, 1:44 p.m., Andrei Budnik wrote: > > src/tests/cluster.cpp > > Lines 699 (patched) > > > > > > What if there is more than one container whose > > `Future` is ready? Should we call `settle()` for

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- (Updated Dec. 13, 2018, 3:08 p.m.) Review request for mesos, Andrew

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69547/#review211287 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

> On Dec. 7, 2018, 3:18 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8228 (patched) > > > > > > It seems to me that we should remove the disappeared resources even if > > there is no resource

Re: Review Request 69338: Change agent to not report disconnected resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69338/ --- (Updated Dec. 13, 2018, 2:51 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69338: Change agent to not report disconnected resource providers.

> On Dec. 7, 2018, 3:28 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Line 7595 (original), 7598 (patched) > > > > > > It seems to me that the compiler should be able to hoist > >

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Dec. 13, 2018, 2:51 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68018: Added `SeccompFilter` class.

> On Dec. 13, 2018, 8:25 a.m., Gilbert Song wrote: > > src/linux/seccomp/seccomp.hpp > > Lines 27 (patched) > > > > > > Having the linux/seccomp common library to include containerizer.hpp > > seems a little strange

[GitHub] asfgit closed pull request #321: Fixed SIGINT handling in parallel test runner.

asfgit closed pull request #321: Fixed SIGINT handling in parallel test runner. URL: https://github.com/apache/mesos/pull/321 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

Re: Review Request 69541: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/#review211282 ---

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69522/#review211279 --- Fix it, then Ship it! src/tests/resources_tests.cpp Line 2373

Re: Review Request 69521: Fixed test `AgentResourceProviderConfigApiTest.Update` for the `vendor` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69521/#review211276 --- Fix it, then Ship it! Can you make sure the commit message

Re: Review Request 69520: Set up the `Resource.DiskInfo.Source.vendor` field in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69520/#review211277 --- Fix it, then Ship it!

Re: Review Request 69037: Added an optional `vendor` field to `Resource.DiskInfo.Source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69037/#review211281 --- Fix it, then Ship it! include/mesos/mesos.proto Lines

Re: Review Request 69541: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 13, 2018, 7:46 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

> On Dec. 11, 2018, 10:02 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp > > Lines 180 (patched) > > > > > > Suggestion: we could also pass `containerId` to

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review211265 --- We probably need to refactor these helpers a little bit, based on

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211275 --- include/mesos/slave/containerizer.proto Lines 197 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211264 --- include/mesos/slave/containerizer.proto Lines 200-215 (patched)