> On Dec. 13, 2018, 8:24 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > <https://reviews.apache.org/r/68017/diff/10/?file=2109592#file2109592line197> > > > > When parsing a profile, I can see unavoidably we have to do some > > transforming in the parser helper, but probably we could do best effort to > > leverage protobuf::parse<>().
Our internal json format is incompatible with Docker Seccomp profile format. However, I use proto-generated helpers to parse enums, grep for `_Parse(` in `seccomp_parser.cpp`. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211275 ----------------------------------------------------------- On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 3:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 06a901d26693757edc653cd833d55aa42e4ff2c6 > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 75cdb2889b2b645e23d9f5ab263ee63bf62b4221 > > > Diff: https://reviews.apache.org/r/68017/diff/10/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
