Re: Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69905/#review212602 --- PASS: Mesos patch 69905 was successfully built and tested. Review

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212601 --- Fix it, then Ship it! Thanks for fixing this! Can you add a tes

Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69905/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Review Request 69904: Extracted common offer matching functions from SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69904/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

> On Feb. 5, 2019, 5:55 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3137 (patched) > > > > > > This is some pretty strong coupling to `master::validate` checking > > `reso

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/ --- (Updated Feb. 6, 2019, 4:59 a.m.) Review request for mesos, Benjamin Bannier, J

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

> On Feb. 5, 2019, 5:15 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2577-2579 (patched) > > > > > > Maybe make this more in line with what we already have for `UNRESERVE` > > of persistent

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 5, 2019, 5:41 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 62-67 (original), 62-77 (patched) > > > > > > Any reason we cannot use a single field containing the `bootId` of the > > last tr

Re: Review Request 69900: Reduced unnecessary agent lookups in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69900/#review212589 --- Ship it! Ship It! - Meng Zhu On Feb. 5, 2019, 2:30 p.m., Ben

Re: Review Request 69869: [WIP] Added test for tearing down frameworks while creating disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69869/#review212588 --- PASS: Mesos patch 69869 was successfully built and tested. Review

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/#review212587 --- Patch looks great! Reviews applied: [69858, 69866, 69892, 69893,

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 5, 2019, 5:41 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 62-67 (original), 62-77 (patched) > > > > > > Any reason we cannot use a single field containing the `bootId` of the > > last tr

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/ --- (Updated Feb. 6, 2019, 12:04 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 5, 2019, 5:41 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 62-67 (original), 62-77 (patched) > > > > > > Any reason we cannot use a single field containing the `bootId` of the > > last tr

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212582 --- PASS: Mesos patch 69902 was successfully built and tested. Review

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Feb. 6, 2019, 12:05 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

> On Feb. 5, 2019, 12:08 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 2889 (patched) > > > > > > Why is this always true? Probably a good idea to document this here if > >

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

> On Feb. 5, 2019, 12:07 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1342-1343 (original), 1391-1392 (patched) > > > > > > This seems weird as `UpdateSlaveMessages

Review Request 69900: Reduced unnecessary agent lookups in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69900/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Repository: mesos De

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212573 --- Much appreciated for having split out the changes! This is nice an

Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Bugs: MESOS-9554 h

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 5, 2019, 5:41 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 62-67 (original), 62-77 (patched) > > > > > > Any reason we cannot use a single field containing the `bootId` of the > > last tr

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/#review212566 --- PASS: Mesos patch 69871 was successfully built and tested. Review

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212565 --- PASS: Mesos patch 69680 was successfully built and tested. Review

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/#review212564 --- Whoops, missed that this needs to be updated in updateFramework.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212563 --- Looks good! Just some minor comments below src/tests/hierarchica

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/#review212562 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/#review212561 --- Ship it! Ship It! - Benjamin Mahler On Feb. 4, 2019, 10:05 p

Re: Review Request 69876: Removed operations from master state when an agent is downgraded.

> On Feb. 4, 2019, 4:28 p.m., Gastón Kleiman wrote: > > src/tests/master_tests.cpp > > Lines 9419 (patched) > > > > > > We should consider making the agent not recover the operation status > > update manager if it

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/#review212559 --- PASS: Mesos patch 69891 was successfully built and tested. Review

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/#review212558 --- src/resource_provider/storage/provider.cpp Lines 3137 (patched) <

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/#review212557 --- src/csi/state.proto Lines 62-67 (original), 62-77 (patched)

Re: Review Request 69854: Set status update UUID in MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69854/#review212556 --- Ship it! Ship It! - Greg Mann On Jan. 29, 2019, 1:20 p.m., B

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

> On Feb. 5, 2019, 4:57 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10950 (patched) > > > > > > I don't know if sending UNREACHABLE for all the 3 cases when > > `_removeSlave` is called is the righ

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/#review212552 --- Fix it, then Ship it! src/master/validation.cpp Lines 2577-257

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ --- (Updated Feb. 5, 2019, 6:02 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/#review212551 --- src/master/master.cpp Lines 10950 (patched)

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 5, 2019, 5:38 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ --- (Updated Feb. 5, 2019, 5:40 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2041-2042 (original), 2075-2076 (patched) > > > > > > Hm.. isn't the framework capability stripping mess

Re: Review Request 69871: Added more documentation for operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69871/ --- (Updated Feb. 5, 2019, 4:33 p.m.) Review request for mesos, Benjamin Bannier, G

Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/ --- Review request for mesos, Gastón Kleiman and Joseph Wu. Bugs: MESOS-9541 ht

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/#review212548 --- Ship it! Ship It! - James DeFelice On Feb. 5, 2019, 7:43 a.m

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/#review212547 --- src/resource_provider/storage/provider.cpp Lines 2889 (patched) <

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/#review212545 --- Fix it, then Ship it! src/tests/storage_local_resource_provide

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/#review212543 --- PASS: Mesos patch 69898 was successfully built and tested. Review

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/#review212542 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/ --- (Updated Feb. 5, 2019, 9:27 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69897/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss

Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544 https://iss