Re: Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/#review216518
---



Patch looks great!

Reviews applied: [71050, 71051, 71052, 71053]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 11, 2019, 12:17 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71053/
> ---
> 
> (Updated July 11, 2019, 12:17 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This provides helpful information for debugging, as well as for the
> webui to display in the roles table.
> 
> 
> Diffs
> -
> 
>   src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d 
>   src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 
> 
> 
> Diff: https://reviews.apache.org/r/71053/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/#review216514
---


Ship it!




See my comment in https://reviews.apache.org/r/71050/

- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71053/
> ---
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This provides helpful information for debugging, as well as for the
> webui to display in the roles table.
> 
> 
> Diffs
> -
> 
>   src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d 
>   src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 
> 
> 
> Diff: https://reviews.apache.org/r/71053/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 70528: Updated release guide.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216515
---


Fix it, then Ship it!





docs/release-guide.md
Lines 69 (patched)


Super minor nit: s/  / / =)


- Gastón Kleiman


On July 10, 2019, 7:58 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70528/
> ---
> 
> (Updated July 10, 2019, 7:58 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the release guide in `docs/release-guide.md` to match
> the de-facto process we're using to release new versions.
> 
> Also mentioned some additional third-party tooling to the post-release
> desription.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md a3ad2668a1953a7f20dd7209e122481ad8b30f17 
> 
> 
> Diff: https://reviews.apache.org/r/70528/diff/3/
> 
> 
> Testing
> ---
> 
> Released Mesos 1.8.0 according to this procedure.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216513
---




src/master/master.hpp
Lines 2800-2801 (patched)


hmm, what if reservation has non-scalar resources? I guess in all cases, we 
are just showing scalar ones.

But if role `dev` has a reservation of 100 ports, when they hit `/roles`, 
they will get `reserved : {}`, feels somewhat inappropriate.


- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> ---
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7 
> 
> 
> Diff: https://reviews.apache.org/r/71050/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71052/#review216512
---


Ship it!




Ship It!

- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71052/
> ---
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a TODO to add resources breakdowns to v1 GET_ROLES.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto c4dd0dee0a924351d2b3bb65f2e9cdeb1967e720 
>   include/mesos/v1/mesos.proto 158db3501e84be7f4ed504e9a484b158d13a17e3 
> 
> 
> Diff: https://reviews.apache.org/r/71052/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71051: Updated /role 'resources' field to strip 0 values.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71051/#review216511
---


Ship it!




Ship It!

- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71051/
> ---
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To be consistent with quota and quota consumption, as well as to
> include resoures outside of {cpus,mem,disk,gpus}, this updates the
> field to be filled based on ResourceQuantities.
> 
> This should also help performance a bit.
> 
> 
> Diffs
> -
> 
>   src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d 
>   src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 
> 
> 
> Diff: https://reviews.apache.org/r/71051/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/#review216510
---


Ship it!




Ship It!

- Meng Zhu


On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71050/
> ---
> 
> (Updated July 10, 2019, 5:17 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-8789
> https://issues.apache.org/jira/browse/MESOS-8789
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This provides a breakdown of resource quantities on a per-role
> basis, that would aid debugging if shown in the endpoints and
> roles table in the ui.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7 
> 
> 
> Diff: https://reviews.apache.org/r/71050/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 71052: Added a TODO to add resources breakdowns to v1 GET_ROLES.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71052/
---

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Repository: mesos


Description
---

Added a TODO to add resources breakdowns to v1 GET_ROLES.


Diffs
-

  include/mesos/mesos.proto c4dd0dee0a924351d2b3bb65f2e9cdeb1967e720 
  include/mesos/v1/mesos.proto 158db3501e84be7f4ed504e9a484b158d13a17e3 


Diff: https://reviews.apache.org/r/71052/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 71051: Updated /role 'resources' field to strip 0 values.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71051/
---

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Repository: mesos


Description
---

To be consistent with quota and quota consumption, as well as to
include resoures outside of {cpus,mem,disk,gpus}, this updates the
field to be filled based on ResourceQuantities.

This should also help performance a bit.


Diffs
-

  src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d 
  src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 


Diff: https://reviews.apache.org/r/71051/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 71053: Added reserved, offered, allocated resources to the /roles endpoint.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71053/
---

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789


Repository: mesos


Description
---

This provides helpful information for debugging, as well as for the
webui to display in the roles table.


Diffs
-

  src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d 
  src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 


Diff: https://reviews.apache.org/r/71053/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Review Request 71050: Added Role::reserved, Role::allocated, Role::offered to master.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71050/
---

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-8789
https://issues.apache.org/jira/browse/MESOS-8789


Repository: mesos


Description
---

This provides a breakdown of resource quantities on a per-role
basis, that would aid debugging if shown in the endpoints and
roles table in the ui.


Diffs
-

  src/master/master.hpp 9b861551b0b19666a256730fe711bc32268bf0b7 


Diff: https://reviews.apache.org/r/71050/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216506
---



Patch looks great!

Reviews applied: [71033, 71034, 71035]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 8, 2019, 11:28 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> ---
> 
> (Updated July 8, 2019, 11:28 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
>   src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a6217581e20168c5114f733323e927a83ac59fd0 
> 
> 
> Diff: https://reviews.apache.org/r/71035/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> Verified that this new test fails on current master, and passes when the 
> preceding patches in this chain are applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216502
---


Ship it!




Ship It!

- Benno Evers


On July 8, 2019, 6:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> ---
> 
> (Updated July 8, 2019, 6:28 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
>   src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a6217581e20168c5114f733323e927a83ac59fd0 
> 
> 
> Diff: https://reviews.apache.org/r/71035/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> Verified that this new test fails on current master, and passes when the 
> preceding patches in this chain are applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71041: Added best-effort validation for DRAIN_AGENT master call.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71041/#review216501
---




src/master/http.cpp
Lines 3950 (patched)


This line assumes that the schedules are non-empty. We should guard this 
loop with a conditional to prevent a segfault.


- Greg Mann


On July 9, 2019, 7:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71041/
> ---
> 
> (Updated July 9, 2019, 7:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-9814
> https://issues.apache.org/jira/browse/MESOS-9814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds two cases which the master cannot deterministically enforce
> when using the DRAIN_AGENT call.  The draining feature is currently
> incompatible with maintenance schedules and older versions of the
> Mesos agent.  However, in both cases, an agent can reregister with
> incompatible info after starting to drain.  Also, unreachable agents
> do not have enough info to enforce either case.
> 
> These are unexpected cases and are not expected to cause any problems
> if circumvented.  However, the agent draining feature is also not
> expected to work correctly if circumvented.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c 
> 
> 
> Diff: https://reviews.apache.org/r/71041/diff/1/
> 
> 
> Testing
> ---
> 
> TODO
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 70960: Added test for agent to leave draining state on its own.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70960/#review216500
---



Bad patch!

Reviews applied: [70822, 70839, 70834, 70835, 70836, 70899, 70900, 70901, 
70903, 70904, 70906, 70907, 70936, 70958, 70959, 70960]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_70960"]

Error:
..
rOperationsWithResourceProviderResources_v0_lv1KXi/2GB-c6b345fa-5b35-4878-837b-5a4c59d9b4dc,test)]:2048,
 allocated: {}) on agent 42f89090-73ba-4432-bc19-4b81bc70b0d4-S0 from framework 
42f89090-73ba-4432-bc19-4b81bc70b0d4-
I0710 20:50:55.278487 18285 hierarchical.cpp:1264] Framework 
42f89090-73ba-4432-bc19-4b81bc70b0d4- filtered agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0 for 5secs
I0710 20:50:55.280719 18280 master.cpp:12361] Sending operation '' (uuid: 
6a3648f1-7d50-402f-bf46-da66c8c4b071) to agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0 at slave(1206)@172.17.0.2:35051 
(f57a0dc1c520)
I0710 20:50:55.281229 18269 slave.cpp:4328] Ignoring new checkpointed resources 
and operations identical to the current version
I0710 20:50:55.283566 18264 hierarchical.cpp:1508] Performed allocation for 1 
agents in 1.090114ms
I0710 20:50:55.283691 18279 provider.cpp:481] Received APPLY_OPERATION event
I0710 20:50:55.283728 18279 provider.cpp:1295] Received UNRESERVE operation '' 
(uuid: 6a3648f1-7d50-402f-bf46-da66c8c4b071)
I0710 20:50:55.284237 18276 master.cpp:10195] Sending offers [ 
42f89090-73ba-4432-bc19-4b81bc70b0d4-O6 ] to framework 
42f89090-73ba-4432-bc19-4b81bc70b0d4- (default) at 
scheduler-50e8ad20-f69c-4a0e-8a57-a8c43544c191@172.17.0.2:35051
I0710 20:50:55.284814 18277 sched.cpp:934] Scheduler::resourceOffers took 
74991ns
I0710 20:50:55.307996 18275 http.cpp:1115] HTTP POST for 
/slave(1206)/api/v1/resource_provider from 172.17.0.2:47190
I0710 20:50:55.308835 18263 slave.cpp:8395] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: e5a4c8b5-da58-4673-a11e-439cd71c02fc) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0710 20:50:55.308989 18263 slave.cpp:8848] Updating the state of operation 
with no ID (uuid: e5a4c8b5-da58-4673-a11e-439cd71c02fc) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0710 20:50:55.309039 18263 slave.cpp:8602] Forwarding status update of 
operation with no ID (operation_uuid: e5a4c8b5-da58-4673-a11e-439cd71c02fc) for 
an operator API call
I0710 20:50:55.309415 18269 master.cpp:12017] Updating the state of operation 
'' (uuid: e5a4c8b5-da58-4673-a11e-439cd71c02fc) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0710 20:50:55.310154 18269 slave.cpp:4328] Ignoring new checkpointed resources 
and operations identical to the current version
I0710 20:50:55.535017 18277 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
c58d4b22-ac3c-42a5-9e5a-ffc0cb9993eb) for operation UUID 
6a3648f1-7d50-402f-bf46-da66c8c4b071 on agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0
I0710 20:50:55.535095 18277 status_update_manager_process.hpp:414] Creating 
operation status update stream 6a3648f1-7d50-402f-bf46-da66c8c4b071 
checkpoint=true
I0710 20:50:55.535154 18279 provider.cpp:481] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I0710 20:50:55.535501 18277 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: c58d4b22-ac3c-42a5-9e5a-ffc0cb9993eb) for operation UUID 
6a3648f1-7d50-402f-bf46-da66c8c4b071 on agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0
I0710 20:50:55.676519 18277 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
c58d4b22-ac3c-42a5-9e5a-ffc0cb9993eb) for operation UUID 
6a3648f1-7d50-402f-bf46-da66c8c4b071 on agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0
I0710 20:50:55.676914 18277 status_update_manager_process.hpp:252] Received 
operation status update acknowledgement (UUID: 
25653fcb-24c7-4814-b338-e6173b9b0136) for stream 
e5a4c8b5-da58-4673-a11e-439cd71c02fc
I0710 20:50:55.676985 18277 status_update_manager_process.hpp:929] 
Checkpointing ACK for operation status update OPERATION_FINISHED (Status UUID: 
25653fcb-24c7-4814-b338-e6173b9b0136) for operation UUID 
e5a4c8b5-da58-4673-a11e-439cd71c02fc on agent 
42f89090-73ba-4432-bc19-4b81bc70b0d4-S0
I0710 20:50:55.677397 18266 http_connection.hpp:131] Sending 2 call to 
http://172.17.0.2:35051/slave(1206)/api/v1/resource_provider
I0710 20:50:55.678514 18280 process.cpp:3671] Handling HTTP event for 

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

[Greg Mann]

> On July 10, 2019, 3:27 p.m., Benno Evers wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5250 (patched)
> > 
> >
> > The test itself looks good, but is it possible to run it with a stopped 
> > clock? Given the various timers involved in the body, this feels like a 
> > prime candidate to become flaky sooner or later.

I ran into issues using a stopped clock due to the use of the Docker runtime. 
I'm not sure precisely why, but it seems that some Docker containerizer 
operations require the clock to be running; currently, no tests in this file 
stop the clock :-/


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216483
---


On July 8, 2019, 6:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> ---
> 
> (Updated July 8, 2019, 6:28 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
>   src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a6217581e20168c5114f733323e927a83ac59fd0 
> 
> 
> Diff: https://reviews.apache.org/r/71035/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> Verified that this new test fails on current master, and passes when the 
> preceding patches in this chain are applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

[Greg Mann]

> On July 10, 2019, 3:19 p.m., Benno Evers wrote:
> > src/docker/executor.cpp
> > Line 401 (original), 404 (patched)
> > 
> >
> > Should we print the override value here if it is provided?

Good call; done.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/#review216482
---


On July 10, 2019, 8:17 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71034/
> ---
> 
> (Updated July 10, 2019, 8:17 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a new `killTask()` overload to the Docker executor
> and updates the Mesos executor driver to call into that
> overload when the loaded executor is the Docker executor.
> 
> This allows the executor driver to pass the kill policy
> override, when present, into the Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 
> 
> 
> Diff: https://reviews.apache.org/r/71034/diff/2/
> 
> 
> Testing
> ---
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/
---

(Updated July 10, 2019, 8:17 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
---

This adds a new `killTask()` overload to the Docker executor
and updates the Mesos executor driver to call into that
overload when the loaded executor is the Docker executor.

This allows the executor driver to pass the kill policy
override, when present, into the Docker executor.


Diffs (updated)
-

  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 


Diff: https://reviews.apache.org/r/71034/diff/2/

Changes: https://reviews.apache.org/r/71034/diff/1-2/


Testing
---

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 70903: Killed all tasks on the agent when draining.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/
---

(Updated July 10, 2019, 7:07 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and 
Joseph Wu.


Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821


Repository: mesos


Description
---

This patch updates the agent's `DrainSlaveMessage` handler
to kill all tasks on the agent when the message is received.


Diffs (updated)
-

  include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
  src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 


Diff: https://reviews.apache.org/r/70903/diff/4/

Changes: https://reviews.apache.org/r/70903/diff/3-4/


Testing
---

Testing details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 70903: Killed all tasks on the agent when draining.

[Greg Mann]

> On June 27, 2019, 1:36 p.m., Benjamin Bannier wrote:
> > src/slave/slave.cpp
> > Lines 1010-1016 (patched)
> > 
> >
> > What about custom executors? :/
> > 
> > I feel that in general we shouldn't make assumptions  about what 
> > certain executors are doing, and instead introduce our own agent-specific 
> > value (best controllable via a flag).
> > 
> > While you are working on this block you could immediately initialize 
> > `killPolicyGracePeriod` with the default value, and then possibily 
> > overwrite it with the user-provided input.
> > 
> > Note that with your first conditional we would inject the 3s even if a 
> > kill policy was set (to e.g., be interpreted by a custom executor).
> 
> Greg Mann wrote:
> Maybe the following makes sense:
> - For the default executor and the command executor, use their default 
> grace period of 3 seconds when no kill policy was set on the task.
> - For the Docker executor and custom executors, use the 
> 'executor_shutdown_grace_period' set on the agent. This is the default grace 
> period used by the Docker executor, and perhaps also a reasonable default to 
> assume for custom executors?

After some more thought, I think it may be OK to simply pass through the drain 
max grace period when it's set and the task grace period is unknown. The 
worst-case scenario here is that we would apply a longer grace period than 
intended, which seems OK.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70903/#review216192
---


On July 1, 2019, 7:57 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70903/
> ---
> 
> (Updated July 1, 2019, 7:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the agent's `DrainSlaveMessage` handler
> to kill all tasks on the agent when the message is received.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp ed9190b50c18bd218e2d2c04a6aff82687d2996d 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70903/diff/3/
> 
> 
> Testing
> ---
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70899: Refactored the agent's task-killing code.

[Greg Mann]

> On July 2, 2019, 10:52 p.m., Joseph Wu wrote:
> > src/slave/slave.cpp
> > Lines 3673-3680 (original), 3673-3679 (patched)
> > 
> >
> > Due to splitting out the `killPendingTask`, this logic is now executed 
> > before the check for `framework->state == Framework::TERMINATING`.  This 
> > means the agent will no longer log that warning message (Ignoring kill task 
> > ...) for pending tasks only.
> > 
> > Is this intentional?  (It probably isn't a big deal if we don't log 
> > this warning.)

Oh whoops this was unintentional; thanks!! I think it's best to move the 
conditional logging back into `killTask()` just before we call into 
`killPendingTask()`. This maintains exactly the same behavior as before.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/#review216322
---


On July 10, 2019, 6:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70899/
> ---
> 
> (Updated July 10, 2019, 6:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-9821
> https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch factors the code responsible for killing tasks
> out into two helper functions. This will facilitate the
> calling of this common code by the agent-draining handler.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
>   src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 
> 
> 
> Diff: https://reviews.apache.org/r/70899/diff/5/
> 
> 
> Testing
> ---
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70899: Refactored the agent's task-killing code.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70899/
---

(Updated July 10, 2019, 6:59 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and 
Joseph Wu.


Bugs: MESOS-9821
https://issues.apache.org/jira/browse/MESOS-9821


Repository: mesos


Description
---

This patch factors the code responsible for killing tasks
out into two helper functions. This will facilitate the
calling of this common code by the agent-draining handler.


Diffs (updated)
-

  src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 
  src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e 


Diff: https://reviews.apache.org/r/70899/diff/5/

Changes: https://reviews.apache.org/r/70899/diff/4-5/


Testing
---

Testing details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71047: Added per-role suppress/revival to Java test framework.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/#review216493
---



Unsuppressing upon registering seems reasonable, but the suppress/revive upon 
TASK_FINISHED seems strange.


src/examples/java/TestFramework.java
Lines 53 (patched)


Let's just clear the suppressed roles? It looks like there's no actual 
assertion that the name change took place? Whereas the unsuppression is needed 
to get offers and launch the tasks.



src/examples/java/TestFramework.java
Lines 150-153 (patched)


This is strange, and is it even going to fail the test if these calls don't 
take effect properly?


- Benjamin Mahler


On July 10, 2019, 1:16 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71047/
> ---
> 
> (Updated July 10, 2019, 1:16 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
> https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds exercising per-role suppress/revival to the Java test
> framework to ensure that passing the corresponding arguments through the
> Java bindings works.
> 
> 
> Diffs
> -
> 
>   src/examples/java/TestFramework.java 
> c8b0ceacd1305f7ff67f2ef490e14513d2757f5a 
> 
> 
> Diff: https://reviews.apache.org/r/71047/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70528: Updated release guide.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216492
---



Bad patch!

Reviews applied: [70526, 70527, 70528]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_70528"]

Error:
..
UID 52b069fa-1131-41fd-861c-1230ef843ede on agent 
de29b93d-7ba1-4009-9d77-451584f13437-S0
I0710 18:19:26.869289 18267 http_connection.hpp:131] Sending 2 call to 
http://172.17.0.2:37975/slave(1199)/api/v1/resource_provider
I0710 18:19:26.870834 18273 process.cpp:3671] Handling HTTP event for process 
'slave(1199)' with path: '/slave(1199)/api/v1/resource_provider'
I0710 18:19:26.874341 18281 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0710 18:19:26.876186 18268 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:59214
I0710 18:19:26.876731 18268 http.cpp:263] Processing call UNRESERVE_RESOURCES
I0710 18:19:26.877645 18268 master.cpp:3785] Authorizing principal 
'test-principal' to unreserve resources 
'[{"disk":{"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_Ra4Xby/2GB-3ba32cea-b665-4e39-8fa2-044850ba5fe5","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"}},"name":"disk","provider_id":{"value":"9a5db9fa-3490-4d6d-9200-f8fdc8d5b603"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0710 18:19:26.880581 18287 sched.cpp:960] Rescinded offer 
de29b93d-7ba1-4009-9d77-451584f13437-O5
I0710 18:19:26.880709 18287 sched.cpp:971] Scheduler::offerRescinded took 
34521ns
I0710 18:19:26.880852 18284 master.cpp:12470] Removing offer 
de29b93d-7ba1-4009-9d77-451584f13437-O5
I0710 18:19:26.880779 18269 hierarchical.cpp:1218] Recovered disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_Ra4Xby/2GB-3ba32cea-b665-4e39-8fa2-044850ba5fe5,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024; 
ports(allocated: storage/default-role):[31000-32000] (total: cpus:2; mem:1024; 
disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_Ra4Xby/2GB-3ba32cea-b665-4e39-8fa2-044850ba5fe5,test)]:2048,
 allocated: {}) on agent de29b93d-7ba1-4009-9d77-451584f13437-S0 from framework 
de29b93d-7ba1-40
 09-9d77-451584f13437-
I0710 18:19:26.881059 18269 hierarchical.cpp:1264] Framework 
de29b93d-7ba1-4009-9d77-451584f13437- filtered agent 
de29b93d-7ba1-4009-9d77-451584f13437-S0 for 5secs
I0710 18:19:26.883929 18285 master.cpp:12361] Sending operation '' (uuid: 
29dd5c44-70eb-4479-82db-5b8c91a86cb1) to agent 
de29b93d-7ba1-4009-9d77-451584f13437-S0 at slave(1199)@172.17.0.2:37975 
(e12b3ef9ecdc)
I0710 18:19:26.884701 18285 slave.cpp:4198] Ignoring new checkpointed resources 
and operations identical to the current version
I0710 18:19:26.887869 18277 provider.cpp:481] Received APPLY_OPERATION event
I0710 18:19:26.887921 18277 provider.cpp:1295] Received UNRESERVE operation '' 
(uuid: 29dd5c44-70eb-4479-82db-5b8c91a86cb1)
I0710 18:19:26.895143 18268 hierarchical.cpp:1508] Performed allocation for 1 
agents in 1.590289ms
I0710 18:19:26.895936 18279 master.cpp:10195] Sending offers [ 
de29b93d-7ba1-4009-9d77-451584f13437-O6 ] to framework 
de29b93d-7ba1-4009-9d77-451584f13437- (default) at 
scheduler-78871aab-8d14-43b9-94fd-2dc92e6fb5b4@172.17.0.2:37975
I0710 18:19:26.896667 18276 sched.cpp:934] Scheduler::resourceOffers took 
75360ns
I0710 18:19:26.909900 18274 http.cpp:1115] HTTP POST for 
/slave(1199)/api/v1/resource_provider from 172.17.0.2:59196
I0710 18:19:26.911051 18267 slave.cpp:8217] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 52b069fa-1131-41fd-861c-1230ef843ede) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0710 18:19:26.911311 18267 slave.cpp:8670] Updating the state of operation 
with no ID (uuid: 52b069fa-1131-41fd-861c-1230ef843ede) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0710 

Re: Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71048/#review216490
---


Ship it!




Ship It!

- Gilbert Song


On July 10, 2019, 9:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71048/
> ---
> 
> (Updated July 10, 2019, 9:53 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Meng Zhu.
> 
> 
> Bugs: MESOS-9886
> https://issues.apache.org/jira/browse/MESOS-9886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When this test was run as root in CI, the --launcher gets implicitly
> set to `linux` whereas it gets implicitly set to `posix` when run
> as non-root. When run as `linux`, the use of cgroups causes the
> agents to detect each other's containers as orphans and kill them.
> 
> The fix for now is to force the launcher to be posix.
> 
> 
> Diffs
> -
> 
>   src/tests/role_tests.cpp f7a8234030387efbdf7f0353270a9a04d56b164c 
> 
> 
> Diff: https://reviews.apache.org/r/71048/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition as root.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71048/#review216489
---


Ship it!




Ship It!

- Meng Zhu


On July 10, 2019, 9:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71048/
> ---
> 
> (Updated July 10, 2019, 9:53 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Meng Zhu.
> 
> 
> Bugs: MESOS-9886
> https://issues.apache.org/jira/browse/MESOS-9886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When this test was run as root in CI, the --launcher gets implicitly
> set to `linux` whereas it gets implicitly set to `posix` when run
> as non-root. When run as `linux`, the use of cgroups causes the
> agents to detect each other's containers as orphans and kill them.
> 
> The fix for now is to force the launcher to be posix.
> 
> 
> Diffs
> -
> 
>   src/tests/role_tests.cpp f7a8234030387efbdf7f0353270a9a04d56b164c 
> 
> 
> Diff: https://reviews.apache.org/r/71048/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition as root.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 71048: Fixed the flaky RoleTest.RolesEndpointContainsConsumedQuota test.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71048/
---

Review request for mesos, Gilbert Song and Meng Zhu.


Bugs: MESOS-9886
https://issues.apache.org/jira/browse/MESOS-9886


Repository: mesos


Description
---

When this test was run as root in CI, the --launcher gets implicitly
set to `linux` whereas it gets implicitly set to `posix` when run
as non-root. When run as `linux`, the use of cgroups causes the
agents to detect each other's containers as orphans and kill them.

The fix for now is to force the launcher to be posix.


Diffs
-

  src/tests/role_tests.cpp f7a8234030387efbdf7f0353270a9a04d56b164c 


Diff: https://reviews.apache.org/r/71048/diff/1/


Testing
---

Ran in repetition as root.


Thanks,

Benjamin Mahler

Re: Review Request 71043: Added quota consumption to the roles table in the webui.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71043/#review216488
---


Ship it!




Nice!


src/webui/app/roles/roles.html
Line 17 (original), 17 (patched)


I feel we should remove offered here, just show allocation? Given current 
UI, there is no way to tell amount of allocation. I doubt if users care much 
about offered.


- Meng Zhu


On July 9, 2019, 8:31 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71043/
> ---
> 
> (Updated July 9, 2019, 8:31 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9618
> https://issues.apache.org/jira/browse/MESOS-9618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This keeps the existing 'Allocation + Offered' column, rather than
> removing it. However, it would be nice to add additional columns
> for reservation, offered resources, and allocation quantities. Then
> we can remove the old 'Allocation + Offered' column, but will
> probably want to introduce the ability for the user to enable /
> disable columns while viewing.
> 
> 
> Diffs
> -
> 
>   src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478 
> 
> 
> Diff: https://reviews.apache.org/r/71043/diff/2/
> 
> 
> Testing
> ---
> 
> Ran locally.
> 
> 
> File Attachments
> 
> 
> post-change
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/10/da7ac898-35a8-45ff-a434-d98bd76c0e79__Screen_Shot_2019-07-09_at_10.43.20_PM.png
> tooltip
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/10/db7677dd-6647-4d44-9c20-b35ca5b7de85__Screen_Shot_2019-07-09_at_11.28.42_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 71047: Added per-role suppress/revival to Java test framework.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/#review216487
---



Bad patch!

Reviews applied: [71047]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71047"]

Error:
..
us UUID: c4a37b8a-d6f4-4c32-ae99-3ddf48e8de12) for operation UUID 
814d4696-73e9-4929-8797-bbc5bf7eb5be on agent 
d00b84e5-8718-46ea-940c-e286f72e8ecc-S0
I0710 15:54:55.127045 18278 http_connection.hpp:131] Sending 2 call to 
http://172.17.0.2:44968/slave(1199)/api/v1/resource_provider
I0710 15:54:55.128481 18271 process.cpp:3671] Handling HTTP event for process 
'slave(1199)' with path: '/slave(1199)/api/v1/resource_provider'
I0710 15:54:55.132359 18264 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0710 15:54:55.134366 18274 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:45566
I0710 15:54:55.134639 18274 http.cpp:263] Processing call UNRESERVE_RESOURCES
I0710 15:54:55.135423 18274 master.cpp:3785] Authorizing principal 
'test-principal' to unreserve resources 
'[{"disk":{"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_diZEs1/2GB-fb8728fd-97b6-48f0-a119-3c585c3b43dd","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"}},"name":"disk","provider_id":{"value":"ac49acbc-1b73-421b-9599-b71c27ac1aef"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0710 15:54:55.138424 18266 master.cpp:12470] Removing offer 
d00b84e5-8718-46ea-940c-e286f72e8ecc-O5
I0710 15:54:55.138586 18263 sched.cpp:960] Rescinded offer 
d00b84e5-8718-46ea-940c-e286f72e8ecc-O5
I0710 15:54:55.138669 18263 sched.cpp:971] Scheduler::offerRescinded took 
23992ns
I0710 15:54:55.139626 18277 hierarchical.cpp:1218] Recovered disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_diZEs1/2GB-fb8728fd-97b6-48f0-a119-3c585c3b43dd,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024; 
ports(allocated: storage/default-role):[31000-32000] (total: cpus:2; mem:1024; 
disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v0_diZEs1/2GB-fb8728fd-97b6-48f0-a119-3c585c3b43dd,test)]:2048,
 allocated: {}) on agent d00b84e5-8718-46ea-940c-e286f72e8ecc-S0 from framework 
d00b84e5-8718-46
 ea-940c-e286f72e8ecc-
I0710 15:54:55.139758 18277 hierarchical.cpp:1264] Framework 
d00b84e5-8718-46ea-940c-e286f72e8ecc- filtered agent 
d00b84e5-8718-46ea-940c-e286f72e8ecc-S0 for 5secs
I0710 15:54:55.142410 18269 master.cpp:12361] Sending operation '' (uuid: 
b7639072-1776-41d5-ba53-0e24f7548b4c) to agent 
d00b84e5-8718-46ea-940c-e286f72e8ecc-S0 at slave(1199)@172.17.0.2:44968 
(b727e219f54d)
I0710 15:54:55.142972 18278 slave.cpp:4198] Ignoring new checkpointed resources 
and operations identical to the current version
I0710 15:54:55.146268 18264 provider.cpp:481] Received APPLY_OPERATION event
I0710 15:54:55.146315 18264 provider.cpp:1295] Received UNRESERVE operation '' 
(uuid: b7639072-1776-41d5-ba53-0e24f7548b4c)
I0710 15:54:55.152446 18280 hierarchical.cpp:1508] Performed allocation for 1 
agents in 1.127484ms
I0710 15:54:55.153100 18262 master.cpp:10195] Sending offers [ 
d00b84e5-8718-46ea-940c-e286f72e8ecc-O6 ] to framework 
d00b84e5-8718-46ea-940c-e286f72e8ecc- (default) at 
scheduler-a2595cdd-6af2-49fb-bd5f-313deba49d89@172.17.0.2:44968
I0710 15:54:55.153779 18274 sched.cpp:934] Scheduler::resourceOffers took 138us
I0710 15:54:55.166543 18260 http.cpp:1115] HTTP POST for 
/slave(1199)/api/v1/resource_provider from 172.17.0.2:45554
I0710 15:54:55.167589 18269 slave.cpp:8217] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 814d4696-73e9-4929-8797-bbc5bf7eb5be) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0710 15:54:55.167793 18269 slave.cpp:8670] Updating the state of operation 
with no ID (uuid: 814d4696-73e9-4929-8797-bbc5bf7eb5be) for an operation API 
call (latest state: OPERATION_FINISHED, status 

Re: Review Request 70528: Updated release guide.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216485
---


Ship it!




- Vinod Kone


On July 10, 2019, 2:58 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70528/
> ---
> 
> (Updated July 10, 2019, 2:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the release guide in `docs/release-guide.md` to match
> the de-facto process we're using to release new versions.
> 
> Also mentioned some additional third-party tooling to the post-release
> desription.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md a3ad2668a1953a7f20dd7209e122481ad8b30f17 
> 
> 
> Diff: https://reviews.apache.org/r/70528/diff/3/
> 
> 
> Testing
> ---
> 
> Released Mesos 1.8.0 according to this procedure.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70528: Updated release guide.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/#review216486
---


Ship it!




Ship It!

- Vinod Kone


On July 10, 2019, 2:58 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70528/
> ---
> 
> (Updated July 10, 2019, 2:58 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the release guide in `docs/release-guide.md` to match
> the de-facto process we're using to release new versions.
> 
> Also mentioned some additional third-party tooling to the post-release
> desription.
> 
> 
> Diffs
> -
> 
>   docs/release-guide.md a3ad2668a1953a7f20dd7209e122481ad8b30f17 
> 
> 
> Diff: https://reviews.apache.org/r/70528/diff/3/
> 
> 
> Testing
> ---
> 
> Released Mesos 1.8.0 according to this procedure.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 70527: Updated Bintray URL in docs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70527/#review216484
---


Ship it!




Ship It!

- Vinod Kone


On April 23, 2019, 2:32 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70527/
> ---
> 
> (Updated April 23, 2019, 2:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Bintray URL in docs.
> 
> 
> Diffs
> -
> 
>   docs/binary-packages.md 462e732246aa3f3a69f243e512fa73012341 
> 
> 
> Diff: https://reviews.apache.org/r/70527/diff/1/
> 
> 
> Testing
> ---
> 
> Opened the modified links in a browser to ensure no typos.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

[GitHub] [mesos] bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-510110404
 
 
   @vinodkone : is this sentence a few lines above accurate then? 
   
   > This call can only be made against containers that have been launched with 
an associated IOSwitchboard (i.e. nested containers launched via a 
LAUNCH_NESTED_CONTAINER_SESSION call or normal containers launched with a 
TTYInfo in their ContainerInfo)
   
   See also 
https://github.com/dcos/dcos-core-cli/blob/1.14-patch.x/python/lib/dcos/dcos/mesos.py#L1425-L1428,
 where the code treats a missing I/O Switchboard as missing TTY.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 71035: Added test to verify that Docker executor can override kill policy.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71035/#review216483
---




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5250 (patched)


The test itself looks good, but is it possible to run it with a stopped 
clock? Given the various timers involved in the body, this feels like a prime 
candidate to become flaky sooner or later.


- Benno Evers


On July 8, 2019, 6:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71035/
> ---
> 
> (Updated July 8, 2019, 6:28 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a test which verifies that when a scheduler attemps to
> override a task's default kill policy, the Docker executor will
> honor that override.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp ffbb342a42ec3501383500dee55dff3588725478 
>   src/internal/evolve.cpp 81de15e192580d2f35237e124c11902e1fc67a1d 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a6217581e20168c5114f733323e927a83ac59fd0 
> 
> 
> Diff: https://reviews.apache.org/r/71035/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> `sudo bin/mesos-tests.sh --gtest_filter="*ROOT_DOCKER_OverrideKillPolicy*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> Verified that this new test fails on current master, and passes when the 
> preceding patches in this chain are applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/#review216482
---


Fix it, then Ship it!





src/docker/executor.cpp
Line 401 (original), 404 (patched)


Should we print the override value here if it is provided?



src/docker/executor.cpp
Lines 948 (patched)


Unnecessary `move`?



src/docker/executor.cpp
Lines 992 (patched)


Same as above, unnecessary `std::move()`.



src/exec/exec.cpp
Lines 374 (patched)


I believe the "standard" way to write this would be

```
auto* dockerExecutor = dynamic_cast(executor);
if (dockerExecutor) {
  // `executor` was a `DockerExecutor`
} else {
  // `executor` was some other `Executor`
}
```

This way, classes derived from `DockerExecutor` will also get the correct 
overload.


- Benno Evers


On July 8, 2019, 6:25 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71034/
> ---
> 
> (Updated July 8, 2019, 6:25 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a new `killTask()` overload to the Docker executor
> and updates the Mesos executor driver to call into that
> overload when the loaded executor is the Docker executor.
> 
> This allows the executor driver to pass the kill policy
> override, when present, into the Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 
> 
> 
> Diff: https://reviews.apache.org/r/71034/diff/1/
> 
> 
> Testing
> ---
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71033: Moved the Docker executor declaration into a header.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/#review216481
---


Ship it!




Ship It!

- Benno Evers


On July 8, 2019, 6:22 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71033/
> ---
> 
> (Updated July 8, 2019, 6:22 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
> https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This moves the declaration of the Docker executor into the
> Docker executor header file and moves the code for the Docker
> executor binary into a new launcher implementation file.
> 
> This change will enable the Mesos executor driver
> implementation to make use of the `DockerExecutor` symbol.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/launcher/docker_executor.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71033/diff/1/
> 
> 
> Testing
> ---
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

[GitHub] [mesos] vinodkone commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

vinodkone commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-510098398
 
 
   IOSwitchboard is used by containers with or without TTY. 
   
   s/launched with an associated IOSwitchboard/launched with TTYInfo in their 
ContainerInfo/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 70528: Updated release guide.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70528/
---

(Updated July 10, 2019, 2:58 p.m.)


Review request for mesos, Greg Mann, Joseph Wu, and Till Toenshoff.


Summary (updated)
-

Updated release guide.


Repository: mesos


Description (updated)
---

Updated the release guide in `docs/release-guide.md` to match
the de-facto process we're using to release new versions.

Also mentioned some additional third-party tooling to the post-release
desription.


Diffs (updated)
-

  docs/release-guide.md a3ad2668a1953a7f20dd7209e122481ad8b30f17 


Diff: https://reviews.apache.org/r/70528/diff/3/

Changes: https://reviews.apache.org/r/70528/diff/2-3/


Testing (updated)
---

Released Mesos 1.8.0 according to this procedure.


Thanks,

Benno Evers

[GitHub] [mesos] jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

jdef commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-510070437
 
 
   @vinodkone PTAL, feedback has been addressed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

bamarni commented on issue #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340#issuecomment-510063838
 
 
   Updated it, I've used `launched with an associated IOSwitchboard` instead of 
tty as it's what's being used elsewhere on the page.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

bamarni opened a new pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340
 
 
   This documents how to indicate when EOF is reached on STDIN.
   
   See 
https://github.com/dcos/dcos-core-cli/blob/00e1d8f4eddca5d961152f32669e02ed81d5/python/lib/dcos/dcos/mesos.py#L1657-L1658


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mesos] bamarni closed pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT

[GitBox]

bamarni closed pull request #340: Documented EOF in ATTACH_CONTAINER_INPUT
URL: https://github.com/apache/mesos/pull/340
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Review Request 71047: Added per-role suppress/revival to Java test framework.

[Andrei Sekretenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71047/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9849
https://issues.apache.org/jira/browse/MESOS-9849


Repository: mesos


Description
---

This patch adds exercising per-role suppress/revival to the Java test
framework to ensure that passing the corresponding arguments through the
Java bindings works.


Diffs
-

  src/examples/java/TestFramework.java c8b0ceacd1305f7ff67f2ef490e14513d2757f5a 


Diff: https://reviews.apache.org/r/71047/diff/1/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 71043: Added quota consumption to the roles table in the webui.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71043/#review216475
---



Patch looks great!

Reviews applied: [71031, 71032, 71043]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 10, 2019, 3:31 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71043/
> ---
> 
> (Updated July 10, 2019, 3:31 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9618
> https://issues.apache.org/jira/browse/MESOS-9618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This keeps the existing 'Allocation + Offered' column, rather than
> removing it. However, it would be nice to add additional columns
> for reservation, offered resources, and allocation quantities. Then
> we can remove the old 'Allocation + Offered' column, but will
> probably want to introduce the ability for the user to enable /
> disable columns while viewing.
> 
> 
> Diffs
> -
> 
>   src/webui/app/roles/roles.html 02cb7ba09845d4f9b51630d9c59c1bbd533ac478 
> 
> 
> Diff: https://reviews.apache.org/r/71043/diff/2/
> 
> 
> Testing
> ---
> 
> Ran locally.
> 
> 
> File Attachments
> 
> 
> post-change
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/10/da7ac898-35a8-45ff-a434-d98bd76c0e79__Screen_Shot_2019-07-09_at_10.43.20_PM.png
> tooltip
>   
> https://reviews.apache.org/media/uploaded/files/2019/07/10/db7677dd-6647-4d44-9c20-b35ca5b7de85__Screen_Shot_2019-07-09_at_11.28.42_PM.png
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>