Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/#review93557 --- Ship it! - Alexander Rojas On July 29, 2015, 7:40 p.m., haosdent

Re: Review Request 36911: Removed unnecessary using directive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36911/#review94036 --- Ship it! Ship It! - Alexander Rojas On Aug. 3, 2015, 4:58 p.m

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

--- make check Thanks, Alexander Rojas

Re: Review Request 36049: Added support for modularized Authorizer

--- make check Thanks, Alexander Rojas

Re: Review Request 36050: Added test authorizer module.

src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36050: Added test authorizer module.

03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

- Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93900 ------- On Aug. 4, 2015, 4:13 p.m., Alexander Rojas wrote: >

Re: Review Request 36049: Added support for modularized Authorizer

alize method at least with that signature), and then entirely remove this code. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review93906 --------

Re: Review Request 36050: Added test authorizer module.

/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

check Thanks, Alexander Rojas

Re: Review Request 36049: Added support for modularized Authorizer

check Thanks, Alexander Rojas

Re: Review Request 37074: Added process id prefix for benchmarks and process tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37074/#review94383 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 4:52 p.m

Re: Review Request 37073: Added process id prefix for cram_md5_authentication_tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37073/#review94384 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 4:53 p.m

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

come from the RFC. Can you move it before the headline or after the contents from the rfc? 3rdparty/libprocess/src/http.cpp (line 159) <https://reviews.apache.org/r/37097/#comment148964> I don't think we use `cout` in libprocess but `VLOG` (check `decode` in this file). - Alexa

Re: Review Request 37108: Remove unused failover functionality in scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37108/#review94387 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 3:19 a.m

Re: Review Request 36847: Added HTTP Delete Method.

http calls. That being said, the way I have seen other http libraries getting around the keyword issue is by using an underscore at some point. - Alexander Rojas On Aug. 4, 2015, 12:57 p.m., Joerg Schad wrote: > > --- > This

Re: Review Request 37109: Removed ability to mutate user from scheduler library

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37109/#review94389 --- Ship it! - Alexander Rojas On Aug. 5, 2015, 3:23 a.m., Anand

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

)`. `mlock()` will only lock the memory passed to the call in the physical memory while `mlockall()` will lock every new allocation after we made this call (and that includes stack, heap and code sections) until we make a `munlockall()` call, which we don't. - Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

tps://reviews.apache.org/r/37097/#comment149139> s/2606/2616/ - Alexander Rojas On Aug. 6, 2015, 7:35 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review94516 --- Ship it! Ship It! - Alexander Rojas On Aug. 7, 2015, 11:45 a.m

Re: Review Request 37188: Added std::hash template specializations.

- 687) <https://reviews.apache.org/r/37188/#comment149141> Can you explain why these two comparisons in each case need to be done. - Alexander Rojas On Aug. 7, 2015, 11:45 a.m., Jan Schlicht wrote: > > --- > This is a

Re: Review Request 37189: Added std::hash template specializations.

tic has any value here. src/tests/containerizer.hpp (lines 56 - 59) <https://reviews.apache.org/r/37189/#comment149144> I think is better to use `boost::hash_combine` here. - Alexander Rojas On Aug. 7, 2015, 11:46 a

Re: Review Request 37189: Added std::hash template specializations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94539 --- Ship it! Ship It! - Alexander Rojas On Aug. 7, 2015, 1:52 p.m

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

ave the solution I described there. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94648 ---

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

, Alexander Rojas

Re: Review Request 36049: Added support for modularized Authorizer

://reviews.apache.org/r/36049/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36050: Added test authorizer module.

/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36049: Added support for modularized Authorizer

--- make check Thanks, Alexander Rojas

Re: Review Request 36050: Added test authorizer module.

03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 ------- On Aug. 12, 2015, 3:52 p.m., Alexander Rojas wrote: > > --- > This is an automatically

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

plicated. I filled a JIRA ([MESOS-3072](https://issues.apache.org/jira/browse/MESOS-3072)) on the matter. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#revi

Re: Review Request 36819: Use setup.py in python cli package.

g/r/36819/#comment149927> Why was the shebang line removed? - Alexander Rojas On Aug. 7, 2015, 5:08 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

check Thanks, Alexander Rojas

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95271 --- On Aug. 13, 2015, 7:08 p.m., Alexander Rojas wrote: > >

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

tps://reviews.apache.org/r/37443/#comment150348> Line length is 81 characters. src/tests/fault_tolerance_tests.cpp (line 1866) <https://reviews.apache.org/r/37443/#comment150349> Line length is 81 characters. - Alexander Rojas On Aug. 14, 2015, 1:29 p.m., James De

Re: Review Request 37443: Add "labels" to FrameworkInfo (v2)

> On Aug. 14, 2015, 1:49 p.m., Alexander Rojas wrote: > > src/tests/fault_tolerance_tests.cpp, line 1834 > > <https://reviews.apache.org/r/37443/diff/4/?file=1039554#file1039554line1834> > > > > Line length is 81 characters. > > James DeFelice wrote:

Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

fb3e7a1d0377001389980302342813217f49cf5f 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp b625ffaeb3672f58fbd9558a868f87404e659c53 Diff: https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 36620: Added Non-Freezeer Task Killer.

rg/r/36620/#comment151431> Again the name, without looking anywhere else, if feels as if we where checking for frozen tasks and that were an error. - Alexander Rojas On Aug. 24, 2015, 11:33 a.m., Joerg Schad wrote: > >

Review Request 37791: Removed provisioner_backend_tests.cpp from build in OSX

/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964 Diff: https://reviews.apache.org/r/37791/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37791: Removed provisioner_backend_tests.cpp from build in OSX

7b620ff66856b3f0adac121b3297d55ed71a3d99 src/tests/containerizer/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964 Diff: https://reviews.apache.org/r/37791/diff/ Testing (updated) --- # Both linux and windows. make check Thanks, Alexander Rojas

Re: Review Request 37791: Removed provisioner_backend_tests.cpp from build in OSX

7b620ff66856b3f0adac121b3297d55ed71a3d99 src/tests/containerizer/provisioner_backend_tests.cpp 096bd4d4bbd602913796c5e542e033bdd9e04964 Diff: https://reviews.apache.org/r/37791/diff/ Testing (updated) --- # Both linux and OSX. make check Thanks, Alexander Rojas

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

, Alexander Rojas

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97062 --- Ship it! Ship It! - Alexander Rojas On Aug. 29, 2015, 12:25 a.m

Re: Review Request 37996: Added property manager

/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714 3rdparty/libprocess/3rdparty/stout/tests/properties_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38000: WIP: Added an API for libprocess users to interact with http::AuthenticatorManager

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

sting --- make check Thanks, Alexander Rojas

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

h. I'll drop this and if you think I really ought to remove it, please reopen. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review98293

Re: Review Request 38481: Fix UUID::random compile error in OSX.

advertised, this is a clean and elegant solution. 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 34) <https://reviews.apache.org/r/38481/#comment156413> Add empty line here. - Alexander Rojas On Sept. 18, 2015, 11:02 a.m., haosdent huang

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

che.org/r/38399/#comment156983> +1 - Alexander Rojas On Sept. 18, 2015, 11:37 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

check Thanks, Alexander Rojas

Re: Review Request 37996: WIP: Added property manager

org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

-CREATION Diff: https://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

s.cpp 4afa30569b4d235637b49a624602e6b199c32e0e Diff: https://reviews.apache.org/r/37998/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

Diff: https://reviews.apache.org/r/37999/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

/38000/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

://reviews.apache.org/r/38094/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

/multimap_tests.cpp 535cd2d10e3074c86c149ce85b205e73ca42ddd3 Diff: https://reviews.apache.org/r/37714/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37997: Running PathInheritedProperties tests from libprocess Makefile

Sept. 23, 2015, 10:55 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37997/ > --- >

Re: Review Request 37996: Added property manager

. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review100236 --- On Sept. 23, 2015, 1:17 p.m., Alexander Rojas wrote: > > -

Re: Review Request 37999: Implemented http::AuthenticatorManager

ws.apache.org/r/37999/#review100235 --- On Sept. 23, 2015, 10:57 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

d0b9399d38fa284466a012a21080b1d9007af98b Diff: https://reviews.apache.org/r/38094/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

ttps://reviews.apache.org/r/37996/#review100561 --- On Sept. 23, 2015, 1:17 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 37996: Added property manager

/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

is not used anywhere and it doesn't allow for asynchronous operations within handle. Diffs (updated) - 3rdparty/libprocess/src/process.cpp c03fba47435505484704e6c8a61e56123859781f Diff: https://reviews.apache.org/r/37998/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

16ddbd77afa6efdf6bad201aa497ee102aa863ae 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2 3rdparty/libprocess/src/process.cpp c03fba47435505484704e6c8a61e56123859781f Diff: https://reviews.apache.org/r/37999/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37997: Running InheritanceTree tests from libprocess Makefile

iff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37998: Made ProcessManager::handle() a void returning method.

is not used anywhere and it doesn't allow for asynchronous operations within handle. Diffs (updated) - 3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 Diff: https://reviews.apache.org/r/37998/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

16ddbd77afa6efdf6bad201aa497ee102aa863ae 3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416 3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 Diff: https://reviews.apache.org/r/37999/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

c380f356548cf9f5491044bccabcd9c66ad5f55a Diff: https://reviews.apache.org/r/38094/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

d1c81f1d244f02bf42cab97198587ce1b8c7c407 3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a Diff: https://reviews.apache.org/r/38000/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

hanks, Alexander Rojas

Review Request 38950: Http Authenticators can be loaded as modules from mesos.

0820978441aede18dae6d1701433bff705b8c3c2 src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f Diff: https://reviews.apache.org/r/38950/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

check Thanks, Alexander Rojas

Re: Review Request 37997: Running InheritanceTree tests from libprocess Makefile

commits. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 Diff: https://reviews.apache.org/r/37997/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

Thanks, Alexander Rojas

Re: Review Request 37996: Added property manager

is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101552 ------- On Oct. 5, 2015, 6:02 p.m., Alexander Rojas wrote: > > --- &g

Re: Review Request 37996: Added property manager

--- make check Thanks, Alexander Rojas

Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager

d1c81f1d244f02bf42cab97198587ce1b8c7c407 3rdparty/libprocess/src/tests/http_tests.cpp 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472 Diff: https://reviews.apache.org/r/38000/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

/http_authentication_tests.cpp PRE-CREATION src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f Diff: https://reviews.apache.org/r/38950/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 39043: Added support for HTTP Authentication in Mesos.

9d957519bb0f717526af9b2717dc870fae93c20f src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b src/tests/teardown_tests.cpp 2eeead74b877e282660c4009910c42d93ef3ff46 Diff: https://reviews.apache.org/r/39043/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added InheritanceTree

ATION Diff: https://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

/libprocess/3rdparty/stout/tests/inheritancetree_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/37996/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 37999: Implemented http::AuthenticatorManager

/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review102220 --- Ship it! Ship It! - Alexander Rojas On Oct. 8, 2015, 3:27 p.m

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/#review101639 --- On Oct. 7, 2015, 11:54 a.m., Alexander Rojas wrote: > > --

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

we cannot use `FILE(GLOB_RECURSE …)` - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review102160 -------

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

Any reason you can't layer that > functionality on top or, even better, on the side via a free standing > function so that you don't need to introduce a new data structure? > > Jie Yu wrote: > +1 if we can compose/inherit from boost property tree rather than > im

<    1   2   3   4   5   6   7   8   9   10   >