Review Request 70377: Added tests to check that the framework cannot change its principal.

, Andrei Sekretenko

Review Request 70379: Added validation that the principal stays the same on resubscription.

/master.hpp 94891af9deeaddbfc9d6eabb243aed97f7b7 src/master/master.cpp cf5caa0893ba1387a1f3a9d129ecd7d974f776bd Diff: https://reviews.apache.org/r/70379/diff/1/ Testing --- make check Now the two failing tests from https://reviews.apache.org/r/70377/ pass. Thanks, Andrei

Re: Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

) --- make check Thanks, Andrei Sekretenko

Review Request 70378: Wrapped access to hashmaps in `frameworks.principals` and `authorized`.

, it is not - and this is the direct cause of MESOS-2842.) Diffs - src/master/master.hpp 94891af9deeaddbfc9d6eabb243aed97f7b7 src/master/master.cpp cf5caa0893ba1387a1f3a9d129ecd7d974f776bd Diff: https://reviews.apache.org/r/70378/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70387: Updated the bundled glog to 0.4.0.

0d584b8ee0606075d8de7c314395b92c0fe248eb Diff: https://reviews.apache.org/r/70387/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

/ Testing --- Thanks, Andrei Sekretenko

Review Request 70408: Deduplicated common validation code in Master::subscribe()'s.

: https://reviews.apache.org/r/70408/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

/70377/ pass. Thanks, Andrei Sekretenko

Re: Review Request 70377: Added tests to check that framework cannot change its principal.

--- Ran make check - these two tests fail, others don't. Thanks, Andrei Sekretenko

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

the information about the old principal from master, I'll add the new principal to the error and gladly drop this line. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#revie

Review Request 70334: Extended the glog LogSink interface to be able to log microseconds.

to glog 0.3.3 Diffs - 3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06 Diff: https://reviews.apache.org/r/70334/diff/1/ Testing --- Run existing tests, including Windows build. Thanks, Andrei Sekretenko

Re: Review Request 70334: Extended the glog LogSink interface to be able to log microseconds.

/diff/1/ Testing --- Run existing tests, including Windows build. Thanks, Andrei Sekretenko

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

://reviews.apache.org/r/70388/diff/3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.

://reviews.apache.org/r/70388/diff/3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70377: Added tests to check that framework cannot change its principal.

fail, others don't. Thanks, Andrei Sekretenko

Re: Review Request 70408: Deduplicated common validation code in Master::subscribe()'s.

94891af9deeaddbfc9d6eabb243aed97f7b7 src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 Diff: https://reviews.apache.org/r/70408/diff/3/ Changes: https://reviews.apache.org/r/70408/diff/2-3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

://reviews.apache.org/r/70379/diff/4/ Changes: https://reviews.apache.org/r/70379/diff/3-4/ Testing --- make check Now the two failing tests from https://reviews.apache.org/r/70377/ pass. Thanks, Andrei Sekretenko

Re: Review Request 70466: Prevented bundled glog cmake build from finding system gflags.

.org/r/70466/ > --- > > (Updated April 12, 2019, 11:40 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benno Evers. > > > Repository: mesos > > > Description > --- > > Since glog-0.4.0 the glog cmake build seems to find a system-wide > install

Review Request 70666: Introduced a function for validating a `FrameworkInfo` update.

95638a17052ece6c957aa76e4cead8d7bfe82024 src/master/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8 Diff: https://reviews.apache.org/r/70666/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70667: Added unit tests for 'framework::validateUpdate()'.

--- Thanks, Andrei Sekretenko

Review Request 70664: Made `activateRecoveredFramework()` return void instead of Nothing().

c523c937e294eaffe0e58306c267770c119c9f42 src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d Diff: https://reviews.apache.org/r/70664/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70663: Removed non-implemented declaration of 'Master::validate()'.

, Andrei Sekretenko

Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8 src/tests/master_validation_tests.cpp 1b7a8273f2704e0a4dedf33c55ede33dc1b1a4af Diff: https://reviews.apache.org/r/70669/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.

/ Testing --- Thanks, Andrei Sekretenko

Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

c72b92656dddca63ee89abf676da66bd76f58a6d Diff: https://reviews.apache.org/r/70665/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.

9fb0850987ce385d345302cac9721adead7181b8 Diff: https://reviews.apache.org/r/70532/diff/6/ Changes: https://reviews.apache.org/r/70532/diff/5-6/ Testing --- Thanks, Andrei Sekretenko

Review Request 70670: Simplified the `Framework::update()` method.

/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b Diff: https://reviews.apache.org/r/70670/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- Thanks, Andrei Sekretenko

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

Diff: https://reviews.apache.org/r/70533/diff/6/ Changes: https://reviews.apache.org/r/70533/diff/5-6/ Testing --- Thanks, Andrei Sekretenko

Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

/tests/mock_master_api_subscriber.hpp PRE-CREATION src/tests/mock_master_api_subscriber.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70671/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215206 --- On May 17, 2019, 3:19 p.m., Andrei Sekretenko wrote: > >

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

st CHECK it. Moved this into call validation. Now this method does not need the `frameworkId` at all. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review215205 ---

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/#review214864 ----------- On May 17, 2019, 3:18 p.m., Andrei Sekretenko wrote: > > --- > This is

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

le on waiting for AGENT_ADDED, I'll have to write a better comment. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215500 ----------

Review Request 70782: Added a crude probabilistic test for MESOS-9808.

as the code in MESOS-9808. With a fix from https://reviews.apache.org/r/70778/ - one run takes around 2 seconds. Sometimes still deadlocks with similar stacks. Thanks, Andrei Sekretenko

Re: Review Request 70778: Fixed a deadlock in libprocess.

https://reviews.apache.org/r/70782/ Stacks of deadlock: https://issues.apache.org/jira/secure/attachment/12970834/12970834_deadlock_stacks_with_fix.txt - Andrei Sekretenko On June 4, 2019, 3:49 a.m., Benjamin Mahler

Re: Review Request 70778: Fixed a deadlock in libprocess.

> On June 4, 2019, 1:15 p.m., Andrei Sekretenko wrote: > > 3rdparty/libprocess/src/process.cpp > > Line 3520 (original), 3526 (patched) > > <https://reviews.apache.org/r/70778/diff/1/?file=2147700#file2147700line3528> > > > > It turns out that this

Review Request 70809: Fixed non-deferred callback calling Master::send() in UpdateFramework.

/ Testing --- make check + tests from https://reviews.apache.org/r/70755/ which is not committed yet: `./bin/mesos-tests.sh --verbose --gtest_filter="UpdateFrameworkV0Test*" --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Sekretenko

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

in in MESOS-9808. With both fixes applied, one run takes around 400 ms on a release build. No deadlock observed in 1000 runs. Thanks, Andrei Sekretenko

Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver.

stored in the driver for the purposes of (re-)subscribing). Diffs - include/mesos/scheduler.hpp 2ea7cdf1f9473c7b94d4282dd0df129947c97e69 src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 Diff: https://reviews.apache.org/r/70752/diff/2/ Testing --- Thanks, Andrei

Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver.

/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 Diff: https://reviews.apache.org/r/70752/diff/2/ Changes: https://reviews.apache.org/r/70752/diff/1-2/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

nerated e-mail. To reply, visit: https://reviews.apache.org/r/70782/#review215728 --- On June 5, 2019, 3:47 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically gen

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

epeat=1000` with new tests from https://reviews.apache.org/r/70534/ `./bin/mesos-tests.sh --verbose --gtest_filter="*MasterAPITest*" --gtest_break_on_failure --gtest_repeat=1000` with refactored tests from https://reviews.apache.org/r/70756/ Thanks, Andrei Sekretenko

Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

/java/src/org/apache/mesos/SchedulerDriver.java 85faa8e6f8b3420ce140eff7ac860a5f3d417928 Diff: https://reviews.apache.org/r/70813/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing - WIP

2e50861bf40ceeaf6a40476a742e6e82c23ba86f Diff: https://reviews.apache.org/r/70814/diff/1/ Testing (updated) --- make check NOTE: without this change it is not possible to subscribe the java example framework with a role/roles other than `*` Thanks, Andrei Sekretenko

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

778/ - deadlocks 100 out of 100 times on the hardware I used. Without the first fix the deadlock is due to the same reason as initially observed in in MESOS-9808. With both fixes applied, one run takes around 400 ms on a release build. No deadlock observed in 1000 runs. Thanks, Andrei Sekretenko

Review Request 70814: Added explicit roles to ACL of script tests for UpdateFramework testing.

with a role/roles other than `*` Thanks, Andrei Sekretenko

Review Request 70815: Added using updateFramework() to java V0 example framework.

c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899 Diff: https://reviews.apache.org/r/70815/diff/1/ Testing --- `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100` Thanks, Andrei Sekretenko

Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces.

--- Thanks, Andrei Sekretenko

Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

, Andrei Sekretenko

Review Request 70756: Refactored some of `MasterAPITest`s using MockMasterAPISubscriber.

2220cecc22778a86f0c29317adf495927e1a900d Diff: https://reviews.apache.org/r/70756/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70751: Implemented V0 UPDATE_FRAMEWORK call.

/master/master.hpp 2771f4c045c877b7d8aa5db042810232c0e40ba0 src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b Diff: https://reviews.apache.org/r/70751/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70752: Supported updating framework in MesosSchedulerDriver.

of (re-)subscribing). Diffs - include/mesos/scheduler.hpp 2ea7cdf1f9473c7b94d4282dd0df129947c97e69 src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 Diff: https://reviews.apache.org/r/70752/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

://reviews.apache.org/r/70671/diff/3-4/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70751: Implemented V0 UPDATE_FRAMEWORK call.

--- Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

look. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215579 --- On May 29, 2019, 7:17 p.m., Andrei Sekretenko wrote: > > -

Review Request 70753: Templatized UPDATE_FRAMEWORK test helpers over type of FrameworkInfo.

/update_framework_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70753/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

est_break_on_failure --gtest_repeat=1000 with refactored tests from https://reviews.apache.org/r/70756/ Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

est_break_on_failure --gtest_repeat=1000` with refactored tests from https://reviews.apache.org/r/70756/ Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

-CREATION src/tests/master/mock_master_api_subscriber.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70671/diff/5/ Changes: https://reviews.apache.org/r/70671/diff/4-5/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

e6b1d8a097246f0921467d7f778034d6754fcff6 src/tests/master/update_framework_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70534/diff/9/ Changes: https://reviews.apache.org/r/70534/diff/8-9/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

://reviews.apache.org/r/70755/diff/2/ Changes: https://reviews.apache.org/r/70755/diff/1-2/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

e process to terminate before we leave > > // the destructor (and therefore cannot spawn the process with > > `managed=true`) > > // since the process may invoke the mock methods on this class. > > terminate(process.get()); > > wait(process.ge

Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.

still deadlocks with similar stacks. Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

/master/mock_master_api_subscriber.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70671/diff/3/ Changes: https://reviews.apache.org/r/70671/diff/2-3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

e6b1d8a097246f0921467d7f778034d6754fcff6 src/tests/master/update_framework_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/70534/diff/8/ Changes: https://reviews.apache.org/r/70534/diff/7-8/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

with gmock's API. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215497 --- On May 28, 2019, 5:35 p.m., Andrei Sek

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215500 ------- On May 28, 2019, 5:36 p.m., Andrei Sekretenko wrote: > > -

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

07bdd4b273137bad11742e9024947c7f1ad905e4 src/java/src/org/apache/mesos/SchedulerDriver.java 85faa8e6f8b3420ce140eff7ac860a5f3d417928 Diff: https://reviews.apache.org/r/70813/diff/3/ Changes: https://reviews.apache.org/r/70813/diff/2-3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70854: Made scheduler driver's updateFramework() require FrameworkInfo with ID.

://reviews.apache.org/r/70854/diff/2/ Changes: https://reviews.apache.org/r/70854/diff/1-2/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70855: Adapted UpdateFrameworkV0 tests to the fix of FrameworkID handling.

="UpdateFrameworkV0*ID*" --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Sekretenko

Re: Review Request 70815: Added using updateFramework() to java V0 example framework.

: https://reviews.apache.org/r/70815/diff/3/ Changes: https://reviews.apache.org/r/70815/diff/2-3/ Testing --- `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=100` Thanks, Andrei Sekretenko

Re: Review Request 70855: Adapted UpdateFrameworkV0 tests to the fix of FrameworkID handling.

V0*ID*" --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Sekretenko

Re: Review Request 70854: Made scheduler driver's updateFramework() require FrameworkInfo with ID.

/reviews.apache.org/r/70854/#review215916 --- On June 14, 2019, 12:32 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 70897: Supported suppressedRoles in updateFramework() in V0 Java bindings.

/70897/diff/1-2/ Testing --- `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` with a patch from https://reviews.apache.org/r/70815/ Thanks, Andrei Sekretenko

Re: Review Request 70895: Added a test for supperssing roles via V0 updateFramework().

Roles" --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Sekretenko

Re: Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework().

epeat=1000` +a new test from the depending patch Thanks, Andrei Sekretenko

Review Request 70943: Added scheduler driver constructors which set initial suppressed roles.

e6cc534264e3ff4edaa703a660afb2f896388802 Diff: https://reviews.apache.org/r/70943/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70945: Added a constructor with a list of suppressed roles to Java V0 bindings.

/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4 Diff: https://reviews.apache.org/r/70945/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70944: Added a test for scheduler driver registering with a suppressed role.

/ Testing --- Thanks, Andrei Sekretenko

Review Request 70947: Added `reviveOffers(roles)` to V0 Java bindings.

/MesosSchedulerDriver.java 55ebc8772d9183286c908b4dba342109f28394f4 src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f Diff: https://reviews.apache.org/r/70947/diff/1/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70942: Added a test for 'reviveOffers(roles)'.

epeat=1000` Thanks, Andrei Sekretenko

Review Request 70941: Added to the scheduler driver a method to revive a subset of roles.

8c6774885ceb3b0644c32842a17fba39e2c3e472 src/sched/sched.cpp e6cc534264e3ff4edaa703a660afb2f896388802 Diff: https://reviews.apache.org/r/70941/diff/1/ Testing --- Thanks, Andrei Sekretenko

Review Request 70942: Added a test for 'reviveOffers(roles)'.

55ebc8772d9183286c908b4dba342109f28394f4 src/java/src/org/apache/mesos/SchedulerDriver.java ee5a9e24956299d84ff03a0fc5a22e641470a03f src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da Diff: https://reviews.apache.org/r/70942/diff/1/ Testing --- Thanks, Andrei

Review Request 70946: WIP: Added reviveOffers() and the new constructor to Java TestFramework.

Diff: https://reviews.apache.org/r/70946/diff/1/ Testing --- `./bin/mesos-tests.sh --gtest_filter="ExamplesTest.JavaFramework" --gtest_break_on_failure --gtest_repeat=10` Thanks, Andrei Sekretenko

Re: Review Request 70894: Provided ability to change suppressed roles via V0 updateFramework().

> // (but it sends ["role1", "role2"] in this patch) > > ``` > > > > Similarly for suppressOffers() where all of the roles become suppressed. > > > > If we add role(s) arguments to reviveOffers() / suppressOffers() then they > > would be remov

Re: Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces.

78304c211c5eb9f50ea629121a6dddfe47942e9f Diff: https://reviews.apache.org/r/70754/diff/2/ Changes: https://reviews.apache.org/r/70754/diff/1-2/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

Diff: https://reviews.apache.org/r/70755/diff/4/ Changes: https://reviews.apache.org/r/70755/diff/3-4/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70753: Templatized UPDATE_FRAMEWORK test helpers over type of FrameworkInfo.

by templatizing them over type of FrameworkInfo. Diffs (updated) - src/tests/master/update_framework_tests.cpp 78304c211c5eb9f50ea629121a6dddfe47942e9f Diff: https://reviews.apache.org/r/70753/diff/2/ Changes: https://reviews.apache.org/r/70753/diff/1-2/ Testing --- Thanks, Andrei

Re: Review Request 70814: Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY.

://reviews.apache.org/r/70814/diff/2/ Changes: https://reviews.apache.org/r/70814/diff/1-2/ Testing --- make check NOTE: without this change it is not possible to subscribe the java example framework with a role/roles other than `*` Thanks, Andrei Sekretenko

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

78304c211c5eb9f50ea629121a6dddfe47942e9f Diff: https://reviews.apache.org/r/70755/diff/3/ Changes: https://reviews.apache.org/r/70755/diff/2-3/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

78304c211c5eb9f50ea629121a6dddfe47942e9f Diff: https://reviews.apache.org/r/70755/diff/5/ Changes: https://reviews.apache.org/r/70755/diff/4-5/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70755/#review215810 --- On June 12, 2019, 4:25 p.m., Andrei Sekretenko wrote: > >

Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.

enerated e-mail. To reply, visit: https://reviews.apache.org/r/70755/#review215810 --- On June 12, 2019, 4:44 p.m., Andrei Sekretenko wrote: > > --- > This is an automati

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

ahler wrote: > > src/tests/master/mock_master_api_subscriber.cpp > > Lines 171-172 (patched) > > <https://reviews.apache.org/r/70671/diff/6/?file=2148193#file2148193line171> > > > > Why do we need the pointer? We can use a PID? > > &g

Review Request 70843: Replaced a pointer to managed MockMasterAPISubscriberProcess with a pid.

://reviews.apache.org/r/70843/diff/1/ Testing --- `./bin/mesos-tests.sh --gtest_filter="UpdateFramework*" --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Sekretenko

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

07bdd4b273137bad11742e9024947c7f1ad905e4 src/java/src/org/apache/mesos/SchedulerDriver.java 85faa8e6f8b3420ce140eff7ac860a5f3d417928 Diff: https://reviews.apache.org/r/70813/diff/2/ Changes: https://reviews.apache.org/r/70813/diff/1-2/ Testing --- Thanks, Andrei Sekretenko

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

ps://reviews.apache.org/r/70813/#review215882 ------- On June 13, 2019, 7:24 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail.

Review Request 70855: Added tests for handling of FrameworkID by V0 framework updates.

--- Thanks, Andrei Sekretenko

Review Request 70854: Made scheduler driver's updateFramework() accept FrameworkInfo with ID.

c5e61d4fd7aae5067d8c7d8dec878dc82c86e4ec src/sched/sched.cpp 281236bb53e1c6ed77b69bf954e27705595ffb2a Diff: https://reviews.apache.org/r/70854/diff/1/ Testing --- Thanks, Andrei Sekretenko

  1   2   3   4   5   6   7   8   >