Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

fee46bafc88f8cdade868aab8c0fee79b8d2fb6d Diff: https://reviews.apache.org/r/47892/diff/ Testing --- make check sudo ./build/bin/mesos-tests.sh Thanks, Avinash sridharan

Re: Review Request 48893: Added documentation about Mesos metadata for CNI plugins.

ion to enforce domain specific policies while attaching containers to a CNI network. - Avinash sridharan On June 18, 2016, 12:52 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 48893: Added documentation about Mesos metadata for CNI plugins.

893/#comment203545> s/e.g., ADD,/e.g., with command ADD/ docs/cni.md (line 140) <https://reviews.apache.org/r/48893/#comment203546> s/It is/ This is simply/ - Avinash sridharan On June 18, 2016, 12:52 a.m., Jie Yu wrote: > >

Re: Review Request 48893: Added documentation about Mesos metadata for CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48893/#review138366 --- Ship it! Ship It! - Avinash sridharan On June 18, 2016, 12

Re: Review Request 48893: Added documentation about Mesos metadata for CNI plugins.

893/#comment203548> A minor edit to the suggested paragraph: s/ As per the spec, the CNI plugins can use/As per the spec, it is the prerogative of the CNI plugins to use/ - Avinash sridharan On June 18, 2016, 12:52 a.m., Jie Yu

Re: Review Request 48921: Added a check of namespaces in Posix launcher.

tps://reviews.apache.org/r/48921/#comment203648> Is there a valid case where we would be calling `fork` with `namespaces = ` ? If not isn't checking namespaces.isSome() enough? - Avinash sridharan On June 19, 2016, 5:10 a.m., J

Re: Review Request 48921: Added a check of namespaces in Posix launcher.

tps://reviews.apache.org/r/48921/#comment203649> Typo: Meant to ask "Is there a valid case where we would be calling `fork` with `namespaces = 0` ? - Avinash sridharan On June 19, 2016, 5:10 a.m., Jie Yu wrote: > > ---

Re: Review Request 48980: Removed the deprecated fields in NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138768 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 4

Re: Review Request 49004: Copied network info if specified in Docker executor.

che.org/r/49004/#comment203966> s/NetworkInfo/`NetworkInfo` s/in containerizer/ in the `DockerContainerizer` - Avinash sridharan On June 21, 2016, 4:52 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

with a (WARNING) tag? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1495) <https://reviews.apache.org/r/48991/#comment203967> You don't need `endl` for LOG - Avinash sridharan On June 21, 2016, 2:46 a.m., G

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review138772 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 2

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

> On June 21, 2016, 5:21 a.m., Avinash sridharan wrote: > > Ship It! Sorry, meant Fix it then Ship it !! The events got serialized instead !! - Avinash --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

(line 976) <https://reviews.apache.org/r/49008/#comment203973> Should we say: "Failed to create the temp file for CNI JSON config" ? Since there is no name for the temp file here, the error will become cryptic. - Avinash sridharan On June 21, 2016, 6:13 a.

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/#review138786 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 6

Re: Review Request 47999: Added calico information for CNI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47999/#review139083 --- Ship it! Ship It! - Avinash sridharan On June 22, 2016, 4

Re: Review Request 49122: Added a MAC parse function to stout.

/mac.hpp (line 85) <https://reviews.apache.org/r/49122/#comment204342> s/digits/digit - Avinash sridharan On June 22, 2016, 11:56 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49122: Added a MAC parse function to stout.

-- > > (Updated June 22, 2016, 11:56 p.m.) > > > Review request for mesos, Avinash sridharan and Gilbert Song. > > > Repository: mesos > > > Description > --- > > Added a MAC parse function to stout. > > >

Review Request 49171: Added a `Networking` section.

PRE-CREATION Diff: https://reviews.apache.org/r/49171/diff/ Testing --- https://github.com/asridharan/mesos/blob/docs/docs/networking.md Thanks, Avinash sridharan

Re: Review Request 49171: Added a `Networking` section.

attach Mesos and Docker containers to IP Networks. Diffs (updated) - docs/networking.md PRE-CREATION Diff: https://reviews.apache.org/r/49171/diff/ Testing --- https://github.com/asridharan/mesos/blob/docs/docs/networking.md Thanks, Avinash sridharan

Re: Review Request 49171: Added a `Networking` section.

ed e-mail. To reply, visit: https://reviews.apache.org/r/49171/#review139326 --- On June 24, 2016, 3:27 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 49773: Moved veth related functions to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49773/#review141228 --- Ship it! Ship It! - Avinash sridharan On July 7, 2016, 10

<    5   6   7   8   9   10