Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review120003 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 2:24 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43691/ > --- > > (Updated Feb. 18, 2016, 2:24 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake:[2/2] Fixed http-parser library directory for Windows builds. > > > Diffs > - > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > > Diff: https://reviews.apache.org/r/43691/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review120004 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 12:59 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43417/ > --- > > (Updated Feb. 18, 2016, 12:59 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Marked functions in headers `inline` to avoid linker errors. > > > Diffs > - > > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp > 046388189823c0c41ce6cc135d5d3838e9131087 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp > 9a592c4ec9f45fdd8ae8c724c3cab67876de72f5 > > Diff: https://reviews.apache.org/r/43417/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43906: CMake: Added files to be built as part of libmesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121098 --- src/CMakeLists.txt (line 376) <https://reviews.apache.org/r/43906/#comment182693> Please lift the values used by the build.cpp and passed as BUILD* defines into their ows CMAKE macros to get dynamic values into a subsequential commit. - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43906/ > --- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake: Added files to be built as part of libmesos. > > > Diffs > - > > src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a > > Diff: https://reviews.apache.org/r/43906/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43906: CMake: Added files to be built as part of libmesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121099 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43906/ > --- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > CMake: Added files to be built as part of libmesos. > > > Diffs > - > > src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a > > Diff: https://reviews.apache.org/r/43906/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121100 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:41 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43907/ > --- > > (Updated Feb. 25, 2016, 7:41 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout:[1/2] Fix error reporting bug in `os::rmdir`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > bc420c9c10d93ddd619a9eb2c5f4db67f31d722f > > Diff: https://reviews.apache.org/r/43907/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review121101 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44078/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows: Added Socket compatibility `#define`s to windows.hpp. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 > > Diff: https://reviews.apache.org/r/44078/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review121103 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43904/ > --- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4780 > https://issues.apache.org/jira/browse/MESOS-4780 > > > Repository: mesos > > > Description > --- > > `chroot` is does not exist on Windows. Unfortunately, the launcher also > depends on it. In this commit, we remove Windows support for the > launcher flag `rootfs`, which controls whether we use `chroot` in the > launcher. This allows us to divest ourselves of `chroot` altogether on > Windows. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > 129406abdff715e321f683911e404c46676b6daf > src/slave/containerizer/mesos/launch.hpp > 7e29ca2b8bec1c20aef122472cff60f6003603ad > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/43904/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121104 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43905/ > --- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > `su` does not exist on Windows. Unfortunately, the launcher also depends > on it. In this commit, we remove Windows support for the launcher flag > `user`, which controls whether we use `su` in the launcher. This > allows us to divest ourselves of `su` altogether on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > d917a99a46841156dc1e359c44010938cc45e943 > src/slave/containerizer/mesos/containerizer.cpp > 129406abdff715e321f683911e404c46676b6daf > src/slave/containerizer/mesos/launch.hpp > 7e29ca2b8bec1c20aef122472cff60f6003603ad > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/43905/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review121105 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:13 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43903/ > --- > > (Updated Feb. 25, 2016, 7:13 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout: Add `WindowsError` constructor to `Result`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp > 577c8e459f505b7b9021153d5e42e9d5a892ec33 > > Diff: https://reviews.apache.org/r/43903/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review121106 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43709/ > --- > > (Updated Feb. 18, 2016, 5:25 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4704 > https://issues.apache.org/jira/browse/MESOS-4704 > > > Repository: mesos > > > Description > --- > > This review was originally at #40582, put up by Dario Bazan. Dario went > on paternity leave, so I've dusted it off, rebased it against the state > of the art, and gotten it ready for submission. It remains mostly > unchanged, with only minor alterations from the original. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp > 3d074a5296b4435b29792201cb9a1b021673fd97 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp > eb52beb2bcdfbdb71e1456f3286e087e7bbf524e > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp > 8698e997965add14e0a8a268b0ebcf1a5ab4d49d > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 3c65d0422dc6e198180d53d1c9e6cb2839137434 > > Diff: https://reviews.apache.org/r/43709/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review121117 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44077/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows:[3/3] Transitioned Windows `system` to use `os::execlp`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp > 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b > > Diff: https://reviews.apache.org/r/44077/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review121118 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44076/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Windows: [2/3] Used `os::execlp` in launch.cpp. > > > Diffs > - > > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/44076/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review121120 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:09 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44046/ > --- > > (Updated Feb. 26, 2016, 4:09 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Used `evutil_socket_t` typedef for sockets. > > > Diffs > - > > 3rdparty/libprocess/src/libevent.cpp > c787fa9622a22894535ebe64327dd33cfaf1fcd7 > > Diff: https://reviews.apache.org/r/44046/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review121119 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44075/ > --- > > (Updated Feb. 26, 2016, 4:11 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3632 > https://issues.apache.org/jira/browse/MESOS-3632 > > > Repository: mesos > > > Description > --- > > Isolated shell argouments in a namespace. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp > e0039fdab20ba547dc2bb78c544549c30c535294 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp > 42e2ee1d5cc3bfe4a8fe121d591ad04213a6730b > > Diff: https://reviews.apache.org/r/44075/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review121121 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 10:28 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44045/ > --- > > (Updated Feb. 25, 2016, 10:28 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Style fixes to `stout/include/Makefile.am`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 03eff5a831283f6d298e9a1feecfdc7369cacfe7 > > Diff: https://reviews.apache.org/r/44045/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review121122 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 9:16 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44042/ > --- > > (Updated Feb. 25, 2016, 9:16 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > f1d38029eef7e89dfdb8915158fba17865e6855b > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 84a2a021859d4e5c8547ad2a509eebda428a8255 > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp > 625636525ee0fb35214cc3df3a304c40c9a0b0a6 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > d3ba0b4ff5d2d125252389a0f8f618c78aa6d948 > > Diff: https://reviews.apache.org/r/44042/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44141/ --- (Updated March 1, 2016, 8:58 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Forked subprocess.cpp, added `Windows` implementation. Repository: mesos Description (updated) --- Windows: Forked subprocess.cpp, added `Windows` implementation. Diffs (updated) - 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 3rdparty/libprocess/include/process/subprocess.hpp e0c306aa5cf5f393abb73768bbd287c45730f076 3rdparty/libprocess/src/CMakeLists.txt 12dfaf61b801372b6ec70c535080fde350866fb8 3rdparty/libprocess/src/subprocess.cpp 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44141/diff/ Testing (updated) --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated March 1, 2016, 9:42 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi. Bugs: MESOS-4780 https://issues.apache.org/jira/browse/MESOS-4780 Repository: mesos Description --- Windows: Unified POSIX and Windows implementation of `su` Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am a25e2c1e5584e744c666bbc654eafbfc5f7b10e6 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 581ec5baac05bd8b702bfe000893e67fb04bde3b 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 42733d429814bf0512540188264830aeaabcabbe Diff: https://reviews.apache.org/r/40939/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat
Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/ --- (Updated March 1, 2016, 10:07 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi. Summary (updated) - Stout: Mark `os::chroot` as deleted on Windows. Bugs: MESOS-4780 https://issues.apache.org/jira/browse/MESOS-4780 Repository: mesos Description (updated) --- Stout: Mark `os::chroot` as deleted on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp f1d38029eef7e89dfdb8915158fba17865e6855b 3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 84a2a021859d4e5c8547ad2a509eebda428a8255 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp d917a99a46841156dc1e359c44010938cc45e943 Diff: https://reviews.apache.org/r/40938/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat
Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40939/ --- (Updated March 1, 2016, 10:08 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi. Summary (updated) - Stout: Marked `os::su` as deleted on Windows. Bugs: MESOS-4780 https://issues.apache.org/jira/browse/MESOS-4780 Repository: mesos Description (updated) --- Stout: Marked `os::su` as deleted on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp f1d38029eef7e89dfdb8915158fba17865e6855b 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 84a2a021859d4e5c8547ad2a509eebda428a8255 Diff: https://reviews.apache.org/r/40939/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat
Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.
> On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, > > line 30 > > <https://reviews.apache.org/r/40938/diff/3/?file=1175257#file1175257line30> > > > > remove newline I don't see it. Maybe in the old version of os.hpp > On March 1, 2016, 9:54 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp, > > line 23 > > <https://reviews.apache.org/r/40938/diff/3/?file=1175257#file1175257line23> > > > > remove new line I don't see it. Maybe in the old version of os.hpp - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40938/#review121509 ------- On March 1, 2016, 10:07 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40938/ > --- > > (Updated March 1, 2016, 10:07 p.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, and M Lawindi. > > > Bugs: MESOS-4780 > https://issues.apache.org/jira/browse/MESOS-4780 > > > Repository: mesos > > > Description > --- > > Stout: Mark `os::chroot` as deleted on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 03eff5a831283f6d298e9a1feecfdc7369cacfe7 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > f1d38029eef7e89dfdb8915158fba17865e6855b > 3rdparty/libprocess/3rdparty/stout/include/stout/os/chroot.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chroot.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chroot.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 84a2a021859d4e5c8547ad2a509eebda428a8255 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > d917a99a46841156dc1e359c44010938cc45e943 > > Diff: https://reviews.apache.org/r/40938/diff/ > > > Testing > --- > > OSX: make check > Windows: make.bat > > > Thanks, > > Daniel Pravat > >
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated March 1, 2016, 11:54 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun. Repository: mesos Description (updated) --- Windows: Added support for `slave/gc.cpp`. Diffs (updated) - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 1, 2016, 11:56 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40620/ --- (Updated March 1, 2016, 11:58 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Added suppport for `slave/monitor.cpp`. Diffs (updated) - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a Diff: https://reviews.apache.org/r/40620/diff/ Testing --- OSX: make Windows: make Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 2, 2016, 12:41 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 2, 2016, 7:26 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 44140: Windows: libprocess:process.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44140/ --- (Updated March 3, 2016, 12:27 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: libprocess:process.cpp. Diffs (updated) - 3rdparty/libprocess/src/process.cpp 4a5302085917db14654a2f942d85261b934473f7 Diff: https://reviews.apache.org/r/44140/diff/ Testing (updated) --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 3, 2016, 3 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 03eff5a831283f6d298e9a1feecfdc7369cacfe7 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:10 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Added Console Ctrl handling in `slave.cpp`. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description (updated) --- Windows: Added Console Ctrl handling in `slave.cpp`. Diffs (updated) - src/slave/posix_signalhandler.hpp PRE-CREATION src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 src/slave/windows_ctrlhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:15 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description --- Windows: Added Console Ctrl handling in `slave.cpp`. Diffs (updated) - src/slave/posix_signalhandler.hpp PRE-CREATION src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 src/slave/windows_ctrlhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41632/diff/ Testing --- OSX: make check Windows: make Thanks, Daniel Pravat
Re: Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43707/#review122993 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43707/ > --- > > (Updated Feb. 18, 2016, 5:25 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4704 > https://issues.apache.org/jira/browse/MESOS-4704 > > > Repository: mesos > > > Description > --- > > This review was originally at #40567, put up by Dario Bazan. Dario went > on paternity leave, so I've dusted it off, rebased it against the state > of the art, and gotten it ready for submission. It remains mostly > unchanged, with only minor alterations from the original. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 > cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b > > Diff: https://reviews.apache.org/r/43707/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43708: Windows:[2/3] Added zlib compilation steps for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43708/#review122994 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line 111) <https://reviews.apache.org/r/43708/#comment185107> The comment can be more explicit. We use static zlib for Windows build. - Daniel Pravat On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43708/ > --- > > (Updated Feb. 18, 2016, 5:25 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4704 > https://issues.apache.org/jira/browse/MESOS-4704 > > > Repository: mesos > > > Description > --- > > This review was originally at #40568, put up by Dario Bazan. Dario went > on paternity leave, so I've dusted it off, rebased it against the state > of the art, and gotten it ready for submission. It remains mostly > unchanged, with only minor alterations from the original. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 9b61376ea6aad304607c20c9823d9ef19013eca0 > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 2a37fdb6501aaf7baac2ada0a714bbe67e7c5aca > > Diff: https://reviews.apache.org/r/43708/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review122998 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43709/ > --- > > (Updated Feb. 18, 2016, 5:25 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4704 > https://issues.apache.org/jira/browse/MESOS-4704 > > > Repository: mesos > > > Description > --- > > This review was originally at #40582, put up by Dario Bazan. Dario went > on paternity leave, so I've dusted it off, rebased it against the state > of the art, and gotten it ready for submission. It remains mostly > unchanged, with only minor alterations from the original. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp > 3d074a5296b4435b29792201cb9a1b021673fd97 > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/gzip.hpp > eb52beb2bcdfbdb71e1456f3286e087e7bbf524e > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/gzip.hpp > 8698e997965add14e0a8a268b0ebcf1a5ab4d49d > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 3c65d0422dc6e198180d53d1c9e6cb2839137434 > > Diff: https://reviews.apache.org/r/43709/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 12, 2016, 2:02 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 44090: Windows: Added a cast for `get/setsockopt` parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 12, 2016, 2:54 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Added a cast for `get/setsockopt` parameters. Repository: mesos Description (updated) --- Windows: Added a cast for `get/setsockopt` parameters. Diffs (updated) - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44090/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123268 --- Ship it! Ship It! - Daniel Pravat On March 12, 2016, 1:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 12, 2016, 1:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 13, 2016, 7:27 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Changed the calling parameters for Windows API. Repository: mesos Description (updated) --- Windows: Changed the calling parameters for Windows API. Diffs (updated) - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44090/diff/ Testing (updated) --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 13, 2016, 7:28 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs (updated) - 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 Diff: https://reviews.apache.org/r/44089/diff/ Testing (updated) --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Review Request 44760: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44760/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 14, 2016, 3:45 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 14, 2016, 3:46 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 Diff: https://reviews.apache.org/r/44139/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 17, 2016, 6:52 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 Diff: https://reviews.apache.org/r/44139/diff/ Testing (updated) --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/ --- (Updated March 18, 2016, 6:48 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Libprocess: Use Windows-compatible memory fence in logging. Repository: mesos Description (updated) --- Libprocess: Use Windows-compatible memory fence in logging. Diffs (updated) - 3rdparty/libprocess/include/process/logging.hpp ee680ae8ecd837f24ec7731d55680ad8440808db Diff: https://reviews.apache.org/r/44135/diff/ Testing --- OSX: make Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44760: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 18, 2016, 6:49 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44760/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs - 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 Diff: https://reviews.apache.org/r/44089/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44760: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 17, 2016, 6:54 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44760/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 17, 2016, 6:53 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Changed the calling parameters for Windows API. Diffs - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44090/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 17, 2016, 6:48 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing (updated) --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 21, 2016, 10:53 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 Diff: https://reviews.apache.org/r/44139/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44760: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44760/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs (updated) - 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 Diff: https://reviews.apache.org/r/44089/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Changed the calling parameters for Windows API. Diffs (updated) - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44090/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.
> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 49 > > <https://reviews.apache.org/r/44139/diff/3/?file=1302888#file1302888line49> > > > > does this still work considering your refactoring of the parent patches? The function is added into `network` namespace as before - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/#review124513 --- On March 21, 2016, 10:54 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44139/ > --- > > (Updated March 21, 2016, 10:54 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[2/2] Lifted socket API into Stout. > > > Diffs > - > > 3rdparty/libprocess/include/process/network.hpp > 7d203f0ff1cdb3145bc2b914f8bd606203878f09 > > Diff: https://reviews.apache.org/r/44139/diff/ > > > Testing > --- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.
> On March 22, 2016, 9:52 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/logging.hpp, line 57 > > <https://reviews.apache.org/r/44135/diff/2/?file=1306311#file1306311line57> > > > > I wonder whether we can use something from C++11 to avoid the need for > > non-portable code here. From a quick skim of the reference page, > > `std::atomic_thread_fence(std::memory_order_seq_cst)` _might_ work, but I > > haven't dug in enough to say for sure. It may be posible, in fact std::atomic_thread_fence uses MemoryBarrier on x64. However this requires glog patching. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/#review124898 ------- On March 18, 2016, 6:49 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44135/ > --- > > (Updated March 18, 2016, 6:49 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Libprocess: Use Windows-compatible memory fence in logging. > > > Diffs > - > > 3rdparty/libprocess/include/process/logging.hpp > ee680ae8ecd837f24ec7731d55680ad8440808db > > Diff: https://reviews.apache.org/r/44135/diff/ > > > Testing > --- > > OSX: make > Windows: build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.
> On March 22, 2016, 9:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > <https://reviews.apache.org/r/44136/diff/1/?file=1272977#file1272977line13> > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include > > #include > > #endif // __WINDOWS__ > > > > #include > > #include > > #include > > #include > > ``` Thanks! I splited the change in two commits: https://reviews.apache.org/r/44136/ https://reviews.apache.org/r/45194/ - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44136/#review124888 --- On March 23, 2016, 2:46 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44136/ > ------- > > (Updated March 23, 2016, 2:46 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Libprocess: [1/2] Conditioned out Windows-incompatible includes. > > > Diffs > - > > 3rdparty/libprocess/src/http.cpp 3ca0cfd37ac58f6d2bf5341dc88e8abed05fe994 > 3rdparty/libprocess/src/pid.cpp 9387f59a3834af368bf37f8cc2e85102f0bb34f6 > > Diff: https://reviews.apache.org/r/44136/diff/ > > > Testing > --- > > OSX: make > Windows: build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44136/ --- (Updated March 23, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Libprocess: [1/2] Conditioned out Windows-incompatible includes. Repository: mesos Description (updated) --- Libprocess: [1/2] Conditioned out Windows-incompatible includes. Diffs (updated) - 3rdparty/libprocess/src/http.cpp 3ca0cfd37ac58f6d2bf5341dc88e8abed05fe994 3rdparty/libprocess/src/pid.cpp 9387f59a3834af368bf37f8cc2e85102f0bb34f6 Diff: https://reviews.apache.org/r/44136/diff/ Testing --- OSX: make Windows: build/run Thanks, Daniel Pravat
Review Request 45194: STOUT: [2/2] Conditioned out Windows-incompatible includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45194/ --- Review request for mesos. Repository: mesos Description --- STOUT: [2/2] Conditioned out Windows-incompatible includes. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/stopwatch.hpp 00ffe6f41dcd3f6450ce9e21311c088c0ea6ad85 Diff: https://reviews.apache.org/r/45194/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, lines > > 28-36 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302884#file1302884line28> > > > > Let's namespace these with `socket` since both functions currently > > start with `socket`. > > > > How about `is_restartable_error(int error)` and `is_retryable_error`? We cannot redefine `socket` as a namespace. However the new error code is descriptive enough to drop the socket `prefix`. > On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 26 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302884#file1302884line26> > > > > why are these in `internal`? Moved those functions to `net` namespace. > On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp, > > lines 16-17 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302886#file1302886line16> > > > > Where are these used? I moved them in the common header. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124122 --- On March 21, 2016, 10:53 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > --- > > (Updated March 21, 2016, 10:53 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > --- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > <https://reviews.apache.org/r/44138/diff/4-5/?file=1302884#file1302884line35> > > > > Should `EINPROGRESS` be in here? > > would a retry not cause an `EALREADY`? The error from the socket operations is dependent on the operation and the environement conditions. ::connect will initialy return EINPROGRESS and the subseqential call to connect will return EALREADY. Since the original code was not handling EALREADY we may assume the connect is happening before the second call (or we don't connect if takes too much time). - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 ----------- On March 21, 2016, 10:53 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > --- > > (Updated March 21, 2016, 10:53 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > --- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 3:59 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 23, 2016, 4:01 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs (updated) - 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 Diff: https://reviews.apache.org/r/44089/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.
> On March 23, 2016, 12:42 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/io.cpp, lines 86-87 > > <https://reviews.apache.org/r/44089/diff/3/?file=1309573#file1309573line86> > > > > This behavior is not quite consistent: > > see my comment in https://reviews.apache.org/r/44138/ See the comment from https://reviews.apache.org/r/44138/. I tried to keep the behaviour in the reworked code consistent with the existent code. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/#review125012 --- On March 21, 2016, 10:54 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44089/ > --- > > (Updated March 21, 2016, 10:54 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Used os::read/write from Stout for proper OS isolation. > > > Diffs > - > > 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95 > > Diff: https://reviews.apache.org/r/44089/diff/ > > > Testing > --- > > OSX: make check > Windows: build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 4:09 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44091: Windows:[1/3] Implemented `os::pagesize`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44091/ --- (Updated March 23, 2016, 5:39 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/3] Implemented `os::pagesize`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/44091/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44091: Windows:[1/3] Implemented `os::pagesize`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44091/ --- (Updated March 23, 2016, 5:42 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/3] Implemented `os::pagesize`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 9ee233b988c08d953e70345c55bcdd5c2f7c101b 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 6a391ff198ab724f689bcef79d4e2e05a786cbc2 Diff: https://reviews.apache.org/r/44091/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44092: Windows:[2/3] Transitioned `os::recv` to use `os::pagesize`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44092/ --- (Updated March 23, 2016, 6:23 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/3] Transitioned `os::recv` to use `os::pagesize`. Diffs (updated) - 3rdparty/libprocess/src/socket.cpp ab73814c60d58253a60562ef22c814ae9cb69c8a Diff: https://reviews.apache.org/r/44092/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 8:47 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44760: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 23, 2016, 8:49 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Changes --- Extracting EINPROGRESS test in OS dependent function Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09 3rdparty/libprocess/src/poll_socket.cpp 6e6634b4b352e3723096521843546cf56ec6dd8b Diff: https://reviews.apache.org/r/44760/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 24, 2016, 3:17 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44138/diff/ Testing --- OSX: make check Windows: build/execute Thanks, Daniel Pravat
Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.
> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > <https://reviews.apache.org/r/44138/diff/4-5/?file=1302884#file1302884line35> > > > > Should `EINPROGRESS` be in here? > > would a retry not cause an `EALREADY`? > > Daniel Pravat wrote: > The error from the socket operations is dependent on the operation and > the environement conditions. ::connect will initialy return EINPROGRESS and > the subseqential call to connect will return EALREADY. Since the original > code was not handling EALREADY we may assume the connect is happening before > the second call (or we don't connect if takes too much time). Based on offline discussion the test for EINPROGRESS after `::connect` has been extracted in its own method. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 ------- On March 24, 2016, 3:17 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > --- > > (Updated March 24, 2016, 3:17 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > --- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.
> On March 25, 2016, 6:48 p.m., Yi Sun wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 87 > > <https://reviews.apache.org/r/45299/diff/1/?file=1314070#file1314070line87> > > > > nit: getpagesize() is irrelevant now. Alex is working on replacing getpagesize() calls. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45299/#review125452 --- On March 25, 2016, 6:12 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45299/ > --- > > (Updated March 25, 2016, 6:12 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Stout:[1/2] transitioned codebase to use `os::pagesize`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > 6b81bf1ea3d571e8f5fb170076b85223b02efe2c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > 182ac9cfbacd4535fb355aac6ec38559d786e63a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/45299/diff/ > > > Testing > --- > > make check > > > Thanks, > > Alex Clemmer > >
Re: Review Request 45313: Introduced `WindowsSocketError` and factored out `WindowsErrorBase`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/#review125538 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 30) <https://reviews.apache.org/r/45313/#comment188385> The constructor should be WindowsErrorBase 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 33) <https://reviews.apache.org/r/45313/#comment188386> Constructor name == WindowsErrorBase 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 105) <https://reviews.apache.org/r/45313/#comment188388> Make the constructor public 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 113) <https://reviews.apache.org/r/45313/#comment188389> Make the constructor public 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 115) <https://reviews.apache.org/r/45313/#comment188391> This shoulf be WindowsSocketError - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45313/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > 64102e1f31437d4271a1126e339fb2f33f0181b8 > > Diff: https://reviews.apache.org/r/45313/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45313: Introduced `WindowsSocketError` and factored out `WindowsErrorBase`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/#review125544 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 34) <https://reviews.apache.org/r/45313/#comment188400> Same name for member variable and input parameter. I think is confusing. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45313/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > 64102e1f31437d4271a1126e339fb2f33f0181b8 > > Diff: https://reviews.apache.org/r/45313/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45310: Removed unnecessary constructors in `Try`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/#review125546 --- 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp (line 56) <https://reviews.apache.org/r/45310/#comment188402> Without additional context the reviewer may think that this change will break the build. Maybe you can change the order between this review and the next or eliminate the constructors in the next commit. - Daniel Pravat On March 24, 2016, 8:22 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45310/ > --- > > (Updated March 24, 2016, 8:22 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Correctly constrained the templated constructor. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45310/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 --- 3rdparty/libprocess/include/process/network.hpp (line 75) <https://reviews.apache.org/r/45314/#comment188404> We tried to avoid axecuting too much code between ::connect WSAGetLastError() calls. Constructing the parameter for WindowsSocketError may overwrite the last error. It should be better to pass in the return from WSAGetLastError() as a parameter to the constructor, that is evaluate before the std::string parameter. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/include/process/network.hpp > 9976257d2d13316062bc95a22ab564ca0df165e5 > 3rdparty/libprocess/src/poll_socket.cpp > 6e6634b4b352e3723096521843546cf56ec6dd8b > > Diff: https://reviews.apache.org/r/45314/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45312: Captured the error code in `ErrnoError` and `WindowsError`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45312/#review125550 --- Ship it! Ship It! - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45312/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp > 1e9db7e1cd2f411efb94893ba2c29bd0694e4ddc > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > 64102e1f31437d4271a1126e339fb2f33f0181b8 > > Diff: https://reviews.apache.org/r/45312/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45311: Added an additional template parameter to 'Try' for typeful error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/#review125548 --- 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp (line 33) <https://reviews.apache.org/r/45311/#comment188403> With this default parameter the code has to be changed on every place where we return or handle a WindowsError object. One sugestion is to use different defaults on Windows and Posix and handle the conversion from ErrnoError/Error to WindowsError inside WindowsError class. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45311/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45311/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review125923 --- Ship it! Ship It! - Daniel Pravat On March 14, 2016, 9:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44808/ > --- > > (Updated March 14, 2016, 9:06 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Fixup POSIX build by removing headers from load.*. > > > Diffs > - > > src/slave/qos_controllers/load.hpp 098a6d0b2dfc54b5b95a261a780eea70a838c12d > src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 > > Diff: https://reviews.apache.org/r/44808/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > <https://reviews.apache.org/r/45314/diff/1/?file=1314163#file1314163line75> > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls. > > Constructing the parameter for WindowsSocketError may overwrite the > > last error. It should be better to pass in the return from > > WSAGetLastError() as a parameter to the constructor, that is evaluate > > before the std::string parameter. > > Michael Park wrote: > Gave this some thought. I'm inclined to keep this as is. > > Even if you're suggesting that we provide `::WSAGetLastError()` on every > callsite like: > > ``` > int result = ::connect(...); > > // BE AWARE! > > // Even ignoring `::WSAGetLastError()` being Windows-specific. > return ConnectError(::WSAGetLastError(), "Failed to connect to " + > stringify(address)); > ``` > > The order of evaluation of the parameters is unspecified. > > Even if it were to be specified (left-to-right), we still need to be > mindful of the code between > `::connect` and `ConnectError`. We would run into the same sequence of > code execution if someone > were to pull out the expression and constructed a variable. > > ``` > int result = ::connect(...); > > // BE AWARE! > > std::string message = "Failed to connect to " + stringify(address); // > BE AWARE! > return ConnectError(::WSAGetLastError(), message); > ``` > > The only way we would completely solve this is if we were to say either: > `::WSAGetLastError()` must be > called immediately after `::connect`, or ensure that nothing between > `::connect` and the call to > `::WSAGetLastError()` can overwrite the error code. The latter is what we > currently do, and I don't think > that reordering just the `::WSAGetLastError` call and the argument to > `ConnectError` is a big win. > > Please share your ideas and solutions! Exposing a constructor taking both the error code and the message should be suficient. The convenience provided by the parameters reordering is not adding a lot of value given the small number of instance where the error code is interpreted. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 --- On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/include/process/network.hpp > 9976257d2d13316062bc95a22ab564ca0df165e5 > 3rdparty/libprocess/src/poll_socket.cpp > 6e6634b4b352e3723096521843546cf56ec6dd8b > > Diff: https://reviews.apache.org/r/45314/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.
> On March 26, 2016, 8:05 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 75 > > <https://reviews.apache.org/r/45314/diff/1/?file=1314163#file1314163line75> > > > > We tried to avoid axecuting too much code between ::connect > > WSAGetLastError() calls. > > Constructing the parameter for WindowsSocketError may overwrite the > > last error. It should be better to pass in the return from > > WSAGetLastError() as a parameter to the constructor, that is evaluate > > before the std::string parameter. > > Michael Park wrote: > Gave this some thought. I'm inclined to keep this as is. > > Even if you're suggesting that we provide `::WSAGetLastError()` on every > callsite like: > > ``` > int result = ::connect(...); > > // BE AWARE! > > // Even ignoring `::WSAGetLastError()` being Windows-specific. > return ConnectError(::WSAGetLastError(), "Failed to connect to " + > stringify(address)); > ``` > > The order of evaluation of the parameters is unspecified. > > Even if it were to be specified (left-to-right), we still need to be > mindful of the code between > `::connect` and `ConnectError`. We would run into the same sequence of > code execution if someone > were to pull out the expression and constructed a variable. > > ``` > int result = ::connect(...); > > // BE AWARE! > > std::string message = "Failed to connect to " + stringify(address); // > BE AWARE! > return ConnectError(::WSAGetLastError(), message); > ``` > > The only way we would completely solve this is if we were to say either: > `::WSAGetLastError()` must be > called immediately after `::connect`, or ensure that nothing between > `::connect` and the call to > `::WSAGetLastError()` can overwrite the error code. The latter is what we > currently do, and I don't think > that reordering just the `::WSAGetLastError` call and the argument to > `ConnectError` is a big win. > > Please share your ideas and solutions! > > Daniel Pravat wrote: > Exposing a constructor taking both the error code and the message should > be suficient. > > The convenience provided by the parameters reordering is not adding a lot > of value given the small number of instance where the error code is > interpreted. > > Michael Park wrote: > I'm not quite following. From > > Exposing a constructor taking both the error code and the message > should be suficient. > > It seems like you're saying we should introduce a constructor that takes > an error code, something like: > ``` > WindowsSockerError::WindowsSocketError(int code, const std::string& > message); > ``` > But as I mentioned, even if we do that, the order of evaluation of the > arguments is unspecified. > and even if we were to say, well it's "implementation-defined", we still > have to be mindful > of the code between `::connect` and `WindowsSocketError`. You seem to be > supporting this argument > with the second quote: > > The convenience provided by the parameters reordering is not adding a > lot of value given the small number of instance where the error code is > interpreted. > > so I'm a bit confused. Could you be a little more specific/concrete? I was agreeing with you. We can both agree that we need both parameters to the constructor (the error message for logging and the error code for the execution flow). Your example from the first comment seems to imply you agree with a constructor with two parameters. You also made a reference to the parameter reorder that may allow one line return `return ConnectError(message, ::WSAGetLastError());`. However given this error is returned/used only in a few places at this time, the parameters can be in any order. The user (returning `WindowsError`) has to be aware that last error may be overwritten, has to capture it ASAP and later used it to construct `WindowsError`. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review125549 --- On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > --- > > (U
Review Request 45614: Windows: Implemented os::close for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Windows: Implemented os::close for Windows. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 Diff: https://reviews.apache.org/r/45614/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44095: Windows: [2/2] Transitioned sources to use `os::gmtime_r`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44095/ --- (Updated April 2, 2016, 6:42 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: [2/2] Transitioned sources to use `os::gmtime_r`. Diffs (updated) - 3rdparty/libprocess/src/encoder.hpp 57e28052aa082cd15ea5d6c1bb190ebc9387c1c9 3rdparty/libprocess/src/time.cpp a40fb4063c9e7c5c421b0870bea26557d2ebc4a0 Diff: https://reviews.apache.org/r/44095/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 45310: Removed unnecessary constructors in `Try`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45310/#review126796 --- Ship it! Ship It! - Daniel Pravat On March 24, 2016, 8:22 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45310/ > --- > > (Updated March 24, 2016, 8:22 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Correctly constrained the templated constructor. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45310/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45311: Added an additional template parameter to 'Try' for typeful error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/#review126797 --- Ship it! Ship It! - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45311/ > --- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45311/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45313: Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/#review126798 --- Ship it! Ship It! - Daniel Pravat On March 28, 2016, 8:57 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45313/ > --- > > (Updated March 28, 2016, 8:57 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Introduced `WindowsSocketError` and refactored out `WindowsErrorBase`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > 64102e1f31437d4271a1126e339fb2f33f0181b8 > > Diff: https://reviews.apache.org/r/45313/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 45314: Updated `network::connect` to use the typeful `Try` error state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45314/#review126799 --- Ship it! Ship It! - Daniel Pravat On April 3, 2016, 9:34 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45314/ > --- > > (Updated April 3, 2016, 9:34 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Updated `network::connect` to use the typeful `Try` error state. > > > Diffs > - > > 3rdparty/libprocess/include/process/network.hpp > 9976257d2d13316062bc95a22ab564ca0df165e5 > 3rdparty/libprocess/src/poll_socket.cpp > 6e6634b4b352e3723096521843546cf56ec6dd8b > > Diff: https://reviews.apache.org/r/45314/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Review Request 45861: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/ --- Review request for mesos, Alex Clemmer and switched to 'mcypark'. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs - 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/45861/diff/ Testing --- OSX: make check -j8 Thanks, Daniel Pravat
Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated April 8, 2016, 9:38 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Changed the calling parameters for Windows API. Diffs (updated) - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/44090/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 44142: Windows:[2/2] Implemented os::close for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44142/ --- (Updated April 8, 2016, 9:40 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows:[2/2] Implemented os::close for Windows. Repository: mesos Description (updated) --- Windows:[2/2] Implemented os::close for Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d Diff: https://reviews.apache.org/r/44142/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 45861: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/ --- (Updated April 8, 2016, 9:47 p.m.) Review request for mesos, Alex Clemmer and switched to 'mcypark'. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/45861/diff/ Testing --- OSX: make check -j8 Thanks, Daniel Pravat
Re: Review Request 44142: Windows: Implemented os::close for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44142/ --- (Updated April 8, 2016, 10:05 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Implemented os::close for Windows. Repository: mesos Description (updated) --- Windows: Implemented os::close for Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp a7f855dc9d0a87fe3b6d1611e7ae22e4d7cd7b6d Diff: https://reviews.apache.org/r/44142/diff/ Testing --- Thanks, Daniel Pravat
Re: Review Request 45861: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/ --- (Updated April 9, 2016, 12:32 a.m.) Review request for mesos, Alex Clemmer and switched to 'mcypark'. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/45861/diff/ Testing --- OSX: make check -j8 Thanks, Daniel Pravat
Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated April 9, 2016, 12:32 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Changed the calling parameters for Windows API. Diffs (updated) - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/44090/diff/ Testing --- OSX: make check Windows: build/run Thanks, Daniel Pravat
Re: Review Request 45861: Windows: Fixed non-blocking connect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45861/ --- (Updated April 9, 2016, 11:51 p.m.) Review request for mesos, Alex Clemmer and switched to 'mcypark'. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs - 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 Diff: https://reviews.apache.org/r/45861/diff/ Testing --- OSX: make check -j8 Thanks, Daniel Pravat
Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/ --- (Updated April 11, 2016, 4:20 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Stout: [1/2] Implemented assorted `os::` functions on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/44123/diff/ Testing (updated) --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 11, 2016, 4:21 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Libprocess: [2/2] Implemented assorted `os::` functions on Windows. Diffs (updated) - 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 Diff: https://reviews.apache.org/r/44131/diff/ Testing (updated) --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 45614: Windows: Implemented os::close for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/ --- (Updated April 13, 2016, 6:21 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Changes --- Removing discarded review from "depends on" field -- @vinodkone Repository: mesos Description --- Windows: Implemented os::close for Windows. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 Diff: https://reviews.apache.org/r/45614/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44123/ --- (Updated April 15, 2016, 12:23 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Stout: [1/2] Implemented assorted `os::` functions on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff Diff: https://reviews.apache.org/r/44123/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/ --- (Updated April 15, 2016, 1:25 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Libprocess: [2/2] Implemented assorted `os::` functions on Windows. Diffs (updated) - 3rdparty/libprocess/src/process.cpp d2c458ed93307f75358bb642aaf2ed8e17b2fe97 Diff: https://reviews.apache.org/r/44131/diff/ Testing --- OSX: make check Thanks, Daniel Pravat
