> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > <https://reviews.apache.org/r/44138/diff/4-5/?file=1302884#file1302884line35> > > > > Should `EINPROGRESS` be in here? > > would a retry not cause an `EALREADY`? > > Daniel Pravat wrote: > The error from the socket operations is dependent on the operation and > the environement conditions. ::connect will initialy return EINPROGRESS and > the subseqential call to connect will return EALREADY. Since the original > code was not handling EALREADY we may assume the connect is happening before > the second call (or we don't connect if takes too much time).
Based on offline discussion the test for EINPROGRESS after `::connect` has been extracted in its own method. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 ----------------------------------------------------------- On March 24, 2016, 3:17 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 3:17 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
