> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, lines > > 28-36 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302884#file1302884line28> > > > > Let's namespace these with `socket` since both functions currently > > start with `socket`. > > > > How about `is_restartable_error(int error)` and `is_retryable_error`?
We cannot redefine `socket` as a namespace. However the new error code is descriptive enough to drop the socket `prefix`. > On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 26 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302884#file1302884line26> > > > > why are these in `internal`? Moved those functions to `net` namespace. > On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp, > > lines 16-17 > > <https://reviews.apache.org/r/44138/diff/4/?file=1302886#file1302886line16> > > > > Where are these used? I moved them in the common header. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124122 ----------------------------------------------------------- On March 21, 2016, 10:53 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44138/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 10:53 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Windows:[1/2] Lifted socket API into Stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/socket.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/socket.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44138/diff/ > > > Testing > ------- > > OSX: make check > Windows: build/execute > > > Thanks, > > Daniel Pravat > >
