Review Request 48599: Fixed continuation logic in docker.cpp.

2016-06-12 Thread Joerg Schad
. Diffs - src/slave/containerizer/docker.cpp 1af5b451922e1eeb0af025f29c53a85ab9deec3b Diff: https://reviews.apache.org/r/48599/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

2016-06-12 Thread Joerg Schad
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/#review137172 --- On June 12, 2016, 3:09 p.m., Joerg Schad wrote: > > --- > This is an

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

2016-06-12 Thread Joerg Schad
. This patch fixes this behavior (it should run on the same process) and avoids potential race conditions. Diffs - src/slave/containerizer/docker.cpp 1af5b451922e1eeb0af025f29c53a85ab9deec3b Diff: https://reviews.apache.org/r/48599/diff/ Testing --- make check Thanks, Joerg

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

2016-06-12 Thread Joerg Schad
> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? > > Greg Mann wrote: > Yes! Thanks for thinking of this, Joerg! > > Joerg Schad wrote: > I will take care of that in another patch. https://reviews.ap

Review Request 48598: Added changes to upgrades.md.

2016-06-12 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

2016-06-10 Thread Joerg Schad
run on the same process). Diffs - src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be Diff: https://reviews.apache.org/r/48566/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

2016-06-10 Thread Joerg Schad
on the same process). Diffs - src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be Diff: https://reviews.apache.org/r/48566/diff/ Testing --- make check Thanks, Joerg Schad

Review Request 48563: Fixed continuation logic in endpoint authorization.

2016-06-10 Thread Joerg Schad
4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 Diff: https://reviews.apache.org/r/48563/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

2016-06-10 Thread Joerg Schad
run on the same process) and avoids potential race conditions if the file logic is handled by different processes. Diffs - src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be Diff: https://reviews.apache.org/r/48566/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

2016-06-10 Thread Joerg Schad
between the master process changing the related data-structures and another process reading them. Diffs (updated) - src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 Diff: https://reviews.apache.org/r/48563/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

2016-06-09 Thread Joerg Schad
g/r/46887/#comment201894> IMO this also needs to be added to the CHANGELOG and upgrades.md. - Joerg Schad On June 1, 2016, 8:05 a.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-25 Thread Joerg Schad
613/#comment199745> move && src/authorizer/local/authorizer.cpp (line 238) <https://reviews.apache.org/r/46613/#comment199747> indentation src/authorizer/local/authorizer.cpp (line 239) <https://reviews.apache.org

Re: Review Request 47068: Added fine-grained filtering master flag.

2016-05-24 Thread Joerg Schad
entire chain. Thanks, Joerg Schad

Re: Review Request 47558: Added Allower interface to authorizer.

2016-05-24 Thread Joerg Schad
/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-24 Thread Joerg Schad
/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

2016-05-24 Thread Joerg Schad
://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-24 Thread Joerg Schad
://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

2016-05-24 Thread Joerg Schad
/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-24 Thread Joerg Schad
/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-24 Thread Joerg Schad
/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

2016-05-25 Thread Joerg Schad
g/r/47704/#comment199770> use std::tie src/master/http.cpp (line 1648) <https://reviews.apache.org/r/47704/#comment199771> move to function - Joerg Schad On May 25, 2016, 4:58 p.m., Joerg

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-25 Thread Joerg Schad
629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-25 Thread Joerg Schad
://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-25 Thread Joerg Schad
/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Review Request 48626: Fixed typo in markdown styleguide.

2016-06-13 Thread Joerg Schad
--- Fixed typo in markdown styleguide. Diffs - docs/markdown-style-guide.md 46024206876354cfb1ed2d053695ffc07996d78f Diff: https://reviews.apache.org/r/48626/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 48598: Added changes to upgraded.md.

2016-06-13 Thread Joerg Schad
) - docs/upgrades.md 3d31d15ea3327d1d0734b0d79be3cc86a66ab1f4 Diff: https://reviews.apache.org/r/48598/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

2016-06-11 Thread Joerg Schad
run on the same process) and avoids potential race conditions if the file logic is handled by different processes. Diffs - src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be Diff: https://reviews.apache.org/r/48566/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

2016-06-11 Thread Joerg Schad
run on the same process). Diffs (updated) - src/files/files.cpp 55c310af149cb03abfa1ffbb6477dc1ac5dc14be Diff: https://reviews.apache.org/r/48566/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

2016-06-11 Thread Joerg Schad
between the master process changing the related data-structures and another process reading them. Diffs (updated) - src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 Diff: https://reviews.apache.org/r/48563/diff/ Testing --- make check Thanks, Joerg Schad

Re: Review Request 48497: Added documentation on starting to use acls.

2016-06-14 Thread Joerg Schad
://reviews.apache.org/r/48497/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Re: Review Request 48495: Added missing 'get_weights' actions to authorization.md.

2016-06-14 Thread Joerg Schad
dcf2160424771c513579063911cc14792f464821 Diff: https://reviews.apache.org/r/48495/diff/ Testing --- viewed via docker website container. Thanks, Joerg Schad

Re: Review Request 48497: Added documentation on starting to use acls.

2016-06-14 Thread Joerg Schad
/r/48497/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

2016-06-14 Thread Joerg Schad
87/#comment202639> Add something along the lines: Be careful when using this together with ACLs and permissive = false. - Joerg Schad On June 14, 2016, 11:46 a.m., Jan Schlicht wrote: > > --- > This is an automatically gen

Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.

2016-06-14 Thread Joerg Schad
> On June 14, 2016, 1:13 p.m., Joerg Schad wrote: > > docs/authorization.md, line 140 > > <https://reviews.apache.org/r/46887/diff/2/?file=1418305#file1418305line140> > > > > Could we > > a) check that the HTTP HELP text is correct for

Re: Review Request 48496: Fixed misleading acls example in authorization.md.

2016-06-14 Thread Joerg Schad
dcf2160424771c513579063911cc14792f464821 Diff: https://reviews.apache.org/r/48496/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Review Request 48733: Updated TODO and comments refering to 0.29.

2016-06-15 Thread Joerg Schad
--- Thanks, Joerg Schad

Re: Review Request 48495: Added missing 'get_weights' actions to authorization.md.

2016-06-15 Thread Joerg Schad
dcf2160424771c513579063911cc14792f464821 Diff: https://reviews.apache.org/r/48495/diff/ Testing --- viewed via docker website container. Thanks, Joerg Schad

Re: Review Request 48496: Fixed misleading acls example in authorization.md.

2016-06-15 Thread Joerg Schad
dcf2160424771c513579063911cc14792f464821 Diff: https://reviews.apache.org/r/48496/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Re: Review Request 48497: Added documentation on starting to use acls.

2016-06-15 Thread Joerg Schad
did that actually :-). - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48497/#review137673 --- On June 15, 2

Re: Review Request 48497: Added documentation on starting to use acls.

2016-06-15 Thread Joerg Schad
://reviews.apache.org/r/48497/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Re: Review Request 48497: Added documentation on starting to use acls.

2016-06-15 Thread Joerg Schad
://reviews.apache.org/r/48497/diff/ Testing --- viewed via website container. Thanks, Joerg Schad

Re: Review Request 48598: Added changes to upgraded.md.

2016-06-13 Thread Joerg Schad
Diff: https://reviews.apache.org/r/48598/diff/ Testing --- Thanks, Joerg Schad

Review Request 48263: Fixed documentation for MESOS-5405.

2016-06-06 Thread Joerg Schad
://reviews.apache.org/r/48263/diff/ Testing --- viewed documentation via gist: https://gist.github.com/joerg84/0971f48b8ae88a335f88c1344d4cf180 Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-28 Thread Joerg Schad
Park. Repository: mesos Description --- Used TaskObjectAllower to filter /tasks endpoint. Diffs (updated) - src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 Diff: https://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

2016-05-30 Thread Joerg Schad
tps://reviews.apache.org/r/48038/#comment200519> Just curious: will we keep this around after the deprecation cycle? - Joerg Schad On May 30, 2016, 1:17 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

2016-05-30 Thread Joerg Schad
/authorizer.proto (line 64) <https://reviews.apache.org/r/48037/#comment200516> Does this empty line still make sense? - Joerg Schad On May 30, 2016, 1:17 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

2016-05-30 Thread Joerg Schad
> On May 30, 2016, 3:28 p.m., Joerg Schad wrote: > > include/mesos/authorizer/authorizer.hpp, line 58 > > <https://reviews.apache.org/r/48037/diff/1/?file=1400966#file1400966line58> > > > > I guess we also need to copy this new field over to the C++ object

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

2016-05-30 Thread Joerg Schad
tps://reviews.apache.org/r/48037/#comment200517> I guess we also need to copy this new field over to the C++ object, or? See `Future authorized(const authorization::Request& request)` - Joerg Schad On May 30, 2016, 1:17 p.m., Michael

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-30 Thread Joerg Schad
/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
) Thanks, Joerg Schad

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

2016-05-30 Thread Joerg Schad
) Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-30 Thread Joerg Schad
: https://reviews.apache.org/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
and Michael Park. Repository: mesos Description --- Used TaskObjectAllower to filter /tasks endpoint. Diffs (updated) - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

2016-05-30 Thread Joerg Schad
. Repository: mesos Description --- Used TaskObjectAllower to filter /state endpoint. Diffs (updated) - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-30 Thread Joerg Schad
, Joerg Schad

Re: Review Request 47558: Added ObjectApprover interface to authorizer.

2016-05-30 Thread Joerg Schad
--- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

2016-05-30 Thread Joerg Schad
/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Review Request 48053: Removed discarded handling from .repair() call.

2016-05-30 Thread Joerg Schad
--- Repair() is only called fir failed futures. Diffs - src/slave/http.cpp 0b83f6dbd51f39380d75334e6e4cbe3211d04c44 Diff: https://reviews.apache.org/r/48053/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 48052: Factored out `approved` function for `LocalAuthorizerObjectApprover`.

2016-05-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48052/#review135562 --- Ship it! Ship It! - Joerg Schad On May 30, 2016, 11:46 p.m

Re: Review Request 47977: Added tests for VIEW_* authorization actions.

2016-05-30 Thread Joerg Schad
the same request via new authorizer interface implicitly. Diffs - src/tests/authorization_tests.cpp 54bfb46a807677f4a4a2bb88dcb78a358cf5121a Diff: https://reviews.apache.org/r/47977/diff/ Testing --- make check (OSx). Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-30 Thread Joerg Schad
/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-30 Thread Joerg Schad
c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47704: Used TaskObjectApprover to filter /state endpoint.

2016-05-30 Thread Joerg Schad
/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

2016-05-31 Thread Joerg Schad
/diff/ Testing (updated) --- Viewed via gist: https://gist.github.com/joerg84/44045c005949f25df401de726ca41433 Also checked via website docker container. Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectApprover to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
and Michael Park. Repository: mesos Description (updated) --- Used TaskObjectApprover to filter /tasks endpoint. Diffs - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectApprover to filter /tasks endpoint.

2016-05-30 Thread Joerg Schad
://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47704: Added authorization-based filtering to `/master/state`.

2016-05-31 Thread Joerg Schad
) - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47559: Added authorization-based filtering to `/master/state-summary`.

2016-05-31 Thread Joerg Schad
`. Diffs (updated) - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Re: Review Request 47977: Added tests for `VIEW_*` authorization actions.

2016-05-31 Thread Joerg Schad
/diff/ Testing --- make check (OSx). Thanks, Joerg Schad

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-31 Thread Joerg Schad
) + 100x repeat on new tests. Thanks, Joerg Schad

Re: Review Request 47736: Added authorization-based filtering to `/master/tasks`.

2016-05-31 Thread Joerg Schad
) - src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 Diff: https://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47558: Added `ObjectApprover` interface to `Authorizer`.

2016-05-31 Thread Joerg Schad
/ Testing --- tested entire chain. Thanks, Joerg Schad

Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

2016-05-31 Thread Joerg Schad
--- Added `ObjectApprover` and endpoint filtering to the CHANGELOG. Diffs - CHANGELOG c778aeed24579d9c0ca880e7ebfa61a25f3cdd63 Diff: https://reviews.apache.org/r/48092/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-31 Thread Joerg Schad
e fact I want to. Does that make sense? - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/#review135679 ------- On May 31, 2016, 4:24 p.m., Joerg Schad wrote: > > ---

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

2016-05-31 Thread Joerg Schad
5c221f059585d49be5848bc0b655adab6b02 Diff: https://reviews.apache.org/r/48054/diff/ Testing --- make check (OSx) + 100x repeat on new tests. Thanks, Joerg Schad

Re: Review Request 48093: Updated comments in authorizer.proto.

2016-05-31 Thread Joerg Schad
tps://reviews.apache.org/r/48093/#comment200735> only if they set an object (e.g., the teardown) - Joerg Schad On May 31, 2016, 9:15 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

2016-05-31 Thread Joerg Schad
5c221f059585d49be5848bc0b655adab6b02 src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/48101/diff/ Testing --- make check OSx Thanks, Joerg Schad

Re: Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

2016-05-31 Thread Joerg Schad
eviews.apache.org/r/48092/#review135720 --- On May 31, 2016, 11:14 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-25 Thread Joerg Schad
/tests/common/http_tests.cpp 300f7cc21239b7d8727f7f0f02963f1af0dc80d7 Diff: https://reviews.apache.org/r/47069/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-25 Thread Joerg Schad
://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-25 Thread Joerg Schad
line 624) <https://reviews.apache.org/r/46613/#comment199856> remove else src/authorizer/local/authorizer.cpp (line 628) <https://reviews.apache.org/r/46613/#comment199857> Similar default. - Joerg Schad On May 26, 2016, 1:07 a.m., Joerg Schad wrote: > >

Re: Review Request 47736: Used Tasked ObjectAllower to filter /tasks endpoint.

2016-05-25 Thread Joerg Schad
: https://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

2016-05-25 Thread Joerg Schad
. Repository: mesos Description --- Used Tasked ObjectAllower to filter /state endpoint. Diffs (updated) - src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 Diff: https://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47490: Moved `Task` to public protobufs.

2016-05-25 Thread Joerg Schad
037c4336276258d671d0b1bf66cdab50b5bf9fb8 src/messages/messages.cpp 41dcdb3996ce173fb0a56704053e4b4e03f6dd63 src/messages/messages.proto 7fd3a2a3540e57bd1ce02a15de54123bf22b074c Diff: https://reviews.apache.org/r/47490/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-25 Thread Joerg Schad
/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-25 Thread Joerg Schad
://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Review Request 47977: Added tests for VIEW_* authorization actions.

2016-05-27 Thread Joerg Schad
54bfb46a807677f4a4a2bb88dcb78a358cf5121a Diff: https://reviews.apache.org/r/47977/diff/ Testing --- make check (OSx). Thanks, Joerg Schad

Re: Review Request 47736: Used TaskObjectAllower to filter /tasks endpoint.

2016-05-27 Thread Joerg Schad
://reviews.apache.org/r/47736/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47891: Added RUN_TASK authorization action.

2016-05-27 Thread Joerg Schad
tps://reviews.apache.org/r/47891/#comment200360> command is required in ExecutorInfo. src/authorizer/local/authorizer.cpp (line 152) <https://reviews.apache.org/r/47891/#comment200361> Note that at least with the other Actions non-existent `value` implies `ANY` - Joerg Schad On May 27

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

2016-05-31 Thread Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7 src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c Diff: https://reviews.apache.org/r/48101/diff/ Testing --- make check OSx Thanks, Joerg Schad

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

2016-05-31 Thread Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7 src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c Diff: https://reviews.apache.org/r/48101/diff/ Testing --- make check OSx Thanks, Joerg Schad

Re: Review Request 48092: Added authorizer interface changes and to the CHANGELOG.

2016-05-31 Thread Joerg Schad
c778aeed24579d9c0ca880e7ebfa61a25f3cdd63 Diff: https://reviews.apache.org/r/48092/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

2016-05-31 Thread Joerg Schad
5d7b5d13ebcf543cd908c33fbfdf541b78869bc7 src/tests/mesos.cpp 6c64bd547413d68de842ee03b13c12bbbf51779c Diff: https://reviews.apache.org/r/48101/diff/ Testing --- make check OSx Thanks, Joerg Schad

Review Request 47875: Consistent entity naming in acls.proto.

2016-05-26 Thread Joerg Schad
--- Object field `user` should be `users`. Diffs - include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8 Diff: https://reviews.apache.org/r/47875/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-26 Thread Joerg Schad
/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b Diff: https://reviews.apache.org/r/46613/diff/ Testing --- make check (OSX) Thanks, Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

2016-05-26 Thread Joerg Schad
b36b439a1fa07c52146deff2b90728f92676ade3 src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e Diff: https://reviews.apache.org/r/47558/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

2016-05-26 Thread Joerg Schad
. Repository: mesos Description --- Used Tasked ObjectAllower to filter /state endpoint. Diffs (updated) - src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 Diff: https://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-26 Thread Joerg Schad
/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

2016-05-26 Thread Joerg Schad
://reviews.apache.org/r/47704/diff/ Testing --- Make check (OSX) Thanks, Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

2016-05-26 Thread Joerg Schad
/r/47559/diff/ Testing --- make check + (sudo) make check on various linux systems Thanks, Joerg Schad

<    1   2   3   4   5   6   7   8   9   10   >