.
Changes
---
rebased
Repository: mesos
Description
---
Updated release guide to include doxygen site generation.
Diffs (updated)
-
docs/release-guide.md a0d27cbafeb5311d2c704dcb632b4de179ba994c
Diff: https://reviews.apache.org/r/43318/diff/
Testing
---
Thanks,
Kapil
10817d42eb572aa6e250a2d2fad9f3b385839f8b
Diff: https://reviews.apache.org/r/43122/diff/
Testing
---
Thanks,
Kapil Arya
/43382/diff/
Testing
---
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43258/#review118674
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 9, 2016, 6:47 p.m
ContainerStatus :-).
- Kapil Arya
On Feb. 8, 2016, 3:33 p.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ContainerStatus :-).
- Kapil Arya
On Feb. 8, 2016, 3:33 p.m., Avinash sridharan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43323/#review118677
---
Ship it!
Ship It!
- Kapil Arya
On Feb. 10, 2016, 2:05 a.m
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43093/
> -------
>
> (Updated Feb. 4, 2016, 4:27 p.m.)
>
>
> Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53136/#review153802
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 24, 2016, 11:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53138/#review154729
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 1, 2016, 12:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53341/#review154730
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 1, 2016, 12:26 p.m
/53137/#comment224395>
Maybe, also change this variable to `ENABLE_PYTHON_DEPENDENCY_INSTALL` and
change the test in src/Makefile.am to:
if !ENABLE_PYTHON_DEPENDENCY_INSTALL
...
fi
This will improve readability, I guess.
- Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53137/#review154822
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 3, 2016, 1:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53437/#review154823
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 3, 2016, 4:11 p.m
executor. Is this something
reasonable?
include/mesos/hook.hpp (line 120)
<https://reviews.apache.org/r/53308/#comment225601>
Can we add comment on the relationship of this hook vs. the
`slavePreLaunchDockerEnvironmentDecorator` hook above?
- Kapil Arya
On Oct. 31, 2016, 11:49 a.m.
tps://reviews.apache.org/r/53877/#comment226793>
Minor nit: Should we change `file` to something like `environmentVariables`
or `environment` because it's a string, not a file.
- Kapil Arya
On Nov. 22, 2016, 2:36 p.m., Till Toen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54038/#review156777
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 23, 2016, 2:26 p.m
e 24)
<https://reviews.apache.org/r/54038/#comment227062>
s/TaskExecutorDecoratorInfo/DockerTaskExecutorPrepareInfo/
src/hook/manager.hpp (lines 70 - 75)
<https://reviews.apache.org/r/54038/#comment227063>
Indent
- Kapil Arya
On Nov. 23, 2016, 2:26 p.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54128/#review157287
---
Ship it!
- Kapil Arya
On Nov. 29, 2016, 11:38 a.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54165/#review157323
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 29, 2016, 11:37 a.m
/test_hook_module.cpp (line 228)
<https://reviews.apache.org/r/54174/#comment227875>
Do we have a test where we are testing for the presence of `foo`?
- Kapil Arya
On Nov. 29, 2016, 2:54 p.m., Till Toenshoff wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54129/#review157324
---
Ship it!
Ship It!
- Kapil Arya
On Nov. 29, 2016, 2:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55268/#review160789
---
Ship it!
Ship It!
- Kapil Arya
On Jan. 6, 2017, 10:16 a.m
003>
Should we put it in a separate RR?
- Kapil Arya
On Jan. 6, 2017, 10:16 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Also, I am wondering if we should include a little more information about the
environment (either as part of `./configure` or `make`) such as kernel, libc
version, etc.!
- Kapil Arya
On Aug. 8, 2016, 11:57 a.m., Gastón Kleiman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52677/#review152547
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 10, 2016, 7:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52676/#review152548
---
Ship it!
Ship It!
- Kapil Arya
On Oct. 10, 2016, 7:54 a.m
Line 53 (original), 65 (patched)
<https://reviews.apache.org/r/58706/#comment245933>
Please add the tagged version back.
- Kapil Arya
On April 25, 2017, 11:09 a.m., Neil Conway wrote:
>
> ---
> This is an automatica
---
Added secret to Image.{docker,appc} and ContainerInfo.volume.
Diffs
-
include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
Diff: https://reviews.apache.org/r/58758/diff/1/
Testing
---
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/58759/diff/1/
Testing
---
Thanks,
Kapil Arya
---
Added default secret fetcher module.
Diffs
-
src/Makefile.am 1fc453c497f278c9fc3fa5e91eb720a932915fde
src/secret/fetcher.hpp PRE-CREATION
src/secret/fetcher.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/1/
Testing
---
Thanks,
Kapil Arya
72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
Diff: https://reviews.apache.org/r/58761/diff/1/
Testing
---
Thanks,
Kapil Arya
://reviews.apache.org/r/58758/diff/1-2/
Testing
---
Thanks,
Kapil Arya
PRE-CREATION
src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4
src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193
Diff: https://reviews.apache.org/r/58759/diff/2/
Changes: https://reviews.apache.org/r/58759/diff/1-2/
Testing
---
Thanks,
Kapil Arya
le.am 29da17bee13226e18757e2ad3a7a091427fd35f4
src/secret/fetcher.hpp PRE-CREATION
src/secret/fetcher.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/2/
Changes: https://reviews.apache.org/r/58760/diff/1-2/
Testing
---
Thanks,
Kapil Arya
src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
Diff: https://reviews.apache.org/r/58761/diff/2/
Changes: https://reviews.apache.org/r/58761/diff/1-2/
Testing
---
Thanks,
Kapil Arya
02d8f800c3eb9b1e617a14c78c2ef1e45d1c72bb
Diff: https://reviews.apache.org/r/58762/diff/1/
Testing
---
Thanks,
Kapil Arya
767ed3d0444258f30b7338981ccc0080166ac5a7
src/tests/mock_slave.cpp c435ec76ac44775bf8a87421640649495c16187e
Diff: https://reviews.apache.org/r/58763/diff/1/
Testing
---
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58924/#review173840
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2017, 1:28 p.m
Lines 166 (patched)
<https://reviews.apache.org/r/58923/#comment246873>
s/for the executor already/only for the executor/?
- Kapil Arya
On May 2, 2017, 1:28 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58925/#review173851
---
Ship it!
Ship It!
- Kapil Arya
On May 2, 2017, 1:28 p.m
/secret/fetcher.hpp PRE-CREATION
src/secret/fetcher.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/3/
Changes: https://reviews.apache.org/r/58760/diff/2-3/
Testing
---
Thanks,
Kapil Arya
sting
---
Thanks,
Kapil Arya
b47a6b5081a63ac474ac4634701b1a572eb58137
src/tests/containerizer/mesos_containerizer_tests.cpp
13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
Diff: https://reviews.apache.org/r/58999/diff/1/
Testing
---
Thanks,
Kapil Arya
-CREATION
Diff: https://reviews.apache.org/r/59000/diff/1/
Testing
---
Added a new test and ran `make check`.
Thanks,
Kapil Arya
src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/59001/diff/1/
Testing
---
Thanks,
Kapil Arya
to update the existing unit tests involving
containerizers.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/#review173969
---
much to do with authentication either.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58759/#review173966
----
> On May 4, 2017, 6:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/containerizer.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/58999/diff/1/?file=1708769#file1708769line66>
> >
> > Why optional?
>
> Kapil Arya wrote:
>
25 p.m., Jie Yu wrote:
> > include/mesos/secret/fetcher.hpp
> > Lines 17 (patched)
> > <https://reviews.apache.org/r/58759/diff/3/?file=1708762#file1708762line17>
> >
> > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp
>
> Kapil Arya wr
> On May 4, 2017, 6:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/containerizer.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/58999/diff/1/?file=1708769#file1708769line66>
> >
> > Why optional?
>
> Kapil Arya wrote:
>
: https://reviews.apache.org/r/58759/diff/4/
Changes: https://reviews.apache.org/r/58759/diff/3-4/
Testing
---
Thanks,
Kapil Arya
resolver module.
Diffs (updated)
-
src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/4/
Changes: https://reviews.apache.org/r/58760/diff/3-4/
Testing
---
Thanks,
Kapil Arya
https://reviews.apache.org/r/58999/diff/1-2/
Testing
---
Thanks,
Kapil Arya
/environment_secret_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/59000/diff/2/
Changes: https://reviews.apache.org/r/59000/diff/1-2/
Testing
---
Added a new test and ran `make check`.
Thanks,
Kapil Arya
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/#review173970
-------
On May 5, 2017, 6:43 a.m., Kapil Arya wrote:
>
> ---
>
/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/59001/diff/2/
Changes: https://reviews.apache.org/r/59001/diff/1-2/
Testing (updated)
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
> On May 4, 2017, 6:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/containerizer.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/58999/diff/1/?file=1708769#file1708769line66>
> >
> > Why optional?
>
> Kapil Arya wrote:
>
: https://reviews.apache.org/r/58759/diff/5/
Changes: https://reviews.apache.org/r/58759/diff/4-5/
Testing
---
Thanks,
Kapil Arya
src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/5/
Changes: https://reviews.apache.org/r/58760/diff/4-5/
Testing
---
Thanks,
Kapil Arya
> On May 4, 2017, 6:29 p.m., Jie Yu wrote:
> > src/slave/containerizer/containerizer.hpp
> > Lines 66 (patched)
> > <https://reviews.apache.org/r/58999/diff/1/?file=1708769#file1708769line66>
> >
> > Why optional?
>
> Kapil Arya wrote:
>
test and ran `make check`.
Thanks,
Kapil Arya
anges: https://reviews.apache.org/r/59001/diff/2-3/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
een created (with tmpfs mount), while the secret is downloaded _before_
container creation. That's why the additional step.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews
src/tests/containerizer/mesos_containerizer_tests.cpp
13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
Diff: https://reviews.apache.org/r/58999/diff/3/
Changes: https://reviews.apache.org/r/58999/diff/2-3/
Testing
---
Thanks,
Kapil Arya
/59001/diff/3-4/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
://reviews.apache.org/r/58759/diff/5-6/
Testing
---
Thanks,
Kapil Arya
/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/6/
Changes: https://reviews.apache.org/r/58760/diff/5-6/
Testing
---
Thanks,
Kapil Arya
/containerizer/mesos_containerizer_tests.cpp
13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
Diff: https://reviews.apache.org/r/58999/diff/4/
Changes: https://reviews.apache.org/r/58999/diff/3-4/
Testing
---
Thanks,
Kapil Arya
`make check`.
Thanks,
Kapil Arya
/diff/5/
Changes: https://reviews.apache.org/r/59001/diff/4-5/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
/diff/7/
Changes: https://reviews.apache.org/r/58759/diff/6-7/
Testing
---
Thanks,
Kapil Arya
s.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9
src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/7/
Changes: https://reviews.apache.org/r/58760/diff/6-7/
Testing
---
Thanks,
Kapil Arya
sting
---
Added a new test and ran `make check`.
Thanks,
Kapil Arya
58137
src/tests/containerizer/mesos_containerizer_tests.cpp
13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4
Diff: https://reviews.apache.org/r/58999/diff/5/
Changes: https://reviews.apache.org/r/58999/diff/4-5/
Testing
---
Thanks,
Kapil Arya
/diff/5-6/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/#review174248
-------
On May 9, 2017, 2:11 p.m., Kapil Arya wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/#review174246
---
On May 9, 2017, 2:11 p.m., Kapil Arya wrote:
>
> ---
https://reviews.apache.org/r/59001/diff/6-7/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
/diff/5-6/
Testing
---
Thanks,
Kapil Arya
ran `make check`.
Thanks,
Kapil Arya
://reviews.apache.org/r/58759/diff/7-8/
Testing
---
Thanks,
Kapil Arya
/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/8/
Changes: https://reviews.apache.org/r/58760/diff/7-8/
Testing
---
Thanks,
Kapil Arya
/diff/7-8/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
58759/diff/9/
Changes: https://reviews.apache.org/r/58759/diff/8-9/
Testing
---
Thanks,
Kapil Arya
s.txt eef718d95b5d8e051a5094369dc9b4532bc307ff
src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a
src/secret/resolver.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/58760/diff/9/
Changes: https://reviews.apache.org/r/58760/diff/8-9/
Testing
---
Thanks,
Kapil Arya
sting
---
Added a new test and ran `make check`.
Thanks,
Kapil Arya
/diff/6-7/
Testing
---
Thanks,
Kapil Arya
ATION
Diff: https://reviews.apache.org/r/59001/diff/9/
Changes: https://reviews.apache.org/r/59001/diff/8-9/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
Name == DEFAULT_SECRET_RESOLVER)
{...}`.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58999/#review174918
-------
On May 16, 2017, 3:22 p.m., Kapil Arya wrote:
>
> ---
To reply, visit:
https://reviews.apache.org/r/59000/#review174942
---
On May 16, 2017, 3:22 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail.
---
See summary.
Diffs
-
src/tests/master_tests.cpp 37a54138b03229778bc62501532e698e87760218
Diff: https://reviews.apache.org/r/59318/diff/1/
Testing
---
Make check with an without the patch.
Thanks,
Kapil Arya
,
Kapil Arya
tps://reviews.apache.org/r/59372/#comment248861>
No. The first action is when the flag is specified. So, if the flag is
specified, we do want to set it to "yes" after emmitting the warning.
- Kapil Arya
On May 18, 2017, 1:40 p.m.,
`Disabled
`./configure --with-port-mapping-isolator` Enabled
`./configure --with-network-isolator`Enabled
Thanks,
Kapil Arya
https://reviews.apache.org/r/59372/#review175412
---
On May 18, 2017, 1:56 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-m
-port-mapping-isolator` Enabled
`./configure --with-network-isolator`Enabled
Thanks,
Kapil Arya
eviews.apache.org/r/59372/#review175419
-------
On May 18, 2017, 2:28 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59372/
> ---
f/7-8/
Testing
---
Thanks,
Kapil Arya
ATION
Diff: https://reviews.apache.org/r/59001/diff/10/
Changes: https://reviews.apache.org/r/59001/diff/9-10/
Testing
---
Added new tests an ran `make check`.
Thanks,
Kapil Arya
401 - 500 of 825 matches
Mail list logo
