ted the review.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49602/#review142391
---
On July 18, 2016, 5:53
atch, does
not emit the warning. Note that the warning seems to occur more often if you
remove the `os::sleep` from `Clock::settle`, which we want to do anyway.
Thanks,
Neil Conway
3rdparty/libprocess/src/tests/metrics_tests.cpp
5a82f4f49aecd03d12687de629516be5b7895036
Diff: https://reviews.apache.org/r/50187/diff/
Testing
---
`make check` with lots of iterations.
Thanks,
Neil Conway
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49955/#review142433
---
On July 12, 2016, 5:40 p.m., Neil Conway wrote:
>
> ---
------
On July 12, 2016, 5:40 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49955/
> ---
src/local/local.cpp a543aef117fea62660d55435be4d66d30f8ee860
src/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8
src/master/main.cpp 9775b8a1e5fe51670789805557339bd0737a02b7
Diff: https://reviews.apache.org/r/49955/diff/
Testing
---
make check
Thanks,
Neil Conway
ot;, where I thought that made more
sense.
Thanks,
Neil Conway
470fb26a2985f912b2b91d647cd7a27b8748c2a5
Diff: https://reviews.apache.org/r/50235/diff/
Testing
---
make check
Also switched a few "ASSERTs" to be "EXPECTs", where I thought that made more
sense.
Thanks,
Neil Conway
/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8
src/master/main.cpp 9775b8a1e5fe51670789805557339bd0737a02b7
Diff: https://reviews.apache.org/r/49955/diff/
Testing
---
make check
Thanks,
Neil Conway
df11e91f2e373774fad999b0cd3fe1db9a4671de
Diff: https://reviews.apache.org/r/49957/diff/
Testing
---
Thanks,
Neil Conway
9775b8a1e5fe51670789805557339bd0737a02b7
Diff: https://reviews.apache.org/r/49955/diff/
Testing
---
make check
Thanks,
Neil Conway
and then deleting
the target checkpoint file, what about renaming target -> current checkpoint?
Rename is typically atomic (within a single filesystem), which is nice, and it
would avoid the need to separately delete the target checkpoint afterward.
- Neil Conway
On July 12, 2016, 8:25 p.m., Anin
6c85e19eeaa69bf3a4e3077261331191db6eec06
Diff: https://reviews.apache.org/r/49323/diff/
Testing
---
make check
This test passes without any Mesos changes. i.e., it doesn't reproduce the bug
by itself, but having more test coverage for this scenario seems wise.
Thanks,
Neil Conway
tps://reviews.apache.org/r/49250/#comment204803>
"view.See" <- missing whitespace
docs/endpoints/master/teardown.md (line 30)
<https://reviews.apache.org/r/49250/#comment204806>
"cr
improve
performance, and for what kinds of inputs? (e.g., short vs. long strings, found
match vs. no-match-found).
- Neil Conway
On June 27, 2016, 6:16 a.m., Klaus Ma wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49246/#review139555
---
Ship it!
Ship It!
- Neil Conway
On June 27, 2016, 6:16 a.m
: mesos
Description
---
Made some other edits and cleanups to quota docs.
Diffs
-
docs/quota.md 61c6be0d94466b40933d75d53d2b4464243e4796
Diff: https://reviews.apache.org/r/49325/diff/
Testing
---
Previewed in site-docker.
Thanks,
Neil Conway
---
Previous name was likely unintentional.
Diffs
-
src/tests/allocator.hpp bc2d89e840883ea736d0f76438e2a5ac68f96913
Diff: https://reviews.apache.org/r/49314/diff/
Testing
---
make check
Thanks,
Neil Conway
Thanks,
Neil Conway
github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061),
previously `make check` passes, but it fails with this new test added.
Thanks,
Neil Conway
/
Testing
---
`mesos-tests --gtest_filter=HierarchicalAllocatorTest.* --gtest_repeat=500
--gtest_break_on_failure`
Thanks,
Neil Conway
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49612/diff/
Testing
---
`mesos-tests --gtest_filter=HierarchicalAllocatorTest.* --gtest_repeat=500
--gtest_break_on_failure`
Thanks,
Neil Conway
ps://reviews.apache.org/r/49610/#review140704
-------
On July 4, 2016, 8:39 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49610/
> -
---
The comment was correct when written, but is no longer accurate.
Diffs
-
src/master/master.cpp 78a8889313179b4509a6657e6c61d9f6d3bb99c0
Diff: https://reviews.apache.org/r/49623/diff/
Testing
---
Thanks,
Neil Conway
urces"
--gtest_repeat=500 --gtest_break_on_failure` passes. When you apply a patch
that breaks quota allocation behavior
(https://gist.github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061),
previously `make check` passes, but it fails with this new test added.
Thanks,
Neil Conway
/49623/diff/
Testing (updated)
---
Also tweak another comment in `master.hpp`
Thanks,
Neil Conway
---
Thanks,
Neil Conway
test. It's not immediately clear
> > that `AWAIT` happens in `handleAllocationsAndRecoverResources()`.
>
> Neil Conway wrote:
> I don't agree with keeping `Clock::settle` in this case. For one thing,
> it implies the wrong thing: i.e., keeping `Clock::settle` implies that
> `handleAl
Description
---
Renamed a function in allocator tests for clarity.
Diffs
-
src/tests/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49883/diff/
Testing
---
make check
Thanks,
Neil Conway
/hierarchical_allocator_tests.cpp
0498cd5e54b0e4b87a767585a77699653aa52179
Diff: https://reviews.apache.org/r/49883/diff/
Testing
---
make check
Thanks,
Neil Conway
re` passes. When you apply a patch
that breaks quota allocation behavior
(https://gist.github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061),
previously `make check` passes, but it fails with this new test added.
Thanks,
Neil Conway
)
<https://reviews.apache.org/r/49892/#comment207048>
Should we check that the status update is for the `TASK_RUNNING` state?
- Neil Conway
On July 11, 2016, 12:25 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically g
```
Note that I'm not convinced this is a super useful thing to be logging, even at
`VLOG(1)`, so I'd also be fine with just removing the log statement altogether.
Thanks,
Neil Conway
:
```
I0704 20:15:47.270100 1970868224 clock.cpp:329] Clock paused at 0x7ff72842d310
```
Revised log output:
```
I0704 20:17:59.394853 1970868224 clock.cpp:329] Clock paused at 2016-07-04
18:17:59.394846976+00:00
```
Thanks,
Neil Conway
age its use whenever possible.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49612/#review140790
-------
On July 5, 2016, 8:51 a.m., Neil Conway wrote:
>
> -
test. It's not immediately clear
> > that `AWAIT` happens in `handleAllocationsAndRecoverResources()`.
>
> Neil Conway wrote:
> I don't agree with keeping `Clock::settle` in this case. For one thing,
> it implies the wrong thing: i.e., keeping `Clock::settle` implies that
> `handleAl
Description
---
Cleaned up some minor style issues.
Diffs
-
src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f
Diff: https://reviews.apache.org/r/49693/diff/
Testing
---
`make check`
Thanks,
Neil Conway
="MasterSlaveReconciliationTest.SlaveReregisterActiveFrameworks"
--gtest_repeat=700 --gtest_break_on_failure`
Thanks,
Neil Conway
src/slave/state.cpp (line 732)
<https://reviews.apache.org/r/48313/#comment207028>
Should be `string`, not `std::string`.
Can you update the review summary to describe the new protocol implemented by
this RR?
- Neil Conway
On July 1, 2016, 9:39 p.m., Anindya Sinha wrote:
>
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49892/#review141700
---
Ship it!
Ship It!
- Neil Conway
On July 11, 2016, 2:04 p.m
---
Fixed outdated comment.
Diffs
-
src/master/master.cpp 92595097c8f26675aee122c8a11366262534db64
Diff: https://reviews.apache.org/r/50844/diff/
Testing
---
make check
Thanks,
Neil Conway
/50846/diff/
Testing
---
make check
Thanks,
Neil Conway
91969e4c3196a4f36c19abf38e229f3a36e87ea1
src/tests/reconciliation_tests.cpp 492560c430eba45e3a9f7a767ee761dfa0cacb05
src/tests/registrar_tests.cpp ba7c66ff83f09d68fb5324a3f85d2875068a35a6
Diff: https://reviews.apache.org/r/50845/diff/
Testing
---
make check
Thanks,
Neil Conway
_tests.cpp 91969e4c3196a4f36c19abf38e229f3a36e87ea1
Diff: https://reviews.apache.org/r/50705/diff/
Testing
---
make check
Thanks,
Neil Conway
esting
---
make check
Thanks,
Neil Conway
ps://reviews.apache.org/r/50699/#review145016
-------
On Aug. 9, 2016, 12:59 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50699/
> -
> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote:
> > hmm, why can't the TaskID's have spaces?
> >
> > They are generated by the framework and are free to contain spaces.
>
> Neil Conway wrote:
> Yeah, I was wondering that myself :) We don't quote them a
----
On July 27, 2016, 5:29 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50301/
> -
6c85e19eeaa69bf3a4e3077261331191db6eec06
Diff: https://reviews.apache.org/r/49377/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
---
Documented behavior when framework and master both failover.
Diffs
-
docs/high-availability-framework-guide.md
0c73e1478682d2a26c369bcf88235dc962e6c834
Diff: https://reviews.apache.org/r/49442/diff/
Testing
---
Previewed in site-docker.
Thanks,
Neil Conway
88b7fc4c36ed3974ac6b103a29e1d975619f0c69
src/launcher/executor.cpp bb88a4570d183d22dff65f6e220d566c0924001a
src/master/allocator/mesos/hierarchical.cpp
c3639342335499a04a23147a4205f1b475c123fa
Diff: https://reviews.apache.org/r/49469/diff/
Testing
---
make check
Thanks,
Neil Conway
8e9254afcf798d5158ec8a2c2b4cddfe50fac3f1
Diff: https://reviews.apache.org/r/49503/diff/
Testing
---
make check
Thanks,
Neil Conway
://reviews.apache.org/r/49469/diff/
Testing
---
make check
Thanks,
Neil Conway
967290d4d1100208900b4b724422c3218abc23cb
Diff: https://reviews.apache.org/r/49376/diff/
Testing
---
These assertions DO NOT PASS. They are conceptually correct, however -- after
r/49377 they pass on `make check`.
Thanks,
Neil Conway
reproduce the bug
by itself, but having more test coverage for this scenario seems wise.
Thanks,
Neil Conway
971a7b38d26b26c8543815e467f30cbb83ee412c
Diff: https://reviews.apache.org/r/49377/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
llocator/sorter/sorter.hpp
5ce6bb82b0127257d97daf0cea6d1d0db405bf83
src/tests/sorter_tests.cpp 6fc58829892dc0223140f1b47593a3e5853cace5
Diff: https://reviews.apache.org/r/49375/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
/master/allocator/sorter/drf/sorter.cpp
967290d4d1100208900b4b724422c3218abc23cb
Diff: https://reviews.apache.org/r/49376/diff/
Testing
---
These assertions DO NOT PASS. They are conceptually correct, however -- after
r/49377 they pass on `make check`.
Thanks,
Neil Conway
g/r/49251/#comment205326>
"based on" -- here and below.
src/master/http.cpp (line 2615)
<https://reviews.apache.org/r/49251/#comment205328>
"to teardown frameworks"
- Neil Conway
On June 27, 201
://reviews.apache.org/r/49323/diff/
Testing
---
make check
This test passes without any Mesos changes. i.e., it doesn't reproduce the bug
by itself, but having more test coverage for this scenario seems wise.
Thanks,
Neil Conway
rc/tests/sorter_tests.cpp 6fc58829892dc0223140f1b47593a3e5853cace5
Diff: https://reviews.apache.org/r/49375/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
/diff/
Testing
---
These assertions DO NOT PASS. They are conceptually correct, however -- after
r/49377 they pass on `make check`.
Thanks,
Neil Conway
.
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49251/#review139988
---
Ship it!
Ship It!
- Neil Conway
On June 29, 2016, 1:59 p.m
y));
Personally, I prefer grouping the two `CHECKs` together because they are
semantically related.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49376/#review140620
------
. i.e., it doesn't reproduce the bug
by itself, but having more test coverage for this scenario seems wise.
Thanks,
Neil Conway
/persistent_volume_endpoints_tests.cpp
971a7b38d26b26c8543815e467f30cbb83ee412c
Diff: https://reviews.apache.org/r/49377/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49375/#review140617
---
On July 1, 2016, 9:47 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
b
src/master/allocator/sorter/sorter.hpp
5ce6bb82b0127257d97daf0cea6d1d0db405bf83
src/tests/sorter_tests.cpp 6fc58829892dc0223140f1b47593a3e5853cace5
Diff: https://reviews.apache.org/r/49375/diff/
Testing
---
make check on OSX and recent Arch Linux.
Thanks,
Neil Conway
src/tests/resources_tests.cpp (line 882)
<https://reviews.apache.org/r/51099/#comment212144>
Wouldn't hurt to have another test case that is even larger, IMO.
- Neil Conway
On Aug. 15, 2016, 5:54 p.m., Jiang Yan Xu wrote:
>
> ---
&g
a6f97c4bb5fb29d610c01255036095e2b30c44c5
src/tests/reservation_tests.cpp 6181c6f8abbf254b45ea77f33c48dee918106ef0
src/tests/slave_tests.cpp 30ca3da6ca2f1e068bb3f8a6abc7efeebd5bfe8c
Diff: https://reviews.apache.org/r/51148/diff/
Testing
---
make check
Thanks,
Neil Conway
bdeffd5114ab481903c1178d9ecb3452ec85b
src/tests/slave_recovery_tests.cpp b6d4ae54e327ece18263e11cb7ca01fb832a5da4
Diff: https://reviews.apache.org/r/51150/diff/
Testing
---
make check
Thanks,
Neil Conway
---
Cleaned up 'using' statements.
Diffs
-
src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f
src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04
Diff: https://reviews.apache.org/r/51149/diff/
Testing
---
make check
Thanks,
Neil Conway
/51152/diff/
Testing
---
make check
Thanks,
Neil Conway
: https://reviews.apache.org/r/51151/diff/
Testing
---
make check
Thanks,
Neil Conway
/
Testing
---
`make check`
Thanks,
Neil Conway
`
Thanks,
Neil Conway
---
Replaced use of ".get()" in master quota tests with "->".
Diffs
-
src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6
Diff: https://reviews.apache.org/r/56248/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Fixed typos in name of test suite.
Diffs
-
src/tests/role_tests.cpp 0d0f1a94ff9aaec6ea04280282a52ac88dc6b273
Diff: https://reviews.apache.org/r/56245/diff/
Testing
---
`make check`
Thanks,
Neil Conway
b48678bae8b3f5bab62710043eaca14ab8370183
src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6
Diff: https://reviews.apache.org/r/56246/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
---
Cleaned up code style slightly in DRF sorter.
Diffs
-
src/master/allocator/sorter/drf/sorter.cpp
5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56249/diff/
Testing
---
`make check`
Thanks,
Neil Conway
5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56251/diff/
Testing
---
`make check`
Thanks,
Neil Conway
(line 336)
<https://reviews.apache.org/r/56177/#comment235325>
s/updates/update/
include/mesos/v1/scheduler/scheduler.proto (line 326)
<https://reviews.apache.org/r/56177/#comment235326>
s/updates/update/
- Neil Conway
On Feb. 1, 2017, 4:49 p.m., Alexander Ruk
] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/26 (10821 ms)
[ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/27 (11182 ms)
[ OK ] AgentAndClientCount/Sorter_BENCHMARK_Test.FullSort/28 (11077 ms)
```
Thanks,
Neil Conway
.
Thanks,
Neil Conway
.
Thanks,
Neil Conway
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56427/#review164819
---
On Feb. 8, 2017, 3:40 a.m., Neil Con
eviews.apache.org/r/56247/#review164201
---
On Feb. 2, 2017, 10:59 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To re
comments in sorter.
Diffs
-
src/master/allocator/sorter/drf/sorter.hpp
5bed53a1641fee0c09862f77b394a0e9ec131990
Diff: https://reviews.apache.org/r/56349/diff/
Testing
---
`make check` (no functional changes).
Thanks,
Neil Conway
737b13f66f989ac23c9a2fb6467a51f84339c773
Diff: https://reviews.apache.org/r/56350/diff/
Testing
---
`make check`
Note that this changes the sorter interface. I can add a note to the
`CHANGELOG` if warranted.
Thanks,
Neil Conway
rter.hpp
5bed53a1641fee0c09862f77b394a0e9ec131990
src/master/allocator/sorter/drf/sorter.cpp
5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56351/diff/
Testing
---
`make check`
Thanks,
Neil Conway
Diff: https://reviews.apache.org/r/56352/diff/
Testing
---
`make check`
Running the sorter benchmarks with an optimized build, this results in a modest
improvement (~10%).
Thanks,
Neil Conway
`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
s (updated)
-
src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b
src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba
Diff: https://reviews.apache.org/r/55474/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/55395/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/55395/diff/
Testing
---
`make check`
Thanks,
Neil Conway
: https://reviews.apache.org/r/55395/diff/
Testing
---
`make check`
Thanks,
Neil Conway
0cf69efc319ba
Diff: https://reviews.apache.org/r/55475/diff/
Testing
---
`make check`
Thanks,
Neil Conway
1001 - 1100 of 2064 matches
Mail list logo
