src/tests/containerizer/volume_secret_isolator_tests.cpp
11cd3b627b056d1811ab481b8aa599c346181383
Diff: https://reviews.apache.org/r/68204/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
663aafc7173667f8f78b26bdc824a3ab2e04ed25
Diff: https://reviews.apache.org/r/68203/diff/1/
Testing
---
Thanks,
Qian Zhang
706b8ff28e1b1c8d15606d54d40622bc09885667
src/slave/containerizer/mesos/isolators/volume/image.cpp
345772439b73b4816f71e15bb4e43a5d67c51c02
Diff: https://reviews.apache.org/r/68041/diff/2/
Changes: https://reviews.apache.org/r/68041/diff/1-2/
Testing
---
Thanks,
Qian Zhang
84b342cdd4b8ef4803725ecfa9f922687ccdadd8
Diff: https://reviews.apache.org/r/68162/diff/2/
Changes: https://reviews.apache.org/r/68162/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/r/68163/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
: https://reviews.apache.org/r/68162/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
a47899cb528eef103f299def3bd3466905ac5b51
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
f91a2eeb835bb65a855eeb314d4c69e3b58fecae
Diff: https://reviews.apache.org/r/68161/diff/1/
Testing
---
Thanks,
Qian Zhang
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp
f91a2eeb835bb65a855eeb314d4c69e3b58fecae
Diff: https://reviews.apache.org/r/68161/diff/1/
Testing
---
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/68127/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/68126/diff/1/
Testing
---
Thanks,
Qian Zhang
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp
ab749be6234a5eedc0617a131c126129f43f8d62
Diff: https://reviews.apache.org/r/68125/diff/1/
Testing
---
Thanks,
Qian Zhang
ts.cpp#L300:L374
src/tests/gc_tests.cpp
Lines 957 (patched)
<https://reviews.apache.org/r/68068/#comment289579>
Ditto.
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68065/#review206582
---
Ship it!
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu
tched)
<https://reviews.apache.org/r/68067/#comment289567>
Ditto.
- Qian Zhang
On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-ma
Can we merge these code into the above `if (containerId.has_parent()) {`?
- Qian Zhang
On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and
`CHANGELOG`.
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
://reviews.apache.org/r/67996/diff/2-3/
Testing
---
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/68044/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/containerizer/mesos/isolators/volume/image.cpp
345772439b73b4816f71e15bb4e43a5d67c51c02
Diff: https://reviews.apache.org/r/68041/diff/1/
Testing
---
Thanks,
Qian Zhang
/slave/containerizer/mesos/provisioner/provisioner.cpp
ac402fbead81e4b356cb35cea08a00049002e870
Diff: https://reviews.apache.org/r/68040/diff/1/
Testing
---
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/68043/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
://reviews.apache.org/r/67996/diff/1-2/
Testing
---
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/67997/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
4896c6811c2c59dcf00871b7a8b6b9b50da0f062
src/slave/containerizer/mesos/utils.hpp
bfd07e28c78fc140e395ffccd11d65545bf007fc
src/slave/containerizer/mesos/utils.cpp
30e76d1d91651975033078f5450e45f5f2fd8ba0
Diff: https://reviews.apache.org/r/67996/diff/1/
Testing
---
Thanks,
Qian Zhang
09d0a40a74a293dcf6eecde2a443281e4b8d9fe8
Diff: https://reviews.apache.org/r/66814/diff/2/
Changes: https://reviews.apache.org/r/66814/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
ff/2/
Changes: https://reviews.apache.org/r/67896/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
eviews.apache.org/r/67896/#review206219
---
On July 12, 2018, 10:16 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
sudo make check
Thanks,
Qian Zhang
ttps://reviews.apache.org/r/67896/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
mesos/isolators/network/cni/cni.cpp
dfa26c682333e19d246442def8482b782e7b0d24
Diff: https://reviews.apache.org/r/67769/diff/3/
Changes: https://reviews.apache.org/r/67769/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
>
> Qian Zhang wrote:
> And is it possible for CNI DEL command gets called after
> `reregisterExecutorMessage` is received?
>
> Jie Yu wrote:
>
dfa26c682333e19d246442def8482b782e7b0d24
Diff: https://reviews.apache.org/r/67769/diff/2/
Testing
---
sudo make check
Thanks,
Qian Zhang
il. To reply, visit:
https://reviews.apache.org/r/67769/#review205516
---
On June 29, 2018, 9:20 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generat
: https://reviews.apache.org/r/67769/diff/2/
Changes: https://reviews.apache.org/r/67769/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
,
Qian Zhang
/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
>
> Qian Zhang wrote:
> And is it possible for CNI DEL command gets called after
> `reregisterExecutorMessage` is received?
>
> Jie Yu wrote:
>
> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
And is it possible for CNI DEL command gets called after
`reregisterExecutorMessage` is received?
- Qian
---
T
/r/67743/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
`TASK_KILLED`?
- Qian Zhang
On June 26, 2018, 1:36 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/67739/diff/1/
Testing
---
Not a code change.
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67728/#review205339
---
Ship it!
Ship It!
- Qian Zhang
On June 26, 2018, 3 a.m
/cgroups_isolator_tests.cpp
d1028e351c2ff395adc48489169597adbb0ce857
Diff: https://reviews.apache.org/r/67564/diff/3/
Changes: https://reviews.apache.org/r/67564/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
://reviews.apache.org/r/67526/diff/5/
Changes: https://reviews.apache.org/r/67526/diff/4-5/
Testing
---
Thanks,
Qian Zhang
st, we will still do the bind mount under
`/sys/fs/cgroup` for the container launched on CentOS 6 host.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review20
he.org/r/67662/#review205255
---
On June 20, 2018, 10:37 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
s 111 (patched)
<https://reviews.apache.org/r/66875/#comment288104>
Kill this blank line.
- Qian Zhang
On June 21, 2018, 2:26 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
Lines 177 (patched)
<https://reviews.apache.org/r/53105/#comment288103>
Better to change to:
```
struct Metrics
{
```
- Qian Zhang
On June 21, 2018, 2:25 a.m., Zhitao Li wrote:
>
> ---
> This is a
81c934318dcc2bcc9df594af0ee25f0334541a65
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
6d146729123b85e46f580a594fb9f9ac37b542f7
Diff: https://reviews.apache.org/r/67673/diff/1/
Testing (updated)
---
sudo make check
Thanks,
Qian Zhang
/containerizer/mesos/isolators/cgroups/cgroups.cpp
6d146729123b85e46f580a594fb9f9ac37b542f7
Diff: https://reviews.apache.org/r/67673/diff/1/
Testing
---
Thanks,
Qian Zhang
86 (patched)
<https://reviews.apache.org/r/66875/#comment287931>
I'd name it
`image_pull("containerizer/mesos/provisioner/docker_store/image_pull",
Hours(1))`
- Qian Zhang
On May 22, 2018, 1:16 a.m., Zhitao Li wrote:
>
> ---
container->containerWorkDir,
image,
container->forcePullImage()));
```
- Qian Zhang
On May 22, 2018, 1:16 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To repl
: https://reviews.apache.org/r/67526/diff/3-4/
Testing
---
Thanks,
Qian Zhang
d1028e351c2ff395adc48489169597adbb0ce857
Diff: https://reviews.apache.org/r/67565/diff/3/
Changes: https://reviews.apache.org/r/67565/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
/67662/diff/1/
Testing
---
Thanks,
Qian Zhang
231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67564/diff/2/
Changes: https://reviews.apache.org/r/67564/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67565/diff/2/
Changes: https://reviews.apache.org/r/67565/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/3/
Changes: https://reviews.apache.org/r/67526/diff/2-3/
Testing
---
Thanks,
Qian Zhang
18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/4/
Changes: https://reviews.apache.org/r/67381/diff/3-4/
Testing
---
Not a code change.
Thanks,
Qian Zhang
`.
Diffs (updated)
-
src/tests/containerizer/cgroups_isolator_tests.cpp
231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67358/diff/3/
Changes: https://reviews.apache.org/r/67358/diff/2-3/
Testing
---
Ran this test repeatedly
Thanks,
Qian Zhang
/67343/diff/4-5/
Testing
---
sudo make check
Thanks,
Qian Zhang
18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/3/
Changes: https://reviews.apache.org/r/67381/diff/2-3/
Testing
---
Not a code change.
Thanks,
Qian Zhang
://reviews.apache.org/r/67574/diff/1/
Testing
---
Thanks,
Qian Zhang
To reply, visit:
https://reviews.apache.org/r/67381/#review204439
---
On June 1, 2018, 11:28 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e
/67565/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/r/67564/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/
Changes: https://reviews.apache.org/r/67526/diff/1-2/
Testing
---
Thanks,
Qian Zhang
4acbee990188bed11e1a02bfee222a6e0a3f78a7
src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 8e448d8755a7e1826a1f059c8b280286ec2448a4
src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076
Diff: https://reviews.apache.org/r/67563/diff/1/
Testing
---
Thanks,
Qian Zhang
/cgroups/cgroups.cpp
215e32461e851668247f9fae62aa656f5dd5e245
Diff: https://reviews.apache.org/r/67526/diff/1/
Testing
---
Thanks,
Qian Zhang
> On April 18, 2018, 9:24 p.m., Qian Zhang wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp
> > Lines 493-517 (patched)
> > <https://reviews.apache.org/r/66562/diff/2/?file=2004051#file2004051line493>
> >
> > Can you use raw string liter
https://reviews.apache.org/r/66561/#comment286906>
s/either pulling from/pulling from either/
src/slave/flags.cpp
Line 205 (original), 205 (patched)
<https://reviews.apache.org/r/66561/#comment286891>
Ditto.
src/slave/flags.cpp
Lines 206 (patched)
<https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66650/#review204369
---
Ship it!
Ship It!
- Qian Zhang
On June 6, 2018, 4:40 p.m
18632edd20fcf943c6e7147aca3fec5b5521f14f
Diff: https://reviews.apache.org/r/67381/diff/2/
Changes: https://reviews.apache.org/r/67381/diff/1-2/
Testing
---
Not a code change.
Thanks,
Qian Zhang
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
215e32461e851668247f9fae62aa656f5dd5e245
Diff: https://reviews.apache.org/r/67343/diff/4/
Changes: https://reviews.apache.org/r/67343/diff/3-4/
Testing
---
sudo make check
Thanks,
Qian Zhang
e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/3/
Changes: https://reviews.apache.org/r/67342/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
that.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67342/#review204092
---
On May 30, 2018, 9:04 p.m., Q
s://reviews.apache.org/r/67343/diff/3/?file=2032117#file2032117line163>
> >
> > why not const ref?
My bad, thanks for catching this!
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.
/67381/diff/1/
Testing
---
Not a code change.
Thanks,
Qian Zhang
Diff: https://reviews.apache.org/r/67358/diff/2/
Testing (updated)
---
Ran this test repeatedly
Thanks,
Qian Zhang
`CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.
Diffs (updated)
-
src/tests/containerizer/cgroups_isolator_tests.cpp
231e9588c0d831c05a1d84f35f0f68105900789c
Diff: https://reviews.apache.org/r/67358/diff/2/
Changes: https://reviews.apache.org/r/67358/diff/1-2/
Testing
---
Thanks,
Qian Zhang
)
-
docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/2/
Changes: https://reviews.apache.org/r/67342/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/isolators/cgroups/cgroups.cpp
6d663a5770418b7ffe2b3af50b9181ecde183c67
Diff: https://reviews.apache.org/r/67343/diff/3/
Changes: https://reviews.apache.org/r/67343/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
/diff/1/
Testing
---
Thanks,
Qian Zhang
/isolators/cgroups/cgroups.cpp
6d663a5770418b7ffe2b3af50b9181ecde183c67
Diff: https://reviews.apache.org/r/67343/diff/2/
Changes: https://reviews.apache.org/r/67343/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
/cgroups.cpp
6d663a5770418b7ffe2b3af50b9181ecde183c67
Diff: https://reviews.apache.org/r/67343/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/67342/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
change.
Thanks,
Qian Zhang
: https://reviews.apache.org/r/67335/diff/1/
Testing
---
Not a code change.
Thanks,
Qian Zhang
Thanks,
Qian Zhang
: mesos
Description
---
Added `windows/cpu` and `windows/mem` isolators into `agent.md`.
Diffs
-
docs/configuration/agent.md af0c0405da54bad748dcf4de1af0d1cad2dd4661
Diff: https://reviews.apache.org/r/67335/diff/1/
Testing
---
Not a code change.
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67317/#review203873
---
Ship it!
Ship It!
- Qian Zhang
On May 25, 2018, 6:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203739
---
Ship it!
Ship It!
- Qian Zhang
On April 27, 2018, 1 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66671/#review203738
---
Ship it!
Ship It!
- Qian Zhang
On April 17, 2018, 11:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66670/#review203736
---
Ship it!
Ship It!
- Qian Zhang
On April 17, 2018, 11:23 p.m
> On May 24, 2018, 4:24 p.m., Qian Zhang wrote:
> > Ship It!
A minor comment, since we fixed a tech debt (memory leak) in
`ComposingContainerizerProcess::__recover()` in this patch, can you please
mention it in the commit message?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8/#review203734
---
Ship it!
Ship It!
- Qian Zhang
On April 17, 2018, 11:23 p.m
> On May 21, 2018, 9:21 p.m., Qian Zhang wrote:
> > Can you please explain how the container will be cleaned up from the
> > `containers_` map after agent recovery?
>
> Andrei Budnik wrote:
> In the current implementation, a recovered container can be cleaned up
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67135/#review203567
---
Ship it!
Ship It!
- Qian Zhang
On May 16, 2018, 12:10 a.m
Lines 2635 (patched)
<https://reviews.apache.org/r/65505/#comment285850>
Can you please elaborate a bit on why it does a destroy?
- Qian Zhang
On April 27, 2018, 1 a.m., Andrei Budnik wrote:
>
> ---
> This is an automatica
/containerizer.hpp
Line 131 (original), 131 (patched)
<https://reviews.apache.org/r/67130/#comment285849>
Can we just remove this line?
- Qian Zhang
On May 15, 2018, 9:50 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically g
901 - 1000 of 2373 matches
Mail list logo
