Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-29 Thread Sivaram Kannan
whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-29 Thread Sivaram Kannan
-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-29 Thread Sivaram Kannan
user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-29 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-29 Thread Sivaram Kannan
/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-29 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-29 Thread Sivaram Kannan
ks. - Sivaram --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/#review150744 --- On Sept. 27, 2016, 7:59 p.m., Sivar

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-29 Thread Sivaram Kannan
/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-29 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-29 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-29 Thread Sivaram Kannan
sit: https://reviews.apache.org/r/52311/#review150743 --- On Sept. 29, 2016, 6:51 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 52392: Switch the uid to passed user before spawning the process.

2016-09-29 Thread Sivaram Kannan
the uid to passed user before spawning the process. Diffs - Diff: https://reviews.apache.org/r/52392/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-29 Thread Sivaram Kannan
/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-05 Thread Sivaram Kannan
://reviews.apache.org/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-10-05 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-10-05 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan
--- Read user details passed in executorInfo and assign it to user flag. Diffs - src/slave/container_loggers/lib_logrotate.cpp 1c170e5d11ef31d468b200c2c4cbd27abeeb418a Diff: https://reviews.apache.org/r/52096/diff/ Testing --- Thanks, Sivaram Kannan

Review Request 52095: Add the new flag for executor launching with different user.

2016-09-20 Thread Sivaram Kannan
/diff/ Testing --- Thanks, Sivaram Kannan

Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
--- Functionality to switch user when executor launches as non-root user. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52097/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52095: Add the new flag for executor launching with different user.

2016-09-20 Thread Sivaram Kannan
/container_loggers/logrotate.hpp f906a167f8897385af5f54e1e77cb790121a Diff: https://reviews.apache.org/r/52095/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
://reviews.apache.org/r/52097/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan
: https://reviews.apache.org/r/52096/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52095: Add the new flag for executor launching with different user.

2016-09-20 Thread Sivaram Kannan
/slave/container_loggers/logrotate.hpp f906a167f8897385af5f54e1e77cb790121a Diff: https://reviews.apache.org/r/52095/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52096/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52097: Functionality to switch user when executor launches as non-root user.

2016-09-20 Thread Sivaram Kannan
: https://reviews.apache.org/r/52097/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-09-30 Thread Sivaram Kannan
and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-09-30 Thread Sivaram Kannan
and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-09-30 Thread Sivaram Kannan
. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-09-27 Thread Sivaram Kannan
-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-09-27 Thread Sivaram Kannan
/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52309: Pass the user variable from library to binary.

2016-09-27 Thread Sivaram Kannan
. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-27 Thread Sivaram Kannan
--- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-09-27 Thread Sivaram Kannan
-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-27 Thread Sivaram Kannan
as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-09-27 Thread Sivaram Kannan
-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-30 Thread Sivaram Kannan
user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Fix removed empty lines from slave.cpp.

2016-09-30 Thread Sivaram Kannan
rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-30 Thread Sivaram Kannan
/r/52311/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-09-30 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Set the user to stderr-logger binary too.

2016-09-30 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Set the executorInfo user before the custom executor code flow.

2016-09-30 Thread Sivaram Kannan
/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 52424: Fix removed empty lines from slave.cpp.

2016-09-30 Thread Sivaram Kannan
empty lines from slave.cpp. Diffs - Diff: https://reviews.apache.org/r/52424/diff/ Testing --- Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid to passed user before spawning the process.

2016-09-30 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-01 Thread Sivaram Kannan
rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-01 Thread Sivaram Kannan
. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-07 Thread Sivaram Kannan
whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-11-07 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-07 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-11-14 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-14 Thread Sivaram Kannan
/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-14 Thread Sivaram Kannan
whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-14 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-15 Thread Sivaram Kannan
tps://reviews.apache.org/r/53473/#comment226008> Does not make much sense to run docker containrizer with anyother user other than root right?? - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is a

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-16 Thread Sivaram Kannan
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-11-17 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-17 Thread Sivaram Kannan
: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-17 Thread Sivaram Kannan
whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-17 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-15 Thread Sivaram Kannan
tps://reviews.apache.org/r/53699/#comment226006> Should I remove the below function? - Sivaram Kannan On Nov. 14, 2016, 9:51 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-15 Thread Sivaram Kannan
) <https://reviews.apache.org/r/53473/#comment226007> Passing None() has the agent crashing when we have switch_user=false. - Sivaram Kannan On Nov. 14, 2016, 9:52 p.m., Sivaram Kannan wrote: > > --- > This is an automatica

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-15 Thread Sivaram Kannan
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashi

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-16 Thread Sivaram Kannan
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-17 Thread Sivaram Kannan
: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-15 Thread Sivaram Kannan
> On Nov. 15, 2016, 2:42 p.m., Sivaram Kannan wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1388 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563497#file1563497line1388> > > > > Passing None() has the agent crashing when we hav

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-14 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-11-14 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53473: Add new param user to logrotate's prepare function.

2016-11-14 Thread Sivaram Kannan
whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-14 Thread Sivaram Kannan
: https://reviews.apache.org/r/53699/diff/ Testing --- Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-11-02 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-02 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-11-02 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-11-02 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-31 Thread Sivaram Kannan
/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

2016-10-31 Thread Sivaram Kannan
Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

2016-10-31 Thread Sivaram Kannan
/mesos-tests.sh Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

2016-10-31 Thread Sivaram Kannan
Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53306: Modify prepare function of logrotate to accept new param user.

2016-10-31 Thread Sivaram Kannan
, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Review Request 53305: Add new param user to logrotate's prepare function.

2016-10-31 Thread Sivaram Kannan
, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-10-31 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-10-31 Thread Sivaram Kannan
/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

2016-10-31 Thread Sivaram Kannan
Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53306: Modify prepare function of logrotate to accept new param user.

2016-10-31 Thread Sivaram Kannan
, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

2016-10-31 Thread Sivaram Kannan
Thanks, Sivaram Kannan

Re: Review Request 52309: Pass the user variable from library to binary.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52309/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

2016-10-31 Thread Sivaram Kannan
://reviews.apache.org/r/52308/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

2016-10-31 Thread Sivaram Kannan
Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan

Re: Review Request 53305: Add new param user to logrotate's prepare function.

2016-10-31 Thread Sivaram Kannan
-tests.sh Thanks, Sivaram Kannan

  1   2   >