---
manual testing;
Running the included test without patching `scheduler.cpp` -> fails as the
master does in fact receive two SUBSCRIBE requests.
`make check`
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69721/#review212036
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 14, 2019, 7:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69720/#review212037
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 14, 2019, 7:54
---
Dont review - just a test!
Thanks,
Till Toenshoff
: mesos
Description
---
Tester.
Diffs (updated)
-
configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4
Diff: https://reviews.apache.org/r/69694/diff/3/
Changes: https://reviews.apache.org/r/69694/diff/2-3/
Testing
---
Dont review - just a test!
Thanks,
Till Toenshoff
!
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69701/#review211778
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 9, 2019, 3:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69698/#review211777
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 9, 2019, 9:35
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69697/#review211776
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 9, 2019, 9:30
- just a test!
Diffs
-
configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4
Diff: https://reviews.apache.org/r/69694/diff/1/
Testing
---
Dont review - just a test!
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69608/#review211497
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 21, 2018, 2:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69591/#review211437
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 19, 2018, 6:11
ms to be the most relevant part of this test - checking with and
without this flag enabled. Maybe we should add a comment here?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 2569 (patched)
<https://reviews.apache.org/r/69590/#comment296500>
Either remove these two please or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69559/#review211397
---
Ship it!
Ship It!
- Till Toenshoff
On Dec. 17, 2018, 3:55
> On Dec. 17, 2018, 12:52 p.m., Till Toenshoff wrote:
> > support/verify-reviews.py
> > Lines 277 (patched)
> > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line296>
> >
> > Python's way of `contains` for a dic
r/69559/#comment296362>
Does this mean that if a RR changed in the chain that was not the last one,
that we wont run validate the chain?
Can you please explain the consequences in the comment?
- Till Toenshoff
On Dec. 13, 2018, 3:59 p.m., Armand Grillet wrote:
>
> -
s/src/tests/jwt_tests.cpp
Lines 464 (patched)
<https://reviews.apache.org/r/69412/#comment295729>
s/Thread/thread/
- Till Toenshoff
On Nov. 20, 2018, 2:51 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generat
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G
Ninja && ninja tests -j12
```
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69442/#review210843
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 24, 2018, 1:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69441/#review210842
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 24, 2018, 5:22
> On Nov. 24, 2018, 1:17 a.m., Till Toenshoff wrote:
> > Thanks for adding this Benjamin - also thanks James for reviewing!
Just realized that we should consider moving this into stout, no?
- Till
---
This is an automatically
this blank OR add more blsnks to the rest to make the entire
picture a bit more consistent.
Adjusting while committing - leaving this open for your entertainment.
- Till Toenshoff
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> ---
.
Thanks,
Till Toenshoff
/posix_rlimits_isolator_tests.cpp
Lines 138-142 (patched)
<https://reviews.apache.org/r/69438/#comment295595>
Thanks, that will help others to understand the failure before going
through debug-hell :)
- Till Toenshoff
On Nov. 23, 2018, 11 p.m., Benjamin Bannier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69311/#review210707
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 14, 2018, 1:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69312/#review210706
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 11, 2018, 12:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69313/#review210705
---
Ship it!
- Till Toenshoff
On Nov. 11, 2018, 12:01 a.m
luster.cpp 2b351ca70d8e80008e49722aa7d46918b5ecd9b0
src/tests/logging_tests.cpp 30bcdc7f4aa9d6a39c5ef6e825357815bf4f9f19
Diff: https://reviews.apache.org/r/69405/diff/1/
Testing
---
`make check` and internal CI
Thanks,
Till Toenshoff
_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0
Diff: https://reviews.apache.org/r/69384/diff/2/
Changes: https://reviews.apache.org/r/69384/diff/1-2/
Testing
---
make check and private ci
Thanks,
Till Toenshoff
)
<https://reviews.apache.org/r/69368/#comment295376>
Lacks period.
- Till Toenshoff
On Nov. 18, 2018, 10:48 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
: mesos
Description
---
Added test for ACCESS_MESOS_LOG authorization.
Diffs
-
src/tests/authorization_tests.cpp ac52181aa29bb5a5e4197cd90f32330aeb59385f
Diff: https://reviews.apache.org/r/69386/diff/1/
Testing
---
`make check` and internal CI
Thanks,
Till Toenshoff
fa7ef71e059441fb171aff6
src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb
Diff: https://reviews.apache.org/r/69385/diff/1/
Testing
---
`make check` and internal CI validation
Thanks,
Till Toenshoff
384/diff/1/
Testing
---
make check and private ci
Thanks,
Till Toenshoff
---
`make check` before applying the fix for MESOS-9317 and after doing so.
Thanks,
Till Toenshoff
Testing
---
`make check` and internal CI validation.
Thanks,
Till Toenshoff
9457f648a0
Diff: https://reviews.apache.org/r/69369/diff/2/
Changes: https://reviews.apache.org/r/69369/diff/1-2/
Testing
---
`make check` and internal CI validation.
Thanks,
Till Toenshoff
/
Testing
---
`make check` before applying the fix for MESOS-9317 and after doing so.
Thanks,
Till Toenshoff
andler.cpp 222ec754e216da195250d1895a728294a076ee5d
src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0
Diff: https://reviews.apache.org/r/69369/diff/1/
Testing
---
`make check` and internal CI validation.
Thanks,
Till Toenshoff
failed.
Diffs
-
src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0
Diff: https://reviews.apache.org/r/69368/diff/1/
Testing
---
`make check` before applying the fix for MESOS-9317 and after doing so.
Thanks,
Till Toenshoff
.org/r/69324/
> ---
>
> (Updated Nov. 13, 2018, 5:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Removed some unnecessary intermediate build variables.
>
>
> Diffs
>
mistakes less likely, great
improvement.
- Till Toenshoff
On Nov. 13, 2018, 5:01 a.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69224/#review210255
---
Ship it!
Ship It!
- Till Toenshoff
On Nov. 1, 2018, 3:15
he.org/r/69140/#review209976
---
On Oct. 30, 2018, 8:20 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
that
one then as well... NOTED
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69140/#review209976
---
On Oct. 30, 2018, 8:20 p.m.,
cmake .. -DUNBUNDLED_LIBARCHIVE=OFF
cmake .. -DUNBUNDLED_LIBARCHIVE=ON
-DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive
cmake ..
Thanks,
Till Toenshoff
/diff/1/
Testing
---
```
cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON
-DENABLE_LIBEVENT=ON -G Ninja
```
Thanks,
Till Toenshoff
a2c0dd12e34ae739be85885fd815514f7d3d59a5
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68812/diff/3/
Changes: https://reviews.apache.org/r/68812/diff/2-3/
Testing
---
make check
Thanks,
Till Toenshoff
/examples/CMakeLists.txt a2c0dd12e34ae739be85885fd815514f7d3d59a5
src/examples/inverse_offer_framework.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68812/diff/2/
Changes: https://reviews.apache.org/r/68812/diff/1-2/
Testing
---
make check
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69160/#review210096
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 25, 2018, 10:54
> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote:
> > src/tests/fetcher_tests.cpp
> > Lines 105-106 (patched)
> > <https://reviews.apache.org/r/69146/diff/2/?file=2102314#file2102314line105>
> >
> > While this solution appears to be the most
> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote:
> > src/tests/fetcher_tests.cpp
> > Lines 105-106 (patched)
> > <https://reviews.apache.org/r/69146/diff/2/?file=2102314#file2102314line105>
> >
> > While this solution appears to be the most
ts job.
```
path::join(os::getcwd(), "fetcher");
path::join(os::getcwd(), "frameworks");
```
would be consistent.
Alternatively, we could at least do away with one `CHECK_NOTNONE` and pull
it in front of these two uses of `sandbox`.
- Till Toenshoff
On Oct.
tps://reviews.apache.org/r/69140/#comment294607>
Created https://issues.apache.org/jira/browse/MESOS-9351 for tracking this
effort. Will tackle that soonish...
- Till Toenshoff
On Oct. 24, 2018, 12:25 p.m., Till Toenshoff
)
<https://reviews.apache.org/r/69140/#comment294604>
Am a bit unsure about this specific change and would appreciate a
windows-feedback :)
- Till Toenshoff
On Oct. 24, 2018, 12:25 p.m., Till Toenshoff wrote:
>
> ---
5d2be0adc55ac5302c2e0e62131feb65657466be
Diff: https://reviews.apache.org/r/69140/diff/1/
Testing
---
cmake .. -DUNBUNDLED_LIBARCHIVE=ON
cmake .. -DUNBUNDLED_LIBARCHIVE=OFF
cmake .. -DUNBUNDLED_LIBARCHIVE=ON
-DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive
cmake ..
Thanks,
Till Toenshoff
b3ecc8c9a34ef07
Diff: https://reviews.apache.org/r/69075/diff/4/
Changes: https://reviews.apache.org/r/69075/diff/3-4/
Testing
---
`make check`
`sudo ./bin/mesos-tests.sh
--gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system wit
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69075/#review209868
-------
On Oct. 22, 2018, 11:22 a.m., Till Toenshoff wrote:
>
> --
iews.apache.org/r/69075/diff/3/
Changes: https://reviews.apache.org/r/69075/diff/2-3/
Testing
---
`make check`
`sudo ./bin/mesos-tests.sh
--gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system with curl 7.59.0 installed.
Thanks,
Till Toenshoff
tps://reviews.apache.org/r/69075/#comment294339>
As discussed with James, HTTP 1.0 may be introducing new imcompatibilities
with certain proxy setups.
We should instead use --http1.1 when available, fallback to --http1.0 if
not.
- Till Toenshoff
On Oct. 18, 2018, 11:41 p.m., Till Toe
ws.apache.org/r/69075/diff/1-2/
Testing (updated)
---
`make check`
`sudo ./bin/mesos-tests.sh
--gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system with curl 7.59.0 installed.
Thanks,
Till Toenshoff
pdated)
---
WIP - needs CENTOS 7 fixup - DO NOT COMMIT
`make check`
`sudo ./bin/mesos-tests.sh
--gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system with curl 7.59.0 installed.
Thanks,
Till Toenshoff
_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"`
on a system with curl 7.59.0 installed.
Thanks,
Till Toenshoff
/http.hpp
Lines 568-569 (patched)
<https://reviews.apache.org/r/68992/#comment294129>
As discussed out of band, let's come up with a proper story here in a JIRA
first and then get back to it.
- Till Toenshoff
On Oct. 11, 2018, 2:16 p.m., Alexander Rukl
t; ---
>
> (Updated Oct. 11, 2018, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler,
> Gastón Kleiman, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Desc
Lines 353-354 (patched)
<https://reviews.apache.org/r/68993/#comment294139>
Thanks for the TODO.
- Till Toenshoff
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68994/#review209611
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 11, 2018, 2:16
Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68994/
> ---
>
> (Updated Oct. 11, 2018, 2:16 p.m.)
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68970/#review209406
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 10, 2018, 5:21
)
<https://reviews.apache.org/r/68951/#comment293632>
IIUC, then `sys.executable` may be `None`. Shall we guard against that?
- Till Toenshoff
On Oct. 8, 2018, 6:06 p.m., Armand Grillet wrote:
>
> ---
> This is an automatica
for the user.
However, I also guess on the other hand that "Checking..." stuff is useful if
the linting introduces a considerable delay - which in my experience actually
can happen in cases where changes happened on our monster "master.cpp".
Thanks again!
- Till Toenshoff
O
> On Oct. 5, 2018, 2:24 p.m., Till Toenshoff wrote:
> > Thanks a bunch Armand. Can we please have the same for "apple-reviews.py"?
Jeez - sorry for this confusion - here some more orderly feedback:
Before applying your patch:
```
Checking 1 C++ file
Done processing 3rdparty
for "apple-reviews.py"?
- Till Toenshoff
On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On Oct. 5, 2018, 2:17 p.m., Till Toenshoff wrote:
> > support/mesos-style.py
> > Line 229 (original)
> > <https://reviews.apache.org/r/68937/diff/1/?file=2094915#file2094915line230>
> >
> > Why is this not needed anymore?
Ah, now understood -- sorry
tps://reviews.apache.org/r/68937/#comment293559>
Why is this not needed anymore?
- Till Toenshoff
On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68936/#review209254
---
Ship it!
Ship It!
- Till Toenshoff
On Oct. 5, 2018, 9:10
h and without bundled libevent.
Tested combinations were:
macOS 10.14.1 - libevent 2.2
macOS 10.14.1 - libevent 2.1.8
macOS 10.14.1 - libevent 2.0.22
Ubuntu 16.04 - libevent 2.1.8
Thanks,
Till Toenshoff
ninja check -j12
Thanks,
Till Toenshoff
3a7fcad7d0c2d967fb308714c4b1f631c988001b
Diff: https://reviews.apache.org/r/68916/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
://reviews.apache.org/r/68915/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
check
Thanks,
Till Toenshoff
/r/68916/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
://reviews.apache.org/r/68914/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
://reviews.apache.org/r/68913/diff/1/
Testing
---
make check
Thanks,
Till Toenshoff
generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205395
-------
On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.
buntu 16.04 - libevent 2.1.8
Thanks,
Till Toenshoff
3a7fcad7d0c2d967fb308714c4b1f631c988001b
Diff: https://reviews.apache.org/r/68905/diff/1/
Testing
---
make check on macOS 10.14.1 with and without bundled libevent.
Thanks,
Till Toenshoff
://reviews.apache.org/r/68904/diff/1/
Testing
---
make check on macOS 10.14.1 with and without bundled libevent.
Thanks,
Till Toenshoff
.
Repository: mesos
Description
---
Fixed libevent M4 macro to be fully compatible with older autoconf.
Diffs
-
3rdparty/libprocess/m4/libevent.m4 b8462f810a87b0144d479c37927fcb1a5f3475e8
Diff: https://reviews.apache.org/r/68857/diff/1/
Testing
---
Thanks,
Till Toenshoff
.
Repository: mesos
Description
---
Fixed libevent M4 macro to be fully compatible with older autoconf.
Diffs
-
m4/libevent.m4 b8462f810a87b0144d479c37927fcb1a5f3475e8
Diff: https://reviews.apache.org/r/68858/diff/1/
Testing
---
Thanks,
Till Toenshoff
/
Changes: https://reviews.apache.org/r/68856/diff/1-2/
Testing
---
CI and make check
Thanks,
Till Toenshoff
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68856/#review209052
---
On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote:
>
>
------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68856/#review209048
---
On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote:
>
> ---
.
Repository: mesos
Description
---
Added missing python egg build extensions for libevent.
Diffs
-
src/python/native_common/ext_modules.py.in
7efbb8ec91b74c32ac629f1f2e7de82986d518db
Diff: https://reviews.apache.org/r/68856/diff/1/
Testing
---
CI and make check
Thanks,
Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68816/#review209026
---
Ship it!
Ship It!
- Till Toenshoff
On Sept. 23, 2018, 7:32
> On Sept. 26, 2018, 2:42 p.m., Till Toenshoff wrote:
> > Ship It!
Modulo CI issues.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68816/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68817/#review209025
---
Ship it!
Ship It!
- Till Toenshoff
On Sept. 23, 2018, 7:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68819/#review209024
---
Ship it!
Ship It!
- Till Toenshoff
On Sept. 23, 2018, 7:32
/
Testing
---
Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing is
ongoing. CMake updates will follow.
Thanks,
Till Toenshoff
/
Testing
---
make check
Thanks,
Till Toenshoff
2089808#file2089808line94>
> >
> > Use `AS_IF` consistently here?
Thanks!
- Till
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68640/#review208863
--
101 - 200 of 1274 matches
Mail list logo
