/diff/
Testing
---
Thanks,
haosdent huang
/diff/
Testing
---
Thanks,
haosdent huang
: mesos
Description
---
Updated mesos_logo_fb_preview.png.
Diffs (updated)
-
site/source/assets/img/mesos_logo_fb_preview.png
8dc5fa57576a6e89df9e9f6efe0930bee3041d33
Diff: https://reviews.apache.org/r/52663/diff/
Testing
---
Thanks,
haosdent huang
mesos_logo_fb_preview.png.
Diffs
-
site/source/assets/img/mesos_logo_fb_preview.png
8dc5fa57576a6e89df9e9f6efe0930bee3041d33
Diff: https://reviews.apache.org/r/52663/diff/
Testing
---
Thanks,
haosdent huang
.
Repository: mesos
Description
---
Fixed incorrect link in getting-started document.
Diffs
-
docs/getting-started.md de3fba4a821ca7fa9b9e2fd692b33b40edd35b68
Diff: https://reviews.apache.org/r/52662/diff/
Testing
---
Thanks,
haosdent huang
b2092- (default) at
scheduler-ed39be00-91ea-4b3f-85a1-59f1cf6075df@127.0.0.1:57221 disconnected
```
Thanks,
haosdent huang
rizer/cgroups_isolator_tests.cpp
f1035a0b505a8db7fd495a586e7ce3c23914250a
Diff: https://reviews.apache.org/r/52244/diff/
Testing
---
Thanks,
haosdent huang
/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d
src/tests/containerizer/cgroups_tests.cpp
0afaec6ae948cabf1472bf01103210d8f9809cb1
src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2
Diff: https://reviews.apache.org/r/51031/diff/
Testing
---
Thanks,
haosdent
_tests.cpp 26f99f7c337fbbc5278d1b30d3d5c8f659ddf5ca
Diff: https://reviews.apache.org/r/51624/diff/
Testing
---
Added a new test case `AgentAPITest.GetAgent`.
Thanks,
haosdent huang
ter/static/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
: https://reviews.apache.org/r/52470/diff/
Testing (updated)
---
Add a new test case `CommandExecutorTest.EmptyExecutorIdInTask`.
Thanks,
haosdent huang
p.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
diff/
Testing
---
Thanks,
haosdent huang
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151854
---
On Oct. 7, 2016, 6:09 p.m., haosdent huang wrote:
>
> ---
> This is an automatically gen
79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
/home.html 179cb15140f85811df0ea0a87620dd3c90dd30c7
src/webui/master/static/js/app.js 400a4286d9358c699453326d87a0bd49dbb105a7
src/webui/master/static/js/controllers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
haosdent huang
p.cpp 79061c3cd94d856ec695e5a82bf6792bf089d1f8
src/tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
/52560/diff/
Testing
---
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52563/diff/
Testing
---
```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*"
--gtest_also_run_disabled_tests
[--] Global test environment tear-down
[==] 19 tests from 1 test case ran. (35264 ms total)
[ PASSED ] 19 tests.
```
Thanks,
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
SED ] 19 tests.
```
Thanks,
haosdent huang
g/r/51700/#comment220112>
`protobuf::master::event::model(*framework)` should be enough?
src/master/http.cpp (line 1411)
<https://reviews.apache.org/r/51700/#comment220113>
`protobuf::master::event::model(*framework)` should be enough?
- haosdent huang
On Oct. 4, 2016, 2:44
org/r/52516/#comment220099>
Append
```
slave->reset();
```
above?
- haosdent huang
On Oct. 5, 2016, 11:48 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52515/#review151652
---
Ship it!
Ship It!
- haosdent huang
On Oct. 5, 2016, 11:47
://reviews.apache.org/r/52563/diff/
Testing
---
```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*"
--gtest_also_run_disabled_tests
[--] Global test environment tear-down
[==] 19 tests from 1 test case ran. (35264 ms total)
[ PASSED ] 19 tests.
```
Thanks,
/52560/diff/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
)
---
```
sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest.*"
--gtest_also_run_disabled_tests
[--] Global test environment tear-down
[==] 19 tests from 1 test case ran. (35264 ms total)
[ PASSED ] 19 tests.
```
Thanks,
haosdent huang
: mesos
Description
---
* Replace `Testing` to `Tests` in comments.
* Remove redundant `.Times(1)`.
Diffs
-
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52563/diff/
Testing
---
Thanks,
haosdent huang
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
: mesos
Description
---
Renamed `flags` to `agentFlags` in health check test cases.
Diffs
-
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52561/diff/
Testing
---
Thanks,
haosdent huang
: mesos
Description
---
Avoided temporary `MockDocker` pointers in health check test cases.
Diffs
-
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52560/diff/
Testing
---
Thanks,
haosdent huang
eviews.apache.org/r/52252/#review151515
---
On Oct. 5, 2016, 4:10 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52252/
> --
t; Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.
>
>
> Diffs
> -
>
> src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96
>
> Diff: https://reviews.apache.org/r/52252/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> haosdent huang
>
>
r TCP health check.
Diffs (updated)
-
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
(updated)
-
src/tests/health_check_tests.cpp 1d1676d7259bf52cfb1e499954fa815fe7e37522
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52253/diff/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52253/diff/
Testing
---
Thanks,
haosdent huang
f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52253/diff/
Testing
---
Thanks,
haosdent huang
tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
s.cpp f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
s.cpp f4a63e2f5def022bf4469920861e6a5af229af96
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
Diff: https://reviews.apache.org/r/52253/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52432/#review151496
---
Ship it!
Ship It!
- haosdent huang
On Oct. 5, 2016, 1 p.m
tps://reviews.apache.org/r/52432/#comment219913>
Add
```
EXPECT_FALSE(statusRunning.get().has_healthy());
```
here as well?
- haosdent huang
On Oct. 5, 2016, 12:37 p.m., Gastón Kleiman wrote:
>
> ---
> This is a
tps://reviews.apache.org/r/52432/#comment219899>
Should be
```
AWAIT_READY(statusRunning);
EXPECT_EQ(TASK_RUNNING, statusRunning.get().state());
```
here.
- haosdent huang
On Sept. 30, 2016, 6:12 p.m., Gastón Kleiman
tps://reviews.apache.org/r/51605/#comment219898>
I saw in other source files, the header files of `.h` come first.
- haosdent huang
On Oct. 4, 2016, 1:54 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52431/#review151479
---
Ship it!
Ship It!
- haosdent huang
On Sept. 30, 2016, 5:15
t; > path to exist? Morever, I think it's worthwhile for people to have access
> > to executor sandbox through the WebUI.
> >
> > Maybe we should keep AgetExecutorRerouteCtrl and add a new
> > AgentTaskRerouterCtrl.
>
> haosdent huang wrote:
> Hi
> On Sept. 2, 2016, 4:53 p.m., haosdent huang wrote:
> > src/Makefile.am, line 1377
> > <https://reviews.apache.org/r/51605/diff/1/?file=1490602#file1490602line1377>
> >
> > I think the name `mesos-tcp-connect` may be not clear enough. Should we
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51606/#review151359
---
Ship it!
Ship It!
- haosdent huang
On Oct. 4, 2016, 1:55
> On Sept. 6, 2016, 3:31 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, lines 155-159
> > <https://reviews.apache.org/r/51606/diff/1/?file=1490609#file1490609line155>
> >
> > I think we need to put this after `M
diff/
Testing
---
Thanks,
haosdent huang
tests/default_executor_tests.cpp 9e0fd678a7f5e9c2288fbb11a60cf6f339efa24f
Diff: https://reviews.apache.org/r/52520/diff/
Testing
---
Thanks,
haosdent huang
02a2fb29bdd8484fc90e5cb033ac29b49a141860
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
So when Web UI use the task id to
search the executor, it would fail.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52470/#review151238
-------
On Oct. 3, 2016, 2:56 a.m., haosdent huan
routeCtrl` would be useful so that we don't need to add it back
at that time.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52471/#review151236
------
rollers.js
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4
Diff: https://reviews.apache.org/r/52471/diff/
Testing
---
Thanks,
haosdent huang
c83ee2f9fa05372748ff5056229fbe2bf06bfabb
Diff: https://reviews.apache.org/r/52470/diff/
Testing
---
Thanks,
haosdent huang
/r/52470/diff/
Testing
---
Thanks,
haosdent huang
> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote:
> > site/source/layouts/documentation.erb, lines 15-19
> > <https://reviews.apache.org/r/52064/diff/1/?file=1503011#file1503011line15>
> >
> > Any reason that we add a back button instead of using the back
> On Sept. 30, 2016, 5:23 p.m., haosdent huang wrote:
> > It is flaky in slow machine because advance Clock before statusUpdate. May
> > refer to https://reviews.apache.org/r/47089/diff/3#index_header about how
> > to fix it.
Never mind, I discard that stal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52434/#review151041
---
Ship it!
Ship It!
- haosdent huang
On Sept. 30, 2016, 5:15
statusUpdate. May
refer to https://reviews.apache.org/r/47089/diff/3#index_header about how to
fix it.
- haosdent huang
On Sept. 30, 2016, 5:15 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To rep
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52431/#review151037
---
Ship it!
Ship It!
- haosdent huang
On Sept. 30, 2016, 5:15
/
Testing
---
Thanks,
haosdent huang
/r/52253/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
s.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3
Diff: https://reviews.apache.org/r/52251/diff/
Testing
---
Thanks,
haosdent huang
Diff: https://reviews.apache.org/r/52250/diff/
Testing
---
Thanks,
haosdent huang
tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3
Diff: https://reviews.apache.org/r/52253/diff/
Testing
---
Thanks,
haosdent huang
tests/health_check_tests.cpp 5702f452d1ed9add4fdf85dd641b86aec56d29a3
Diff: https://reviews.apache.org/r/52252/diff/
Testing
---
Thanks,
haosdent huang
/linux/cgroups.cpp 1475c8eb848ece2a093e8243b51e9ce08981dd7d
src/tests/containerizer/cgroups_tests.cpp
0afaec6ae948cabf1472bf01103210d8f9809cb1
src/tests/mesos.cpp 2aae160fb941ab3672a5665ae27f517ff40600e2
Diff: https://reviews.apache.org/r/51031/diff/
Testing
---
Thanks,
haosdent
ve::Flags flags = CreateSlaveFlags();
flags.isolation = "posix/cpu,posix/mem";
Owned detector = master.get()->createDetector();
Try> agent = StartSlave(detector.get());
ASSERT_SOME(agent);
```
- haosdent huang
On Sept. 29, 2016,
Description
---
Updated the document link of 'Image Provisioning Design'.
Diffs
-
docs/design-docs.md 2908181a432916a4069b8ca3f8eff93d6219f2a6
Diff: https://reviews.apache.org/r/52395/diff/
Testing
---
Thanks,
haosdent huang
iew150756
---
On Sept. 29, 2016, 4:21 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
/mesos.proto 2209ea2fb0bf39c773d60f8a0eea865320a03bb6
include/mesos/v1/mesos.proto 00c623450268a990d48b4e119aa9429fabf2f135
Diff: https://reviews.apache.org/r/51803/diff/
Testing
---
Thanks,
haosdent huang
/health_check_tests.cpp e6b02f23dc1b1b84381ab0af0e3df5918b60ae40
Diff: https://reviews.apache.org/r/52301/diff/
Testing
---
Thanks,
haosdent huang
bal test environment tear-down
[==] 1 test from 1 test case ran. (1005 ms total)
[ PASSED ] 1 test.
```
Thanks,
haosdent huang
/mesos.proto 2209ea2fb0bf39c773d60f8a0eea865320a03bb6
include/mesos/v1/mesos.proto 00c623450268a990d48b4e119aa9429fabf2f135
Diff: https://reviews.apache.org/r/51803/diff/
Testing
---
Thanks,
haosdent huang
nvironment tear-down
[==] 1 test from 1 test case ran. (1005 ms total)
[ PASSED ] 1 test.
```
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150749
---
Ship it!
Ship It!
- haosdent huang
On Sept. 28, 2016, 6:22
terRedirectPath +
"/")) {
```
src/master/http.cpp (line 2045)
<https://reviews.apache.org/r/52105/#comment218804>
Comment need to end with `.`
- haosdent huang
On Sept. 28, 2016, 5:56 p.m., Charles Allen wrote:
>
> ---
> On Sept. 24, 2016, 8:02 p.m., haosdent huang wrote:
> > src/master/http.cpp, lines 2046-2048
> > <https://reviews.apache.org/r/52105/diff/3/?file=1509354#file1509354line2046>
> >
> > Hi, @drcrallen This comment is not true. As
> > https://github.
add a comment said `` is the grace_period.
Or use `createTask()` instead of `populateTasks`.
src/tests/health_check_tests.cpp (lines 1414 - 1415)
<https://reviews.apache.org/r/52357/#comment218784>
Could remove this if we use
```
os::mktemp(path::join(os::getcwd(), "
501 - 600 of 3998 matches
Mail list logo
