Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

> On March 18, 2016, 6:24 p.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > <https://reviews.apache.org/r/45000/diff/1/?file=1304561#file1304561line959> > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc39

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

t this code was written against. - Ben Whitehead On March 17, 2016, 5:04 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review105333 --- Ship it! Ship It! - Ben Whitehead On Nov. 5, 2015, 3:50 p.m

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

RecordIO not http clients. Please remove this sentence. docs/scheduler-http-api.md (lines 66 - 68) <https://reviews.apache.org/r/39452/#comment161299> These two lines don't flow together very well, a single paragraph should contain the motivation and justification. - Ben White

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 66 > > > > > > Do we need this line anymore now ? This can be killed in favor of the > > following lines that we added around

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 59 > > > > > > Should we also mention why just encoding one event per chunk won't > > suffice and why we needed this ? > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

docs/scheduler-http-api.md (line 59) <https://reviews.apache.org/r/39452/#comment161171> +1 - Ben Whitehead On Oct. 19, 2015, 2:07 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35961/ > --- > > (Updated June 29, 2015, 8:53 a.m.) > > > Review request f

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89605 --- Ship it! Ship It! - Ben Whitehead On June 26, 2015, 6:18 p.m

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

> On June 26, 2015, 6:30 p.m., Ben Whitehead wrote: > > Ship It! Downloaded patch, applied, configure make, Manual Verification. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or