Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/ --- (Updated April 12, 2018, 5:13 a.m.) Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-8761 https://issues.apache.org/jira/browse/MESOS-8761 Repository: mesos Description --- Made FreeBSD default to non-GNU ld. Diffs (updated) - cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c Diff: https://reviews.apache.org/r/66493/diff/3/ Changes: https://reviews.apache.org/r/66493/diff/2-3/ Testing --- make on FreeBSD, with both lld and gold. Thanks, David Forsythe
Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 308-311 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line308>
> >
> > I was briefly wondering why we checked for clang below. The reason is
> > of course that cmake by default uses the compiler as linker, and there is
> > an incompatibility on FreeBSD when compiling with clang and linking with
> > `ld.bfd`.
> >
> > I think it would be useful to describe this in more detail here so we
> > have a chance to understand when this check can go in the future. Ideally
> > we'd be able to link some upstream issue, but it may not exist.
>
> Andrew Schwartzmeyer wrote:
> Yeah, it took me a while to reason through this too, even with your
> comment Benjamin. It's because of how the linker command is formed (described
> [here](https://cmake.org/pipermail/cmake/2014-August/058268.html)). Not
> knowing this will leave you bewildered here.
>
> David Forsythe wrote:
> I'll make the comment a bit more descriptive.
I'm the beginning to think this isn't actually a FreeBSD specific issue, but I
left the comment FreeBSD specific (and left the CMAKE_SYSTEM_NAME check) since
I haven't had anyone tell me they've reproduced it on Linux.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 326-329 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line326>
> >
> > I am not sure this is an issue, but customary there are similar
> > variables defined for other build types like `DEBUG`, `RELEASE`, etc.
> > (e.g., `CMAKE_EXE_LINKER_FLAGS_DEBUG`).
> >
> > Do we have something to set all related flags @andschwa?
>
> Andrew Schwartzmeyer wrote:
> It might soon be time to put this into a function, but yeah, it'd be a
> nested for loop akin to this:
>
> ```
> foreach (lang C CXX)
> list(APPEND CMAKE_${lang}_FORWARD_ARGS
> ${CMAKE_FORWARD_ARGS}
> -DCMAKE_${lang}_COMPILER=${CMAKE_${lang}_COMPILER}
> -DCMAKE_${lang}_COMPILER_LAUNCHER=${CMAKE_${lang}_COMPILER_LAUNCHER}
> -DCMAKE_${lang}_FLAGS=${CMAKE_${lang}_FLAGS})
>
> foreach (config DEBUG RELEASE RELWITHDEBINFO MINSIZEREL)
> list(APPEND CMAKE_${lang}_FORWARD_ARGS
> -DCMAKE_${lang}_FLAGS_${config}=${CMAKE_${lang}_FLAGS_${config}})
> endforeach ()
> endforeach ()
>
> ```
>
> Note that this only matters if you're using a multi-configuration
> generator (like Visual Studio and some other IDEs), but not `make` nor
> `ninja`.
>
> David Forsythe wrote:
> Will switch over to something like that.
I left off the the config loop because it didn't seem like the other flags
being set in this file were using them. It wasn't clear to me if they were
actually needed, so if I should add them just let me know.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200725
---
On April 10, 2018, 6:36 a.m., David Forsythe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66493/
> ---
>
> (Updated April 10, 2018, 6:36 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-8761
> https://issues.apache.org/jira/browse/MESOS-8761
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Made FreeBSD default to non-GNU ld.
>
>
> Diffs
> -
>
> cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c
>
>
> Diff: https://reviews.apache.org/r/66493/diff/2/
>
>
> Testing
> ---
>
> make on FreeBSD, with both lld and gold.
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/ --- (Updated April 10, 2018, 6:36 a.m.) Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-8761 https://issues.apache.org/jira/browse/MESOS-8761 Repository: mesos Description --- Made FreeBSD default to non-GNU ld. Diffs (updated) - cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c Diff: https://reviews.apache.org/r/66493/diff/2/ Changes: https://reviews.apache.org/r/66493/diff/1-2/ Testing --- make on FreeBSD, with both lld and gold. Thanks, David Forsythe
Re: Review Request 66493: Made FreeBSD default to non-GNU ld.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 308-311 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line308>
> >
> > I was briefly wondering why we checked for clang below. The reason is
> > of course that cmake by default uses the compiler as linker, and there is
> > an incompatibility on FreeBSD when compiling with clang and linking with
> > `ld.bfd`.
> >
> > I think it would be useful to describe this in more detail here so we
> > have a chance to understand when this check can go in the future. Ideally
> > we'd be able to link some upstream issue, but it may not exist.
>
> Andrew Schwartzmeyer wrote:
> Yeah, it took me a while to reason through this too, even with your
> comment Benjamin. It's because of how the linker command is formed (described
> [here](https://cmake.org/pipermail/cmake/2014-August/058268.html)). Not
> knowing this will leave you bewildered here.
I'll make the comment a bit more descriptive.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 315 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line315>
> >
> > This conditional seems not needed as cmake will automatically detect if
> > `LD_PROGRAM` was set by the user. Is this a variable we should document as
> > a customization point?
>
> Andrew Schwartzmeyer wrote:
> Do you mean documenting like as an `option(...)` and in the docs, or just
> in the docs? Maybe we should wait until the FreeBSD build is working, and
> then add a doc for it (in which we could also explain the weirdness with
> linkers).
Hm, I didn't realize find_program wouldn't run if I set this on my own. I'll
clean it up.
As for documenting it, I figured that it would be best to wait until the build
was fixed and settled. Even if someone is building on FreeBSD at this point
nothing is really working. It might be a bit pre-mature to start surfacing docs
about the build (which probably means there should be a ticket about
documenting this?).
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 318 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line318>
> >
> > Since this variable will be setable from the outside _Alternative_
> > seems redundant here.
Removed.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 322 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line322>
> >
> > Could we make clearer what a user needs to do to have this check pass?
> > The error message appears too technical to me.
>
> Andrew Schwartzmeyer wrote:
> +1 I have no clue what I would do to get a "non-base LD."
This isn't even accurate since lld is in base. I'll update it.
> On April 9, 2018, 1:13 p.m., Benjamin Bannier wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 326-329 (patched)
> > <https://reviews.apache.org/r/66493/diff/1/?file=1993835#file1993835line326>
> >
> > I am not sure this is an issue, but customary there are similar
> > variables defined for other build types like `DEBUG`, `RELEASE`, etc.
> > (e.g., `CMAKE_EXE_LINKER_FLAGS_DEBUG`).
> >
> > Do we have something to set all related flags @andschwa?
>
> Andrew Schwartzmeyer wrote:
> It might soon be time to put this into a function, but yeah, it'd be a
> nested for loop akin to this:
>
> ```
> foreach (lang C CXX)
> list(APPEND CMAKE_${lang}_FORWARD_ARGS
> ${CMAKE_FORWARD_ARGS}
> -DCMAKE_${lang}_COMPILER=${CMAKE_${lang}_COMPILER}
> -DCMAKE_${lang}_COMPILER_LAUNCHER=${CMAKE_${lang}_COMPILER_LAUNCHER}
> -DCMAKE_${lang}_FLAGS=${CMAKE_${lang}_FLAGS})
>
> foreach (config DEBUG RELEASE RELWITHDEBINFO MINSIZEREL)
> list(APPEND CMAKE_${lang}_FORWARD_ARGS
> -DCMAKE_${lang}_FLAGS_${config}=${CMAKE_${lang}_FLAGS_${config}})
> endforeach ()
> endforeach ()
>
> ```
>
> Note that this only matters if you're using a multi-configuration
> generator (like Visual Studio and some other IDEs), but not `make` nor
> `ninja`.
Will switch over to something like that.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review20
Review Request 66493: Made FreeBSD default to non-GNU ld.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-8761 https://issues.apache.org/jira/browse/MESOS-8761 Repository: mesos Description --- Made FreeBSD default to non-GNU ld. Diffs - cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c Diff: https://reviews.apache.org/r/66493/diff/1/ Testing --- make on FreeBSD, with both lld and gold. Thanks, David Forsythe
Re: Review Request 66387: Link subversion in stout build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66387/ --- (Updated April 5, 2018, 6:42 p.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Link subversion in stout build on FreeBSD. Diffs (updated) - 3rdparty/stout/CMakeLists.txt 5d787d87f0a4b30ba882b24d08118856eb84206b Diff: https://reviews.apache.org/r/66387/diff/2/ Changes: https://reviews.apache.org/r/66387/diff/1-2/ Testing --- Thanks, David Forsythe
Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66385/ --- (Updated April 5, 2018, 6:41 p.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 and MESOS-6849 https://issues.apache.org/jira/browse/MESOS-4176 https://issues.apache.org/jira/browse/MESOS-6849 Repository: mesos Description --- Link execinfo in Glog build on FreeBSD. Diffs (updated) - 3rdparty/CMakeLists.txt 9d0fd552a15387754fb7a27256308ef8beb1e3ed cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c Diff: https://reviews.apache.org/r/66385/diff/3/ Changes: https://reviews.apache.org/r/66385/diff/2-3/ Testing --- Thanks, David Forsythe
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/ --- (Updated April 5, 2018, 6:41 p.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Link libm in ZooKeeper build on FreeBSD. Diffs (updated) - 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 Diff: https://reviews.apache.org/r/66384/diff/2/ Changes: https://reviews.apache.org/r/66384/diff/1-2/ Testing --- Thanks, David Forsythe
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- (Updated April 5, 2018, 6:41 p.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Find sasl2 on non-Windows platforms before trying to link it. Diffs (updated) - 3rdparty/CMakeLists.txt 9d0fd552a15387754fb7a27256308ef8beb1e3ed Diff: https://reviews.apache.org/r/66392/diff/4/ Changes: https://reviews.apache.org/r/66392/diff/3-4/ Testing --- make on FreeBSD Thanks, David Forsythe
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 2:34 p.m.) Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Changes --- Changed `EXTERNAL_MAKE` to `MAKE_PROGRAM`. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Fix 3rdparty build commands for FreeBSD. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 Diff: https://reviews.apache.org/r/66314/diff/4/ Changes: https://reviews.apache.org/r/66314/diff/3-4/ Testing --- make on FreeBSD Thanks, David Forsythe
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 6:45 a.m.) Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Fix 3rdparty build commands for FreeBSD. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 Diff: https://reviews.apache.org/r/66314/diff/3/ Changes: https://reviews.apache.org/r/66314/diff/2-3/ Testing --- make on FreeBSD Thanks, David Forsythe
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. > > David Forsythe wrote: > I took a look at find_program, but I don't think that will solve the > problem. > > We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU > make is a 3rd party application and is actually called and installed as > `gmake`, whereas the system make is actually Pmake (which is incompatible). > > David Forsythe wrote: > I should clarify that there is incompability in a 3rdparty Makefile, not > that the two makes are completely incompatible. > > Particularly there are three issues - LevelDB, libev, and glog. > > LevelDB is always going to fail without `gmake`, because it does not use > autotools. I don't know how we can get around that. > > libev and glog do use autotools. They have some strange behavior when > building, though -- > If I use `cmake --build` they both fail on a bad target (because of an > incompatible Makefile). > If I use (bsd) `make`, they build fine. > If I use `gmake` they both fail (bad target). > > For both the first and third scenario, I can run the commands that are > failing outside of the build and they succeed. > > Accordng to the cache, cmake is using `gmake` as `CMAKE_MAKE_PROGRAM` in > these cases, so it's not clear to me why anything would fail when I do the > whole build with `gmake`. It seems like the build can go make -> gmake, but > not gmake -> make. > > I think the baseline should be having `cmake --build` work, and the only > way I have gotten everything to work as expected is by forcing `gmake` > everywhere. I'm learning Cmake as I go so I could be missing something > obvious to fix this. > > David Forsythe wrote: > I've been thinking about this a bit more, and I think that the best > approach might actually be to just leave the libev and glog calls as make and > leave the conditional gmake call. On FreeBSD we could just tell users to use > `make` instead of cmake build. It seems like a way less intrusive change. > > Thoughts? > > Benjamin Bannier wrote: > I think it should be perfectly fine to use `gmake` if it is available, it > is usually a symlink to `make` anyway. > > The implementation I was thinking of was to add below instead, > > find_program( > GNU_MAKE > NAMES gmake make > DOC "path to GNU make executable") > > if (NOT GNU_MAKE) > message(FATAL_ERROR "Could not find a suitable GNU make executable") > endif() > > David Forsythe wrote: > This would always succeed on FreeBSD (or any system with a make), even if > gmake wasn't installed. It is not a symlink: > > ``` > > root@mesos0:/mesos-build # gmake --version > GNU Make 4.2.1 > ... > root@mesos0:/mesos-build # make --version > usage: make [-BeikNnqrstWwX] > ... > > ``` > > With autotools we didn't run into this because (iirc) so much was > incompatible that I just used/assumed `gmake` for everything. With `cmake` > we're close enough that I think it might be worth it to try and support bsd > make. > > David Forsythe wrote: > I made everything use `gmake`, but I didn't add the check/message because > the check always succeeds. Added a TODO as discussed offline. > > Benjamin Bannier wrote: > There's no guarantee this search will succeed, e.g., no make program > could be installed. Let's check we found _something_ before continuing. You got it. I renamed `GNU_MAKE` to `EXTERNAL_MAKE` since we're just looking for anything that matches. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On April 4, 2018, 6:45 a.m., David Forsythe wrot
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > <https://reviews.apache.org/r/66384/diff/1/?file=1990750#file1990750line154> > > > > Also, if this change should go upstream to ZooKeeper (looks to me like > > it should) then let's make sure it does. Their process is [pretty > > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute). > > > > If you don't want to, I can upstream it. > > David Forsythe wrote: > I can add it to my todo list. > > Andrew Schwartzmeyer wrote: > FWIW I can review/shepherd over on ZooKeeper too, though I can't commit > directly (yet). Michael is pretty good about it though. I opened https://github.com/apache/zookeeper/pull/499 for https://issues.apache.org/jira/browse/ZOOKEEPER-3017 - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200292 --- On April 1, 2018, 2:32 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66384/ > --- > > (Updated April 1, 2018, 2:32 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Link libm in ZooKeeper build on FreeBSD. > > > Diffs > - > > 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 > > > Diff: https://reviews.apache.org/r/66384/diff/1/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
> On April 3, 2018, 4:36 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 267 (patched) > > <https://reviews.apache.org/r/66392/diff/2/?file=1991658#file1991658line267> > > > > This looks good; except I think in generaly it's going to find a shared > > version of `sasl2` not a static. I don't think it really does too much to > > imported targets, as they're not being built, but for accuracy's sake, > > `add_library(sasl2 SHARED IMPORTED GLOBAL)` (unless we really don't know, > > so `UNKNOWN`). Yup. Fixed. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200370 ------- On April 4, 2018, 3:46 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66392/ > --- > > (Updated April 4, 2018, 3:46 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Find sasl2 on non-Windows platforms before trying to link it. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > > > Diff: https://reviews.apache.org/r/66392/diff/3/ > > > Testing > --- > > make on FreeBSD > > > Thanks, > > David Forsythe > >
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- (Updated April 4, 2018, 3:46 a.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Find sasl2 on non-Windows platforms before trying to link it. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 Diff: https://reviews.apache.org/r/66392/diff/3/ Changes: https://reviews.apache.org/r/66392/diff/2-3/ Testing (updated) --- make on FreeBSD Thanks, David Forsythe
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 3:33 a.m.) Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Fix 3rdparty build commands for FreeBSD. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 Diff: https://reviews.apache.org/r/66314/diff/2/ Changes: https://reviews.apache.org/r/66314/diff/1-2/ Testing (updated) --- make on FreeBSD Thanks, David Forsythe
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. > > David Forsythe wrote: > I took a look at find_program, but I don't think that will solve the > problem. > > We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU > make is a 3rd party application and is actually called and installed as > `gmake`, whereas the system make is actually Pmake (which is incompatible). > > David Forsythe wrote: > I should clarify that there is incompability in a 3rdparty Makefile, not > that the two makes are completely incompatible. > > Particularly there are three issues - LevelDB, libev, and glog. > > LevelDB is always going to fail without `gmake`, because it does not use > autotools. I don't know how we can get around that. > > libev and glog do use autotools. They have some strange behavior when > building, though -- > If I use `cmake --build` they both fail on a bad target (because of an > incompatible Makefile). > If I use (bsd) `make`, they build fine. > If I use `gmake` they both fail (bad target). > > For both the first and third scenario, I can run the commands that are > failing outside of the build and they succeed. > > Accordng to the cache, cmake is using `gmake` as `CMAKE_MAKE_PROGRAM` in > these cases, so it's not clear to me why anything would fail when I do the > whole build with `gmake`. It seems like the build can go make -> gmake, but > not gmake -> make. > > I think the baseline should be having `cmake --build` work, and the only > way I have gotten everything to work as expected is by forcing `gmake` > everywhere. I'm learning Cmake as I go so I could be missing something > obvious to fix this. > > David Forsythe wrote: > I've been thinking about this a bit more, and I think that the best > approach might actually be to just leave the libev and glog calls as make and > leave the conditional gmake call. On FreeBSD we could just tell users to use > `make` instead of cmake build. It seems like a way less intrusive change. > > Thoughts? > > Benjamin Bannier wrote: > I think it should be perfectly fine to use `gmake` if it is available, it > is usually a symlink to `make` anyway. > > The implementation I was thinking of was to add below instead, > > find_program( > GNU_MAKE > NAMES gmake make > DOC "path to GNU make executable") > > if (NOT GNU_MAKE) > message(FATAL_ERROR "Could not find a suitable GNU make executable") > endif() > > David Forsythe wrote: > This would always succeed on FreeBSD (or any system with a make), even if > gmake wasn't installed. It is not a symlink: > > ``` > > root@mesos0:/mesos-build # gmake --version > GNU Make 4.2.1 > ... > root@mesos0:/mesos-build # make --version > usage: make [-BeikNnqrstWwX] > ... > > ``` > > With autotools we didn't run into this because (iirc) so much was > incompatible that I just used/assumed `gmake` for everything. With `cmake` > we're close enough that I think it might be worth it to try and support bsd > make. I made everything use `gmake`, but I didn't add the check/message because the check always succeeds. Added a TODO as discussed offline. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On April 4, 2018, 3:33 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > --- > > (Updated April 4, 2018, 3:33 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > > > Diff: https://reviews.apache.org/r/66314/diff/2/ > > > Testing > --- > > make on FreeBSD > > > Thanks, > > David Forsythe > >
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. > > David Forsythe wrote: > I took a look at find_program, but I don't think that will solve the > problem. > > We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU > make is a 3rd party application and is actually called and installed as > `gmake`, whereas the system make is actually Pmake (which is incompatible). > > David Forsythe wrote: > I should clarify that there is incompability in a 3rdparty Makefile, not > that the two makes are completely incompatible. > > Particularly there are three issues - LevelDB, libev, and glog. > > LevelDB is always going to fail without `gmake`, because it does not use > autotools. I don't know how we can get around that. > > libev and glog do use autotools. They have some strange behavior when > building, though -- > If I use `cmake --build` they both fail on a bad target (because of an > incompatible Makefile). > If I use (bsd) `make`, they build fine. > If I use `gmake` they both fail (bad target). > > For both the first and third scenario, I can run the commands that are > failing outside of the build and they succeed. > > Accordng to the cache, cmake is using `gmake` as `CMAKE_MAKE_PROGRAM` in > these cases, so it's not clear to me why anything would fail when I do the > whole build with `gmake`. It seems like the build can go make -> gmake, but > not gmake -> make. > > I think the baseline should be having `cmake --build` work, and the only > way I have gotten everything to work as expected is by forcing `gmake` > everywhere. I'm learning Cmake as I go so I could be missing something > obvious to fix this. > > David Forsythe wrote: > I've been thinking about this a bit more, and I think that the best > approach might actually be to just leave the libev and glog calls as make and > leave the conditional gmake call. On FreeBSD we could just tell users to use > `make` instead of cmake build. It seems like a way less intrusive change. > > Thoughts? > > Benjamin Bannier wrote: > I think it should be perfectly fine to use `gmake` if it is available, it > is usually a symlink to `make` anyway. > > The implementation I was thinking of was to add below instead, > > find_program( > GNU_MAKE > NAMES gmake make > DOC "path to GNU make executable") > > if (NOT GNU_MAKE) > message(FATAL_ERROR "Could not find a suitable GNU make executable") > endif() This would always succeed on FreeBSD (or any system with a make), even if gmake wasn't installed. It is not a symlink: ``` root@mesos0:/mesos-build # gmake --version GNU Make 4.2.1 ... root@mesos0:/mesos-build # make --version usage: make [-BeikNnqrstWwX] ... ``` With autotools we didn't run into this because (iirc) so much was incompatible that I just used/assumed `gmake` for everything. With `cmake` we're close enough that I think it might be worth it to try and support bsd make. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On April 2, 2018, 6:36 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > --- > > (Updated April 2, 2018, 6:36 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66314/diff/1/ > > > Testing > --- > > cmake --build on FreeBSD > > > Thanks, > > David Forsythe > >
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
> On April 2, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Line 1051 (original), 1051 (patched) > > <https://reviews.apache.org/r/66392/diff/1/?file=1991209#file1991209line1051> > > > > Don't think you mean to have this here. Ah sorry, will remove. > On April 2, 2018, 6:44 p.m., Andrew Schwartzmeyer wrote: > > src/CMakeLists.txt > > Lines 513-514 (original), 512-516 (patched) > > <https://reviews.apache.org/r/66392/diff/1/?file=1991210#file1991210line513> > > > > Instead of this, we should have a `NOT WIN32` section in > > 3rdparty/CMakeLists.txt that does `find_library(sasl2)` and then creates an > > imported `sasl2` target, that way `sasl2` will be a target on both Windows > > and non-Windows platforms, and this code can go unchanged. Fixed. Let me know if there is a better way to do it. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200307 --- On April 3, 2018, 2:11 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66392/ > --- > > (Updated April 3, 2018, 2:11 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Find sasl2 on non-Windows platforms before trying to link it. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > > > Diff: https://reviews.apache.org/r/66392/diff/2/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- (Updated April 3, 2018, 2:11 p.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Find sasl2 on non-Windows platforms before trying to link it. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 Diff: https://reviews.apache.org/r/66392/diff/2/ Changes: https://reviews.apache.org/r/66392/diff/1-2/ Testing --- Thanks, David Forsythe
Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66385/ --- (Updated April 3, 2018, 4:58 a.m.) Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 and MESOS-6849 https://issues.apache.org/jira/browse/MESOS-4176 https://issues.apache.org/jira/browse/MESOS-6849 Repository: mesos Description --- Link execinfo in Glog build on FreeBSD. Diffs (updated) - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c Diff: https://reviews.apache.org/r/66385/diff/2/ Changes: https://reviews.apache.org/r/66385/diff/1-2/ Testing --- Thanks, David Forsythe
Re: Review Request 66385: Link execinfo in Glog build on FreeBSD.
> On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 359-361 (patched) > > <https://reviews.apache.org/r/66385/diff/1/?file=1990751#file1990751line359> > > > > This looks confusing (else then if endif), but I think it's because the > > indentation is off. This is supposed to be under the above `else ()`, right? Indeed, will fix. > On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 360 (patched) > > <https://reviews.apache.org/r/66385/diff/1/?file=1990751#file1990751line360> > > > > Is this something that should actually go upstream to Glog? If so, > > let's make sure it does. I'll add it to my todo list. > On April 2, 2018, 5:05 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 304-306 (patched) > > <https://reviews.apache.org/r/66385/diff/1/?file=1990752#file1990752line304> > > > > FWIW we want to remove these eventually, as they create a dependency on > > the top-level project (Mesos) within the "3rdparty" projects (like stout). > > > > Since we already have `LINUX` to fix, it's probably fine, as we're not > > really breaking it any further. I'll try to avoid using it anywhere else. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66385/#review200291 --- On April 3, 2018, 4:58 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66385/ > --- > > (Updated April 3, 2018, 4:58 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 and MESOS-6849 > https://issues.apache.org/jira/browse/MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-6849 > > > Repository: mesos > > > Description > --- > > Link execinfo in Glog build on FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66385/diff/2/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > <https://reviews.apache.org/r/66384/diff/1/?file=1990750#file1990750line154> > > > > Also, if this change should go upstream to ZooKeeper (looks to me like > > it should) then let's make sure it does. Their process is [pretty > > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute). > > > > If you don't want to, I can upstream it. I can add it to my todo list. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200292 ------- On April 1, 2018, 2:32 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66384/ > --- > > (Updated April 1, 2018, 2:32 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Link libm in ZooKeeper build on FreeBSD. > > > Diffs > - > > 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 > > > Diff: https://reviews.apache.org/r/66384/diff/1/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
> On April 2, 2018, 5:02 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Lines 870-873 (original), 870-872 (patched) > > <https://reviews.apache.org/r/66384/diff/1/?file=1990750#file1990750line870> > > > > This is funny, what did this get diffed against? I might have screwed > > up in my original diff... I used the archive in the repo. I don't know what the workflow for changes like this is supposed to look like, but this is as close as I could get. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200289 --- On April 1, 2018, 2:32 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66384/ > --- > > (Updated April 1, 2018, 2:32 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Link libm in ZooKeeper build on FreeBSD. > > > Diffs > - > > 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 > > > Diff: https://reviews.apache.org/r/66384/diff/1/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On April 2, 2018, 6:42 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 359-360 (original), 365-366 (patched)
> > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line365>
> >
> > If I understood the above discussion correctly, I think the following
> > would work well:
> >
> > Use `${CMAKE_MAKE_PROGRAM}` and `${CMAKE_MAKE_PROGRAM} install` for the
> > BUILD/INSTALL commands, instead of adding `${GNU_MAKE}`.
> >
> > Then in the MesosConfigure.cmake, we can have a platform check `if
> > (FREEBSD) ... make sure CMAKE_MAKE_PROGRAM is gmake` or something to that
> > effect.
If we do that, we would be forcing gmake for the entire build, right? It's not
clear to me that is the best approach, since the only problem is leveldb (and
since newer versions of leveldb seem to use cmake?). I might even be more
incline to try patching LevelDBs Makefile rather than force that.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66314/#review200305
---
On April 2, 2018, 6:36 p.m., David Forsythe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66314/
> ---
>
> (Updated April 2, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
>
>
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Fix 3rdparty build commands for FreeBSD.
>
>
> Diffs
> -
>
> 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270
> cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c
>
>
> Diff: https://reviews.apache.org/r/66314/diff/1/
>
>
> Testing
> ---
>
> cmake --build on FreeBSD
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. > > David Forsythe wrote: > I took a look at find_program, but I don't think that will solve the > problem. > > We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU > make is a 3rd party application and is actually called and installed as > `gmake`, whereas the system make is actually Pmake (which is incompatible). > > David Forsythe wrote: > I should clarify that there is incompability in a 3rdparty Makefile, not > that the two makes are completely incompatible. > > Particularly there are three issues - LevelDB, libev, and glog. > > LevelDB is always going to fail without `gmake`, because it does not use > autotools. I don't know how we can get around that. > > libev and glog do use autotools. They have some strange behavior when > building, though -- > If I use `cmake --build` they both fail on a bad target (because of an > incompatible Makefile). > If I use (bsd) `make`, they build fine. > If I use `gmake` they both fail (bad target). > > For both the first and third scenario, I can run the commands that are > failing outside of the build and they succeed. > > Accordng to the cache, cmake is using `gmake` as `CMAKE_MAKE_PROGRAM` in > these cases, so it's not clear to me why anything would fail when I do the > whole build with `gmake`. It seems like the build can go make -> gmake, but > not gmake -> make. > > I think the baseline should be having `cmake --build` work, and the only > way I have gotten everything to work as expected is by forcing `gmake` > everywhere. I'm learning Cmake as I go so I could be missing something > obvious to fix this. I've been thinking about this a bit more, and I think that the best approach might actually be to just leave the libev and glog calls as make and leave the conditional gmake call. On FreeBSD we could just tell users to use `make` instead of cmake build. It seems like a way less intrusive change. Thoughts? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On April 2, 2018, 6:36 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > --- > > (Updated April 2, 2018, 6:36 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66314/diff/1/ > > > Testing > --- > > cmake --build on FreeBSD > > > Thanks, > > David Forsythe > >
Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/ --- Review request for mesos. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Find sasl2 on non-Windows platforms before trying to link it. Diffs - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 Diff: https://reviews.apache.org/r/66392/diff/1/ Testing --- Thanks, David Forsythe
Review Request 66387: Link subversion in stout build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66387/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Link subversion in stout build on FreeBSD. Diffs - 3rdparty/stout/CMakeLists.txt 5d787d87f0a4b30ba882b24d08118856eb84206b Diff: https://reviews.apache.org/r/66387/diff/1/ Testing --- Thanks, David Forsythe
Review Request 66385: Link execinfo in Glog build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66385/ --- Review request for mesos. Bugs: MESOS-4176 and MESOS-6849 https://issues.apache.org/jira/browse/MESOS-4176 https://issues.apache.org/jira/browse/MESOS-6849 Repository: mesos Description --- Link execinfo in Glog build on FreeBSD. Diffs - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c Diff: https://reviews.apache.org/r/66385/diff/1/ Testing --- Thanks, David Forsythe
Review Request 66384: Link libm in ZooKeeper build on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/ --- Review request for mesos. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Link libm in ZooKeeper build on FreeBSD. Diffs - 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 Diff: https://reviews.apache.org/r/66384/diff/1/ Testing --- Thanks, David Forsythe
Re: Review Request 66371: Temporarily disabled CSI proto compilation in CMake.
> On March 30, 2018, 8:34 a.m., David Forsythe wrote: > > src/CMakeLists.txt > > Line 35 (original) > > <https://reviews.apache.org/r/66371/diff/1/?file=1990431#file1990431line35> > > > > Should this line be removed? > > Chun-Hung Hsiao wrote: > This line is the same as Line 31. The review board is not clever enough > to mark the intended one ;) Ah, of course. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66371/#review200228 --- On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66371/ > --- > > (Updated March 29, 2018, 11:58 p.m.) > > > Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht. > > > Bugs: MESOS-8749 > https://issues.apache.org/jira/browse/MESOS-8749 > > > Repository: mesos > > > Description > --- > > The `major` and `minor` macros defined on some systems conflict with > field names in the CSI v0.1.0 spec proto. Temporarily disable it in > CMake until CSI is bumped to 0.2. > > > Diffs > - > > src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e > > > Diff: https://reviews.apache.org/r/66371/diff/1/ > > > Testing > --- > > `make check` with CMake > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66371: Temporarily disabled CSI proto compilation in CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66371/#review200232 --- Ship it! This works for me on FreeBSD now, though I'm not sure if it would be better to gate this rather than removing it completely? - David Forsythe On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66371/ > --- > > (Updated March 29, 2018, 11:58 p.m.) > > > Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht. > > > Bugs: MESOS-8749 > https://issues.apache.org/jira/browse/MESOS-8749 > > > Repository: mesos > > > Description > --- > > The `major` and `minor` macros defined on some systems conflict with > field names in the CSI v0.1.0 spec proto. Temporarily disable it in > CMake until CSI is bumped to 0.2. > > > Diffs > - > > src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e > > > Diff: https://reviews.apache.org/r/66371/diff/1/ > > > Testing > --- > > `make check` with CMake > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66371: Temporarily disabled CSI proto compilation in CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66371/#review200228 --- src/CMakeLists.txt Line 35 (original) <https://reviews.apache.org/r/66371/#comment280886> Should this line be removed? - David Forsythe On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66371/ > --- > > (Updated March 29, 2018, 11:58 p.m.) > > > Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht. > > > Bugs: MESOS-8749 > https://issues.apache.org/jira/browse/MESOS-8749 > > > Repository: mesos > > > Description > --- > > The `major` and `minor` macros defined on some systems conflict with > field names in the CSI v0.1.0 spec proto. Temporarily disable it in > CMake until CSI is bumped to 0.2. > > > Diffs > - > > src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e > > > Diff: https://reviews.apache.org/r/66371/diff/1/ > > > Testing > --- > > `make check` with CMake > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. > > David Forsythe wrote: > I took a look at find_program, but I don't think that will solve the > problem. > > We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU > make is a 3rd party application and is actually called and installed as > `gmake`, whereas the system make is actually Pmake (which is incompatible). I should clarify that there is incompability in a 3rdparty Makefile, not that the two makes are completely incompatible. Particularly there are three issues - LevelDB, libev, and glog. LevelDB is always going to fail without `gmake`, because it does not use autotools. I don't know how we can get around that. libev and glog do use autotools. They have some strange behavior when building, though -- If I use `cmake --build` they both fail on a bad target (because of an incompatible Makefile). If I use (bsd) `make`, they build fine. If I use `gmake` they both fail (bad target). For both the first and third scenario, I can run the commands that are failing outside of the build and they succeed. Accordng to the cache, cmake is using `gmake` as `CMAKE_MAKE_PROGRAM` in these cases, so it's not clear to me why anything would fail when I do the whole build with `gmake`. It seems like the build can go make -> gmake, but not gmake -> make. I think the baseline should be having `cmake --build` work, and the only way I have gotten everything to work as expected is by forcing `gmake` everywhere. I'm learning Cmake as I go so I could be missing something obvious to fix this. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On March 27, 2018, 7:10 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > --- > > (Updated March 27, 2018, 7:10 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66314/diff/1/ > > > Testing > --- > > cmake --build on FreeBSD > > > Thanks, > > David Forsythe > >
Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.
> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > <https://reviews.apache.org/r/66314/diff/1/?file=1989124#file1989124line58> > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the used system, at least currently. > > > > Let's instead use `find_program` to find a `make` and use it to set > > this variable. > > > > Unless I miss something, we do not depend on GNU make here, so let's > > maybe reflect that in a more general name, e.g., just `MAKE` if it is > > available. I took a look at find_program, but I don't think that will solve the problem. We actually *do* depend on gmake here (even on darwin). On FreeBSD GHU make is a 3rd party application and is actually called and installed as `gmake`, whereas the system make is actually Pmake (which is incompatible). - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200098 --- On March 27, 2018, 7:10 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66314/ > --- > > (Updated March 27, 2018, 7:10 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > --- > > Fix 3rdparty build commands for FreeBSD. > > > Diffs > - > > 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 > cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c > > > Diff: https://reviews.apache.org/r/66314/diff/1/ > > > Testing > --- > > cmake --build on FreeBSD > > > Thanks, > > David Forsythe > >
Review Request 66314: Fix 3rdparty build commands for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- Review request for mesos. Bugs: MESOS-4176 https://issues.apache.org/jira/browse/MESOS-4176 Repository: mesos Description --- Fix 3rdparty build commands for FreeBSD. Diffs - 3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 cmake/CompilationConfigure.cmake 64cc56ee4208afe05df0f28af5890157e4c7d82c Diff: https://reviews.apache.org/r/66314/diff/1/ Testing --- cmake --build on FreeBSD Thanks, David Forsythe
Review Request 54775: Made /dev/urandom the fill source in disk_full_framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54775/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6776 https://issues.apache.org/jira/browse/MESOS-6776 Repository: mesos Description --- Made /dev/urandom the fill source in disk_full_framework. When /dev/zero is used to fill on filesystems that support compression (like ZFS), the framework doesn't behave as desired. Diffs - src/examples/disk_full_framework.cpp e13d4c8a427905793dda9bb01c52b6d372c19150 Diff: https://reviews.apache.org/r/54775/diff/ Testing --- gmake check Thanks, David Forsythe
Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54636/ --- Review request for mesos and Ian Downes. Bugs: 6614 https://issues.apache.org/jira/browse/6614 Repository: mesos Description --- Added LOCAL_IP to disk_full_framework_test.sh. Diffs - src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e Diff: https://reviews.apache.org/r/54636/diff/ Testing --- gmake check. Test still fails, but it no longer hangs when given the correct addr. Thanks, David Forsythe
Re: Review Request 53926: Move isJailed for FreeBSD into utils.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/ --- (Updated Nov. 20, 2016, 12:42 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-5644 https://issues.apache.org/jira/browse/MESOS-5644 Repository: mesos Description --- Move isJailed for FreeBSD into utils. Diffs (updated) - 3rdparty/stout/include/stout/tests/utils.hpp 4e5359c82da4a39d4a7093bbfe95afa14e61f69d 3rdparty/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17 Diff: https://reviews.apache.org/r/53926/diff/ Testing --- gmake check on FreeBSD Thanks, David Forsythe
Review Request 53931: Don't expect an init process in a FreeBSD jail.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53931/ --- Review request for mesos and Ian Downes. Bugs: MESOS-5645 https://issues.apache.org/jira/browse/MESOS-5645 Repository: mesos Description --- Don't expect an init process in a FreeBSD jail. Diffs - 3rdparty/stout/tests/os/process_tests.cpp 4cb3b5fab389492bdc1258a27e821e60aef19dc8 Diff: https://reviews.apache.org/r/53931/diff/ Testing --- gmake check Thanks, David Forsythe
Review Request 53927: Check isJailed in tests that call mknod.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53927/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6612 and MESOS-6613 https://issues.apache.org/jira/browse/MESOS-6612 https://issues.apache.org/jira/browse/MESOS-6613 Repository: mesos Description --- Check isJailed in tests that call mknod. Diffs - 3rdparty/stout/tests/os/rmdir_tests.cpp 9aa4059d589e84f3c377163b1d6d2a278d4130b6 3rdparty/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17 Diff: https://reviews.apache.org/r/53927/diff/ Testing --- gmake check Thanks, David Forsythe
Review Request 53926: Move isJailed for FreeBSD into utils.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/ --- Review request for mesos and Ian Downes. Bugs: MESOS-5644 https://issues.apache.org/jira/browse/MESOS-5644 Repository: mesos Description --- Move isJailed for FreeBSD into utils. Diffs - 3rdparty/stout/include/stout/tests/utils.hpp 4e5359c82da4a39d4a7093bbfe95afa14e61f69d 3rdparty/stout/tests/os_tests.cpp f4b9ad71b22b5cc70a412c9a6a3e21da67121e17 Diff: https://reviews.apache.org/r/53926/diff/ Testing --- gmake check on FreeBSD Thanks, David Forsythe
Review Request 53925: Fix wait macros on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53925/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6611 https://issues.apache.org/jira/browse/MESOS-6611 Repository: mesos Description --- Fix wait macros on FreeBSD. Diffs - 3rdparty/stout/include/stout/gtest.hpp b2f75b6c706df9de68edbac86a1e2dec32a574ed Diff: https://reviews.apache.org/r/53925/diff/ Testing --- gmake check gets closer to build completion. Thanks, David Forsythe
Re: Review Request 53882: Fix configure on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/ --- (Updated Nov. 19, 2016, 12:11 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-6607 https://issues.apache.org/jira/browse/MESOS-6607 Repository: mesos Description --- Fix configure on FreeBSD. Diffs (updated) - configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e Diff: https://reviews.apache.org/r/53882/diff/ Testing --- ../configure Thanks, David Forsythe
Review Request 53913: Disable sentinel checks for clang on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53913/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6610 https://issues.apache.org/jira/browse/MESOS-6610 Repository: mesos Description --- Disable sentinel checks for clang on FreeBSD. Diffs - configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e Diff: https://reviews.apache.org/r/53913/diff/ Testing --- gmake on FreeBSD. Thanks, David Forsythe
Review Request 53912: Fix xattr for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53912/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6609 https://issues.apache.org/jira/browse/MESOS-6609 Repository: mesos Description --- Fix xattr for FreeBSD. Diffs - 3rdparty/stout/include/stout/os/posix/xattr.hpp 518940fdffab38ad97cf229078c4494fa944e1d8 Diff: https://reviews.apache.org/r/53912/diff/ Testing --- gmake on FreeBSD, no check run. Thanks, David Forsythe
Review Request 53882: Fix configure on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/ --- Review request for mesos and Ian Downes. Bugs: MESOS-6607 https://issues.apache.org/jira/browse/MESOS-6607 Repository: mesos Description --- Fix configure on FreeBSD. Diffs - configure.ac 5380cbc6a7951ede2f883f7045952a3f3434479e Diff: https://reviews.apache.org/r/53882/diff/ Testing --- ../configure Thanks, David Forsythe
Re: Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/ --- (Updated Feb. 5, 2016, 5:35 p.m.) Review request for mesos and Ian Downes. Bugs: MESOS-4504 https://issues.apache.org/jira/browse/MESOS-4504 Repository: mesos Description --- Split os::memory() out into platform specific files. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 10346dea8d658ea0a9b658a1d72eee8cc3056da8 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp cc9bfe8942db7e62f5d415fc500b78adf2ac9759 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 0e897ea15d6b3ed76a8a264726db70980bb9517a 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b47187870d6d8d21425253dac481e28102e8dcc9 Diff: https://reviews.apache.org/r/42757/diff/ Testing --- gmake check on FreeBSD and Ubuntu. Thanks, David Forsythe
Re: Review Request 42735: Make bash scripts portable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Feb. 5, 2016, 4:51 p.m.) Review request for mesos, Artem Harutyunyan and Ian Downes. Bugs: MESOS-4502 https://issues.apache.org/jira/browse/MESOS-4502 Repository: mesos Description --- Make bash scripts portable. Diffs (updated) - support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a support/docker_build.sh 55d402e35d6d391fd483c47b69b64c1ff99569d3 support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee Diff: https://reviews.apache.org/r/42735/diff/ Testing --- Thanks, David Forsythe
Re: Review Request 42735: Make bash scripts portable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Jan. 26, 2016, 8:42 a.m.) Review request for mesos, Artem Harutyunyan and Ian Downes. Summary (updated) - Make bash scripts portable. Bugs: MESOS-4502 https://issues.apache.org/jira/browse/MESOS-4502 Repository: mesos Description (updated) --- Make bash scripts portable. Diffs - support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee Diff: https://reviews.apache.org/r/42735/diff/ Testing --- Thanks, David Forsythe
Re: Review Request 42735: Make commit-msg hook portable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- (Updated Jan. 26, 2016, 8:40 a.m.) Review request for mesos, Artem Harutyunyan and Ian Downes. Changes --- Update other bash scripts. Bugs: MESOS-4502 https://issues.apache.org/jira/browse/MESOS-4502 Repository: mesos Description --- Make commit-msg hook portable. Diffs (updated) - support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee Diff: https://reviews.apache.org/r/42735/diff/ Testing --- Thanks, David Forsythe
Re: Review Request 42735: Make commit-msg hook portable.
> On Jan. 25, 2016, 9:52 p.m., Ian Downes wrote: > > Can you please fix the other bash Linux-isms in this patch while you're at > > it? > > ``` > > [1350][idownes:mesos]$ git grep "!\/bin\/bash" > > support/atexit.sh:#!/bin/bash > > support/coverage.sh:#!/bin/bash > > support/docker_build.sh:#!/bin/bash > > support/hooks/commit-msg:#!/bin/bash > > support/release.sh:#!/bin/bash > > support/tag.sh:#!/bin/bash > > support/vote.sh:#!/bin/bash > > ``` Sure thing. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review116182 --- On Jan. 25, 2016, 8:07 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42735/ > --- > > (Updated Jan. 25, 2016, 8:07 p.m.) > > > Review request for mesos, Artem Harutyunyan and Ian Downes. > > > Bugs: MESOS-4502 > https://issues.apache.org/jira/browse/MESOS-4502 > > > Repository: mesos > > > Description > --- > > Make commit-msg hook portable. > > > Diffs > - > > support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 > > Diff: https://reviews.apache.org/r/42735/diff/ > > > Testing > --- > > > Thanks, > > David Forsythe > >
Review Request 42757: Split os::memory() out into platform specific files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4504 https://issues.apache.org/jira/browse/MESOS-4504 Repository: mesos Description --- Split os::memory() out into platform specific files. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 10346dea8d658ea0a9b658a1d72eee8cc3056da8 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp cc9bfe8942db7e62f5d415fc500b78adf2ac9759 3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 0e897ea15d6b3ed76a8a264726db70980bb9517a 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8 Diff: https://reviews.apache.org/r/42757/diff/ Testing --- gmake check on FreeBSD and Ubuntu. Thanks, David Forsythe
Review Request 42735: Make commit-msg hook portable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- Review request for mesos, Artem Harutyunyan and Ian Downes. Bugs: MESOS-4502 https://issues.apache.org/jira/browse/MESOS-4502 Repository: mesos Description --- Make commit-msg hook portable. Diffs - support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 Diff: https://reviews.apache.org/r/42735/diff/ Testing --- Thanks, David Forsythe
Re: Review Request 41726: Implement os::memory() for FreeBSD.
> On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 659 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line659> > > > > s/int */int* / > > Project style guide: > > http://mesos.apache.org/documentation/latest/c++-style-guide/ > > > > s/mibDev/mibDevice/? Done and Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 658 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line658> > > > > s/xswdSz/xswdSize/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 657 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line657> > > > > Perhaps comment here that FreeBSD supports multiple swap devices and > > this sums across them all. Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 652 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line652> > > > > s/mibSz/mibSize/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 649 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line649> > > > > s/usedBlks/usedBlocks/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 648 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line648> > > > > s/totalBlks/totalBlocks/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 633 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line633> > > > > Any particular reason why the OSX code above uses sysconf but it's okay > > to use getpagesize() on FreeBSD? Are they equivalent...? On FreeBSD, sysconf() calls getpagesize() for _SC_PAGESIZE (and the man page states they are equivelent). The OS X man page doesn't say if the two are equivelent, and the Linux page says to use sysconf for portablility. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 627 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line627> > > > > Please use complete words unless it's something defined externally. > > s/physMem/physicalMemory/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 626 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line626> > > > > Not yours, but this is getting clumsy. Can you please add a TODO to > > refactor this into separate, platform specfic files. I thought about that while writing this, but didn't want to be presumptuous. I'll split things up in another change. Done. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review113310 --- On Jan. 8, 2016, 12:52 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41726/ > --- > > (Updated Jan. 8, 2016, 12:52 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-4251 > https://issues.apache.org/jira/browse/MESOS-4251 > > > Repository: mesos > > > Description > --- > > Implement os::memory() for FreeBSD. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > > Diff: https://reviews.apache.org/r/41726/diff/ > > > Testing > --- > > gmake check > > > Thanks, > > David Forsythe > >
Re: Review Request 41726: Implement os::memory() for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- (Updated Jan. 8, 2016, 12:52 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-4251 https://issues.apache.org/jira/browse/MESOS-4251 Repository: mesos Description --- Implement os::memory() for FreeBSD. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 Diff: https://reviews.apache.org/r/41726/diff/ Testing --- gmake check Thanks, David Forsythe
Re: Review Request 41726: Implement os::memory() for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- (Updated Dec. 26, 2015, 11:24 p.m.) Review request for mesos and Ian Downes. Bugs: MESOS-4251 https://issues.apache.org/jira/browse/MESOS-4251 Repository: mesos Description --- Implement os::memory() for FreeBSD. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 Diff: https://reviews.apache.org/r/41726/diff/ Testing --- gmake check Thanks, David Forsythe
Review Request 41730: Re-enable HTTPConnectionTest.ClosingRequest on FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41730/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4252 https://issues.apache.org/jira/browse/MESOS-4252 Repository: mesos Description --- Re-enable HTTPConnectionTest.ClosingRequest on FreeBSD. Diffs - 3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc Diff: https://reviews.apache.org/r/41730/diff/ Testing --- gmake check Thanks, David Forsythe
Review Request 41726: Implement os::memory() for FreeBSD.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4251 https://issues.apache.org/jira/browse/MESOS-4251 Repository: mesos Description --- Implement os::memory() for FreeBSD. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 Diff: https://reviews.apache.org/r/41726/diff/ Testing --- gmake check Thanks, David Forsythe
Re: Review Request 41596: FreeBSD: Fix includes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41596/ --- (Updated Dec. 26, 2015, 7:32 p.m.) Review request for mesos and Ian Downes. Bugs: MESOS-4212 https://issues.apache.org/jira/browse/MESOS-4212 Repository: mesos Description --- FreeBSD: Fix includes in stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca Diff: https://reviews.apache.org/r/41596/diff/ Testing --- gmake check on FreeBSD 10.2-R Thanks, David Forsythe
Review Request 41598: FreeBSD: use BSD cp in copy provisioner backend.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41598/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4211 https://issues.apache.org/jira/browse/MESOS-4211 Repository: mesos Description --- FreeBSD: use BSD cp in copy provisioner backend. Diffs - src/slave/containerizer/mesos/provisioner/backends/copy.cpp 86bbe719fe8e268e19eb9cf5fc90a6e41f0e96f5 Diff: https://reviews.apache.org/r/41598/diff/ Testing --- gmake check on FreeBSD 10.2-R Thanks, David Forsythe
Review Request 41596: FreeBSD: Fix includes in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41596/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4212 https://issues.apache.org/jira/browse/MESOS-4212 Repository: mesos Description --- FreeBSD: Fix includes in stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 269e35f56044d250697fe2ffdb181f8bcae64d37 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8cfc77fc30d1bd17f7d3d3b2e8ca449f331aa9ca Diff: https://reviews.apache.org/r/41596/diff/ Testing (updated) --- gmake check on FreeBSD 10.2-R Thanks, David Forsythe
Re: Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp bffdc3829208496ef14fecca497af73d4399867b 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp a1af2c4cc844b3c407c5db19e76b63604c003375 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 828ac46ed479f86b7369fa96be2c94c78384d5e5 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 03e6f75850561b5eb92da4771fbe18e4057ad520 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 84659e82d813b0ddb6aadd0df60fd69ecd66afa7 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp fb73158ebacf28181ef52caadee7f8a9b53679a3 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 5fd80f3dcbdc4426697d9074ee55223d4c935954 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp 8f73397a977ff5ae538f258515e511ef4e44aa66 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp b173682ac27124a71012b8b52b3d17bd1be3bf71 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 46bf489a7fee2a040d28e06af4c4e8606a4b8307 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 95f332897a7491ce41e653fe1c7f2767999824dc 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 1a23c44737ff483612dbab1388fc17175cb6c99f 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp fc5a821bf3bb1416b67103d0ffd7ab5b88f45cca Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs (updated) - configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 src/tests/attributes_tests.cpp d8c84d25a37f9cf1b38a97193d5b3b3001fd54ff src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 src/tests/values_tests.cpp fb7f982a50df8274ad29dab9e55157c39acdc104 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 28, 2015, 4:26 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 3rdparty/libprocess/src/config.hpp 8444a6018f9bc911d59a751b5a763f73d86ab1e6 3rdparty/libprocess/src/tests/http_tests.cpp 2de75ca1c7e224c36b534c368e7379dc158aa5bb Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Re: Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 14, 2015, 9:03 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 6709f5e7f6233983f389203278a0e42694591230 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp a5719bdf26b59955e7c47b6c5677bb6e847358ab 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 8791cfe628563b25ac86a8170966d458c3a9c0c8 Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 14, 2015, 9:02 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp 5e70f1896a86104ac01dfe725eb4d7d1d25bee77 Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 14, 2015, 9:02 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs (updated) - configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Re: Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp fc2df6831ae2cb1a91c7a8cc92965939576e575d 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 10, 2015, 8:33 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs (updated) - configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 103fe4b435e115857e2ebb071b6d88e2776736b5 src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 9b2b8126f39d2b4014cfb637202670e6a06cdf56 src/slave/containerizer/mesos/provisioner/docker/puller.hpp e4202550af4deb0d355ca9ae6d71b40623f9 src/slave/containerizer/mesos/provisioner/docker/puller.cpp 70501f1811fde5b636e5dcf751ef9356b8c7caef src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 3fd84e380f9393a6d46544fb7fc7d24bcb6256ac src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp f6ae9e8919fbd010c16918ddc78aa126b9da0062 src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 2445c8132ee4af07482422f8563b408459c676b2 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp e883b402c32df4d7ed5edb906231500615a00da5 src/slave/containerizer/mesos/provisioner/docker/store.cpp 6fdb85b3d55339556b0982598d2e5258f6159466 src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6 src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/containerizer/provisioner_docker_tests.cpp 9227666868801335003aeb0fa21e6b8f0e94f2cb src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am b73196cfa18e0d270e2533fbf733ad91e0559286 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Re: Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp fc2df6831ae2cb1a91c7a8cc92965939576e575d 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Nov. 10, 2015, 6:35 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs (updated) - configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote: > > configure.ac, lines 612-621 > > <https://reviews.apache.org/r/39634/diff/2/?file=1112829#file1112829line612> > > > > If it's not too much trouble, it would be great to see this logic added > > also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple > > lines of code. Mind if that happens after/if this change lands? I'm not sure what the ettiquite is for filing tickets on unsupported platforms, but I have no problem bringing the cmake stuff up to date if this gets merged. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/#review104756 --- On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39634/ > --- > > (Updated Oct. 30, 2015, 5:05 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-1563 > https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > --- > > FreeBSD: Enable mesos build and start fixing some tests > > > Diffs > - > > configure.ac 656766430e2720c6a407e282521102b54547fd2d > src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db > src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 > src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 > src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 > > Diff: https://reviews.apache.org/r/39634/diff/ > > > Testing > --- > > make check on ubuntu 14.04 > > > Thanks, > > David Forsythe > >
Re: Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Oct. 30, 2015, 5:06 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp fc2df6831ae2cb1a91c7a8cc92965939576e575d 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Oct. 30, 2015, 5:05 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs (updated) - configure.ac 656766430e2720c6a407e282521102b54547fd2d src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Oct. 30, 2015, 5:05 a.m.) Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 3rdparty/libprocess/configure.ac bdbb454c723756196d0994b621506b838fc71d4f 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Review Request 39636: FreeBSD: Add basic support to stout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Add basic support to stout Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b6afe0e76366d0bc68d37097ced83a1e14828d84 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff Diff: https://reviews.apache.org/r/39636/diff/ Testing --- make check on ubuntu 14.04 gmake check on FreeBSD 10.2 (failing, log attached) File Attachments check.log https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log Thanks, David Forsythe
Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable mesos build and start fixing some tests Diffs - configure.ac 35f2908b4fac8e29fc36d89894e447c46ca2e15c src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39634/diff/ Testing --- make check on ubuntu 14.04 Thanks, David Forsythe
Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- Review request for mesos and Ian Downes. Bugs: MESOS-1563 https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- FreeBSD: Enable libprocess build and disable failing test Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 Diff: https://reviews.apache.org/r/39635/diff/ Testing --- make check on ubuntu Thanks, David Forsythe
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
> On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 257 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101502#file1101502line257> > > > > What happens if/when we support IPv6? We could just check ip.family() for AF_INET6, right? We could do that now, but since createSockaddrStorage doesn't it seems unnecessary. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 289-291 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101503#file1101503line289> > > > > IIRC, FreeBSD doesn't often use patch versions, but has in the past. > > Pretty sure I started with 4.6.2! It does, but I was planning on making this more robust in a later change. For patch versions, the release string looks like "10.2-RELEASE-p4". I'll add a TODO. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp, lines 22-24 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101504#file1101504line22> > > > > Alphabetize please. Will do, but for reference sys/types provides the types that sys/sysctl needs, and the build will break if it's not included earlier. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp, line 28 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101512#file1101512line28> > > > > When does/will FreeBSD changes its libc version? FreeBSD bumps it when a major change lands (and will do it on the next major release). Historically when that happens there is a misc/compatNx port added, so libc.so.7 would still be available. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp, lines 419-421 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101513#file1101513line419> > > > > Could you condition this on security.jail.jailed? Yeah, good call > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/configure.ac, lines 818-820 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101514#file1101514line818> > > > > Does FreeBSD require this? If not then split the cases. Hm, thought it did, but it looks like it doesn't now. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 418 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101519#file1101519line418> > > > > This is an interesting point... I think we actually care about the > > usage, not the apparent size since we're using this for setting quota. Hm. In that case, a few more tests are going to fail for now. I'll leave them enabled, though. > On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > src/tests/attributes_tests.cpp, line 40 > > <https://reviews.apache.org/r/39345/diff/4/?file=1101520#file1101520line40> > > > > Did this cause a problem running the tests or are you cleaning things > > up? This, and all changes like it, are for issues I ran into when running tests. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103449 --- On Oct. 20, 2015, 7:45 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39345/ > --- > > (Updated Oct. 20, 2015, 7:45 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1563 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > --- > > Enable build on FreeBSD, start porting components. > > My build steps are: > > - Install dependencies from http://mesos.apache.org/gettingstarted/ > - Install libexecinfo > - Install clang36 (system clang is 3.4) > - boostrap > - ../configure --with-curl=/usr/local --with-apr=/usr/local > --with-svn=/usr/local CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 check > > I disabled one test because I haven't had a chance to debug it and I wanted > to get a bit further in the test suite. A check run is attached. > > > Diffs > - > >
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
> On Oct. 20, 2015, 8:52 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39345] > > > > Failed command: ./support/apply-review.sh -n -r 39345 > > > > Error: > > 2015-10-20 08:52:33 URL:https://reviews.apache.org/r/39345/diff/raw/ > > [26851/26851] -> "39345.patch" [1] > > Successfully applied: Enable build on FreeBSD, start porting components. > > > > Enable build on FreeBSD, start porting components. > > > > My build steps are: > > > > - Install dependencies from http://mesos.apache.org/gettingstarted/ > > - Install libexecinfo > > - Install clang36 (system clang is 3.4) > > - boostrap > > - ../configure --with-curl=/usr/local --with-apr=/usr/local > > --with-svn=/usr/local CC=clang36 CXX=clang++36 > > - gmake CC=clang36 CXX=clang++36 > > - gmake CC=clang36 CXX=clang++36 check > > > > I disabled one test because I haven't had a chance to debug it and I wanted > > to get a bit further in the test suite. A check run is attached. > > > > > > Review: https://reviews.apache.org/r/39345 > > Checking 20 files using filter > > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > > Total errors found: 0 > > ERROR: Commit spanning multiple projects. > > > > Please use separate commits for mesos, libprocess and stout. > > > > Paths grouped by project: > > mesos: > > configure.ac > > src/Makefile.am > > src/slave/containerizer/isolators/posix/disk.cpp > > src/tests/attributes_tests.cpp > > src/tests/resources_tests.cpp > > src/tests/values_tests.cpp > > stout: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > > libprocess: > > 3rdparty/libprocess/3rdparty/Makefile.am > > 3rdparty/libprocess/configure.ac > > 3rdparty/libprocess/src/config.hpp > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Failed to commit patch > > Ian Downes wrote: > Looks like most of the failing tests are for non-posix/Linux specific > stuff? Can't say -- I haven't spent any time digging into these failures yet. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103232 --- On Oct. 20, 2015, 7:45 a.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39345/ > --- > > (Updated Oct. 20, 2015, 7:45 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1563 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > --- > > Enable build on FreeBSD, start porting components. > > My build steps are: > > - Install dependencies from http://mesos.apache.org/gettingstarted/ > - Install libexecinfo > - Install clang36 (system clang is 3.4) > - boostrap > - ../configure --with-curl=/usr/local --with-apr=/usr/local > --with-svn=/usr/local CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 che
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 7:45 a.m.) Review request for mesos and Ian Downes. Bugs: https://issues.apache.org/jira/browse/MESOS-1563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- Enable build on FreeBSD, start porting components. My build steps are: - Install dependencies from http://mesos.apache.org/gettingstarted/ - Install libexecinfo - Install clang36 (system clang is 3.4) - boostrap - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 check I disabled one test because I haven't had a chance to debug it and I wanted to get a bit further in the test suite. A check run is attached. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1c776cd2facfb86854c7b2a8fe6be7949b566587 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc src/slave/containerizer/isolators/posix/disk.cpp 73e62a225da062733557287afa2273d8183d76fd src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39345/diff/ Testing --- make check on coreos (I'll get a ubuntu instance for future testing) gmake check on freebsd 10.2 (failing) (log attached) File Attachments (updated) check3.log https://reviews.apache.org/media/uploaded/files/2015/10/20/c6757057-d221-444f-8b61-0f853e568e9e__check3.log Thanks, David Forsythe
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 3:14 a.m.) Review request for mesos and Ian Downes. Bugs: https://issues.apache.org/jira/browse/MESOS-1563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- Enable build on FreeBSD, start porting components. My build steps are: - Install dependencies from http://mesos.apache.org/gettingstarted/ - Install libexecinfo - Install clang36 (system clang is 3.4) - boostrap - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 check I disabled one test because I haven't had a chance to debug it and I wanted to get a bit further in the test suite. A check run is attached. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1c776cd2facfb86854c7b2a8fe6be7949b566587 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/config.hpp 721816432621c78b3ff5cc3176753821e9ef7975 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc src/slave/containerizer/isolators/posix/disk.cpp 73e62a225da062733557287afa2273d8183d76fd src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39345/diff/ Testing --- make check on coreos (I'll get a ubuntu instance for future testing) gmake check on freebsd 10.2 (failing) (log attached) File Attachments freebsd_check2.log https://reviews.apache.org/media/uploaded/files/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log Thanks, David Forsythe
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 19, 2015, 9:06 p.m.) Review request for mesos and Ian Downes. Bugs: https://issues.apache.org/jira/browse/MESOS-1563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- Enable build on FreeBSD, start porting components. My build steps are: - Install dependencies from http://mesos.apache.org/gettingstarted/ - Install libexecinfo - Install clang36 (system clang is 3.4) - boostrap - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 check I disabled one test because I haven't had a chance to debug it and I wanted to get a bit further in the test suite. A check run is attached. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1c776cd2facfb86854c7b2a8fe6be7949b566587 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 src/Makefile.am 0dc911251ade9c652da7db25a2824b76677499dc src/slave/containerizer/isolators/posix/disk.cpp 73e62a225da062733557287afa2273d8183d76fd src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 Diff: https://reviews.apache.org/r/39345/diff/ Testing --- make check on coreos (I'll get a ubuntu instance for future testing) gmake check on freebsd 10.2 (failing) (log attached) File Attachments (updated) freebsd_check2.log https://reviews.apache.org/media/uploaded/files/2015/10/19/5b62f825-006f-4316-b0a4-c1f39f9a__check2.log Thanks, David Forsythe
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
> On Oct. 15, 2015, 5:21 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39345] > > > > Failed command: ./support/apply-review.sh -n -r 39345 > > > > Error: > > 2015-10-15 17:21:02 URL:https://reviews.apache.org/r/39345/diff/raw/ > > [22252/22252] -> "39345.patch" [1] > > Successfully applied: Enable build on FreeBSD, start porting components. > > > > Enable build on FreeBSD, start porting components. > > > > My build steps are: > > > > - Install dependencies from http://mesos.apache.org/gettingstarted/ > > - Install libexecinfo > > - Install clang36 (system clang is 3.4) > > - boostrap > > - ../configure --with-curl=/usr/local --with-apr=/usr/local > > --with-svn=/usr/local CC=clang36 CXX=clang++36 > > - gmake CC=clang36 CXX=clang++36 > > - gmake CC=clang36 CXX=clang++36 check > > > > I disabled one test because I haven't had a chance to debug it and I wanted > > to get a bit further in the test suite. A check run is attached. > > > > > > Review: https://reviews.apache.org/r/39345 > > Checking 14 files using filter > > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > > Total errors found: 0 > > ERROR: Commit spanning multiple projects. > > > > Please use separate commits for mesos, libprocess and stout. > > > > Paths grouped by project: > > mesos: > > configure.ac > > src/Makefile.am > > stout: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > > libprocess: > > 3rdparty/libprocess/3rdparty/Makefile.am > > 3rdparty/libprocess/configure.ac > > 3rdparty/libprocess/src/poll_socket.cpp > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Failed to commit patch Is there any chance of this landing as is, or will I need to submit seperate reviews? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review102795 --- On Oct. 15, 2015, 5:16 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39345/ > --- > > (Updated Oct. 15, 2015, 5:16 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1563 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 > > > Repository: mesos > > > Description > --- > > Enable build on FreeBSD, start porting components. > > My build steps are: > > - Install dependencies from http://mesos.apache.org/gettingstarted/ > - Install libexecinfo > - Install clang36 (system clang is 3.4) > - boostrap > - ../configure --with-curl=/usr/local --with-apr=/usr/local > --with-svn=/usr/local CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 > - gmake CC=clang36 CXX=clang++36 check > > I disabled one test because I haven't had a chance to debug it and I wanted > to get a bit further in the test suite. A check run is attached. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/Makefile.am > e64e3d9e958fab3c7c25fad17dcc2b279d255500 > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp > d1e2df6151149e03ffb4a76e2c24ff78b891e016 > 3rdparty/libprocess/3rdparty/stout/include/stout/ma
Re: Review Request 39345: Enable build on FreeBSD, start porting components.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 15, 2015, 5:16 p.m.) Review request for mesos and Ian Downes. Bugs: https://issues.apache.org/jira/browse/MESOS-1563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description (updated) --- Enable build on FreeBSD, start porting components. My build steps are: - Install dependencies from http://mesos.apache.org/gettingstarted/ - Install libexecinfo - Install clang36 (system clang is 3.4) - boostrap - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 check I disabled one test because I haven't had a chance to debug it and I wanted to get a bit further in the test suite. A check run is attached. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp d1e2df6151149e03ffb4a76e2c24ff78b891e016 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3f829bafe96526bc2263c9f228f85de38c435f60 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 7eb51e8771e95f57548fc35753e75c6d56cd97cd 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 src/Makefile.am ba9feb10057a863a41a85ab3612f3a841de01df4 Diff: https://reviews.apache.org/r/39345/diff/ Testing --- make check on coreos (I'll get a ubuntu instance for future testing) gmake check on freebsd 10.2 (failing) (log attached) File Attachments gmake check https://reviews.apache.org/media/uploaded/files/2015/10/15/6661fae4-32bf-409a-b975-05514aae3174__freebsd_check.log Thanks, David Forsythe
Review Request 39345: Enable build on FreeBSD, start porting components.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- Review request for mesos and Ian Downes. Bugs: https://issues.apache.org/jira/browse/MESOS-1563 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563 Repository: mesos Description --- Enable build on FreeBSD, start porting components. My build steps are: - Install dependencies from http://mesos.apache.org/gettingstarted/ - Install libexecinfo - Install clang36 (system clang is 3.4) - boostrap - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 - gmake CC=clang36 CXX=clang++36 check I disabled one test because I didn't haven't had a chance to debug it and I wanted to get a bit further in the test suite. A check run is attached. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp d1e2df6151149e03ffb4a76e2c24ff78b891e016 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3f829bafe96526bc2263c9f228f85de38c435f60 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 7eb51e8771e95f57548fc35753e75c6d56cd97cd 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9 src/Makefile.am ba9feb10057a863a41a85ab3612f3a841de01df4 Diff: https://reviews.apache.org/r/39345/diff/ Testing --- make check on coreos (I'll get a ubuntu instance for future testing) gmake check on freebsd 10.2 (failing) (log attached) File Attachments gmake check https://reviews.apache.org/media/uploaded/files/2015/10/15/6661fae4-32bf-409a-b975-05514aae3174__freebsd_check.log Thanks, David Forsythe
