://reviews.apache.org/r/68785/diff/1-2/
Testing
---
Ref MESOS-7278
Thanks,
Eric Chung
and activate virtualenv: `virtualenv env && . env/bin/activate`
3. install reqs: `pip install -r requirements.in`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab
Diff: https://reviews.apache.org/r/67185/diff/5/
Changes: https://reviews.apache.org/r/67185/diff/4-5/
Testing
---
Thanks,
Eric Chung
3ee77681a9b802cd5b4a7910779b8d50aac4cf69
Diff: https://reviews.apache.org/r/68654/diff/4/
Changes: https://reviews.apache.org/r/68654/diff/3-4/
Testing
---
Thanks,
Eric Chung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68832/#review208978
---
Ship it!
Ship It!
- Eric Chung
On Sept. 25, 2018, 12:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review208977
---
Ship it!
Ship It!
- Eric Chung
On Sept. 25, 2018, 12:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review208963
---
Ship it!
Ship It!
- Eric Chung
On Sept. 24, 2018, 8:40 p.m
little weird. are these two
separate todo items or one?
- Eric Chung
On Sept. 21, 2018, 9:53 p.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68804/#review208902
---
Ship it!
Ship It!
- Eric Chung
On Sept. 21, 2018, 10:34 p.m
(patched)
<https://reviews.apache.org/r/68804/#comment293175>
should the commented lines be removed?
- Eric Chung
On Sept. 21, 2018, 10:34 p.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e-mail.
Thanks,
Eric Chung
.
Repository: mesos
Description
---
Added jsonschema.py for managing json-based configs.
Diffs
-
src/python/cli_new/lib/cli/jsonschema.py PRE-CREATION
Diff: https://reviews.apache.org/r/68785/diff/1/
Testing
---
Thanks,
Eric Chung
, Jason Lai, and Kevin Klues.
Repository: mesos
Description (updated)
---
[WIP] Added jsonschema.py for managing json-based configs.
Diffs
-
src/python/cli_new/lib/cli/jsonschema.py PRE-CREATION
Diff: https://reviews.apache.org/r/68785/diff/1/
Testing
---
Thanks,
Eric
/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab
src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
Diff: https://reviews.apache.org/r/68654/diff/3/
Changes: https://reviews.apache.org/r/68654/diff/2-3/
Testing
---
Thanks,
Eric Chung
/
Changes: https://reviews.apache.org/r/68654/diff/1-2/
Testing
---
Thanks,
Eric Chung
tps://reviews.apache.org/r/68711/#comment292875>
now that we're using python3, why not start adding type annotations? e.g.
```
def get_task(tasks: dict, task_id: str):
...
```
this will help greatly with avoiding unnecessary bugs
- Eric Chung
On Sept. 17, 2018, 10:
/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab
src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
Diff: https://reviews.apache.org/r/68654/diff/1/
Testing
---
Thanks,
Eric Chung
/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b
src/python/lib/tox.ini fd5e89c77c8608fea21e9caad814c6e111ad57db
Diff: https://reviews.apache.org/r/68653/diff/1/
Testing
---
Thanks,
Eric Chung
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/67894/#review208096
---
On July 12, 2018, 8:09 a.m., Eric Chung wrote:
>
> ---
> This is an automatically ge
/#comment290177>
indeed it should
- Eric Chung
On June 28, 2018, 6:17 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
tps://reviews.apache.org/r/67894/#comment290174>
not sure what you mean.. can you elaborate?
- Eric Chung
On July 12, 2018, 8:09 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/lib`
Thanks,
Eric Chung
thon3.6
py37: python3.7
```
the cardinality of the tests will grow as `n x m`, so maybe keep the list
of supported python versions below 3
- Eric Chung
On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67413/#review205710
---
Ship it!
Ship It!
- Eric Chung
On July 3, 2018, 2:40 p.m
and generate
requirements.txt from requirements.in to avoid potential dependency conflicts
- Eric Chung
On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b
Diff: https://reviews.apache.org/r/67185/diff/4/
Changes: https://reviews.apache.org/r/67185/diff/3-4/
Testing
---
Thanks,
Eric Chung
66dd6d7c6272d1828dd591829ca3543d3430f69b
Diff: https://reviews.apache.org/r/67185/diff/3/
Changes: https://reviews.apache.org/r/67185/diff/2-3/
Testing
---
Thanks,
Eric Chung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67411/#review20
---
Ship it!
Ship It!
- Eric Chung
On June 1, 2018, 3:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67412/#review204443
---
Ship it!
Ship It!
- Eric Chung
On June 1, 2018, 3:14 p.m
and activate virtualenv: `virtualenv env && . env/bin/activate`
3. install reqs: `pip install -r requirements.in`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2
src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b
Diff: https://reviews.apache.org/r/67185/diff/2/
Changes: https://reviews.apache.org/r/67185/diff/1-2/
Testing
---
Thanks,
Eric Chung
and activate virtualenv: `virtualenv env && . env/bin/activate`
3. install reqs: `pip install -r requirements.in`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
ivate`
3. install reqs: `pip install -r requirements.in`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67177/#review203482
---
Ship it!
Ship It!
- Eric Chung
On May 17, 2018, 1:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67055/#review203357
---
Ship it!
Ship It!
- Eric Chung
On May 16, 2018, 2:29 p.m
Diff: https://reviews.apache.org/r/67185/diff/1/
Testing
---
Thanks,
Eric Chung
th `six.itervalues`
- Eric Chung
On May 16, 2018, 2:29 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67022/#review202730
---
Ship it!
Ship It!
- Eric Chung
On May 9, 2018, 12:40 a.m
in some unit
tests, e.g. using tox.
- Eric Chung
On May 4, 2018, 8:44 p.m., Andrew Schwartzmeyer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
how to include protobuf version defined in makefile?
- Eric Chung
On April 17, 2018, 8:22 p.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
and activate virtualenv: `virtualenv env && . env/bin/activate`
3. install reqs: `pip install -r requirements.in`
4. try to import modules from generated python code: `python -c 'from
mesos.pb2.mesos.v1.master import master_pb2'`
Thanks,
Eric Chung
s an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64970/#review200634
-------
On March 14, 2018, 3:05 p.m., Eric Chung wrote:
>
> ---
> This is an au
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65899/#review199276
---
Ship it!
Ship It!
- Eric Chung
On March 15, 2018, 8:18 a.m
ges: https://reviews.apache.org/r/64970/diff/5-6/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
eviews.apache.org/r/64970/#review198478
---
On March 14, 2018, 3:02 p.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To re
ges: https://reviews.apache.org/r/64970/diff/4-5/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
)
<https://reviews.apache.org/r/65899/#comment278999>
why is the explicit delete needed here? was it not being cleaned up
previously?
- Eric Chung
On March 5, 2018, 7:31 a.m., Jason Lai wrote:
>
> ---
> This is an automati
ache.org/r/64970/diff/4/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
64970/diff/4/
Changes: https://reviews.apache.org/r/64970/diff/3-4/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
/tox.ini 8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054
support/pylint.config f74f553e238553bd6a6c06f4dd888cc5954a33eb
Diff: https://reviews.apache.org/r/61172/diff/10/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
tps://reviews.apache.org/r/64970/#comment276522>
fix --cov
support/mesos-style.py
Lines 381 (patched)
<https://reviews.apache.org/r/64970/#comment276525>
consider using __file__ instead
- Eric Chung
On Jan. 19, 2018, 4:29 a.m., Eric
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review195718
---
On Jan. 19, 2018, 8:48 p.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To rep
support/pylint.config f74f553e238553bd6a6c06f4dd888cc5954a33eb
Diff: https://reviews.apache.org/r/61172/diff/10/
Changes: https://reviews.apache.org/r/61172/diff/9-10/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
iff: https://reviews.apache.org/r/64970/diff/2/
Changes: https://reviews.apache.org/r/64970/diff/1-2/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
f74f553e238553bd6a6c06f4dd888cc5954a33eb
Diff: https://reviews.apache.org/r/61172/diff/9/
Changes: https://reviews.apache.org/r/61172/diff/8-9/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review194862
-------
On Jan. 1, 2018, 1:52 a.m., Eric Chung wrote:
>
> ---
> Thi
1b34ea2d9afa8f17b545841cea7a6853a6e18144
Diff: https://reviews.apache.org/r/64970/diff/1/
Testing
---
1. intentionally create a lint error, such as extra spaces before a parens in a
python file
2. run the pre-commit hook and see tox in action
Thanks,
Eric Chung
s just the default value.
- Eric Chung
On Jan. 1, 2018, 1:52 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
f74f553e238553bd6a6c06f4dd888cc5954a33eb
Diff: https://reviews.apache.org/r/61172/diff/8/
Changes: https://reviews.apache.org/r/61172/diff/7-8/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
y
Lines 41 (patched)
<https://reviews.apache.org/r/61172/#comment272509>
break params into list
src/python/lib/tests/test_http.py
Lines 42-58 (patched)
<https://reviews.apache.org/r/61172/#comment272508>
reformat
- Eric Chung
On Nov. 30, 2017, 10:16 a.m., Eri
f74f553e238553bd6a6c06f4dd888cc5954a33eb
Diff: https://reviews.apache.org/r/61172/diff/7/
Changes: https://reviews.apache.org/r/61172/diff/6-7/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62938/#review189445
---
Ship it!
Ship It!
- Eric Chung
On Oct. 26, 2017, 4:52 p.m
)
<https://reviews.apache.org/r/62938/#comment266333>
why not just use list comprehension?
src/python/cli_new/lib/cli/util.py
Lines 257 (patched)
<https://reviews.apache.org/r/62938/#comment266334>
why not just use `if not json_data`?
- Eric Chung
On Oct. 26, 2017, 4:52
://reviews.apache.org/r/61172/diff/6/
Changes: https://reviews.apache.org/r/61172/diff/5-6/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
/61172/diff/5/
Changes: https://reviews.apache.org/r/61172/diff/4-5/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
://reviews.apache.org/r/61172/diff/4/
Changes: https://reviews.apache.org/r/61172/diff/3-4/
Testing
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
33>
mention overriding defaults
src/python/lib/mesos/http.py
Lines 161-162 (patched)
<https://reviews.apache.org/r/61172/#comment260435>
one param per line
- Eric Chung
On Aug. 9, 2017, 5:54 p.m., Eric Chung wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review183963
---
bump?
- Eric Chung
On Aug. 9, 2017, 5:54 p.m., Eric Chung
Diff: https://reviews.apache.org/r/61172/diff/3/
Testing (updated)
---
install tox
cd src/python/lib
tox
Thanks,
Eric Chung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review182313
---
ping
- Eric Chung
On Aug. 3, 2017, 9:41 p.m., Eric Chung wrote
8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054
Diff: https://reviews.apache.org/r/61172/diff/3/
Testing
---
under src/python/lib, call `tox` for running unit tests. The test should pass
and test coverage should be at 100%.
Thanks,
Eric Chung
://reviews.apache.org/r/61172/diff/3/
Changes: https://reviews.apache.org/r/61172/diff/2-3/
Testing
---
under src/python/lib, call `tox` for running unit tests. The test should pass
and test coverage should be at 100%.
Thanks,
Eric Chung
acepalm)
- Eric
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review181756
---
On Aug. 3, 2017, 9:15 p.m., Eric Ch
and test coverage should be at 100%.
Thanks,
Eric Chung
8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054
Diff: https://reviews.apache.org/r/61172/diff/2/
Testing
---
under src/python/lib, call `tox` for running unit tests. The test should pass
and test coverage should be at 100%.
Thanks,
Eric Chung
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/61172/#review181756
-------
On July 27, 2017, 7:09 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e
e.org/r/61172/#review181756
---
On July 27, 2017, 7:09 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
8ad030d2dbf1fb7a04f1eaadb587462b4ef3f054
Diff: https://reviews.apache.org/r/61172/diff/1/
Testing
---
under src/python/lib, call `tox` for running unit tests. The test should pass
and test coverage should be at 100%.
Thanks,
Eric Chung
` for running unit tests. The test should pass
and test coverage should be at 100%.
Thanks,
Eric Chung
src/python/lib
3. tox
Thanks,
Eric Chung
tps://reviews.apache.org/r/60719/#comment256493>
replace with tox.ini
- Eric Chung
On July 17, 2017, 5:59 p.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
tps://reviews.apache.org/r/60719/#comment256492>
remove
- Eric Chung
On July 17, 2017, 5:59 p.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60900/#review180823
---
Ship it!
Ship It!
- Eric Chung
On July 18, 2017, 5:31 a.m
rcfile={pylint} --ignore={ignore} {files}').
format(files=source_files,
**source_config)],
shell=True, stdout=subprocess.PIPE)
```
- Eric Chung
On July 16, 2017, 7:34 p.m., Armand Grillet
tps://reviews.apache.org/r/60900/#comment255960>
this will crap out because self.source_dirs has been changed to a dict
- Eric Chung
On July 16, 2017, 7:34 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60899/#review180746
---
Ship it!
otherwise lgtm, ship it!
- Eric Chung
On July 16
.) in the test instructions
- Eric Chung
On July 16, 2017, 7:33 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/test_mesos.py PRE-CREATION
support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60719/diff/8/
Changes: https://reviews.apache.org/r/60719/diff/7-8/
Testing
---
under src/python/lib, run `bash test.sh`
Thanks,
Eric Chung
PRE-CREATION
support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60719/diff/7/
Changes: https://reviews.apache.org/r/60719/diff/6-7/
Testing
---
under src/python/lib, run `bash test.sh`
Thanks,
Eric Chung
support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60719/diff/5/
Changes: https://reviews.apache.org/r/60719/diff/4-5/
Testing (updated)
---
under src/python/lib, run `bash test.sh`
Thanks,
Eric Chung
-style.py 48d816f72df65d77364769f812fc06afcd6b5aec
Diff: https://reviews.apache.org/r/60719/diff/6/
Changes: https://reviews.apache.org/r/60719/diff/5-6/
Testing
---
under src/python/lib, run `bash test.sh`
Thanks,
Eric Chung
l generic but makes sense as this is the `mesos` Python package).
the plan was actually to run `setup.py install` as part of bootstrap -- the
mesos package needs to be installed in the same environment as cli_new in order
for cli_new to use it. how about setting up it's own test script instead?
c
/60719/diff/3-4/
Testing
---
1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`
Thanks,
Eric Chung
/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`
Thanks,
Eric Chung
/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`
Thanks,
Eric Chung
/setup.py PRE-CREATION
Diff: https://reviews.apache.org/r/60719/diff/1/
Testing
---
1. under src/python/lib, run `virtualenv env`
2. `. env/bin/activate`
3. `pip install setuptools --upgrade`
4. `python setup.py test`
Thanks,
Eric Chung
.
Diffs
-
src/python/lib/mesos/http.py PRE-CREATION
Diff: https://reviews.apache.org/r/60697/diff/1/
Testing
---
Thanks,
Eric Chung
1 - 100 of 119 matches
Mail list logo
