Re: Review Request 40431: Move RoleInfo message out of allocator.proto
> On Dec. 10, 2015, 10:40 a.m., Adam B wrote:
> > I'm not sure exactly why you needed to move RoleInfo out of
> > allocator.proto. The RoleInfo we use for the allocator module API doesn't
> > need to be (and perhaps shouldn't be) the same class that we use to display
> > role information like weights in the HTTP endpoint, or even the same class
> > that we persist in the registry. There may be some future role metadata we
> > want to set in the HTTP endpoint that doesn't need to be passed on to the
> > allocator (e.g. Role.description), and maybe even something we set that
> > doesn't need to be persisted. I don't actually think we need 3 or 4
> > separate RoleInfo-like protobufs, but I want us to think about how each of
> > these APIs could grow apart in their notion of "important role metadata".
> > Is there a real need to move the RoleInfo protobuf?
Currently, RoleInfo protobuf never be used for serialization, so I think we can
remove it from allocator.proto, and define a struct in mesos.hpp to communicate
between the allocator and master. Then for role information display, then
current serialization way(call modle(role*) in http.cpp) is not better, and we
should get RoleInfo protobuf back for serialization. Refer to other
components(such as quota), I propose to define role protobuf in a separated
package rather than define it in mesos.proto. And for persist, we should define
proto message in registry.proto which only contians the metadata should be
persisted.
- Yong Qiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/#review109704
-------
On Dec. 8, 2015, 5:20 a.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40431/
> ---
>
> (Updated Dec. 8, 2015, 5:20 a.m.)
>
>
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
>
>
> Bugs: MESOS-3944
> https://issues.apache.org/jira/browse/MESOS-3944
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Currently role protobuf is defined in allocator.proto due to only the
> traditional DRF allocator uses roles as it’s first level of hierarchy, I
> think we should move it out and define it in a separated file as quota had in
> dynamic roles project, because role protobuf will also be used by master to
> persist.
>
>
> Diffs
> -
>
> include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
> include/mesos/master/allocator.proto
> 702f56f56c3b1331613cecf26522986f6b572f8c
> include/mesos/role/role.hpp PRE-CREATION
> include/mesos/role/role.proto PRE-CREATION
> src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
> src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
> src/master/allocator/mesos/allocator.hpp
> 97ee80726ad155917811265a983258b0165d3451
> src/master/allocator/mesos/hierarchical.hpp
> 99c742906874c30c39c159e58a65277ade3c07fd
> src/master/allocator/mesos/hierarchical.cpp
> 5da825a1d578a9ee40b4985378fddb3c5fb3b416
> src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
> src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
> src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
> src/tests/hierarchical_allocator_tests.cpp
> fb214a829a57529d3f5c49730ae9733f53e622ca
>
> Diff: https://reviews.apache.org/r/40431/diff/
>
>
> Testing
> ---
>
> 1. Make Check successfully;
>
> 2. $ curl http://9.110.48.168:5050/roles
> {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 41075: Added support for implicit roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109308 --- src/master/allocator/mesos/hierarchical.cpp (line 301) <https://reviews.apache.org/r/41075/#comment168776> In the current implementation, quota(quotaSorter) does not been removed after the corresponding role is removed, then some resources will still be reserved by this non-active role, this will result in the waste of resources. If you rely on cluster operator to remove this quota, I think it is does not make sence and have a bad user experience, because role is implicitly removed when the last framework gone without notify the clsuter admin. - Yong Qiao Wang On Dec. 8, 2015, 8:33 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41075/ > --- > > (Updated Dec. 8, 2015, 8:33 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg > Mann, and Yong Qiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > --- > > Changed the behavior of the master when the `--roles` flag is NOT > specified. Previously, this would allow only the `*` role to be used. Now, > omitting `--roles` means that any role can be used. This is called "implicit > roles". Configuring which principals can perform operations as which roles > should be done using ACLs in the authorization system. > > Note that this changes the behavior of the system when `--roles` is not > specified. This is likely acceptable: if the operator didn't specify `--roles` > in prior versions of Mesos, they were likely not using roles or authorization > at > that time. > > Another minor behavioral change is that the "/roles" endpoint will now only > return results for currently "active" roles (those with one or more registered > frameworks). > > The `--roles` flag is now considered deprecated and will be removed in a > future > version of Mesos. > > > Diffs > - > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > include/mesos/master/allocator.proto > 702f56f56c3b1331613cecf26522986f6b572f8c > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 > src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 > src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c > src/master/quota_handler.cpp b209da42ace752953686eeda9577007a33556d5d > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > > Diff: https://reviews.apache.org/r/41075/diff/ > > > Testing > --- > > "make check" on OSX 10.10 and Ubuntu 15.10; `--gtest_repeat=1000` for the > more likely role-related tests. > > TODOs: > > * Update documentation > * Add tests for allocation behavior for weights + implicit roles > * Add tests for quota + implicit roles? > > Notes: > > * There's two places where we use manual `new`/`delete` where a `unique_ptr` > would probably be nicer. I'm inclined to leave this as-is for now though > (making use of unique_ptr is a broader issue). > > > Thanks, > > Neil Conway > >
Re: Review Request 41075: Added support for implicit roles.
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > > > Yong Qiao Wang wrote: > I have talked with our shepherd Adam B yesterday, and we all agree to > improve /roles endpoint to update/remove/list active roles, and Implicit > Roles will focus on removing the static role list(specified by --roles flag) > and let framework can register with any role. In addition, RoleInfo is still > needed, and will be persisted when the default values are changed by /roles > endpoint. Currently I also have posted some patches for Dynamic Roles, and > there are some serious comflicts between our patches. Can you have a talk > with our shepherd? I think we should reach a consensus before coding. > > Adam B wrote: > I'm still not sure about removeRole, but update/list make sense for > dynamic weights. We'll have to discuss the pros/cons of RoleInfo vs. a > separate weights hashmap, but let's try to communicate & collaborate on our > approaches to avoid too many unnecessary merge conflicts. In the current implementation, role will be implicitly removed after the last framework gone, but it related configurations, such as quota, weight will not be removed, this will cause data inconsistencies, so I think we should let cluster operator to remove the role and it's related configuration after the corresponding framework no longer recovery. In addition, if we all agree to use /roles to update the weight in RoleInfo and persist RoleInfo, then I think it is better to still use RoleInfo rather than weights hashmap, because it can pass more information to allocator, then it can avoid the frequent changes of the interface of allocator. For example, if we add Grace Period for a role in Opetimisitic Offer ticket, and maybe allocator also need to know it, then we on longer need to change this interface again later. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109287 --- On Dec. 8, 2015, 8:33 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41075/ > --- > > (Updated Dec. 8, 2015, 8:33 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg > Mann, and Yong Qiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > --- > > Changed the behavior of the master when the `--roles` flag is NOT > specified. Previously, this would allow only the `*` role to be used. Now, > omitting `--roles` means that any role can be used. This is called "implicit > roles". Configuring which principals can perform operations as which roles > should be done using ACLs in the authorization system. > > Note that this changes the behavior of the system when `--roles` is not > specified. This is likely acceptable: if the operator didn't specify `--roles` > in prior versions of Mesos, they were likely not using roles or authorization > at > that time. > > Another minor behavioral change is that the "/roles" endpoint will now only > return results for currently "active" roles (those with one or more registered > frameworks). > > The `--roles` flag is now considered deprecated and will be removed in a > future > version of Mesos. > > > Diffs > - > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > include/mesos/master/allocator.proto > 702f56f56c3b1331613cecf26522986f6b572f8c > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 > src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 > src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c > src/master/quota_handler.cpp b209da42ace752953686eeda9577007a33556d5d > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > > Diff: https://reviews.apache.org/r/41075/diff/ > > > Testing > --- > > "make check" on OSX 10.10 and Ubuntu 15.10; `--gtest_repeat=1000` for the > more likely role-related tests. > > TODOs
Re: Review Request 41075: Added support for implicit roles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109287 --- include/mesos/master/allocator.hpp (line 99) <https://reviews.apache.org/r/41075/#comment168754> When allocator initialize, their should be no active frameworks in mesos, can we consider to remove this parmeter from initialize()? and can initialize role-related information in addFramework(). - Yong Qiao Wang On Dec. 8, 2015, 5:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41075/ > --- > > (Updated Dec. 8, 2015, 5:41 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg > Mann, and Yong Qiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > --- > > Changed the behavior of the master when the `--roles` flag is NOT > specified. Previously, this would allow only the `*` role to be used. Now, > omitting `--roles` means that any role can be used. This is called "implicit > roles". Configuring which principals can perform operations as which roles > should be done using ACLs in the authorization system. > > Note that this changes the behavior of the system when `--roles` is not > specified. This is likely acceptable: if the operator didn't specify `--roles` > in prior versions of Mesos, they were likely not using roles or authorization > at > that time. > > Another minor behavioral change is that the "/roles" endpoint will now only > return results for currently "active" roles (those with one or more registered > frameworks). > > The `--roles` flag is now considered deprecated and will be removed in a > future > version of Mesos. > > > Diffs > - > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > include/mesos/master/allocator.proto > 702f56f56c3b1331613cecf26522986f6b572f8c > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 > src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 > src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c > src/master/quota_handler.cpp b209da42ace752953686eeda9577007a33556d5d > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > > Diff: https://reviews.apache.org/r/41075/diff/ > > > Testing > --- > > "make check" on OSX 10.10 and Ubuntu 15.10; `--gtest_repeat=1000` for the > more likely role-related tests. > > TODOs: > > * Update documentation > * Add tests for allocation behavior for weights + implicit roles > * Add tests for quota + implicit roles? > > > Thanks, > > Neil Conway > >
Re: Review Request 41075: Added support for implicit roles.
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > I have talked with our shepherd Adam B yesterday, and we all agree to improve /roles endpoint to update/remove/list active roles, and Implicit Roles will focus on removing the static role list(specified by --roles flag) and let framework can register with any role. In addition, RoleInfo is still needed, and will be persisted when the default values are changed by /roles endpoint. Currently I also have posted some patches for Dynamic Roles, and there are some serious comflicts between our patches. Can you have a talk with our shepherd? I think we should reach a consensus before coding. > On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > include/mesos/master/allocator.hpp, line 101 > > <https://reviews.apache.org/r/41075/diff/1/?file=1155806#file1155806line101> > > > > When allocator initialize, their should be no active frameworks in > > mesos, can we consider to remove this parmeter from initialize()? and can > > initialize role-related information in addFramework(). > > Neil Conway wrote: > Hmmm -- I think it is better as written. Right now, weights are static > and set at initialization-time, so I think it makes more sense for them to be > parameters of `initialize`, not `addFramework`. (When we do dynamic weights > we'll need to reconsider this, but even then, I don't think passing weights > to `addFramework` will be the right API). For long term solution in Implicit Roles, --roles and --weights should be removed, so weights parameter will only have one default value(*,1). so it is make sence to remove this parameter from initialize (),and when framework register, we can add its role and the corresponding weight into allocator, then they can become active. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review109287 --- On Dec. 8, 2015, 5:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41075/ > --- > > (Updated Dec. 8, 2015, 5:41 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Hindman, Greg > Mann, and Yong Qiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > --- > > Changed the behavior of the master when the `--roles` flag is NOT > specified. Previously, this would allow only the `*` role to be used. Now, > omitting `--roles` means that any role can be used. This is called "implicit > roles". Configuring which principals can perform operations as which roles > should be done using ACLs in the authorization system. > > Note that this changes the behavior of the system when `--roles` is not > specified. This is likely acceptable: if the operator didn't specify `--roles` > in prior versions of Mesos, they were likely not using roles or authorization > at > that time. > > Another minor behavioral change is that the "/roles" endpoint will now only > return results for currently "active" roles (those with one or more registered > frameworks). > > The `--roles` flag is now considered deprecated and will be removed in a > future > version of Mesos. > > > Diffs > - > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > include/mesos/master/allocator.proto > 702f56f56c3b1331613cecf26522986f6b572f8c > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 99c742906874c30c39c159e58a65277ade3c07fd > src/master/allocator/mesos/hierarchical.cpp > 5da825a1d578a9ee40b4985378fddb3c5fb3b416 > src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 > src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 > src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c > src/master/quota_handler.cpp b209da42ace752953686eeda9577007a33556d5d > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > fb214a829a57529d3f5c49730ae9733f53e622ca > > Diff: https://reviews.apache.org/r/41075/diff/ > > > Testing > --- > > "make check" on OSX 10.10 and Ubuntu 15.10; `--gtest_repeat=1000` for the > more likely role-related tests. > > TODOs: > > * Update documentation > * Add tests for allocation behavior for weights + implicit roles > * Add tests for quota + implicit roles? > > > Thanks, > > Neil Conway > >
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Dec. 7, 2015, 8:41 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
99c742906874c30c39c159e58a65277ade3c07fd
src/master/allocator/mesos/hierarchical.cpp
5da825a1d578a9ee40b4985378fddb3c5fb3b416
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Dec. 7, 2015, 10:12 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
99c742906874c30c39c159e58a65277ade3c07fd
src/master/allocator/mesos/hierarchical.cpp
5da825a1d578a9ee40b4985378fddb3c5fb3b416
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40469: Update Allocator interface to support dynamic roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 7, 2015, 10:12 a.m.) Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. Bugs: MESOS-3956 https://issues.apache.org/jira/browse/MESOS-3956 Repository: mesos Description --- Update Allocator interface to support dynamic roles Diffs (updated) - include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 src/master/allocator/mesos/allocator.hpp 97ee80726ad155917811265a983258b0165d3451 src/master/allocator/mesos/hierarchical.hpp 99c742906874c30c39c159e58a65277ade3c07fd src/master/allocator/mesos/hierarchical.cpp 5da825a1d578a9ee40b4985378fddb3c5fb3b416 src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Dec. 8, 2015, 5:15 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
99c742906874c30c39c159e58a65277ade3c07fd
src/master/allocator/mesos/hierarchical.cpp
5da825a1d578a9ee40b4985378fddb3c5fb3b416
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40469: Update Allocator interface to support dynamic roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Dec. 8, 2015, 5:20 a.m.) Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. Bugs: MESOS-3956 https://issues.apache.org/jira/browse/MESOS-3956 Repository: mesos Description --- Update Allocator interface to support dynamic roles Diffs (updated) - include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 src/master/allocator/mesos/allocator.hpp 97ee80726ad155917811265a983258b0165d3451 src/master/allocator/mesos/hierarchical.hpp 99c742906874c30c39c159e58a65277ade3c07fd src/master/allocator/mesos/hierarchical.cpp 5da825a1d578a9ee40b4985378fddb3c5fb3b416 src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Dec. 8, 2015, 5:20 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
99c742906874c30c39c159e58a65277ade3c07fd
src/master/allocator/mesos/hierarchical.cpp
5da825a1d578a9ee40b4985378fddb3c5fb3b416
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40995: Added test cases for role behavior.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109278 --- Ship it! Ship It! - Yong Qiao Wang On Dec. 7, 2015, 9:22 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40995/ > --- > > (Updated Dec. 7, 2015, 9:22 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong > Qiao Wang. > > > Repository: mesos > > > Description > --- > > Added test cases for role behavior. > > > Diffs > - > > src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 > src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40995/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Neil Conway > >
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 30, 2015, 3:09 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp
31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe
src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 30, 2015, 3:11 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description (updated)
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp
31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe
src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 30, 2015, 7:05 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description (updated)
---
This ticket will enhance the existing HTTP endpoint /roles to query roles as
outlined in the dynamic roles/weights design Doc.
Diffs (updated)
-
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04
src/master/http.cpp 9d729ef7f7d7ad6185934648f833e4f8a4f0a123
src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}
$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 30, 2015, 7:06 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp
31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe
src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 26, 2015, 2:01 p.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp
31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38
src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 26, 2015, 2:16 p.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356
src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b
src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}
$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40697: Enhance endpoint /roles for adding a new role
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/
---
(Updated Nov. 26, 2015, 2:18 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-3942
https://issues.apache.org/jira/browse/MESOS-3942
Repository: mesos
Description
---
Enhance endpoint /roles for adding a new role
Diffs (updated)
-
src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b
src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40697/diff/
Testing
---
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
Failed to validate set role request string:
('role={"name":"role1","weight":2}')': This role already exist!
$ curl -X GET http://127.0.0.1:5050/roles/role1
{"status":[{"infos":{"name":"role1","weight":2.0}}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 25, 2015, 8:38 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}
$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 25, 2015, 8:38 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 25, 2015, 8:20 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Review Request 40697: Enhance endpoint /roles for adding a new role
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/
---
Review request for mesos and Adam B.
Repository: mesos
Description
---
Enhance endpoint /roles for adding a new role
Diffs
-
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40697/diff/
Testing
---
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
Failed to validate set role request string:
('role={"name":"role1","weight":2}')': This role already exist!
$ curl -X GET http://127.0.0.1:5050/roles/role1
{"status":[{"infos":{"name":"role1","weight":2.0}}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40697: Enhance endpoint /roles for adding a new role
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/
---
(Updated Nov. 25, 2015, 8:30 a.m.)
Review request for mesos and Adam B.
Bugs: MESOS-3942
https://issues.apache.org/jira/browse/MESOS-3942
Repository: mesos
Description
---
Enhance endpoint /roles for adding a new role
Diffs
-
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40697/diff/
Testing
---
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
$ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST
http://127.0.0.1:5050/roles
Failed to validate set role request string:
('role={"name":"role1","weight":2}')': This role already exist!
$ curl -X GET http://127.0.0.1:5050/roles/role1
{"status":[{"infos":{"name":"role1","weight":2.0}}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
> On Nov. 25, 2015, 2:48 a.m., Klaus Ma wrote:
> > include/mesos/role/role.proto, line 38
> > <https://reviews.apache.org/r/40431/diff/7/?file=1138459#file1138459line38>
> >
> > I'm thinke whether we need to enhance weight to `int`. Any case that we
> > has to use `double` as weight? If we want to control the scope, TODO is OK.
In mesos, weight can be any value greater than -1, I think it's make sence. It
does not need to change it's type to int if there is no specified requirement.
- Yong Qiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/#review107903
---
On Nov. 25, 2015, 8:38 a.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40431/
> ---
>
> (Updated Nov. 25, 2015, 8:38 a.m.)
>
>
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
>
>
> Bugs: MESOS-3944
> https://issues.apache.org/jira/browse/MESOS-3944
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Move RoleInfo message out of allocator.proto
>
>
> Diffs
> -
>
> include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
> include/mesos/master/allocator.proto
> 702f56f56c3b1331613cecf26522986f6b572f8c
> include/mesos/role/role.hpp PRE-CREATION
> include/mesos/role/role.proto PRE-CREATION
> src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
> src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
> src/master/allocator/mesos/allocator.hpp
> 97ee80726ad155917811265a983258b0165d3451
> src/master/allocator/mesos/hierarchical.hpp
> 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
> src/master/allocator/mesos/hierarchical.cpp
> aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
> src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
> src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
> src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
> src/tests/hierarchical_allocator_tests.cpp
> a45b3dd0a8237fdd080536cb9ab600e71ad939d3
>
> Diff: https://reviews.apache.org/r/40431/diff/
>
>
> Testing
> ---
>
> 1. Make Check successfully;
>
> 2. $ curl http://9.110.48.168:5050/roles
> {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 25, 2015, 1:57 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 25, 2015, 1:35 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Summary (updated)
-
Enhance the existing HTTP endpoint /roles
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs
-
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}
$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 24, 2015, 10:11 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/http.cpp 6c647808a48879cbc176ffe7586c7e9b41bcf4c8
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/role_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40424/diff/
Testing (updated)
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"status":[{"infos":{"name":"*","weight":1.0}},{"infos":{"name":"aa","weight":1.0}},{"framework_id":[{"value":"f1e1af59-9468-4f
f0-8fb4-96825d86b6d7-0142"}],"infos":{"name":"bb","weight":1.0},"resources":[{"name":"cpus","role":"bb","scalar":{"value":5.0},
"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type":"SCALAR"}]},{"infos":{"name":"cc","weight":1.0}}]}
$ curl http://127.0.0.1:5050/roles/aa
{"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource
s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type
":"SCALAR"}]}]}
$ curl http://127.0.0.1:5050/roles/dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 23, 2015, 10:11 a.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles
> On Nov. 24, 2015, 4:19 a.m., Anand Mazumdar wrote:
> > I am assuming this review is still being constantly worked on. Can you
> > update the summary of this review to be a work in progress [WIP] ?
Thanks for your reminder, I have updated the summary.
- Yong Qiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/#review107709
---
On Nov. 24, 2015, 5:17 a.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40424/
> ---
>
> (Updated Nov. 24, 2015, 5:17 a.m.)
>
>
> Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
>
>
> Bugs: MESOS-3791
> https://issues.apache.org/jira/browse/MESOS-3791
>
>
> Repository: mesos
>
>
> Description
> ---
>
> In this ticket, we will enhance the existing
> HTTP endpoint to query roles as outlined in
> the dynamic role design Doc.
>
>
> Diffs
> -
>
> src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
>
> Diff: https://reviews.apache.org/r/40424/diff/
>
>
> Testing
> ---
>
> Test results:
> $ curl http://127.0.0.1:5050/roles
> {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
>
> $ curl http://127.0.0.1:5050/roles?roleName=aa
> {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
>
>
> $ curl http://127.0.0.1:5050/roles?roleName=dd
> The specified role [dd] does not exist!
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 24, 2015, 5:13 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 24, 2015, 5:17 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Summary (updated)
-
[WIP] ]Enhance the existing HTTP endpoint /roles
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 24, 2015, 2:36 a.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 24, 2015, 7:25 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
2a21364fdcaa4ec5e5567b9f367c14a1579b9a49
src/master/allocator/mesos/hierarchical.cpp
aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a
src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66
src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 23, 2015, 2:55 p.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing (updated)
---
Test results:
$ curl http://127.0.0.1:5050/roles
{"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=aa
{"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
$ curl http://127.0.0.1:5050/roles?roleName=dd
The specified role [dd] does not exist!
Thanks,
Yong Qiao Wang
Re: Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
(Updated Nov. 23, 2015, 2:53 p.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs (updated)
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 20, 2015, 2:01 a.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3
include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/master/allocator/mesos/allocator.hpp
d2d32af227d66c4030becd4cd64b907a70d25f49
src/master/allocator/mesos/hierarchical.hpp
64ccf4164197e59d93d739fa2afbdee2cc2a1d23
src/master/allocator/mesos/hierarchical.cpp
f2e3b639f210eb06c70584ee7294609d9fd978ad
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28
src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34
src/tests/hierarchical_allocator_tests.cpp
740cfa801ee90417c038308192d1f4f2416f8315
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40469: Update Allocator interface to support dynamic roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 20, 2015, 2:02 a.m.) Review request for mesos, Adam B, Guangya Liu, and Qian Zhang. Bugs: MESOS-3956 https://issues.apache.org/jira/browse/MESOS-3956 Repository: mesos Description --- Update Allocator interface to support dynamic roles Diffs (updated) - include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 src/master/allocator/mesos/allocator.hpp d2d32af227d66c4030becd4cd64b907a70d25f49 src/master/allocator/mesos/hierarchical.hpp 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 src/master/allocator/mesos/hierarchical.cpp f2e3b639f210eb06c70584ee7294609d9fd978ad src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 20, 2015, 6:42 a.m.)
Review request for mesos, Adam B, Guangya Liu, and Qian Zhang.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3
include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/master/allocator/mesos/allocator.hpp
d2d32af227d66c4030becd4cd64b907a70d25f49
src/master/allocator/mesos/hierarchical.hpp
64ccf4164197e59d93d739fa2afbdee2cc2a1d23
src/master/allocator/mesos/hierarchical.cpp
f2e3b639f210eb06c70584ee7294609d9fd978ad
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28
src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34
src/tests/hierarchical_allocator_tests.cpp
740cfa801ee90417c038308192d1f4f2416f8315
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
Review request for mesos, Adam B and Qian Zhang.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs
-
include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3
include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/master/allocator/mesos/allocator.hpp
d2d32af227d66c4030becd4cd64b907a70d25f49
src/master/allocator/mesos/hierarchical.hpp
64ccf4164197e59d93d739fa2afbdee2cc2a1d23
src/master/allocator/mesos/hierarchical.cpp
f2e3b639f210eb06c70584ee7294609d9fd978ad
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28
src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34
src/tests/hierarchical_allocator_tests.cpp
740cfa801ee90417c038308192d1f4f2416f8315
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Re: Review Request 40431: Move RoleInfo message out of allocator.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
---
(Updated Nov. 19, 2015, 6:46 a.m.)
Review request for mesos, Adam B and Qian Zhang.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description
---
Move RoleInfo message out of allocator.proto
Diffs (updated)
-
include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3
include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752
src/master/allocator/mesos/allocator.hpp
d2d32af227d66c4030becd4cd64b907a70d25f49
src/master/allocator/mesos/hierarchical.hpp
64ccf4164197e59d93d739fa2afbdee2cc2a1d23
src/master/allocator/mesos/hierarchical.cpp
f2e3b639f210eb06c70584ee7294609d9fd978ad
src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80
src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28
src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34
src/tests/hierarchical_allocator_tests.cpp
740cfa801ee90417c038308192d1f4f2416f8315
Diff: https://reviews.apache.org/r/40431/diff/
Testing
---
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Review Request 40469: Update Allocator interface to support dynamic roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- Review request for mesos. Repository: mesos Description --- Update Allocator interface to support dynamic roles Diffs - include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 src/master/allocator/mesos/allocator.hpp d2d32af227d66c4030becd4cd64b907a70d25f49 src/master/allocator/mesos/hierarchical.hpp 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 src/master/allocator/mesos/hierarchical.cpp f2e3b639f210eb06c70584ee7294609d9fd978ad src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 40469: Update Allocator interface to support dynamic roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40469/ --- (Updated Nov. 19, 2015, 6:48 a.m.) Review request for mesos, Adam B and Qian Zhang. Bugs: MESOS-3956 https://issues.apache.org/jira/browse/MESOS-3956 Repository: mesos Description --- Update Allocator interface to support dynamic roles Diffs - include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 src/master/allocator/mesos/allocator.hpp d2d32af227d66c4030becd4cd64b907a70d25f49 src/master/allocator/mesos/hierarchical.hpp 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 src/master/allocator/mesos/hierarchical.cpp f2e3b639f210eb06c70584ee7294609d9fd978ad src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 Diff: https://reviews.apache.org/r/40469/diff/ Testing (updated) --- Make check successfully. Thanks, Yong Qiao Wang
Review Request 40424: Enhance the existing HTTP endpoint /roles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40424/
---
Review request for mesos and Adam B.
Bugs: MESOS-3791
https://issues.apache.org/jira/browse/MESOS-3791
Repository: mesos
Description
---
In this ticket, we will enhance the existing
HTTP endpoint to query roles as outlined in
the dynamic role design Doc.
Diffs
-
src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0
Diff: https://reviews.apache.org/r/40424/diff/
Testing
---
Test results:
$ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
Review Request 39754: Set the UUID of the expected ACK.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Set the UUID of the expected ACK. Diffs - src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 Diff: https://reviews.apache.org/r/39754/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 39754: Set the UUID of the expected ACK.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/ --- (Updated 十月 29, 2015, 12:25 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Set the UUID of the expected ACK. Diffs - src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 Diff: https://reviews.apache.org/r/39754/diff/ Testing (updated) --- Make & Make check succesfully! Thanks, Yong Qiao Wang
Re: Review Request 39754: Set the UUID of the expected ACK.
> On 十月 29, 2015, 5:22 p.m., Vinod Kone wrote: > > Hey Yong. Would you mind if I take over the fix for this? the fix is a bit > > involved and i would like to cleanup some tech debt in the process. If you > > are ok with that, please discard this review. OK, thanks! - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/#review104449 --- On 十月 29, 2015, 12:25 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39754/ > --- > > (Updated 十月 29, 2015, 12:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Set the UUID of the expected ACK. > > > Diffs > - > > src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 > > Diff: https://reviews.apache.org/r/39754/diff/ > > > Testing > --- > > Make & Make check succesfully! > > > Thanks, > > Yong Qiao Wang > >
Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39516/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1832 https://issues.apache.org/jira/browse/MESOS-1832 Repository: mesos Description --- Slave should accept PingSlaveMessage but not "PING" message. Diffs - src/master/master.cpp 2cc814721a8c85b330a402b0ec54491a0b0db5aa src/slave/slave.hpp 04a8646bce53adaaeb6e06ea65bb82e1f1da91e0 src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 Diff: https://reviews.apache.org/r/39516/diff/ Testing --- Make Successfully; Make check Successfully; Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 十月 16, 2015, 2:36 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs (updated) - src/master/master.cpp ba12a83 src/tests/status_update_manager_tests.cpp 9970d71 Diff: https://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 十月 16, 2015, 2:03 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs (updated) - src/master/master.cpp 6bee4f3 src/tests/status_update_manager_tests.cpp 9970d71 Diff: https://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
> On 十月 15, 2015, 6:38 p.m., Vinod Kone wrote: > > src/tests/status_update_manager_tests.cpp, line 844 > > <https://reviews.apache.org/r/38051/diff/4/?file=1083944#file1083944line844> > > > > new line. Do you mean to add an another new line? I found two new lines are added before all functions in this test file, so I add an another new line before this function. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review102731 --- On 十月 16, 2015, 2:36 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > --- > > (Updated 十月 16, 2015, 2:36 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Only update the task status when its old status is not terminal. > > > Diffs > - > > src/master/master.cpp ba12a83 > src/tests/status_update_manager_tests.cpp 9970d71 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > --- > > UT: > 1. Write a test for this change. > 2. make successfully! > 3. make check successfully! > 4. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 24, 2015, 9:45 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs - src/master/master.cpp 6bee4f3 src/tests/status_update_manager_tests.cpp 9970d71 Diff: https://reviews.apache.org/r/38051/diff/ Testing (updated) --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > strategy are: > > 1. Change the python test executor to send the TASK_FINASHED with two > times; > 2. Check the error log message of maser; > > Test passwd! > > Vinod, I am not familiar with current test framework of mesos, cloud you > provide some similar test code, and I can refer to write my test case for > this. Thanks! > > Vinod Kone wrote: > Instaed of updating python executor, write a self-contained unit test. > Take a look at "UnacknowledgedTerminalTask" and > "ReleaseResourcesForTerminalTaskWithPendingUpdates" in > src/tests/master_tests.cpp for inspiration on how to write such a test. > > Also, instead of sending TASK_FINISHED multiple times, have the executor > send TASK_FINISHED followed by a TASK_KILLED. That way you can check that the > status of the task hasn't changed in the master. > > Yong Qiao Wang wrote: > Thanks Vinod. In Master::statusUpdate function, I find if the status > update is invalid(such as out-of-order updates), we still forward the updates > to related framework and update the metrics > (metrics->valid_status_updates++), is it reasonable? > > Vinod Kone wrote: > yes. Vinod, I have appended the test code, my test strantegy are: 1. Launch a task and finish it, then the task status will be changed to TASK_FINISHED. 2. Send a TASK_KILLED update for the same task again. 3. Use the HTTP endpoint /tasks to check out latest status of this task, it should be TASK_FINISHED rather than TASK_KILLED. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99453 --- On Sept. 24, 2015, 9:39 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > --- > > (Updated Sept. 24, 2015, 9:39 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Only update the task status when its old status is not terminal. > > > Diffs > - > > src/master/master.cpp 6bee4f3 > src/tests/status_update_manager_tests.cpp 9970d71 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > --- > > UT: > > 1. make successfully! > 2. make check successfully! > 3. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 24, 2015, 9:39 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs (updated) - src/master/master.cpp 6bee4f3 src/tests/status_update_manager_tests.cpp 9970d71 Diff: https://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > strategy are: > > 1. Change the python test executor to send the TASK_FINASHED with two > times; > 2. Check the error log message of maser; > > Test passwd! > > Vinod, I am not familiar with current test framework of mesos, cloud you > provide some similar test code, and I can refer to write my test case for > this. Thanks! > > Vinod Kone wrote: > Instaed of updating python executor, write a self-contained unit test. > Take a look at "UnacknowledgedTerminalTask" and > "ReleaseResourcesForTerminalTaskWithPendingUpdates" in > src/tests/master_tests.cpp for inspiration on how to write such a test. > > Also, instead of sending TASK_FINISHED multiple times, have the executor > send TASK_FINISHED followed by a TASK_KILLED. That way you can check that the > status of the task hasn't changed in the master. Thanks Vinod. In Master::statusUpdate function, I find if the status update is invalid(such as out-of-order updates), we still forward the updates to related framework and update the metrics (metrics->valid_status_updates++), is it reasonable? - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99453 --- On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > --- > > (Updated Sept. 18, 2015, 7:15 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Only update the task status when its old status is not terminal. > > > Diffs > - > > src/master/master.cpp 1c4e7af > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > --- > > UT: > > 1. make successfully! > 2. make check successfully! > 3. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated Sept. 18, 2015, 7:15 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs (updated) - src/master/master.cpp 1c4e7af Diff: https://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? I find the code changes in this patch does not be tested with an end-to-end case except to check the error log messages of master, so my test strategy are: 1. Change the python test executor to send the TASK_FINASHED with two times; 2. Check the error log message of maser; Test passwd! Vinod, I am not familiar with current test framework of mesos, cloud you provide some similar test code, and I can refer to write my test case for this. Thanks! - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99453 --- On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > --- > > (Updated Sept. 18, 2015, 7:15 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Only update the task status when its old status is not terminal. > > > Diffs > - > > src/master/master.cpp 1c4e7af > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > --- > > UT: > > 1. make successfully! > 2. make check successfully! > 3. Run test framework successfully! > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 37532: Add QUIESCE call interface to the scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99153 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 15, 2015, 11 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37532/ > --- > > (Updated Sept. 15, 2015, 11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > --- > > This is just part of MESOS-3037, this patch only add the interface > of QUIESCE call. > > > Diffs > - > > include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd > include/mesos/scheduler/scheduler.proto > 19f548dba4b5d72fca8e692c5f15796feca17106 > src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb > src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a > src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 > > Diff: https://reviews.apache.org/r/37532/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 37873: Add quiesce logic in allocator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99152 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 6, 2015, 2:40 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37873/ > --- > > (Updated Sept. 6, 2015, 2:40 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod > Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > --- > > Add quiesce logic in allocator > > > Diffs > - > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > cb4020dea897ef198cd9898cabecf61edfade834 > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 > > Diff: https://reviews.apache.org/r/37873/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/#review98394 --- src/master/master.cpp <https://reviews.apache.org/r/38251/#comment154867> If the frameworkInfo.id()and framework->pid do not changed when reregister, then it does not need to call slave to update framework pid. This "return" can gurad this, so this return does not be removed. - Yong Qiao Wang On Sept. 10, 2015, 10:12 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38251/ > --- > > (Updated Sept. 10, 2015, 10:12 a.m.) > > > Review request for mesos, Joris Van Remoortere and Vinod Kone. > > > Bugs: MESOS-3184 > https://issues.apache.org/jira/browse/MESOS-3184 > > > Repository: mesos > > > Description > --- > > FrameworkInfo should only be updated if the re-registration is valid > > > Diffs > - > > src/master/master.cpp 4b60e637b19e749e27c4a8eb9b0a95c7e9305c5f > > Diff: https://reviews.apache.org/r/38251/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 37177: Maintenance Primitives: Added inverse offers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review98186 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37177/ > --- > > (Updated Sept. 2, 2015, 7:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > include/mesos/maintenance/maintenance.hpp > 7fec3ffe063e766dcec4952001fa5c6e20d9eec8 > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > 38f8fd2c84314bb3731684d0e9795cb4f50a227e > src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/tests/hierarchical_allocator_tests.cpp > 9748ca0b3fee25dcec51c64d8ba84dbd4aaf > src/tests/master_allocator_tests.cpp > 89331965553505f6b7eebf39ad27d943df816a24 > src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 > src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b > src/tests/resource_offers_tests.cpp > 882a9ff4d09aace486182828bf43b643b0d0c519 > src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 > > Diff: https://reviews.apache.org/r/37177/diff/ > > > Testing > --- > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review98187 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37180/ > --- > > (Updated Sept. 2, 2015, 7:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > > Diff: https://reviews.apache.org/r/37180/diff/ > > > Testing > --- > > The tests break as expected. > With the scheduler API change there are CHECKs that fail. > Once we update the API these will be resolved. > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98142 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37284/ > --- > > (Updated Sept. 2, 2015, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > > Diff: https://reviews.apache.org/r/37284/diff/ > > > Testing > --- > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98143 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37283/ > --- > > (Updated Sept. 2, 2015, 7:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/master_maintenance_tests.cpp > fb8dca3757a9565d5eb5a69eed10aa34602bb15c > > Diff: https://reviews.apache.org/r/37283/diff/ > > > Testing > --- > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review98144 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37234/ > --- > > (Updated Sept. 2, 2015, 7:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > > Diff: https://reviews.apache.org/r/37234/diff/ > > > Testing > --- > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 38051: Only update the task status when its old status is not terminal.
> On 九月 4, 2015, 7:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4118 > > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118> > > > > Instead of not calling updateTask() the logic should be inside > > updateTask() to do the right thing. Note that updateTask() already has > > logic to deal with duplicate terminal updates. > > Vinod Kone wrote: > Also, needs a test! Thanks a billion for your many times review. I have updated the changes by your usful comments. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97790 ------- On 九月 2, 2015, 1:13 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38051/ > --- > > (Updated 九月 2, 2015, 1:13 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2864 > https://issues.apache.org/jira/browse/MESOS-2864 > > > Repository: mesos > > > Description > --- > > Only update the task status when its old status is not terminal. > > > Diffs > - > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > > Diff: https://reviews.apache.org/r/38051/diff/ > > > Testing > --- > > > Thanks, > > Yong Qiao Wang > >
Review Request 38145: export additional message metrics from scheduler driver
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- Review request for mesos. Bugs: MESOS-3022 https://issues.apache.org/jira/browse/MESOS-3022 Repository: mesos Description --- export additional message metrics from scheduler driver Diffs - src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 Diff: https://reviews.apache.org/r/38145/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 九月 5, 2015, 1:38 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs (updated) - src/master/master.cpp 5589eca Diff: https://reviews.apache.org/r/38051/diff/ Testing (updated) --- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang
Re: Review Request 38145: export additional message metrics from scheduler driver
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---
(Updated 九月 5, 2015, 2:06 p.m.)
Review request for mesos.
Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022
Repository: mesos
Description
---
export additional message metrics from scheduler driver
Diffs (updated)
-
src/sched/sched.cpp 012af05
src/tests/scheduler_driver_tests.cpp 4963f5d
Diff: https://reviews.apache.org/r/38145/diff/
Testing
---
UT:
1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:
# curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}
Thanks,
Yong Qiao Wang
Re: Review Request 38145: export additional message metrics from scheduler driver
> On 九月 5, 2015, 1:04 p.m., haosdent huang wrote:
> > src/sched/sched.cpp, line 102
> > <https://reviews.apache.org/r/38145/diff/1/?file=1064631#file1064631line102>
> >
> > I think need change order to match dictionnary order here.
Thanks a million! I will update the order in the updated code diff.
- Yong Qiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97857
---
On 九月 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
>
> (Updated 九月 5, 2015, 12:41 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
>
>
> Repository: mesos
>
>
> Description
> ---
>
> export additional message metrics from scheduler driver
>
>
> Diffs
> -
>
> src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
> src/tests/scheduler_driver_tests.cpp
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71
>
> Diff: https://reviews.apache.org/r/38145/diff/
>
>
> Testing
> ---
>
> UT:
>
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
>
> # curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38145: export additional message metrics from scheduler driver
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---
(Updated 九月 5, 2015, 12:41 p.m.)
Review request for mesos.
Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022
Repository: mesos
Description
---
export additional message metrics from scheduler driver
Diffs
-
src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21
src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71
Diff: https://reviews.apache.org/r/38145/diff/
Testing (updated)
---
UT:
1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:
# curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}
Thanks,
Yong Qiao Wang
Re: Review Request 38145: export additional message metrics from scheduler driver
> On 九月 5, 2015, 3:27 p.m., haosdent huang wrote:
> > Ship It!
>
> haosdent huang wrote:
> Looks good for me. But you need find a committer help you review and
> commit this patch. :-)
Thanks again. That's very nice of you.
- Yong Qiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---
On 九月 5, 2015, 11:41 p.m., Yong Qiao Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
>
> (Updated 九月 5, 2015, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
>
>
> Repository: mesos
>
>
> Description
> ---
>
> export additional message metrics from scheduler driver
>
>
> Diffs
> -
>
> src/sched/sched.cpp 012af05
> src/tests/scheduler_driver_tests.cpp 4963f5d
>
> Diff: https://reviews.apache.org/r/38145/diff/
>
>
> Testing
> ---
>
> UT:
>
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
>
> # curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:46 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1831 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs - src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 3, 2015, 7:45 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1831 and MESOS-1832 https://issues.apache.org/jira/browse/MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1832 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs (updated) - src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing (updated) --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:04 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1831 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp d07b6860a5b5cbed910b2e9e2ab2429bd70a3999 3rdparty/libprocess/src/tests/process_tests.cpp 435663b10c1bfce07e8e84719aa14b5867c651c6 src/Makefile.am 4b643a32eb68dbd52714e9d66451dc2b62576f6d src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 src/linux/perf.cpp 0011482cf9d920485728798518d32af0e9627724 src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/slave/containerizer/isolators/cgroups/perf_event.hpp 1f722ef3ef7ab7fce5542d4affae961d6cec2406 src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e src/slave/containerizer/provisioners/backend.cpp 6560ece14d8618878a35d1bfe27db3958da64358 src/slave/containerizer/provisioners/backends/copy.hpp 2abca37ed2479d42c634c23cac8e40d515249988 src/slave/containerizer/provisioners/backends/copy.cpp b56946562525e79bef3a7387cd71f39fd0690683 src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 src/tests/containerizer/provisioner_backend_tests.cpp f2498b109c910fbf753a53b4b36a88b8d779aa69 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
> On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 79 > > <https://reviews.apache.org/r/38050/diff/3/?file=1063131#file1063131line79> > > > > why the change to process::Message here and everywhere else? Actually, namespace "using process::Message;" has been used in the header of this file, so it does not need to change to process::Message. I will update to roolback these changes. > On 九月 3, 2015, 3:45 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 187-195 > > <https://reviews.apache.org/r/38050/diff/3/?file=1063130#file1063130line187> > > > > any reason to not just call pong() here? Update the pongOld function to just call pong(). - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97641 --- On 九月 3, 2015, 7:46 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38050/ > --- > > (Updated 九月 3, 2015, 7:46 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1831 > https://issues.apache.org/jira/browse/MESOS-1831 > > > Repository: mesos > > > Description > --- > > Master should send PingSlaveMessage instead of "PING"; Slave should accept > PingSlaveMessage but not "PING" message; > > > Diffs > - > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c > src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 > src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c > > Diff: https://reviews.apache.org/r/38050/diff/ > > > Testing > --- > > Test2: Start master and slave to debug the PingSlaveMessage. Passed! > Test1: Run make check successfully! > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 4, 2015, 1:18 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1831 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs (updated) - src/master/master.cpp 56bcbcc src/tests/partition_tests.cpp b7030ad src/tests/slave_recovery_tests.cpp 4d137e0 src/tests/slave_tests.cpp 2411918 Diff: https://reviews.apache.org/r/38050/diff/ Testing --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang
Review Request 38051: Only update the task status when its old status is not terminal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2864 https://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Only update the task status when its old status is not terminal. Diffs - src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 Diff: https://reviews.apache.org/r/38051/diff/ Testing --- Thanks, Yong Qiao Wang
Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1831 and MESOS-1832 https://issues.apache.org/jira/browse/MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1832 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs - src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 Diff: https://reviews.apache.org/r/38050/diff/ Testing ------- Thanks, Yong Qiao Wang
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
> On 九月 2, 2015, 12:55 p.m., Klaus Ma wrote: > > Thanks @klaus Ma for your comments. I have addressed all of them. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97434 --- On 九月 2, 2015, 2:16 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38050/ > --- > > (Updated 九月 2, 2015, 2:16 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1831 and MESOS-1832 > https://issues.apache.org/jira/browse/MESOS-1831 > https://issues.apache.org/jira/browse/MESOS-1832 > > > Repository: mesos > > > Description > --- > > Master should send PingSlaveMessage instead of "PING"; Slave should accept > PingSlaveMessage but not "PING" message; > > > Diffs > - > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 > src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 > src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c > src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 > src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c > > Diff: https://reviews.apache.org/r/38050/diff/ > > > Testing > --- > > > Thanks, > > Yong Qiao Wang > >
Re: Review Request 37669: Ignore overflow docker components in version parsing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97452 --- Ship it! Ship It! - Yong Qiao Wang On 八月 30, 2015, 8:45 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37669/ > --- > > (Updated 八月 30, 2015, 8:45 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Timothy Chen. > > > Bugs: MESOS-2986 > https://issues.apache.org/jira/browse/MESOS-2986 > > > Repository: mesos > > > Description > --- > > Ignore overflow docker components in version parsing. > > > Diffs > - > > src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 > > Diff: https://reviews.apache.org/r/37669/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/ --- (Updated 九月 2, 2015, 2:16 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-1831 and MESOS-1832 https://issues.apache.org/jira/browse/MESOS-1831 https://issues.apache.org/jira/browse/MESOS-1832 Repository: mesos Description --- Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message; Diffs (updated) - src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing ------- Thanks, Yong Qiao Wang
Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37784/ --- Review request for mesos. Bugs: MESOS-3301 https://issues.apache.org/jira/browse/MESOS-3301 Repository: mesos Description --- Remove the redundant check in HierarchicalDRFAlocator. Diffs - src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e Diff: https://reviews.apache.org/r/37784/diff/ Testing --- Thanks, Yong Qiao Wang
Review Request 37562: The revocable resource information also are missed for slave node in monitoring doc , fix it in this patch.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37562/ --- Review request for mesos. Bugs: MESOS-3286 https://issues.apache.org/jira/browse/MESOS-3286 Repository: mesos Description --- The revocable resource information also are missed for slave node in monitoring doc ,fix it in this patch. Diffs - docs/monitoring.md 6ddf07d334ece4d4dc83d805ac0c51c9579c47c9 Diff: https://reviews.apache.org/r/37562/diff/ Testing --- Thanks, Yong Qiao Wang
Review Request 37518: Add the revocable metrics information in monitoring doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37518/ --- Review request for mesos. Repository: mesos Description --- Add the revocable metrics information in monitoring doc Diffs - docs/monitoring.md d80f9362b33fec307eaaf93398631e6b2d02678f Diff: https://reviews.apache.org/r/37518/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 37518: Add the revocable metrics information in monitoring doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37518/ --- (Updated Aug. 17, 2015, 7:41 a.m.) Review request for mesos and Zhiwei Chen. Bugs: MESOS-3278 https://issues.apache.org/jira/browse/MESOS-3278 Repository: mesos Description --- Add the revocable metrics information in monitoring doc Diffs - docs/monitoring.md d80f9362b33fec307eaaf93398631e6b2d02678f Diff: https://reviews.apache.org/r/37518/diff/ Testing --- Thanks, Yong Qiao Wang
Review Request 37208: Fix the spell error in help message of slave component.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37208/ --- Review request for mesos and Zhiwei Chen. Bugs: MESOS-3228 https://issues.apache.org/jira/browse/MESOS-3228 Repository: mesos Description --- Fix the spell error in help message of slave component. Diffs - src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37208/diff/ Testing --- Thanks, Yong Qiao Wang
Re: Review Request 37179: Enhance the bootstrap script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/#review94385 --- Ship it! Ship It! - Yong Qiao Wang On Aug. 6, 2015, 9:28 a.m., Zhiwei Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/ --- (Updated Aug. 6, 2015, 9:28 a.m.) Review request for mesos and Yong Qiao Wang. Bugs: MESOS-3218 https://issues.apache.org/jira/browse/MESOS-3218 Repository: mesos Description --- Force override the link file when it is invalid. Diffs - bootstrap 779b33cdcb88b2417769bb046a17b47cd6042f2d Diff: https://reviews.apache.org/r/37179/diff/ Testing --- Thanks, Zhiwei Chen
