Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/ --- (Updated Jan. 7, 2016, 11:21 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/tests/master_quota_tests.cpp, line 1103 > > > > > > Does it matter that credentials != None()? Should you maybe clear out > > credentials as well? It should

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 2:38 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 210 > > > > > > Please add to configuration.md Thanks! - Till --- This is

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113255 --- src/master/flags.cpp (line 210)

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote: > > src/master/master.cpp, line 527 > > > > > > Does it make sense to document this behavior (the master not starting > > if flag and no credentials) to either some

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:46 p.m., Joerg Schad wrote: > > docs/configuration.md, line 344 > > > > > > How about: > > > > If true only authenticated requests for HTTP endpoint > > requiring authentification are

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/ --- (Updated Jan. 7, 2016, 8:29 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113318 --- Ship it! - Joerg Schad On Jan. 7, 2016, 8:29 p.m., Till

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:46 p.m., Joerg Schad wrote: > > docs/configuration.md, line 344 > > > > > > How about: > > > > If true only authenticated requests for HTTP endpoint > > requiring authentification are

Re: Review Request 42025: Added flag for enabling HTTP authentication.

> On Jan. 7, 2016, 7:39 p.m., Joerg Schad wrote: > > src/master/master.cpp, line 527 > > > > > > Does it make sense to document this behavior (the master not starting > > if flag and no credentials) to either some

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113293 --- src/master/flags.cpp (line 212)

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113301 --- docs/configuration.md (line 344)

Re: Review Request 42025: Added flag for enabling HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113336 --- Ship it! Minor suggestions, but otherwise looks great Thanks!