Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 24, 2016, 4:13 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review125186 --- Fix it, then Ship it! Thanks! CHANGELOG (line 6)

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 23, 2016, 11:26 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 22, 2016, 5:15 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-19 Thread Alexander Rukletsov
> On March 15, 2016, 11:34 p.m., Ben Mahler wrote: > > Looking pretty good. Would be great to have a CHANGELOG update here that > > outlines the deprecation and what we're advising users to do in each > > version. I'll update the changelog in the next patch, hope this is fine. > On March

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 18, 2016, 5:23 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-18 Thread Ben Mahler
> On March 19, 2016, 2:16 a.m., Ben Mahler wrote: > > Ok I misunderstood what the intent was here. Generally when we say > > "deprecated" we maintain the old behavior and we plan to remove the support > > in a future version. This doesn't maintain the old behavior, why not leave > > as is and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review124361 --- Ok I misunderstood what the intent was here. Generally when we

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review123787 --- Looking pretty good. Would be great to have a CHANGELOG update

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 15, 2016, 2:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review123533 --- src/slave/flags.cpp (line 531)

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 14, 2016, 5:51 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and