Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 21, 2015, 7:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Nov. 16, 2015, 11:08 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review106628 --- Ship it! Ship It! - Bernd Mathiske On Nov. 9, 2015, 8:01 p.m.,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Nov. 16, 2015, 1:55 a.m., Bernd Mathiske wrote: > > src/tests/module_tests.cpp, line 293 > > > > > > This tests whether we can retrieve the parameters that were filled it > > back out. Unlike the tests above

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review105805 --- Ship it! Ship It! - Till Toenshoff On Nov. 10, 2015, 4:01

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Nov. 10, 2015, 5:01 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review105064 --- Ship it! Ship It! - Guangya Liu On 十月 21, 2015, 12:52 p.m.,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103909 --- Ship it! Ship It! - Klaus Ma On Oct. 21, 2015, 8:52 p.m.,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 21, 2015, 9:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103837 --- LGTM - Kapil, any thoughts? - Niklas Nielsen On Oct. 21, 2015,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 21, 2015, 3:02 p.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review103365 --- src/module/manager.hpp (line 94)

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 21, 2015, 9:02 a.m., Klaus Ma wrote: > > src/module/manager.hpp, line 94 > > > > > > Should we merge with `moduleParameters[moduleName]` or replace it? IMO, > > prefer to merge them; I'd like to leave it

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 21, 2015, 2:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 20, 2015, 12:18 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- (Updated Oct. 20, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote: > > src/tests/module.hpp, lines 76-77 > > > > > > same comment here - it would be great to have fully-documented, > > properly-formatted javadoc here, also

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 12, 2015, 2:54 p.m., Marco Massenzio wrote: > > Would it be possible to add a few unit tests, also to show usage patterns? > > especially given the absence of any documentation, it's kinda difficult to > > figure out how is this "intended to work" and, without tests, whether it > >

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

> On Oct. 12, 2015, 5:54 a.m., Marco Massenzio wrote: > > Would it be possible to add a few unit tests, also to show usage patterns? > > especially given the absence of any documentation, it's kinda difficult to > > figure out how is this "intended to work" and, without tests, whether it > >

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102237 --- Ship it! Ship It! - Guangya Liu On 十月 2, 2015, 8:11 p.m.,

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102245 --- Would it be possible to add a few unit tests, also to show usage

Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/ --- Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. Bugs: