Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Nov. 9, 2015, 2:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-11-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Nov. 9, 2015, 12:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104732 --- Ship it! support/apply-reviews.py (line 45)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-28 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 28, 2015, 2:57 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104090 --- Note: considering the amount of changes since my last review, my

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104105 --- Ship it! modulo joseph's comments. support/apply-reviews.py

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-26 Thread Vinod Kone
> On Oct. 22, 2015, 9:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > > > > > s/extract_// > > Artem Harutyunyan wrote: > Marco commented earlier on this one `nit: you are 'masking' the

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-23 Thread Artem Harutyunyan
> On Oct. 22, 2015, 2:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > > > > > s/extract_// Marco commented earlier on this one `nit: you are 'masking' the global builtin id() here - that's a

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103656 --- support/apply-reviews.py (line 25)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-20 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 20, 2015, 12:28 a.m.) Review request for mesos, Benjamin

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review103147 --- support/apply-reviews.py (line 12)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 18, 2015, 3:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review102877 --- Thanks for all the tips, Marco\! I learned a lot of Python here

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
> On Oct. 14, 2015, 5:55 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 7 > > > > > > uhm... could we use `requests` instead? > > much more modern API and widespread use. `requests` looks great,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-16 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 15, 2015, 11:50 p.m.) Review request for mesos, Benjamin

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-14 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101980 --- support/apply-reviews.py (line 7)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-04 Thread Guangya Liu
> On 十月 1, 2015, 1:12 p.m., Guangya Liu wrote: > > support/apply-reviews.py, line 2 > > > > > > The import should be in alpha order > > Artem Harutyunyan wrote: > I am happy to fix this, but could you please

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101405 --- IMHO, we keep both apply-reviews.py and apply-reviews.sh and call

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101225 --- support/apply-reviews.py (line 2)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-01 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Oct. 1, 2015, 10:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-01 Thread Artem Harutyunyan
> On Oct. 1, 2015, 6:12 a.m., Guangya Liu wrote: > > support/apply-reviews.py, line 2 > > > > > > The import should be in alpha order I am happy to fix this, but could you please justify your reasoning? - Artem

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review101129 --- Ship it! LGTM! Note: The long-form cmd-line arguments (i.e.

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-30 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Sept. 29, 2015, 11:09 p.m.) Review request for mesos, Benjamin

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100823 --- Ship it! support/apply-reviews.py (line 8)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100770 --- Patch looks great! Reviews applied: [38705] All tests passed. -

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-26 Thread Artem Harutyunyan
> On Sept. 24, 2015, 5:38 p.m., Joseph Wu wrote: > > support/apply-reviews.py, line 13 > > > > > > Might be cleaner/safer to use urlparse.urljoin for this: > >

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Sept. 26, 2015, 7:02 p.m.) Review request for mesos, Joris Van

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-25 Thread Vinod Kone
> On Sept. 25, 2015, 4:35 p.m., Joseph Wu wrote: > > One more thing: when the patch fails to apply, I get this message: > > > > ``` > > Traceback (most recent call last): > > File "support/apply-reviews.py", line 86, in > > apply_review(r, dry_run) > > File "support/apply-reviews.py",

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100588 --- One more thing: when the patch fails to apply, I get this message:

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-25 Thread Joseph Wu
> On Sept. 25, 2015, 9:35 a.m., Joseph Wu wrote: > > One more thing: when the patch fails to apply, I get this message: > > > > ``` > > Traceback (most recent call last): > > File "support/apply-reviews.py", line 86, in > > apply_review(r, dry_run) > > File "support/apply-reviews.py",

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100375 --- Patch looks great! Reviews applied: [38705] All tests passed. -

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100505 --- Mostly just python style and commenting. My python is a bit rusty

Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Vinod Kone.