Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 2:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Nov. 24, 2015, 6:48 p.m., Klaus Ma wrote: > > include/mesos/role/role.proto, line 38 > > > > > > I'm thinke whether we need to enhance weight to `int`. Any case that we > > has to use `double` as weight? If we

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 2:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review109704 --- I'm not sure exactly why you needed to move RoleInfo out of

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > include/mesos/master/allocator.proto, line 19 > > > > > > Shouldn't this file have `java_package` and `java_outer_classname` just > > like the other protos? > >

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Dec. 10, 2015, 10:40 a.m., Adam B wrote: > > I'm not sure exactly why you needed to move RoleInfo out of > > allocator.proto. The RoleInfo we use for the allocator module API doesn't > > need to be (and perhaps shouldn't be) the same class that we use to display > > role information like

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 7, 2015, 8:41 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 7, 2015, 10:12 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 8, 2015, 5:15 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Dec. 8, 2015, 5:20 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 30, 2015, 3:09 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 30, 2015, 3:11 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 30, 2015, 7:06 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 26, 2015, 2:01 p.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 8:38 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 8:20 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

> On Nov. 25, 2015, 2:48 a.m., Klaus Ma wrote: > > include/mesos/role/role.proto, line 38 > > > > > > I'm thinke whether we need to enhance weight to `int`. Any case that we > > has to use `double` as weight? If we

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 25, 2015, 1:57 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 24, 2015, 7:25 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 20, 2015, 2:01 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review107298 --- src/Makefile.am (line 955)

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 20, 2015, 6:42 a.m.) Review request for mesos, Adam B, Guangya

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review106998 --- Patch looks great! Reviews applied: [40431] Passed command:

Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- Review request for mesos, Adam B and Qian Zhang. Bugs: MESOS-3944

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/ --- (Updated Nov. 19, 2015, 6:46 a.m.) Review request for mesos, Adam B and Qian