Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review132098 --- Ship it! Ship It! - Ben Mahler On April 29, 2016, 1:03

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131612 --- Ship it! Ship It! - Zhiwei Chen On April 29, 2016, 9:03

Re: Review Request 46730: Cleanup syscalls logic.

> On Kwi 30, 2016, 2:55 po południu, haosdent huang wrote: > > As I checked with @bingli1000 and @zhiwei via email before, this works in > > powerpc and IBM System z. Free feel to list your concerns about test :-). > > cc @bmahler and @janisz > > haosdent huang wrote: > By the way, I

Re: Review Request 46730: Cleanup syscalls logic.

> On April 30, 2016, 2:55 p.m., haosdent huang wrote: > > As I checked with @bingli1000 and @zhiwei via email before, this works in > > powerpc and IBM System z. Free feel to list your concerns about test :-). > > cc @bmahler and @janisz By the way, I think the `Summary` is not clear and

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131253 --- Ship it! As I checked with @bingli1000 and @zhiwei via email

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131157 --- Patch looks great! Reviews applied: [46730] Passed command:

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- (Updated April 29, 2016, 1:03 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 46730: Cleanup syscalls logic.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote: > > Could you also update the testing section? How did you ensure this compiles > > on the affected architectures? What do you mean by "testing section"? Unfortunatelly I've only tested it on ARM and x86_64 > On April 27, 2016, 7:41 p.m.,

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131077 --- src/linux/cgroups.cpp

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131070 --- Patch looks great! Reviews applied: [46730] Passed command:

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- (Updated April 29, 2016, 8:11 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 46730: Cleanup syscalls logic.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote: > > src/linux/ns.hpp, lines 161-162 > > > > > > This looks like a similar change but it would be great to split it into > > a separate patch. It's not immediately

Re: Review Request 46730: Cleanup syscalls logic.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote: > > src/linux/cgroups.cpp, line 29 > > > > > > Hm.. where is this header located? > > > > I'd expect to find a unistd.h here: > >

Re: Review Request 46730: Cleanup syscalls logic.

> On April 27, 2016, 7:41 p.m., Ben Mahler wrote: > > src/linux/cgroups.cpp, line 29 > > > > > > Hm.. where is this header located? > > > > I'd expect to find a unistd.h here: > >

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130831 --- Could you also update the testing section? How did you ensure

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130769 --- Patch looks great! Reviews applied: [46730] Passed command:

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130767 --- Ship it! Ship It! - haosdent huang On April 27, 2016, 11:44

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- (Updated April 27, 2016, 11:44 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 46730: Cleanup syscalls logic.

> On April 27, 2016, 10:30 a.m., haosdent huang wrote: > > src/linux/cgroups.cpp, line 28 > > > > > > I think we don't need change `cgroups.cpp`, right? > > > > Not yours, could you change the header files

Re: Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review130755 --- I think need update the summary and the description as well. For

Review Request 46730: Cleanup syscalls logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/ --- Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang. Bugs: