Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review86172 --- Ship it! Ship It! - Till Toenshoff On May 22, 2015, 7:15 p.m., S

Re: Review Request 34268: stout library - adding support for Solaris

> On June 1, 2015, 10:36 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 71-82 > > > > > > Seems we got some options here; > > A. use your separate, stream-based a

Re: Review Request 34268: stout library - adding support for Solaris

> On June 1, 2015, 10:36 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 71-82 > > > > > > Seems we got some options here; > > A. use your separate, stream-based a

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review85719 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review85054 --- Ship it! Ship It! - Stan Teresen On May 22, 2015, 7:15 p.m., Sta

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84974 --- Patch looks great! Reviews applied: [34268] All tests passed. - M

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/ --- (Updated May 22, 2015, 7:15 p.m.) Review request for mesos, Joris Van Remoorter

Re: Review Request 34268: stout library - adding support for Solaris

> On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: > > Thanks a lot for this, Stan - much appreciated! > > > > There are a couple of style nits here and there and one basic question on > > the need of the `read`-variant for Solaris. > > > > For submitting an updated patch, please consult th

Re: Review Request 34268: stout library - adding support for Solaris

> On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, line 72 > > > > > > Could you please explain why the standard implementation of this > > function w

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84202 --- Thanks a lot for this, Stan - much appreciated! There are a couple

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84068 --- Ship it! Ship It! - Stan Teresen On May 15, 2015, 2:25 p.m., Sta

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review83925 --- Patch looks great! Reviews applied: [34268] All tests passed. - M

Re: Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/ --- (Updated May 15, 2015, 2:25 p.m.) Review request for mesos. Repository: mesos

Review Request 34268: stout library - adding support for Solaris

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/ --- Review request for mesos. Repository: mesos-incubating Description --- s