Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 11:09 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 47 > > > > > > why optional? > > Bartek Plotka wrote: > IMO, because we can (only optionally) specify the descrip

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 47 > > > > > > why optional? > > Bartek Plotka wrote: > IMO, because we can (only optionally) specify the descrip

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 12:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 47 > > > > > > why optional? > > Bartek Plotka wrote: > IMO, because we can (only optionally) specify the descri

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 10:24 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 47 > > > > > > why optional? > > Bartek Plotka wrote: > IMO, because we can (only optionally) specify the descrip

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 12:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 48 > > > > > > why a timestamp? > > Bartek Plotka wrote: > It could be necessary for some advanced long term cor

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 9:07 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85252 --- include/mesos/slave/oversubscription.proto

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 8:50 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 48 > > > > > > why a timestamp? > > Bartek Plotka wrote: > It could be necessary for some advanced long term corr

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/oversubscription.proto, line 35 > > > > > > s/future/the future/ Agree. > On May 26, 2015, 7:26 p.m., Vinod Kone wrote: > > include/mesos/slave/

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85227 --- include/mesos/slave/oversubscription.proto

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 23, 2015, 3:35 p.m., Niklas Nielsen wrote: > > LGTM! > > > > Marco - mind taking a look at the comments and see if there are more things > > we need to discuss? done, thanks - Marco --- This is an automatically generated e-ma

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85067 --- Ship it! LGTM! Marco - mind taking a look at the comments and see

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85055 --- Patch looks great! Reviews applied: [34581] All tests passed. - M

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 23, 2015, 3:30 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 23, 2015, 3:27 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85053 --- include/mesos/slave/oversubscription.proto

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85045 --- Patch looks great! Reviews applied: [34581] All tests passed. - M

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 23, 2015, 12:40 a.m.) Review request for mesos, Jie Yu, Niklas Nie

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 1:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 42 > > > > > > can you define this instead as: > > > > ``` > > message ActionInfo { > > option

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 34 > > > > > > please consider calling this `QosCorrectiveAction` > > (we require CamelCase for our types, in

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85016 --- Patch looks great! Reviews applied: [34581] All tests passed. - M

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 22, 2015, 9:45 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 49 > > > > > > I have some concerns about this design - given the Note above, this > > would imply that we would

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

> On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: > > include/mesos/slave/oversubscription.proto, line 30 > > > > > > nit: s/correction/corrective action > > > > also, prefer "needs to be taken" Agree. Also

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84988 --- Thanks for doing this! Minor nits (and a design concern) but otherwi

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84984 --- Patch looks great! Reviews applied: [34581] All tests passed. - M

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 22, 2015, 7:46 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84944 --- Looks good! A few nits and let's get it in include/mesos/slave/ove

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review84858 --- Patch looks great! Reviews applied: [34581] All tests passed. - M

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 22, 2015, 2:31 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone