Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Sept. 1, 2015, 2:52 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [36612, 36620] > > > > All tests passed. > > Timothy Chen wrote: > Jie does this look good to you? > > Jie Yu wrote: > Should we close this given https://reviews.apache.org/r/37967/?

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Sept. 1, 2015, 2:52 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [36612, 36620] > > > > All tests passed. > > Timothy Chen wrote: > Jie does this look good to you? Should we close this given https://reviews.apache.org/r/37967/? - Jie --

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Sept. 1, 2015, 2:52 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [36612, 36620] > > > > All tests passed. Jie does this look good to you? - Timothy --- This is an automatically generated e-mail. To

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review97288 --- Patch looks great! Reviews applied: [36612, 36620] All tests passe

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Sept. 1, 2015, 2:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Sept. 1, 2015, 12:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Sept. 1, 2015, 9:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96872 --- src/linux/cgroups.cpp (line 1676)

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 28, 2015, 3:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote: > > src/linux/cgroups.cpp, line 1749 > > > > > > Do they need to be actual attributes? For example `kill()` could return > > a `Future>>>`, and `reap()` could

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 1776-1791 > > > > > > Could you please introduce a new function under cgroups namespace and > > put this logic there: > > > >

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96734 --- What's the status on this review? Is it still WIP? Would love to ge

Re: Review Request 36620: Added Non-Freezeer Task Killer.

> On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote: > > src/linux/cgroups.cpp, line 1750 > > > > > > Not sure if `chain` needs to be an attribute. The only reason I see is > > the discard call in `finalize()`. B

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96139 --- Given the rather complicated setup of this ( destroy -> Destroyer -.

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review96144 --- src/linux/cgroups.cpp (lines 1486 - 1487)

Re: Review Request 36620: Added Non-Freezeer Task Killer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 20, 2015, 11:42 a.m.) Review request for mesos, Benjamin Hindman