Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/ --- (Updated Nov. 9, 2015, 3:25 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Nov. 6, 2015, 2:40 p.m., Joerg Schad wrote: > > include/mesos/master/allocator.hpp, line 357 > > > > > > s/given role not set/nonexisting role? This sentence refers to an existing role without quota. Do you

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Nov. 2, 2015, 2:22 p.m., Joerg Schad wrote: > > src/master/allocator/mesos/allocator.hpp, line 268 > > > > > > Could we add a todo for updateQuota()? In my opinion this would make it > > easier to understand

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Nov. 4, 2015, 11:24 p.m., Joris Van Remoortere wrote: > > include/mesos/master/allocator.hpp, lines 332-347 > > > > > > do you want to re-order these (here or in the implementations) so that > > the function

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Nov. 5, 2015, 7:09 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 355-356 > > > > > > This bit is somewhat unclear: > > "the group of roles with quota set" sounds like it is referring

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/ --- (Updated Nov. 8, 2015, 11:06 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105638 --- Ship it! Ship It! - Guangya Liu On Nov. 8, 2015, 11:06 p.m.,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105640 --- Ship it! Ship It! - Guangya Liu On Nov. 8, 2015, 11:06 p.m.,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105422 --- include/mesos/master/allocator.hpp (line 357)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Oct. 25, 2015, 8:10 a.m., Klaus Ma wrote: > > include/mesos/master/allocator.hpp, line 358 > > > > > > It said Mesos master will also validate the quota request in design > > document; should we clarify which

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105431 --- Ship it! Ship It! - Klaus Ma On Nov. 6, 2015, 3:29 a.m.,

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105288 --- include/mesos/master/allocator.hpp (lines 355 - 356)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105175 --- Ship it! include/mesos/master/allocator.hpp (lines 332 - 347)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Oct. 25, 2015, 5:46 a.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 357 > > > > > > Why do we assume quota for the given role is not set prior to the call? > > I thought we support setting

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review104710 --- Ship it! src/master/allocator/mesos/allocator.hpp (line 268)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Oct. 25, 2015, 12:46 p.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 357 > > > > > > Why do we assume quota for the given role is not set prior to the call? > > I thought we support

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

> On Oct. 25, 2015, 12:10 a.m., Klaus Ma wrote: > > include/mesos/master/allocator.hpp, line 358 > > > > > > It said Mesos master will also validate the quota request in design > > document; should we clarify which

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103953 --- include/mesos/master/allocator.hpp (line 357)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103910 --- include/mesos/master/allocator.hpp (line 358)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103905 --- include/mesos/master/allocator.hpp (line 360)

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,