Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39452] > > > > Failed command: ./support/apply-review.sh -n -r 39452 > > > > Error: > > 2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ > > [2542/2542] -> "39452.patch" [1] > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39452] > > > > Failed command: ./support/apply-review.sh -n -r 39452 > > > > Error: > > 2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ > > [2542/2542] -> "39452.patch" [1] > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review10 --- Bad patch! Reviews applied: [39452] Failed command:

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review105385 --- Ship it! Please verify your test results from rendering the

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Nov. 6, 2015, 8:53 a.m., Adam B wrote: > > Please verify your test results from rendering the website and then I'll > > commit this. thanks for pointers, done! > On Nov. 6, 2015, 8:53 a.m., Adam B wrote: > > docs/scheduler-http-api.md, line 31 > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Nov. 6, 2015, 7:45 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Nov. 6, 2015, 8:35 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review105333 --- Ship it! Ship It! - Ben Whitehead On Nov. 5, 2015, 3:50 p.m.,

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Nov. 5, 2015, 11:50 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review105356 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103229 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 44 > > > > > > Nit: Can we just check for `200` here (since the response from > > `Subscribe` should be `200` for a good

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103267 --- Ship it! docs/scheduler-http-api.md (line 36)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 4:34 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 20, 2015, 9:30 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 66 > > > > > > Do we need this line anymore now ? This can be killed in favor of the > > following lines that we added around

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote: > > docs/scheduler-http-api.md, line 59 > > > > > > Should we also mention why just encoding one event per chunk won't > > suffice and why we needed this ? > >

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103314 --- docs/scheduler-http-api.md (lines 29 - 34)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103344 --- Patch looks great! Reviews applied: [39452] All tests passed. -

Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3566

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103152 --- Ship it! docs/scheduler-http-api.md (line 59)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/ --- (Updated Oct. 19, 2015, 9:07 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103194 --- docs/scheduler-http-api.md (lines 28 - 36)

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

> On Oct. 20, 2015, 1:03 a.m., Ben Whitehead wrote: > > docs/scheduler-http-api.md, lines 38-57 > > > > > > The rest of the HTTP API Documentation is language agnostic and I feel > > strongly that it should be kept