Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
> On Nov. 26, 2015, 3:35 p.m., Neil Conway wrote: > > src/tests/resources_tests.cpp, line 1526 > > > > > > If we're going to enable this test, the comment should be removed. Based on Klaus Ma's comments will

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-12-07 Thread Avinash sridharan
> On Nov. 26, 2015, 3:48 p.m., Klaus Ma wrote: > > src/tests/resources_tests.cpp, line 1534 > > > > > > We can not change this to `EXPECT_DOUBLE_EQ` because it's used to check > > `operator==` in `Resources`. I

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-11-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108097 --- Patch looks great! Reviews applied: [40730, 40732] Passed

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-11-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108141 --- I don't think we're ready to enable this test yet. The test is

Re: Review Request 40732: Enabling ResourcesTest.Precision

2015-11-26 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/#review108150 --- src/tests/resources_tests.cpp (line 1534)

Review Request 40732: Enabling ResourcesTest.Precision

2015-11-25 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40732/ --- Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. Bugs: