Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 26, 2016, 10:29 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review116455 --- Fix it, then Ship it! Looking good. Just some minor things. s

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 26, 2016, 9:19 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 361 > > > > > > dont you want to set `subscribe` and `nonSubscribe` to None()? As per our discussion, we don't set them to `None()

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review116179 --- src/executor/executor.cpp (line 274)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Jan. 21, 2016, 7:33 p.m., Vinod Kone wrote: > > Moved the code to: `connected`: Invoke this callback after `Subscribe`/non subscribe connection have been established. `disconnected`: Invoke this callback after any of `Subscribe`/non subscribe connection is broken. > On Jan. 21, 2016, 7

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 22, 2016, 1:36 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review115502 --- src/executor/executor.cpp (line 170)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Jan. 14, 2016, 10:33 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 123 > > > > > > The name of this struct is weird considering it is encapsulating two > > connections. > > > > s/HttpConn

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 20, 2016, 10:11 p.m.) Review request for mesos, Ben Mahler and Vi

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review114253 --- src/executor/executor.cpp (lines 20 - 21)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 12, 2016, 9:21 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 11, 2016, 8:13 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 6, 2016, 1:29 a.m.) Review request for mesos, Ben Mahler and Vino

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 30, 2015, 7:25 p.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 229 > > > > > > We should probably limit the max value here. Does not make much sense to me. We do not have any semantics in ou

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112340 --- src/executor/executor.cpp (line 229)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Dec. 30, 2015, 1:30 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112271 --- src/executor/executor.cpp (line 363)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 6:09 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 354 > > > > > > What is the purpose of mutex? It looks like we do the callbacks > > asynchronously. Which means, we have the lo

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112125 --- src/executor/executor.cpp (line 354)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Dec. 29, 2015, 3:11 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > > > > > "else" case? Nothing needs to be done for the `else` case. These env variables **might** be set by the agent w

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112114 --- src/executor/executor.cpp (line 54)

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Dec. 29, 2015, 12:11 a.m.) Review request for mesos, Ben Mahler and Vi

Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3550 https