Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-20 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review111431 --- This looks nicely mechanical given https://reviews.apache.org/r/412

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-15 Thread Joseph Wu
> On Dec. 14, 2015, 7:54 p.m., Timothy Chen wrote: > > src/docker/executor.hpp, line 89 > > > > > > Why default to an empty string? I forgot about module parameters when adding this flag. The `options` have now bee

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/ --- (Updated Dec. 15, 2015, 12:41 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review110389 --- src/docker/executor.hpp (line 89)

Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4