Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114988 --- Ship it! Worked perfectly fine in my tests. Let's fix the nits

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 18, 2016, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review115056 --- Patch looks great! Reviews applied: [42197] Passed command:

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 11:40 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 12:19 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 15, 2016, 3:38 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 14, 2016, 4:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

> On Jan. 14, 2016, 3:57 p.m., Benjamin Bannier wrote: > > src/tests/environment.cpp, lines 345-350 > > > > > > nit-pick: This could also be written as an `and` of the matchers and > > `perfError`; that would show

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

> On Jan. 13, 2016, 6:59 p.m., Till Toenshoff wrote: > > src/tests/environment.cpp, lines 315-329 > > > > > > Why would we not show this warning to users on e.g. OSX? > > > > Right now I would assume that

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 14, 2016, 2:07 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114473 --- Patch looks great! Reviews applied: [42197] Passed command:

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114494 --- Patch looks great! Reviews applied: [42197] Passed command:

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114544 --- Ship it! LGTM, tested under scenarios 1), 2), and 3). *Please

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114659 --- Right now I am not convinced the criterea used are actually

Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3082

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ --- (Updated Jan. 13, 2016, 2:32 p.m.) Review request for mesos and Till

Re: Review Request 42197: Added a filter for tests using 'perf' hardware events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114238 --- You might want to add a positive test to your "testing done" as