Re: Review Request 42236: Added a utility function to create https URI.

2016-01-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-17 Thread Jie Yu
> On Jan. 13, 2016, 7:05 p.m., Gilbert Song wrote: > > LGTM! Just consider whether or not we should put it as `https.hpp` under > > `schemes` directory. I prefer not. https is http + ssl. Also, they might share some functions in the future. - Jie ---

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-17 Thread Jie Yu
> On Jan. 13, 2016, 9:11 p.m., Timothy Chen wrote: > > src/uri/schemes/http.hpp, line 54 > > > > > > Should we provide the default port for https here? Nope. Tools (e.g., curl) will figure out the default. I don't wa

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-13 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114278 --- Ship it! Ship It! src/uri/schemes/http.hpp (line 54)

Re: Review Request 42236: Added a utility function to create https URI.

2016-01-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114257 --- Ship it! LGTM! Just consider whether or not we should put it as `h

Review Request 42236: Added a utility function to create https URI.

2016-01-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C