Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116966 --- Ship it! Ship It! - Kapil Arya On Jan. 28, 2016, 12:59 p.m.,

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116866 --- Ship it! Ship It! - haosdent huang On Jan. 28, 2016, 5:59 p.

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 28, 2016, 5:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116803 --- Patch looks great! Reviews applied: [42530, 42362] Passed comman

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > > pr

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
> On Jan. 28, 2016, 5:49 p.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, lines 1118-1119 > > > > > > I advocate the practice when each block wrapped in curly braces is > > pr

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116797 --- src/tests/persistent_volume_endpoints_tests.cpp (lines 1118 - 111

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
> On Jan. 28, 2016, 11:05 a.m., Alexander Rukletsov wrote: > > Thanks Alex! :-) > On Jan. 28, 2016, 11:05 a.m., Alexander Rukletsov wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1087 > > > > > >

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 28, 2016, 4:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116757 --- Fix it, then Ship it! src/tests/persistent_volume_endpoints_te

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-28 Thread Alexander Rukletsov
> On Jan. 27, 2016, 11:20 p.m., Anand Mazumdar wrote: > > src/tests/persistent_volume_endpoints_tests.cpp, line 1112 > > > > > > Nit: Can we omit the part about not setting the authentication headers > > since it's

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116707 --- Patch looks great! Reviews applied: [42530, 42362] Passed comman

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116649 --- Fix it, then Ship it! LGTM. src/tests/persistent_volume_endpo

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 11:03 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
> On Jan. 27, 2016, 11:30 a.m., Alexander Rukletsov wrote: > > I think the description is a bit outdated, you introduce one test instead > > of two : ). Whoops! Thanks Alex :-) - Greg --- This is an automatically generated e-mail. To r

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 27, 2016, 6:24 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116572 --- I think the description is a bit outdated, you introduce one test

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review115945 --- Patch looks great! Reviews applied: [42530, 42362] Passed comman

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 22, 2016, 5:03 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42362: Added persistent volume endpoint test without authentication.

2016-01-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/ --- (Updated Jan. 21, 2016, 9:03 p.m.) Review request for mesos, Michael Park and N