Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118674 --- Ship it! Ship It! - Kapil Arya On Feb. 9, 2016, 6:47 p.m.,

Re: Review Request 43258: Modified agent to get container status from containerizer.

> On Feb. 9, 2016, 1:33 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3080-3091 > > > > > > This looks problematic to me now as we introduce 'status()' interface > > for isolators. What if there's a network

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 8:32 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 10:08 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118478 --- Fix it, then Ship it! src/slave/slave.cpp (line 3098)

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 11:47 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118520 --- Ship it! Ship It! - Jie Yu On Feb. 9, 2016, 11:47 p.m.,

Re: Review Request 43258: Modified agent to get container status from containerizer.

> On Feb. 9, 2016, 10:23 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3186-3199 > > > > > > I think we should only do this if 'future' is Ready. Otherwise, we > > cannot tell if we should fill IP or not

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 4:16 a.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43258: Modified agent to get container status from containerizer.

> On Feb. 8, 2016, 8:04 p.m., Avinash sridharan wrote: > > src/slave/slave.cpp, line 3178 > > > > > > Should we be destroying the container on failure of the `Future`? This > > is what we are doing in

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 6, 2016, 1:26 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43258: Modified agent to get container status from containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118125 --- src/slave/slave.cpp (lines 3228 - 3234)