Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 27, 2016, 1:24 a.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review121002 --- This breaks the IO based tests in Libprocess. - Joris Van Remoort

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120998 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 26, 2016, 9

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 26, 2016, 10:38 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 26, 2016, 10:29 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120932 --- 3rdparty/libprocess/src/libevent_poll.cpp (line 50)

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120680 --- Patch looks great! Reviews applied: [43799] Passed command: expo

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-24 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 24, 2016, 10:30 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 23, 2016, 7:43 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Alexander Rojas
> On Feb. 23, 2016, 3:06 p.m., Bernd Mathiske wrote: > > 3rdparty/libprocess/src/libevent_poll.cpp, line 57 > > > > > > According to the style guide, we are usually using trailing underscores > > here. We actually d

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120303 --- Fix it, then Ship it! 3rdparty/libprocess/src/libevent_poll.cp

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120023 --- Patch looks great! Reviews applied: [43799] Passed command: expo

Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs: MESOS-32