Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122174 --- Most of my comments are based on an email @alex-mesos sent today,

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 4, 2016, 2:05 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 27 > > > > > > Kill this line. As if it never was there now. > On March 4, 2016, 2:05 p.m., Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 4, 2016, 5:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review122047 --- Fix it, then Ship it! src/master/allocator/mesos/metrics.hpp

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 3, 2016, 3:04 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1711-1712 > > > > > > My intuition is that using `allocationScalarQuantities` will be more > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 3, 2016, 4:04 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1711-1712 > > > > > > My intuition is that using `allocationScalarQuantities` will be more > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121860 --- docs/monitoring.md (line 879)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 1, 2016, 11:48 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2406 > > > > > > I believe the actual value in JSON is double, right? > > Benjamin Bannier wrote: >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 3, 2016, 2:12 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 11:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 29, 2016, 11:48 p.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 413-418 > > > > > > This is really unreadable. I wasn't unsure of what it was happening > > here. I felt

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2406 > > > > > > I believe the actual value in JSON is double, right? This is actually a

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated March 2, 2016, 11:35 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121405 --- docs/monitoring.md (lines 881 - 883)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121330 --- src/master/allocator/mesos/hierarchical.hpp (line 478)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 26, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 8:24 p.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 5:09 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 428 > > > > > > Not yours, but I think we need to update roleSorter when slave > > active/deactive. > > > >

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review120511 --- src/master/allocator/mesos/hierarchical.cpp (line 416)

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:58 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:53 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 11:22 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On 二月 24, 2016, 12:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 24, 2016, 9:46 a.m.) Review request for mesos, Alexander

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

> On Feb. 24, 2016, 1:26 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 432-444 > > > > > > The allocatd may keeps changing due the resource offer and resource > > recovery, I think

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review120415 --- src/master/allocator/mesos/hierarchical.cpp (lines 432 - 444)

Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-4720