Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review122949 --- Ship it! Ship It! - Michael Park On March 9, 2016, 7:25 p.m.

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review122869 --- Patch looks great! Reviews applied: [44026] Passed command: expo

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-09 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- (Updated March 9, 2016, 7:25 p.m.) Review request for mesos, Ben Mahler, Michae

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-09 Thread Anand Mazumdar
> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776 > > > > > > Should this be moved to `future_tests.cpp` too? > > Cong Wang wrote: > Yes,

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-03-09 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- (Updated March 9, 2016, 7:01 p.m.) Review request for mesos, Ben Mahler, Michae

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-26 Thread Cong Wang
> On Feb. 26, 2016, 1:45 a.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 1764-1776 > > > > > > Should this be moved to `future_tests.cpp` too? Yes, it should, because this is

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review120813 --- Fix it, then Ship it! LGTM, Just one minor query around moving

Re: Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/#review120806 --- Patch looks great! Reviews applied: [44026] Passed command: expo

Review Request 44026: Moved future tests into future_tests.cpp.

2016-02-25 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44026/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository: