Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review127499 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 6, 2016, 4:02 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 6, 2016, 3:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > include/mesos/master/contender.hpp, line 65 > > > > > > I am wondering if `type` can be replaced with `moduleName` or something > > more explicit. as

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review125914 --- include/mesos/master/contender.hpp (line 19)

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 21, 2016, 3:43 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review124259 --- Sorry for the delay... As Vinod suggested, you might want to

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 18, 2016, 9:01 p.m., Joseph Wu wrote: > > Sorry for the delay... > > > > As Vinod suggested, you might want to consider reaching out to another > > shepherd (as far as I can tell, BenH is not likely to have time in the > > foreseeable future). (And in case you don't know, I'm not

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 6:16 a.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 14, 2016, 11:48 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review122832 --- I think you should send an email to the user and dev mailing

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 9:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 7:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 9, 2016, 9:20 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 9, 2016, 1:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 3, 2016, 10:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 3, 2016, 2:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 3, 2016, 10:26 p.m., Joseph Wu wrote: > > include/mesos/master/contender.hpp, line 43 > > > > > > I'm going to reiterate this comment > > (https://reviews.apache.org/r/43269/#comment181059). > > > >

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review121946 --- include/mesos/master/contender.hpp (line 43)

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 3, 2016, 5:29 p.m.) Review request for mesos and Benjamin

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 2, 2016, 9:30 p.m.) Review request for mesos. Bugs:

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 2, 2016, 9:20 p.m., Joseph Wu wrote: > > Are you working with @mcavage? (See https://reviews.apache.org/r/43269/) > > > > Also, you might want to add this ticket to your reviews: > > https://issues.apache.org/jira/browse/MESOS-4610 That's correct. I'll update this with the ticket.

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review121719 --- Are you working with @mcavage? (See

Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- Review request for mesos. Repository: mesos Description ---