Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-04-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated April 1, 2016, 3:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 24, 2016, 4:18 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review125185 --- Fix it, then Ship it! include/mesos/mesos.proto (lines 359 -

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review124353 --- Sorry I forgot to publish some stale comments from before, these

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 23, 2016, 11:25 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 22, 2016, 5:13 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/#review124112 --- src/docker/executor.cpp (line 226)

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-19 Thread Alexander Rukletsov
> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 101-105 > > > > > > Ditto feedback from previous reviews about this no longer being a > > default. Per offline discussion, we

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 18, 2016, 5:21 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-19 Thread Ben Mahler
> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 235-239 > > > > > > Ditto earlier comments. I would expect the buffer to be in addition to > > the reap interval. It also wasn't

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-18 Thread Ben Mahler
> On March 15, 2016, 11:21 p.m., Ben Mahler wrote: > > src/docker/executor.cpp, lines 657-663 > > > > > > Hm.. ideally we could ignore the docker stop flag if a kill policy was > > set, because the user is being

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 15, 2016, 4:04 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 15, 2016, 2:28 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 14, 2016, 5:50 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler, Gilbert

Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen. Bugs: