Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-06-21 Thread Qian Zhang
> On March 14, 2016, 2:23 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/info.hpp, line 55 > > > > > > Another problem here is could not avoid different threads to modify a > > same `

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124411 --- Let me discard this because we perfer https://reviews.apache.org/r

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread haosdent huang
> On March 19, 2016, 12:39 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 363 > > > > > > I think what you can do is to save a future in each Subsystem. > > > > I a

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124340 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread haosdent huang
> On March 19, 2016, 12:30 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/info.hpp, line 75 > > > > > > Why? Can that be vector>? If we make this as a vector and pass it to `MemSubystem`, `Me

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review124337 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 75

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123322 --- Bad patch! Reviews applied: [44762] Failed command: ./support/ap

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123321 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 55

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123319 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 55

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/ --- (Updated March 13, 2016, 5:50 p.m.) Review request for mesos and Jie Yu. Bugs

Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

2016-03-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697 https://issues.apache