Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Guangya Liu 


> On 四月 15, 2016, 12:27 a.m., Jie Yu wrote:
> > Second thoughts on this. We should not use a single protobuf file for 
> > checkpointing. Otherwise, we'll have to write the entire file to the 
> > filesystem anytime we do a mount or umount. Let's just create some 
> > directory structure under /var/run/mesos/isolators/docker/volume. Please 
> > take a look at network/cni/paths.hpp|cpp.

OK, will create a separate patch for this.

The hierarchy of the checkpoint will be:

   /var/run/mesos/isolators/docker/volume
|- /
|  |-- mountinfo 
|-- /
| ...


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129043
---


On 四月 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated 四月 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Guangya Liu 


> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, line 19
> > 
> >
> > Why this namespace? This is technically not 'spec', but the _state_ 
> > scheme used by the isolator. We should call the protobuf file 'state.proto'.
> > 
> > I would suggest we still put it under `package mesos.internal.slave`, 
> > and call it `DockerVolumeMount`.
> > 
> > s/ExternalMountList/DockerVolumeState/

what about putting this under `package mesos.internal.slave.volume`?


> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, lines 
> > 21-35
> > 
> >
> > Why do you need to checkpoint 'container_path', 'mount_point' and 
> > 'driver_options'?

My original thought was adding more info here for debug, yes, we can remove 
them now.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129011
---


On 四月 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated 四月 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129043
---



Second thoughts on this. We should not use a single protobuf file for 
checkpointing. Otherwise, we'll have to write the entire file to the filesystem 
anytime we do a mount or umount. Let's just create some directory structure 
under /var/run/mesos/isolators/docker/volume. Please take a look at 
network/cni/paths.hpp|cpp.

- Jie Yu


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129011
---




src/CMakeLists.txt (lines 52 - 54)


the naming here looks bad. We should rename them to:
```
PROVISIONER_DOCKER
ISOLATOR_CNI_SPEC
ISOLATOR_DOCKER_VOLUME_SPEC
```



src/CMakeLists.txt (line 63)


You need to update the protobuf here as well (also adding the new one you 
just added).



src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp (line 29)


Let's not yet introduce file yet.



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 19)


Why this namespace? This is technically not 'spec', but the _state_ scheme 
used by the isolator. We should call the protobuf file 'state.proto'.

I would suggest we still put it under `package mesos.internal.slave`, and 
call it `DockerVolumeMount`.

s/ExternalMountList/DockerVolumeState/



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (lines 21 - 35)


Why do you need to checkpoint 'container_path', 'mount_point' and 
'driver_options'?


- Jie Yu


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Greg Mann 


> On April 14, 2016, 8:17 p.m., Greg Mann wrote:
> >

Could you fix the typo in the commit message: "protobut" should be "protobuf". 
Also, could you remove the duplicate Summary that's in the Description field, 
and add a more verbose description of the patch in the Description field?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128971
---


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128971
---




src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 30)


s/and not configurable/and is not configurable/


- Greg Mann


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128922
---




src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 19)


above `import "mesos/mesos.proto";`



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (lines 26 - 27)


This field make me feel confused, since we also have a `conainer_path` 
field in volume as a required string. Should they be identical? If yes, we 
should comment it.



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 34)


+1 on parameters.


- Gilbert Song


On April 13, 2016, 9:41 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 13, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 14, 2016, 4:41 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 13, 2016, 10:40 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Changes
---

move files to docker/volume


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 13, 2016, 7:16 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-13 Thread Guangya Liu 


> On 四月 4, 2016, 11:16 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp, line 28
> > 
> >
> > Should we add a inline parse method here?

Seems not as the dvd isolator do not need to parse some JSON files.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review126968
---


On 四月 2, 2016, 5:52 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated 四月 2, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review127132
---




src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto (line 32)


Does it should be repeated? And because the options looks like:

```
--volumeopts=k1=v1 --volumeopts=k2=v2
```

I think the type should be `Parameter`?


- haosdent huang


On April 2, 2016, 5:52 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 2, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-04 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review126968
---




src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 28)


Should we add a inline parse method here?



src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 29)


s/function/functions/g


- Gilbert Song


On April 1, 2016, 10:52 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated April 1, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

2016-04-01 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 四月 2, 2016, 5:52 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing (updated)
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-03-30 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 三月 30, 2016, 3:17 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt 366a7ae8f6ef1d55202699df0502a30f15a35e1f 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-03-27 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

(Updated 三月 28, 2016, 2:44 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs (updated)
-

  src/CMakeLists.txt 7bda2ac684f38da94e334f0cef843614687ae4aa 
  src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

2016-03-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review125266
---



Patch looks great!

Reviews applied: [45214, 45217, 45265, 45270]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 24, 2016, 7:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> ---
> 
> (Updated March 24, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0bd7a978306488b687a7e2eeeb8a5c9766d43548 
>   src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 45270: Added spec protobut for external mount.

2016-03-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Added spec protobut for external mount.


Diffs
-

  src/CMakeLists.txt 0bd7a978306488b687a7e2eeeb8a5c9766d43548 
  src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
---


Thanks,

Guangya Liu