Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 12, 2016, 12:19 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 11, 2016, 9:09 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, lines 122-181 > > > > > > Follow-up to https://reviews.apache.org/r/46608/#comment195141: Since > >

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review132623 --- Fix it, then Ship it!

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 10, 2016, 11:44 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On April 30, 2016, 1:04 a.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 305-352 > > > > > > (1) According to the "Security Remarks" section of > >

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 10, 2016, 8:10 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 5, 2016, 9:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 59 > > > > > > In `posix/subprocess.hpp`, we check for `>= 0` because we have `int` > > and

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 5, 2016, 9:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 59 > > > > > > In `posix/subprocess.hpp`, we check for `>= 0` because we have `int` > > and

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 5, 2016, 9:29 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/io.cpp, lines 291-295 > > > > > > So for some reason `lambda::bind(::close, fd)` doesn't work? Do we > > know anything beyond "MSVC's

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 2, 2016, 9:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, line 414 > > > > > > Remove newline. > > Alex Clemmer wrote: > I wasn't sure of intent here. You mean, remove

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131935 --- 3rdparty/libprocess/include/process/windows/subprocess.hpp (line

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 2, 2016, 9:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, line 89 > > > > > > The initialization with `INVALID_HANDLE_VALUE` has no semantic meaning, > > right? We should

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 5, 2016, 3:12 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On April 28, 2016, 11:52 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 534-539 > > > > > > A few comments here. > > > > (1) I think we can simply this to: > > >

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131543 --- 3rdparty/libprocess/src/subprocess.cpp (line 235)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 3, 2016, 5:45 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131356 --- 3rdparty/libprocess/src/subprocess_windows.cpp (line 89)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review131235 --- 3rdparty/libprocess/src/subprocess_windows.cpp (lines 305 - 352)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review130974 --- 3rdparty/libprocess/src/subprocess_windows.cpp (lines 534 - 539)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review130852 --- 3rdparty/libprocess/src/subprocess_windows.cpp (line 348)

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated April 23, 2016, 11:41 p.m.) Review request for mesos, Alex Naparu,

Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris